Skip to contentSkip to conversation

ARM: dts: vfxxx: Add syscon compatible with ocotp

PATCH In review Chris Healy 3 participants 5 messages Aug 20, 2020 – Aug 21, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: dts: vfxxx: Add syscon compatible with ocotp

From: Chris Healy <[email protected]>

Add syscon compatibility with Vybrid ocotp node. This is required to access the UID.

Fixes fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP")

---
Changes in v2:
- Add Fixes line to commit message

 arch/arm/boot/dts/vfxxx.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/vfxxx.dtsi +1 -1
index 0fe03aa0367f..2259d11af721 100644
@@ -495,7 +495,7 @@ edma1: dma-controller@40098000 {
 			};
 
 			ocotp: ocotp@400a5000 {
-				compatible = "fsl,vf610-ocotp";
+				compatible = "fsl,vf610-ocotp", "syscon";
 				reg = <0x400a5000 0x1000>;
 				clocks = <&clks VF610_CLK_OCOTP>;
 			};
Signature · 1 line
2.26.2
#2 lore raw
In reply to Chris Healy
Quoted 4 lines · Chris Healy

From: Chris Healy <[email protected]>

Add syscon compatibility with Vybrid ocotp node. This is required to access the UID.

Hm, it seems today the SoC driver uses the specific compatible. It also should expose the UID as soc_id, see drivers/soc/imx/soc-imx.c.

Maybe it does make sense exposing it as syscon, but then we should probably also adjust Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt.

--
Stefan

Quoted 24 lines
Fixes fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP")

---
Changes in v2:
- Add Fixes line to commit message

 arch/arm/boot/dts/vfxxx.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/vfxxx.dtsi +1 -1
index 0fe03aa0367f..2259d11af721 100644
@@ -495,7 +495,7 @@ edma1: dma-controller@40098000 {
 			};
 
 			ocotp: ocotp@400a5000 {
-				compatible = "fsl,vf610-ocotp";
+				compatible = "fsl,vf610-ocotp", "syscon";
 				reg = <0x400a5000 0x1000>;
 				clocks = <&clks VF610_CLK_OCOTP>;
 			};
#3 lore raw
Quoted 10 lines · Stefan Agner
Quoted 4 lines · Chris Healy

From: Chris Healy <[email protected]>

Add syscon compatibility with Vybrid ocotp node. This is required to access the UID.

Hm, it seems today the SoC driver uses the specific compatible. It also should expose the UID as soc_id, see drivers/soc/imx/soc-imx.c.

Yes, until I added syscon, the soc_id was empty and I would get the following line in dmesg: "failed to find vf610-ocotp regmap!

Quoted 4 lines

Maybe it does make sense exposing it as syscon, but then we should probably also adjust Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt.

Makes sense. I will update vf610-ocotp.txt in v3. Tnx

Quoted 27 lines

--
Stefan

Quoted 24 lines
Fixes fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP")

---
Changes in v2:
- Add Fixes line to commit message

 arch/arm/boot/dts/vfxxx.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/vfxxx.dtsi +1 -1
index 0fe03aa0367f..2259d11af721 100644
@@ -495,7 +495,7 @@ edma1: dma-controller@40098000 {
                      };
 
                      ocotp: ocotp@400a5000 {
-                             compatible = "fsl,vf610-ocotp";
+                             compatible = "fsl,vf610-ocotp", "syscon";
                              reg = <0x400a5000 0x1000>;
                              clocks = <&clks VF610_CLK_OCOTP>;
                      };
#4 lore raw
Quoted 5 lines · Chris Healy
Quoted 4 lines · Stefan Agner
Quoted 2 lines · Chris Healy

From: Chris Healy <[email protected]>

Quoted 9 lines
Quoted 6 lines
Quoted 2 lines

Add syscon compatibility with Vybrid ocotp node. This is required to access the UID.

Hm, it seems today the SoC driver uses the specific compatible. It also should expose the UID as soc_id, see drivers/soc/imx/soc-imx.c.

Yes, until I added syscon, the soc_id was empty and I would get the following line in dmesg: "failed to find vf610-ocotp regmap!

Ah I see, it looks up syscon, so that requires syscon to be in compatible.

Quoted 6 lines
Quoted 4 lines

Maybe it does make sense exposing it as syscon, but then we should probably also adjust Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt.

Makes sense. I will update vf610-ocotp.txt in v3. Tnx

Ok, thx. With that you can add Reviewed-by: Stefan Agner <[email protected]> as well.

--
Stefan

Quoted 27 lines
Quoted 27 lines

--
Stefan

Quoted 24 lines
Fixes fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP")

---
Changes in v2:
- Add Fixes line to commit message

 arch/arm/boot/dts/vfxxx.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/vfxxx.dtsi +1 -1
index 0fe03aa0367f..2259d11af721 100644
@@ -495,7 +495,7 @@ edma1: dma-controller@40098000 {
                      };
 
                      ocotp: ocotp@400a5000 {
-                             compatible = "fsl,vf610-ocotp";
+                             compatible = "fsl,vf610-ocotp", "syscon";
                              reg = <0x400a5000 0x1000>;
                              clocks = <&clks VF610_CLK_OCOTP>;
                      };