ARM: dts: vfxxx: Add syscon compatible with ocotp
Subsystems (2)
PATCH v2 1/1 ARM: dts: vfxxx: Add syscon compatible with ocotp
From: Chris Healy <[email protected]>
Add syscon compatibility with Vybrid ocotp node. This is required to access the UID.
---
Changes in v2:
- Add Fixes line to commit message
arch/arm/boot/dts/vfxxx.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/vfxxx.dtsi +1 -1
@@ -495,7 +495,7 @@ edma1: dma-controller@40098000 { }; ocotp: ocotp@400a5000 { - compatible = "fsl,vf610-ocotp"; + compatible = "fsl,vf610-ocotp", "syscon"; reg = <0x400a5000 0x1000>; clocks = <&clks VF610_CLK_OCOTP>; };
Signature · 1 line
2.26.2
Hi Chris,
Quoted 9 lines · Chris Healy
From: Chris Healy <[email protected]>
Add syscon compatibility with Vybrid ocotp node. This is required to access the UID.
Fixes fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP")Signed-off-by Chris Healy <[email protected]>
Quoted 4 lines · Chris Healy
From: Chris Healy <[email protected]>
Add syscon compatibility with Vybrid ocotp node. This is required to access the UID.
Hm, it seems today the SoC driver uses the specific compatible. It also should expose the UID as soc_id, see drivers/soc/imx/soc-imx.c.
Maybe it does make sense exposing it as syscon, but then we should probably also adjust Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt.
--
Stefan
Quoted 24 lines
Fixes fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP")Signed-off-by Chris Healy <[email protected]>---
Changes in v2:
- Add Fixes line to commit messagearch/arm/boot/dts/vfxxx.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/vfxxx.dtsi +1
-1@@ -495,7 +495,7 @@ edma1: dma-controller@40098000 { }; ocotp: ocotp@400a5000 { - compatible = "fsl,vf610-ocotp"; + compatible = "fsl,vf610-ocotp", "syscon"; reg = <0x400a5000 0x1000>; clocks = <&clks VF610_CLK_OCOTP>; };
Quoted 10 lines · Stefan Agner
Quoted 4 lines · Chris Healy
From: Chris Healy <[email protected]>
Add syscon compatibility with Vybrid ocotp node. This is required to access the UID.
Hm, it seems today the SoC driver uses the specific compatible. It also should expose the UID as
soc_id, seedrivers/soc/imx/soc-imx.c.
Yes, until I added syscon, the soc_id was empty and I would get the following line in dmesg: "failed to find vf610-ocotp regmap!
Quoted 4 lines
Maybe it does make sense exposing it as syscon, but then we should probably also adjust
Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt.
Makes sense. I will update vf610-ocotp.txt in v3. Tnx
Quoted 27 lines
--
StefanQuoted 24 lines
Fixes fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP")Signed-off-by Chris Healy <[email protected]>---
Changes in v2:
- Add Fixes line to commit messagearch/arm/boot/dts/vfxxx.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/vfxxx.dtsi +1
-1@@ -495,7 +495,7 @@ edma1: dma-controller@40098000 { }; ocotp: ocotp@400a5000 { - compatible = "fsl,vf610-ocotp"; + compatible = "fsl,vf610-ocotp", "syscon"; reg = <0x400a5000 0x1000>; clocks = <&clks VF610_CLK_OCOTP>; };
Quoted 5 lines · Chris Healy
Quoted 4 lines · Stefan Agner
Quoted 2 lines · Chris Healy
From: Chris Healy <[email protected]>
Quoted 9 lines
Quoted 6 lines
Quoted 2 lines
Add syscon compatibility with Vybrid ocotp node. This is required to access the UID.
Hm, it seems today the SoC driver uses the specific compatible. It also should expose the UID as
soc_id, seedrivers/soc/imx/soc-imx.c.Yes, until I added syscon, the
soc_idwas empty and I would get the following line in dmesg: "failed to find vf610-ocotp regmap!
Ah I see, it looks up syscon, so that requires syscon to be in compatible.
Quoted 6 lines
Quoted 4 lines
Maybe it does make sense exposing it as syscon, but then we should probably also adjust
Documentation/devicetree/bindings/nvmem/vf610-ocotp.txt.Makes sense. I will update vf610-ocotp.txt in v3. Tnx
Ok, thx. With that you can add Reviewed-by: Stefan Agner <[email protected]> as well.
--
Stefan
Quoted 27 lines
Quoted 27 lines
--
StefanQuoted 24 lines
Fixes fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP")Signed-off-by Chris Healy <[email protected]>---
Changes in v2:
- Add Fixes line to commit messagearch/arm/boot/dts/vfxxx.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/vfxxx.dtsi +1
-1@@ -495,7 +495,7 @@ edma1: dma-controller@40098000 { }; ocotp: ocotp@400a5000 { - compatible = "fsl,vf610-ocotp"; + compatible = "fsl,vf610-ocotp", "syscon"; reg = <0x400a5000 0x1000>; clocks = <&clks VF610_CLK_OCOTP>; };