x86: Introduce USE_EARLY_BOARD_INIT option
PATCH v2 1/15 x86: Introduce USE_EARLY_BOARD_INIT option
Introduce USE_EARLY_BOARD_INIT option and select it by the actual users.
---
v2: added Rb tag(s), appended CONFIG prefix when use the option in the code
arch/x86/Kconfig | 3 +++ arch/x86/cpu/start.S | 3 +++ board/google/chromebook_coral/Kconfig | 1 + board/google/chromebook_link/Kconfig | 1 + board/google/chromebook_samus/Kconfig | 1 + 5 files changed, 9 insertions(+)
arch/x86/Kconfig +3 -0
@@ -203,6 +203,9 @@ config SPL_X86_32BIT_INIT help This is enabled when 32-bit init is in SPL +config USE_EARLY_BOARD_INIT + bool + config RESET_SEG_START hex depends on X86_RESET_VECTOR
arch/x86/cpu/start.S +3 -0
@@ -88,6 +88,7 @@ _start: /* Clear the interrupt vectors */ lidt blank_idt_ptr +#ifdef CONFIG_USE_EARLY_BOARD_INIT /* * Critical early platform init - generally not used, we prefer init * to happen later when we have a console, in case something goes
@@ -96,6 +97,8 @@ _start: jmp early_board_init .globl early_board_init_ret early_board_init_ret: +#endif + post_code(POST_START) /* Initialise Cache-As-RAM */
board/google/chromebook_coral/Kconfig +1 -0
@@ -18,6 +18,7 @@ config SYS_TEXT_BASE config BOARD_SPECIFIC_OPTIONS # dummy def_bool y select X86_RESET_VECTOR + select USE_EARLY_BOARD_INIT select INTEL_APOLLOLAKE select BOARD_ROMSIZE_KB_16384
board/google/chromebook_link/Kconfig +1 -0
@@ -19,6 +19,7 @@ config SYS_TEXT_BASE config BOARD_SPECIFIC_OPTIONS # dummy def_bool y select X86_RESET_VECTOR + select USE_EARLY_BOARD_INIT select NORTHBRIDGE_INTEL_IVYBRIDGE select HAVE_INTEL_ME select BOARD_ROMSIZE_KB_8192
board/google/chromebook_samus/Kconfig +1 -0
@@ -19,6 +19,7 @@ config SYS_TEXT_BASE config BOARD_SPECIFIC_OPTIONS # dummy def_bool y select X86_RESET_VECTOR + select USE_EARLY_BOARD_INIT select INTEL_BROADWELL select HAVE_INTEL_ME select BOARD_ROMSIZE_KB_8192
Signature · 1 line
2.28.0
PATCH v2 2/15 x86: advantech: som-db5800-som-6867: Remove dead code
start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
---
v2: added Rb tag(s)
board/advantech/som-db5800-som-6867/Makefile | 2 +- board/advantech/som-db5800-som-6867/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/advantech/som-db5800-som-6867/start.S
board/advantech/som-db5800-som-6867/Makefile +1 -1
@@ -2,5 +2,5 @@ # # Copyright (C) 2015, Google, Inc -obj-y += som-db5800-som-6867.o start.o +obj-y += som-db5800-som-6867.o obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
board/advantech/som-db5800-som-6867/start.S deleted +0 -8
@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2015, Google, Inc - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.28.0
PATCH v2 2/15 x86: advantech: som-db5800-som-6867: Remove dead code
Quoted 7 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.Cc George McCollister <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>Reviewed-by Simon Glass <[email protected]>
Quoted 7 lines
---
v2: added Rb tag(s)board/advantech/som-db5800-som-6867/Makefile | 2 +- board/advantech/som-db5800-som-6867/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/advantech/som-db5800-som-6867/start.S
PATCH v2 3/15 x86: congatec: conga-qeval20-qa3-e3845: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
---
v2: added Rb tag(s)
board/congatec/conga-qeval20-qa3-e3845/Makefile | 2 +- board/congatec/conga-qeval20-qa3-e3845/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/congatec/conga-qeval20-qa3-e3845/start.S
board/congatec/conga-qeval20-qa3-e3845/Makefile +1 -1
@@ -2,5 +2,5 @@ # # Copyright (C) 2015, Google, Inc -obj-y += conga-qeval20-qa3.o start.o +obj-y += conga-qeval20-qa3.o obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
board/congatec/conga-qeval20-qa3-e3845/start.S deleted +0 -8
@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2015, Google, Inc - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.28.0
PATCH v2 3/15 x86: congatec: conga-qeval20-qa3-e3845: Remove dead code
Quoted 4 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.
Quoted 9 lines
Signed-off-by Andy Shevchenko <[email protected]>Reviewed-by Stefan Roese <[email protected]>---
v2: added Rb tag(s)board/congatec/conga-qeval20-qa3-e3845/Makefile | 2 +- board/congatec/conga-qeval20-qa3-e3845/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/congatec/conga-qeval20-qa3-e3845/start.S
PATCH v2 4/15 x86: coreboot: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
---
v2: added Rb tag(s)
board/coreboot/coreboot/Makefile | 2 +- board/coreboot/coreboot/start.S | 12 ------------ 2 files changed, 1 insertion(+), 13 deletions(-) delete mode 100644 board/coreboot/coreboot/start.S
board/coreboot/coreboot/Makefile +1 -1
@@ -10,4 +10,4 @@ # (C) Copyright 2002 # Daniel Engstr?m, Omicron Ceti AB, daniel at omicron.se. -obj-y += start.o coreboot.o +obj-y += coreboot.o
board/coreboot/coreboot/start.S deleted +0 -12
@@ -1,12 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (c) 2011 The Chromium OS Authors. - * (C) Copyright 2008 - * Graeme Russ, graeme.russ at gmail.com. - */ - -/* board early intialization */ -.globl early_board_init -early_board_init: - /* No 32-bit board specific initialisation */ - jmp early_board_init_ret
Signature · 1 line
2.28.0
PATCH v2 4/15 x86: coreboot: Remove dead code
Quoted 4 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.
Quoted 9 lines
Signed-off-by Andy Shevchenko <[email protected]>Reviewed-by Simon Glass <[email protected]>---
v2: added Rb tag(s)board/coreboot/coreboot/Makefile | 2 +- board/coreboot/coreboot/start.S | 12 ------------ 2 files changed, 1 insertion(+), 13 deletions(-) delete mode 100644 board/coreboot/coreboot/start.S
PATCH v2 5/15 x86: dfi: dfi-bt700: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
---
v2: added Rb tag(s)
board/dfi/dfi-bt700/Makefile | 2 +- board/dfi/dfi-bt700/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/dfi/dfi-bt700/start.S
board/dfi/dfi-bt700/Makefile +1 -1
@@ -2,5 +2,5 @@ # # Copyright (C) 2015, Google, Inc -obj-y += dfi-bt700.o start.o +obj-y += dfi-bt700.o obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
board/dfi/dfi-bt700/start.S deleted +0 -8
@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2015, Google, Inc - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.28.0
PATCH v2 5/15 x86: dfi: dfi-bt700: Remove dead code
Quoted 4 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.
Quoted 9 lines
Signed-off-by Andy Shevchenko <[email protected]>Reviewed-by Stefan Roese <[email protected]>---
v2: added Rb tag(s)board/dfi/dfi-bt700/Makefile | 2 +- board/dfi/dfi-bt700/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/dfi/dfi-bt700/start.S
PATCH v2 6/15 x86: efi: efi-x86_payload: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
---
v2: added Rb tag(s)
board/efi/efi-x86_payload/Makefile | 2 +- board/efi/efi-x86_payload/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/efi/efi-x86_payload/start.S
board/efi/efi-x86_payload/Makefile +1 -1
@@ -2,4 +2,4 @@ # # Copyright (C) 2018, Bin Meng <[email protected]> -obj-y += start.o payload.o +obj-y += payload.o
board/efi/efi-x86_payload/start.S deleted +0 -8
@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2018, Bin Meng <[email protected]> - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.28.0
PATCH v2 6/15 x86: efi: efi-x86_payload: Remove dead code
Quoted 6 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.Signed-off-by Andy Shevchenko <[email protected]>Reviewed-by Simon Glass <[email protected]>
Quoted 8 lines
---
v2: added Rb tag(s)board/efi/efi-x86_payload/Makefile | 2 +- board/efi/efi-x86_payload/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/efi/efi-x86_payload/start.S
PATCH v2 7/15 x86: intel: bayleybay: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
---
v2: added Rb tag(s)
board/intel/bayleybay/Makefile | 2 +- board/intel/bayleybay/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/bayleybay/start.S
board/intel/bayleybay/Makefile +1 -1
@@ -2,5 +2,5 @@ # # Copyright (C) 2015, Bin Meng <[email protected]> -obj-y += bayleybay.o start.o +obj-y += bayleybay.o obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
board/intel/bayleybay/start.S deleted +0 -8
@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2015, Bin Meng <[email protected]> - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.28.0
PATCH v2 7/15 x86: intel: bayleybay: Remove dead code
Quoted 4 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.
Quoted 9 lines
Signed-off-by Andy Shevchenko <[email protected]>Reviewed-by Simon Glass <[email protected]>---
v2: added Rb tag(s)board/intel/bayleybay/Makefile | 2 +- board/intel/bayleybay/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/bayleybay/start.S
PATCH v2 8/15 x86: intel: cherryhill: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
---
v2: added Rb tag(s)
board/intel/cherryhill/Makefile | 2 +- board/intel/cherryhill/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/cherryhill/start.S
board/intel/cherryhill/Makefile +1 -1
@@ -2,4 +2,4 @@ # # Copyright (C) 2017, Bin Meng <[email protected]> -obj-y += cherryhill.o start.o +obj-y += cherryhill.o
board/intel/cherryhill/start.S deleted +0 -8
@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2017, Bin Meng <[email protected]> - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.28.0
PATCH v2 8/15 x86: intel: cherryhill: Remove dead code
Quoted 4 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.
Quoted 9 lines
Signed-off-by Andy Shevchenko <[email protected]>Reviewed-by Simon Glass <[email protected]>---
v2: added Rb tag(s)board/intel/cherryhill/Makefile | 2 +- board/intel/cherryhill/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/cherryhill/start.S
PATCH v2 9/15 x86: intel: cougarcanyon2: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
---
v2: added Rb tag(s)
board/intel/cougarcanyon2/Makefile | 2 +- board/intel/cougarcanyon2/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/cougarcanyon2/start.S
board/intel/cougarcanyon2/Makefile +1 -1
@@ -2,4 +2,4 @@ # # Copyright (C) 2016, Bin Meng <[email protected]> -obj-y += cougarcanyon2.o start.o +obj-y += cougarcanyon2.o
board/intel/cougarcanyon2/start.S deleted +0 -8
@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2016, Bin Meng <[email protected]> - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.28.0
PATCH v2 9/15 x86: intel: cougarcanyon2: Remove dead code
Quoted 4 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.
Quoted 9 lines
Signed-off-by Andy Shevchenko <[email protected]>Reviewed-by Simon Glass <[email protected]>---
v2: added Rb tag(s)board/intel/cougarcanyon2/Makefile | 2 +- board/intel/cougarcanyon2/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/cougarcanyon2/start.S
PATCH v2 10/15 x86: intel: crownbay: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
---
v2: added Rb tag(s)
board/intel/crownbay/Makefile | 2 +- board/intel/crownbay/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/crownbay/start.S
board/intel/crownbay/Makefile +1 -1
@@ -2,4 +2,4 @@ # # Copyright (C) 2014, Bin Meng <[email protected]> -obj-y += crownbay.o start.o +obj-y += crownbay.o
board/intel/crownbay/start.S deleted +0 -8
@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2014, Bin Meng <[email protected]> - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.28.0
PATCH v2 10/15 x86: intel: crownbay: Remove dead code
Quoted 4 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.
Quoted 9 lines
Signed-off-by Andy Shevchenko <[email protected]>Reviewed-by Simon Glass <[email protected]>---
v2: added Rb tag(s)board/intel/crownbay/Makefile | 2 +- board/intel/crownbay/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/crownbay/start.S
PATCH v2 11/15 x86: intel: edison: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
---
v2: added Rb tag(s)
board/intel/edison/Makefile | 2 +- board/intel/edison/start.S | 12 ------------ 2 files changed, 1 insertion(+), 13 deletions(-) delete mode 100644 board/intel/edison/start.S
board/intel/edison/Makefile +1 -1
@@ -4,5 +4,5 @@ # SPDX-License-Identifier: GPL-2.0+ # -obj-y += start.o edison.o +obj-y += edison.o obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
board/intel/edison/start.S deleted +0 -12
@@ -1,12 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (c) 2011 The Chromium OS Authors. - * (C) Copyright 2008 - * Graeme Russ, graeme.russ at gmail.com. - */ - -/* board early intialization */ -.globl early_board_init -early_board_init: - /* No 32-bit board specific initialisation */ - jmp early_board_init_ret
Signature · 1 line
2.28.0
PATCH v2 11/15 x86: intel: edison: Remove dead code
Quoted 6 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.Signed-off-by Andy Shevchenko <[email protected]>Reviewed-by Simon Glass <[email protected]>
Quoted 8 lines
---
v2: added Rb tag(s)board/intel/edison/Makefile | 2 +- board/intel/edison/start.S | 12 ------------ 2 files changed, 1 insertion(+), 13 deletions(-) delete mode 100644 board/intel/edison/start.S
PATCH v2 12/15 x86: intel: galileo: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
---
v2: added Rb tag(s)
board/intel/galileo/Makefile | 2 +- board/intel/galileo/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/galileo/start.S
board/intel/galileo/Makefile +1 -1
@@ -2,5 +2,5 @@ # # Copyright (C) 2015, Bin Meng <[email protected]> -obj-y += galileo.o start.o +obj-y += galileo.o obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
board/intel/galileo/start.S deleted +0 -8
@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2015, Bin Meng <[email protected]> - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.28.0
PATCH v2 12/15 x86: intel: galileo: Remove dead code
Quoted 6 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.Signed-off-by Andy Shevchenko <[email protected]>Reviewed-by Simon Glass <[email protected]>
Quoted 8 lines
---
v2: added Rb tag(s)board/intel/galileo/Makefile | 2 +- board/intel/galileo/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/galileo/start.S
PATCH v2 13/15 x86: intel: minnowmax: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
---
v2: added Rb tag(s)
board/intel/minnowmax/Makefile | 2 +- board/intel/minnowmax/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/minnowmax/start.S
board/intel/minnowmax/Makefile +1 -1
@@ -2,5 +2,5 @@ # # Copyright (C) 2015, Google, Inc -obj-y += minnowmax.o start.o +obj-y += minnowmax.o obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
board/intel/minnowmax/start.S deleted +0 -8
@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2015, Google, Inc - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.28.0
PATCH v2 13/15 x86: intel: minnowmax: Remove dead code
Quoted 6 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.Signed-off-by Andy Shevchenko <[email protected]>Reviewed-by Simon Glass <[email protected]>
Quoted 8 lines
---
v2: added Rb tag(s)board/intel/minnowmax/Makefile | 2 +- board/intel/minnowmax/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/minnowmax/start.S
PATCH v2 14/15 x86: intel: slimbootloader: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
---
v2: added Rb tag(s)
board/intel/slimbootloader/Makefile | 2 +- board/intel/slimbootloader/start.S | 9 --------- 2 files changed, 1 insertion(+), 10 deletions(-) delete mode 100644 board/intel/slimbootloader/start.S
board/intel/slimbootloader/Makefile +1 -1
@@ -2,4 +2,4 @@ # # Copyright (C) 2019 Intel Corporation <www.intel.com> -obj-y += start.o slimbootloader.o +obj-y += slimbootloader.o
board/intel/slimbootloader/start.S deleted +0 -9
@@ -1,9 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2019 Intel Corporation <www.intel.com> - */ - -/* board early initialization */ -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.28.0
PATCH v2 14/15 x86: intel: slimbootloader: Remove dead code
Quoted 7 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.Signed-off-by Andy Shevchenko <[email protected]>Reviewed-by Simon Glass <[email protected]>Reviewed-by Aiden Park <[email protected]>
Quoted 8 lines
---
v2: added Rb tag(s)board/intel/slimbootloader/Makefile | 2 +- board/intel/slimbootloader/start.S | 9 --------- 2 files changed, 1 insertion(+), 10 deletions(-) delete mode 100644 board/intel/slimbootloader/start.S
PATCH v2 15/15 x86: qemu: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
---
v2: added Rb tag(s)
board/emulation/qemu-x86/Makefile | 2 -- board/emulation/qemu-x86/start.S | 8 -------- 2 files changed, 10 deletions(-) delete mode 100644 board/emulation/qemu-x86/start.S
board/emulation/qemu-x86/Makefile +0 -2
@@ -1,5 +1,3 @@ # SPDX-License-Identifier: GPL-2.0+ # # Copyright (C) 2015, Bin Meng <[email protected]> - -obj-y += start.o
board/emulation/qemu-x86/start.S deleted +0 -8
@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2015, Bin Meng <[email protected]> - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.28.0
PATCH v2 15/15 x86: qemu: Remove dead code
Quoted 6 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.Signed-off-by Andy Shevchenko <[email protected]>Reviewed-by Simon Glass <[email protected]>
Quoted 8 lines
---
v2: added Rb tag(s)board/emulation/qemu-x86/Makefile | 2 -- board/emulation/qemu-x86/start.S | 8 -------- 2 files changed, 10 deletions(-) delete mode 100644 board/emulation/qemu-x86/start.S
PATCH v2 15/15 x86: qemu: Remove dead code
In reply to Andy ShevchenkoHi Andy,
Quoted 19 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.Signed-off-by Andy Shevchenko <[email protected]>Reviewed-by Simon Glass <[email protected]>---
v2: added Rb tag(s)board/emulation/qemu-x86/Makefile | 2 -- board/emulation/qemu-x86/start.S | 8 -------- 2 files changed, 10 deletions(-) delete mode 100644 board/emulation/qemu-x86/start.Sboard/emulation/qemu-x86/Makefile +0
-0
board/emulation/qemu-x86/Makefile line 5
Quoted 5 lines
board/emulation/qemu-x86/Makefile +0
-2@@ -1,5 +1,3 @@ # SPDX-License-Identifier: GPL-2.0+ # # Copyright (C) 2015, Bin Meng <[email protected]> - -obj-y += start.o
Unfortunately this does not build.
We possibly need to fix the top-level Makefile and promote the Kconfig option for all boards?
board/emulation/qemu-x86/start.S
Quoted 3 lines
board/emulation/qemu-x86/start.S deleted +0
-0
Regards,
Bin
PATCH v2 15/15 x86: qemu: Remove dead code
Quoted 31 lines · Bin Meng
Hi Andy,
Quoted 19 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.Signed-off-by Andy Shevchenko <[email protected]>Reviewed-by Simon Glass <[email protected]>---
v2: added Rb tag(s)board/emulation/qemu-x86/Makefile | 2 -- board/emulation/qemu-x86/start.S | 8 -------- 2 files changed, 10 deletions(-) delete mode 100644 board/emulation/qemu-x86/start.Sboard/emulation/qemu-x86/Makefile +0
-0board/emulation/qemu-x86/Makefile line 5
Quoted 5 lines
board/emulation/qemu-x86/Makefile +0
-2@@ -1,5 +1,3 @@ # SPDX-License-Identifier: GPL-2.0+ # # Copyright (C) 2015, Bin Meng <[email protected]> - -obj-y += start.oUnfortunately this does not build.
Quoted 2 lines
We possibly need to fix the top-level
Makefileand promote theKconfigoption for all boards?
Hmm... I believe that I left Makefile in order to make it build. Which configuration had you used to reproduce?
Okay, I see linker error now. Let me look into the issue.
Signature · 2 lines
With Best Regards, Andy Shevchenko
PATCH v2 15/15 x86: qemu: Remove dead code
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Bin Meng
On Thu, Aug 20, 2020 at 6:02 PM Andy Shevchenko
<[email protected]> wrote:
...
Quoted 11 lines
Quoted 6 lines
Quoted 1 line
-obj-y += start.o
Unfortunately this does not build.
We possibly need to fix the top-level
Makefileand promote theKconfigoption for all boards?Hmm... I believe that I left
Makefilein order to make it build. Which configuration had you used to reproduce?Okay, I see linker error now. Let me look into the issue.
v3 has been sent.
Signature · 2 lines
With Best Regards, Andy Shevchenko
PATCH v2 1/15 x86: Introduce USE_EARLY_BOARD_INIT option
In reply to Andy ShevchenkoQuoted 6 lines · Andy Shevchenko
Introduce
USE_EARLY_BOARD_INIToption and select it by the actual users.Cc George McCollister <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>
Quoted 9 lines
---
v2: added Rb tag(s), appended CONFIG prefix when use the option in the codearch/x86/Kconfig | 3 +++ arch/x86/cpu/start.S | 3 +++ board/google/chromebook_coral/Kconfig | 1 + board/google/chromebook_link/Kconfig | 1 + board/google/chromebook_samus/Kconfig | 1 + 5 files changed, 9 insertions(+)
PATCH v2 1/15 x86: Introduce USE_EARLY_BOARD_INIT option
Quoted 19 lines · Bin Meng
Quoted 6 lines · Andy Shevchenko
Introduce
USE_EARLY_BOARD_INIToption and select it by the actual users.Cc George McCollister <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>Quoted 9 lines
---
v2: added Rb tag(s), appended CONFIG prefix when use the option in the codearch/x86/Kconfig | 3 +++ arch/x86/cpu/start.S | 3 +++ board/google/chromebook_coral/Kconfig | 1 + board/google/chromebook_link/Kconfig | 1 + board/google/chromebook_samus/Kconfig | 1 + 5 files changed, 9 insertions(+)
Quoted 1 line
Reviewed-by Bin Meng <[email protected]>
series applied to u-boot-x86, thanks!