x86: Introduce USE_EARLY_BOARD_INIT option
PATCH 1/15 x86: Introduce USE_EARLY_BOARD_INIT option
Introduce USE_EARLY_BOARD_INIT option and select it by the actual users.
--- arch/x86/Kconfig | 3 +++ arch/x86/cpu/start.S | 3 +++ board/google/chromebook_coral/Kconfig | 1 + board/google/chromebook_link/Kconfig | 1 + board/google/chromebook_samus/Kconfig | 1 + 5 files changed, 9 insertions(+)
arch/x86/Kconfig +3 -0
@@ -203,6 +203,9 @@ config SPL_X86_32BIT_INIT help This is enabled when 32-bit init is in SPL +config USE_EARLY_BOARD_INIT + bool + config RESET_SEG_START hex depends on X86_RESET_VECTOR
arch/x86/cpu/start.S +3 -0
@@ -88,6 +88,7 @@ _start: /* Clear the interrupt vectors */ lidt blank_idt_ptr +#ifdef USE_EARLY_BOARD_INIT /* * Critical early platform init - generally not used, we prefer init * to happen later when we have a console, in case something goes
@@ -96,6 +97,8 @@ _start: jmp early_board_init .globl early_board_init_ret early_board_init_ret: +#endif + post_code(POST_START) /* Initialise Cache-As-RAM */
board/google/chromebook_coral/Kconfig +1 -0
@@ -18,6 +18,7 @@ config SYS_TEXT_BASE config BOARD_SPECIFIC_OPTIONS # dummy def_bool y select X86_RESET_VECTOR + select USE_EARLY_BOARD_INIT select INTEL_APOLLOLAKE select BOARD_ROMSIZE_KB_16384
board/google/chromebook_link/Kconfig +1 -0
@@ -19,6 +19,7 @@ config SYS_TEXT_BASE config BOARD_SPECIFIC_OPTIONS # dummy def_bool y select X86_RESET_VECTOR + select USE_EARLY_BOARD_INIT select NORTHBRIDGE_INTEL_IVYBRIDGE select HAVE_INTEL_ME select BOARD_ROMSIZE_KB_8192
board/google/chromebook_samus/Kconfig +1 -0
@@ -19,6 +19,7 @@ config SYS_TEXT_BASE config BOARD_SPECIFIC_OPTIONS # dummy def_bool y select X86_RESET_VECTOR + select USE_EARLY_BOARD_INIT select INTEL_BROADWELL select HAVE_INTEL_ME select BOARD_ROMSIZE_KB_8192
Signature · 1 line
2.27.0
PATCH 1/15 x86: Introduce USE_EARLY_BOARD_INIT option
Quoted 1 line · Andy Shevchenko
Introduce
USE_EARLY_BOARD_INIToption and select it by the actual users.
...
Quoted 1 line
+#ifdef
USE_EARLY_BOARD_INIT
And here I missed CONFIG_ prefix...
I'll fix this in v2.
Quoted 8 lines
arch/x86/cpu/start.S +1
-0/* * Critical early platform init - generally not used, we prefer init * to happen later when we have a console, in case something goes@@ -96,6 +97,8 @@ _start: jmp early_board_init .globl early_board_init_ret early_board_init_ret: +#endif
Signature · 2 lines
With Best Regards, Andy Shevchenko
PATCH 2/15 x86: advantech: som-db5800-som-6867: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
--- board/advantech/som-db5800-som-6867/Makefile | 2 +- board/advantech/som-db5800-som-6867/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/advantech/som-db5800-som-6867/start.S
board/advantech/som-db5800-som-6867/Makefile +1 -1
@@ -2,5 +2,5 @@ # # Copyright (C) 2015, Google, Inc -obj-y += som-db5800-som-6867.o start.o +obj-y += som-db5800-som-6867.o obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
board/advantech/som-db5800-som-6867/start.S deleted +0 -8
@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2015, Google, Inc - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.27.0
PATCH 2/15 x86: advantech: som-db5800-som-6867: Remove dead code
Quoted 4 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.
Quoted 8 lines
Cc George McCollister <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>--- board/advantech/som-db5800-som-6867/Makefile | 2 +- board/advantech/som-db5800-som-6867/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/advantech/som-db5800-som-6867/start.S
PATCH 3/15 x86: congatec: conga-qeval20-qa3-e3845: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
--- board/congatec/conga-qeval20-qa3-e3845/Makefile | 2 +- board/congatec/conga-qeval20-qa3-e3845/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/congatec/conga-qeval20-qa3-e3845/start.S
board/congatec/conga-qeval20-qa3-e3845/Makefile +1 -1
@@ -2,5 +2,5 @@ # # Copyright (C) 2015, Google, Inc -obj-y += conga-qeval20-qa3.o start.o +obj-y += conga-qeval20-qa3.o obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
board/congatec/conga-qeval20-qa3-e3845/start.S deleted +0 -8
@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2015, Google, Inc - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.27.0
PATCH 3/15 x86: congatec: conga-qeval20-qa3-e3845: Remove dead code
Quoted 5 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.Cc Stefan Roese <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>
Thanks,
Stefan
Quoted 24 lines
--- board/congatec/conga-qeval20-qa3-e3845/Makefile | 2 +- board/congatec/conga-qeval20-qa3-e3845/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-)delete mode 100644
board/congatec/conga-qeval20-qa3-e3845/start.Sboard/congatec/conga-qeval20-qa3-e3845/Makefile +1
-1@@ -2,5 +2,5 @@ # # Copyright (C) 2015, Google, Inc -obj-y += conga-qeval20-qa3.o start.o +obj-y += conga-qeval20-qa3.o obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.oboard/congatec/conga-qeval20-qa3-e3845/start.S deleted +0
-0
board/congatec/conga-qeval20-qa3-e3845/start.S line 8
Quoted 8 lines
board/congatec/conga-qeval20-qa3-e3845/start.S deleted +0
-8@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2015, Google, Inc - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Viele Gr??e,
Stefan
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de
PATCH 4/15 x86: coreboot: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
--- board/coreboot/coreboot/Makefile | 2 +- board/coreboot/coreboot/start.S | 12 ------------ 2 files changed, 1 insertion(+), 13 deletions(-) delete mode 100644 board/coreboot/coreboot/start.S
board/coreboot/coreboot/Makefile +1 -1
@@ -10,4 +10,4 @@ # (C) Copyright 2002 # Daniel Engstr?m, Omicron Ceti AB, daniel at omicron.se. -obj-y += start.o coreboot.o +obj-y += coreboot.o
board/coreboot/coreboot/start.S deleted +0 -12
@@ -1,12 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (c) 2011 The Chromium OS Authors. - * (C) Copyright 2008 - * Graeme Russ, graeme.russ at gmail.com. - */ - -/* board early intialization */ -.globl early_board_init -early_board_init: - /* No 32-bit board specific initialisation */ - jmp early_board_init_ret
Signature · 1 line
2.27.0
PATCH 4/15 x86: coreboot: Remove dead code
Quoted 11 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.Signed-off-by Andy Shevchenko <[email protected]>--- board/coreboot/coreboot/Makefile | 2 +- board/coreboot/coreboot/start.S | 12 ------------ 2 files changed, 1 insertion(+), 13 deletions(-) delete mode 100644 board/coreboot/coreboot/start.S
PATCH 5/15 x86: dfi: dfi-bt700: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
--- board/dfi/dfi-bt700/Makefile | 2 +- board/dfi/dfi-bt700/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/dfi/dfi-bt700/start.S
board/dfi/dfi-bt700/Makefile +1 -1
@@ -2,5 +2,5 @@ # # Copyright (C) 2015, Google, Inc -obj-y += dfi-bt700.o start.o +obj-y += dfi-bt700.o obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
board/dfi/dfi-bt700/start.S deleted +0 -8
@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2015, Google, Inc - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.27.0
PATCH 5/15 x86: dfi: dfi-bt700: Remove dead code
Quoted 5 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.Cc Stefan Roese <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>
Thanks,
Stefan
Quoted 24 lines
--- board/dfi/dfi-bt700/Makefile | 2 +- board/dfi/dfi-bt700/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-)delete mode 100644
board/dfi/dfi-bt700/start.Sboard/dfi/dfi-bt700/Makefile +1
-1@@ -2,5 +2,5 @@ # # Copyright (C) 2015, Google, Inc -obj-y += dfi-bt700.o start.o +obj-y += dfi-bt700.o obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.oboard/dfi/dfi-bt700/start.S deleted +0
-0
board/dfi/dfi-bt700/start.S line 8
Quoted 8 lines
board/dfi/dfi-bt700/start.S deleted +0
-8@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2015, Google, Inc - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Viele Gr??e,
Stefan
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de
PATCH 6/15 x86: efi: efi-x86_payload: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
--- board/efi/efi-x86_payload/Makefile | 2 +- board/efi/efi-x86_payload/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/efi/efi-x86_payload/start.S
board/efi/efi-x86_payload/Makefile +1 -1
@@ -2,4 +2,4 @@ # # Copyright (C) 2018, Bin Meng <[email protected]> -obj-y += start.o payload.o +obj-y += payload.o
board/efi/efi-x86_payload/start.S deleted +0 -8
@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2018, Bin Meng <[email protected]> - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.27.0
PATCH 6/15 x86: efi: efi-x86_payload: Remove dead code
Quoted 11 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.Signed-off-by Andy Shevchenko <[email protected]>--- board/efi/efi-x86_payload/Makefile | 2 +- board/efi/efi-x86_payload/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/efi/efi-x86_payload/start.S
PATCH 7/15 x86: intel: bayleybay: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
--- board/intel/bayleybay/Makefile | 2 +- board/intel/bayleybay/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/bayleybay/start.S
board/intel/bayleybay/Makefile +1 -1
@@ -2,5 +2,5 @@ # # Copyright (C) 2015, Bin Meng <[email protected]> -obj-y += bayleybay.o start.o +obj-y += bayleybay.o obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
board/intel/bayleybay/start.S deleted +0 -8
@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2015, Bin Meng <[email protected]> - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.27.0
PATCH 7/15 x86: intel: bayleybay: Remove dead code
Quoted 11 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.Signed-off-by Andy Shevchenko <[email protected]>--- board/intel/bayleybay/Makefile | 2 +- board/intel/bayleybay/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/bayleybay/start.S
PATCH 8/15 x86: intel: cherryhill: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
--- board/intel/cherryhill/Makefile | 2 +- board/intel/cherryhill/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/cherryhill/start.S
board/intel/cherryhill/Makefile +1 -1
@@ -2,4 +2,4 @@ # # Copyright (C) 2017, Bin Meng <[email protected]> -obj-y += cherryhill.o start.o +obj-y += cherryhill.o
board/intel/cherryhill/start.S deleted +0 -8
@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2017, Bin Meng <[email protected]> - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.27.0
PATCH 8/15 x86: intel: cherryhill: Remove dead code
Quoted 11 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.Signed-off-by Andy Shevchenko <[email protected]>--- board/intel/cherryhill/Makefile | 2 +- board/intel/cherryhill/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/cherryhill/start.S
PATCH 9/15 x86: intel: cougarcanyon2: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
--- board/intel/cougarcanyon2/Makefile | 2 +- board/intel/cougarcanyon2/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/cougarcanyon2/start.S
board/intel/cougarcanyon2/Makefile +1 -1
@@ -2,4 +2,4 @@ # # Copyright (C) 2016, Bin Meng <[email protected]> -obj-y += cougarcanyon2.o start.o +obj-y += cougarcanyon2.o
board/intel/cougarcanyon2/start.S deleted +0 -8
@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2016, Bin Meng <[email protected]> - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.27.0
PATCH 9/15 x86: intel: cougarcanyon2: Remove dead code
Quoted 10 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.Signed-off-by Andy Shevchenko <[email protected]>--- board/intel/cougarcanyon2/Makefile | 2 +- board/intel/cougarcanyon2/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/cougarcanyon2/start.S
PATCH 10/15 x86: intel: crownbay: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
--- board/intel/crownbay/Makefile | 2 +- board/intel/crownbay/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/crownbay/start.S
board/intel/crownbay/Makefile +1 -1
@@ -2,4 +2,4 @@ # # Copyright (C) 2014, Bin Meng <[email protected]> -obj-y += crownbay.o start.o +obj-y += crownbay.o
board/intel/crownbay/start.S deleted +0 -8
@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2014, Bin Meng <[email protected]> - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.27.0
PATCH 10/15 x86: intel: crownbay: Remove dead code
Quoted 11 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.Signed-off-by Andy Shevchenko <[email protected]>--- board/intel/crownbay/Makefile | 2 +- board/intel/crownbay/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/crownbay/start.S
PATCH 11/15 x86: intel: edison: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
--- board/intel/edison/Makefile | 2 +- board/intel/edison/start.S | 12 ------------ 2 files changed, 1 insertion(+), 13 deletions(-) delete mode 100644 board/intel/edison/start.S
board/intel/edison/Makefile +1 -1
@@ -4,5 +4,5 @@ # SPDX-License-Identifier: GPL-2.0+ # -obj-y += start.o edison.o +obj-y += edison.o obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
board/intel/edison/start.S deleted +0 -12
@@ -1,12 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (c) 2011 The Chromium OS Authors. - * (C) Copyright 2008 - * Graeme Russ, graeme.russ at gmail.com. - */ - -/* board early intialization */ -.globl early_board_init -early_board_init: - /* No 32-bit board specific initialisation */ - jmp early_board_init_ret
Signature · 1 line
2.27.0
PATCH 11/15 x86: intel: edison: Remove dead code
Quoted 11 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.Signed-off-by Andy Shevchenko <[email protected]>--- board/intel/edison/Makefile | 2 +- board/intel/edison/start.S | 12 ------------ 2 files changed, 1 insertion(+), 13 deletions(-) delete mode 100644 board/intel/edison/start.S
PATCH 12/15 x86: intel: galileo: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
--- board/intel/galileo/Makefile | 2 +- board/intel/galileo/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/galileo/start.S
board/intel/galileo/Makefile +1 -1
@@ -2,5 +2,5 @@ # # Copyright (C) 2015, Bin Meng <[email protected]> -obj-y += galileo.o start.o +obj-y += galileo.o obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
board/intel/galileo/start.S deleted +0 -8
@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2015, Bin Meng <[email protected]> - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.27.0
PATCH 12/15 x86: intel: galileo: Remove dead code
Quoted 10 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.Signed-off-by Andy Shevchenko <[email protected]>--- board/intel/galileo/Makefile | 2 +- board/intel/galileo/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/galileo/start.S
PATCH 13/15 x86: intel: minnowmax: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
--- board/intel/minnowmax/Makefile | 2 +- board/intel/minnowmax/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/minnowmax/start.S
board/intel/minnowmax/Makefile +1 -1
@@ -2,5 +2,5 @@ # # Copyright (C) 2015, Google, Inc -obj-y += minnowmax.o start.o +obj-y += minnowmax.o obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
board/intel/minnowmax/start.S deleted +0 -8
@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2015, Google, Inc - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.27.0
PATCH 13/15 x86: intel: minnowmax: Remove dead code
Quoted 11 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.Signed-off-by Andy Shevchenko <[email protected]>--- board/intel/minnowmax/Makefile | 2 +- board/intel/minnowmax/start.S | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) delete mode 100644 board/intel/minnowmax/start.S
PATCH 14/15 x86: intel: slimbootloader: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
--- board/intel/slimbootloader/Makefile | 2 +- board/intel/slimbootloader/start.S | 9 --------- 2 files changed, 1 insertion(+), 10 deletions(-) delete mode 100644 board/intel/slimbootloader/start.S
board/intel/slimbootloader/Makefile +1 -1
@@ -2,4 +2,4 @@ # # Copyright (C) 2019 Intel Corporation <www.intel.com> -obj-y += start.o slimbootloader.o +obj-y += slimbootloader.o
board/intel/slimbootloader/start.S deleted +0 -9
@@ -1,9 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2019 Intel Corporation <www.intel.com> - */ - -/* board early initialization */ -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.27.0
PATCH 14/15 x86: intel: slimbootloader: Remove dead code
Quoted 11 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.Cc Aiden Park <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>--- board/intel/slimbootloader/Makefile | 2 +- board/intel/slimbootloader/start.S | 9 --------- 2 files changed, 1 insertion(+), 10 deletions(-) delete mode 100644 board/intel/slimbootloader/start.S
Park
PATCH 14/15 x86: intel: slimbootloader: Remove dead code
In reply to Andy ShevchenkoQuoted 48 lines
-----Original Message-----
From: Andy Shevchenko <[email protected]>
Sent: Thursday, August 6, 2020 7:55 AM
To: Simon Glass <[email protected]>; Bin Meng <[email protected]>; u- boot at lists.denx.de
Cc: Andy Shevchenko <[email protected]>; Park, Aiden <[email protected]>
Subject: [PATCH v1 14/15] x86: intel: slimbootloader: Remove dead code
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.Cc Aiden Park <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>---
board/intel/slimbootloader/Makefile | 2 +-board/intel/slimbootloader/start.S
| 9 ---------2 files changed, 1 insertion(+), 10 deletions(-) delete mode 100644
board/intel/slimbootloader/start.Sboard/intel/slimbootloader/Makefile +1
-1@@ -2,4 +2,4 @@ # # Copyright (C) 2019 Intel Corporation <www.intel.com> -obj-y += start.o slimbootloader.o +obj-y += slimbootloader.oboard/intel/slimbootloader/start.S deleted +0
-10@@ -1,9 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2019 Intel Corporation <www.intel.com> - */ - -/* board early initialization */ -.globl early_board_init -early_board_init: - jmp early_board_init_ret --
Quoted 1 line
2.27.0
PATCH 1/15 x86: Introduce USE_EARLY_BOARD_INIT option
In reply to Andy ShevchenkoQuoted 6 lines · Andy Shevchenko
Introduce
USE_EARLY_BOARD_INIToption and select it by the actual users.Cc Aiden Park <[email protected]>Cc Stefan Roese <[email protected]>Cc George McCollister <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>
Thanks,
Stefan
Quoted 73 lines
--- arch/x86/Kconfig | 3 +++ arch/x86/cpu/start.S | 3 +++ board/google/chromebook_coral/Kconfig | 1 + board/google/chromebook_link/Kconfig | 1 + board/google/chromebook_samus/Kconfig | 1 + 5 files changed, 9 insertions(+)arch/x86/Kconfig +3
-0@@ -203,6 +203,9 @@ config SPL_X86_32BIT_INIT help This is enabled when 32-bit init is in SPL +config USE_EARLY_BOARD_INIT + bool + config RESET_SEG_START hex depends on X86_RESET_VECTORarch/x86/cpu/start.S +3
-0@@ -88,6 +88,7 @@ _start: /* Clear the interrupt vectors */ lidt blank_idt_ptr +#ifdef USE_EARLY_BOARD_INIT /* * Critical early platform init - generally not used, we prefer init * to happen later when we have a console, in case something goes@@ -96,6 +97,8 @@ _start: jmp early_board_init .globl early_board_init_ret early_board_init_ret: +#endif + post_code(POST_START) /* Initialise Cache-As-RAM */board/google/chromebook_coral/Kconfig +1
-0@@ -18,6 +18,7 @@ config SYS_TEXT_BASE config BOARD_SPECIFIC_OPTIONS # dummy def_bool y select X86_RESET_VECTOR + select USE_EARLY_BOARD_INIT select INTEL_APOLLOLAKE select BOARD_ROMSIZE_KB_16384board/google/chromebook_link/Kconfig +1
-0@@ -19,6 +19,7 @@ config SYS_TEXT_BASE config BOARD_SPECIFIC_OPTIONS # dummy def_bool y select X86_RESET_VECTOR + select USE_EARLY_BOARD_INIT select NORTHBRIDGE_INTEL_IVYBRIDGE select HAVE_INTEL_ME select BOARD_ROMSIZE_KB_8192board/google/chromebook_samus/Kconfig +0
-0
board/google/chromebook_samus/Kconfig config SYS_TEXT_BASE · line 25
Quoted 7 lines
board/google/chromebook_samus/Kconfig +1
-0@@ -19,6 +19,7 @@ config SYS_TEXT_BASE config BOARD_SPECIFIC_OPTIONS # dummy def_bool y select X86_RESET_VECTOR + select USE_EARLY_BOARD_INIT select INTEL_BROADWELL select HAVE_INTEL_ME select BOARD_ROMSIZE_KB_8192
Viele Gr??e,
Stefan
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de
Park
PATCH 1/15 x86: Introduce USE_EARLY_BOARD_INIT option
In reply to Andy ShevchenkoQuoted 99 lines
-----Original Message-----
From: Andy Shevchenko <[email protected]>
Sent: Thursday, August 6, 2020 7:54 AM
To: Simon Glass <[email protected]>; Bin Meng <[email protected]>; u- boot at lists.denx.de
Cc: Andy Shevchenko <[email protected]>; Park, Aiden <[email protected]>; Stefan Roese <[email protected]>; George McCollister <[email protected]>
Subject: [PATCH v1 01/15] x86: IntroduceUSE_EARLY_BOARD_INIToptionIntroduce
USE_EARLY_BOARD_INIToption and select it by the actual users.Cc Aiden Park <[email protected]>Cc Stefan Roese <[email protected]>Cc George McCollister <[email protected]>Signed-off-by Andy Shevchenko <[email protected]>--- arch/x86/Kconfig | 3 +++ arch/x86/cpu/start.S | 3 +++ board/google/chromebook_coral/Kconfig | 1 + board/google/chromebook_link/Kconfig | 1 + board/google/chromebook_samus/Kconfig | 1 + 5 files changed, 9 insertions(+)arch/x86/Kconfig index renamed from arch/x86/Kconfig +0
-0
ff4f06ed79cc..167cc96205c5100644arch/x86/Kconfig +3
-0@@ -203,6 +203,9 @@ config SPL_X86_32BIT_INIT help This is enabled when 32-bit init is in SPL +config USE_EARLY_BOARD_INIT + bool + config RESET_SEG_START hex depends on X86_RESET_VECTORarch/x86/cpu/start.S index renamed from arch/x86/cpu/start.S +0
-0
4ad515ce0856..8d00c97db42c100644arch/x86/cpu/start.S +3
-1@@ -88,6 +88,7 @@ _start: /* Clear the interrupt vectors */ lidt blank_idt_ptr +#ifdef USE_EARLY_BOARD_INIT /* * Critical early platform init - generally not used, we prefer init * to happen later when we have a console, in case something goes @@ -96,6 +97,8 @@ _start: jmp early_board_init .globl early_board_init_ret early_board_init_ret: +#endif + post_code(POST_START) /* Initialise Cache-As-RAM */board/google/chromebook_coral/Kconfig +1
-0@@ -18,6 +18,7 @@ config SYS_TEXT_BASE config BOARD_SPECIFIC_OPTIONS # dummy def_bool y select X86_RESET_VECTOR + select USE_EARLY_BOARD_INIT select INTEL_APOLLOLAKE select BOARD_ROMSIZE_KB_16384board/google/chromebook_link/Kconfig +1
-0@@ -19,6 +19,7 @@ config SYS_TEXT_BASE config BOARD_SPECIFIC_OPTIONS # dummy def_bool y select X86_RESET_VECTOR + select USE_EARLY_BOARD_INIT select NORTHBRIDGE_INTEL_IVYBRIDGE select HAVE_INTEL_ME select BOARD_ROMSIZE_KB_8192board/google/chromebook_samus/Kconfig +1
-1@@ -19,6 +19,7 @@ config SYS_TEXT_BASE config BOARD_SPECIFIC_OPTIONS # dummy def_bool y select X86_RESET_VECTOR + select USE_EARLY_BOARD_INIT select INTEL_BROADWELL select HAVE_INTEL_ME select BOARD_ROMSIZE_KB_8192 --
Quoted 1 line
2.27.0
PATCH 15/15 x86: qemu: Remove dead code
In reply to Andy Shevchenkostart.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.
--- board/emulation/qemu-x86/Makefile | 2 -- board/emulation/qemu-x86/start.S | 8 -------- 2 files changed, 10 deletions(-) delete mode 100644 board/emulation/qemu-x86/start.S
board/emulation/qemu-x86/Makefile +0 -2
@@ -1,5 +1,3 @@ # SPDX-License-Identifier: GPL-2.0+ # # Copyright (C) 2015, Bin Meng <[email protected]> - -obj-y += start.o
board/emulation/qemu-x86/start.S deleted +0 -8
@@ -1,8 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * Copyright (C) 2015, Bin Meng <[email protected]> - */ - -.globl early_board_init -early_board_init: - jmp early_board_init_ret
Signature · 1 line
2.27.0
PATCH 15/15 x86: qemu: Remove dead code
Quoted 10 lines · Andy Shevchenko
start.Sdoes nothing and can be safely removed.Makefileis still being used by the build system, so simply drop the rule from it.Signed-off-by Andy Shevchenko <[email protected]>--- board/emulation/qemu-x86/Makefile | 2 -- board/emulation/qemu-x86/start.S | 8 -------- 2 files changed, 10 deletions(-) delete mode 100644 board/emulation/qemu-x86/start.S