Skip to contentSkip to conversation

x86: Introduce USE_EARLY_BOARD_INIT option

PATCH Superseded Andy Shevchenko 4 participants 33 messages Aug 6, 2020 – Aug 20, 2020 x86

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/15 x86: Introduce USE_EARLY_BOARD_INIT option

Introduce USE_EARLY_BOARD_INIT option and select it by the actual users.

Cc Aiden Park <[email protected]>
Cc Stefan Roese <[email protected]>
Cc George McCollister <[email protected]>
---
 arch/x86/Kconfig                      | 3 +++
 arch/x86/cpu/start.S                  | 3 +++
 board/google/chromebook_coral/Kconfig | 1 +
 board/google/chromebook_link/Kconfig  | 1 +
 board/google/chromebook_samus/Kconfig | 1 +
 5 files changed, 9 insertions(+)
arch/x86/Kconfig +3 -0
index ff4f06ed79cc..167cc96205c5 100644
@@ -203,6 +203,9 @@ config SPL_X86_32BIT_INIT
 	help
 	  This is enabled when 32-bit init is in SPL
 
+config USE_EARLY_BOARD_INIT
+	bool
+
 config RESET_SEG_START
 	hex
 	depends on X86_RESET_VECTOR
arch/x86/cpu/start.S +3 -0
index 4ad515ce0856..8d00c97db42c 100644
@@ -88,6 +88,7 @@ _start:
 	/* Clear the interrupt vectors */
 	lidt	blank_idt_ptr
 
+#ifdef USE_EARLY_BOARD_INIT
 	/*
 	 * Critical early platform init - generally not used, we prefer init
 	 * to happen later when we have a console, in case something goes
@@ -96,6 +97,8 @@ _start:
 	jmp	early_board_init
 .globl early_board_init_ret
 early_board_init_ret:
+#endif
+
 	post_code(POST_START)
 
 	/* Initialise Cache-As-RAM */
board/google/chromebook_coral/Kconfig +1 -0
index 940bee89b0b6..27671958e146 100644
@@ -18,6 +18,7 @@ config SYS_TEXT_BASE
 config BOARD_SPECIFIC_OPTIONS # dummy
 	def_bool y
 	select X86_RESET_VECTOR
+	select USE_EARLY_BOARD_INIT
 	select INTEL_APOLLOLAKE
 	select BOARD_ROMSIZE_KB_16384
 
board/google/chromebook_link/Kconfig +1 -0
index 944716d002c9..dd29ddf694be 100644
@@ -19,6 +19,7 @@ config SYS_TEXT_BASE
 config BOARD_SPECIFIC_OPTIONS # dummy
 	def_bool y
 	select X86_RESET_VECTOR
+	select USE_EARLY_BOARD_INIT
 	select NORTHBRIDGE_INTEL_IVYBRIDGE
 	select HAVE_INTEL_ME
 	select BOARD_ROMSIZE_KB_8192
board/google/chromebook_samus/Kconfig +1 -0
index 90c23cba1bed..9f66d7998870 100644
@@ -19,6 +19,7 @@ config SYS_TEXT_BASE
 config BOARD_SPECIFIC_OPTIONS # dummy
 	def_bool y
 	select X86_RESET_VECTOR
+	select USE_EARLY_BOARD_INIT
 	select INTEL_BROADWELL
 	select HAVE_INTEL_ME
 	select BOARD_ROMSIZE_KB_8192
Signature · 1 line
2.27.0
#1 lore raw

PATCH 1/15 x86: Introduce USE_EARLY_BOARD_INIT option

Quoted 1 line · Andy Shevchenko

Introduce USE_EARLY_BOARD_INIT option and select it by the actual users.

...

Quoted 1 line

+#ifdef USE_EARLY_BOARD_INIT

And here I missed CONFIG_ prefix...

I'll fix this in v2.

Quoted 8 lines
arch/x86/cpu/start.S +1 -0
 	/*
 	 * Critical early platform init - generally not used, we prefer init
 	 * to happen later when we have a console, in case something goes
@@ -96,6 +97,8 @@ _start:
 	jmp	early_board_init
 .globl early_board_init_ret
 early_board_init_ret:
+#endif
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw

PATCH 2/15 x86: advantech: som-db5800-som-6867: Remove dead code

In reply to Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

Cc George McCollister <[email protected]>
---
 board/advantech/som-db5800-som-6867/Makefile | 2 +-
 board/advantech/som-db5800-som-6867/start.S  | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100644 board/advantech/som-db5800-som-6867/start.S
board/advantech/som-db5800-som-6867/Makefile +1 -1
index 0524766bb718..7975547f4109 100644
@@ -2,5 +2,5 @@
 #
 # Copyright (C) 2015, Google, Inc
 
-obj-y	+= som-db5800-som-6867.o start.o
+obj-y	+= som-db5800-som-6867.o
 obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
board/advantech/som-db5800-som-6867/start.S deleted +0 -8
deleted file mode 100644
index 65d1f7e96150..000000000000
@@ -1,8 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (C) 2015, Google, Inc
- */
-
-.globl early_board_init
-early_board_init:
-	jmp	early_board_init_ret
Signature · 1 line
2.27.0
#3 lore raw

PATCH 2/15 x86: advantech: som-db5800-som-6867: Remove dead code

Quoted 4 lines · Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

Quoted 8 lines
Cc George McCollister <[email protected]>
---
 board/advantech/som-db5800-som-6867/Makefile | 2 +-
 board/advantech/som-db5800-som-6867/start.S  | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100644 board/advantech/som-db5800-som-6867/start.S
#4 lore raw

PATCH 3/15 x86: congatec: conga-qeval20-qa3-e3845: Remove dead code

In reply to Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/congatec/conga-qeval20-qa3-e3845/Makefile | 2 +-
 board/congatec/conga-qeval20-qa3-e3845/start.S  | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100644 board/congatec/conga-qeval20-qa3-e3845/start.S
board/congatec/conga-qeval20-qa3-e3845/Makefile +1 -1
index 2f04828a27f2..451a4fcd6c4d 100644
@@ -2,5 +2,5 @@
 #
 # Copyright (C) 2015, Google, Inc
 
-obj-y	+= conga-qeval20-qa3.o start.o
+obj-y	+= conga-qeval20-qa3.o
 obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
board/congatec/conga-qeval20-qa3-e3845/start.S deleted +0 -8
deleted file mode 100644
index 65d1f7e96150..000000000000
@@ -1,8 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (C) 2015, Google, Inc
- */
-
-.globl early_board_init
-early_board_init:
-	jmp	early_board_init_ret
Signature · 1 line
2.27.0
#5 lore raw

PATCH 3/15 x86: congatec: conga-qeval20-qa3-e3845: Remove dead code

Quoted 5 lines · Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

Thanks,
Stefan

Quoted 24 lines
---
  board/congatec/conga-qeval20-qa3-e3845/Makefile | 2 +-
  board/congatec/conga-qeval20-qa3-e3845/start.S  | 8 --------
  2 files changed, 1 insertion(+), 9 deletions(-)

delete mode 100644 board/congatec/conga-qeval20-qa3-e3845/start.S

board/congatec/conga-qeval20-qa3-e3845/Makefile +1 -1
index 2f04828a27f2..451a4fcd6c4d 100644
@@ -2,5 +2,5 @@
  #
  # Copyright (C) 2015, Google, Inc
 
-obj-y	+= conga-qeval20-qa3.o start.o
+obj-y	+= conga-qeval20-qa3.o
  obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
board/congatec/conga-qeval20-qa3-e3845/start.S deleted +0 -0
deleted file mode 100644
index 65d1f7e96150..000000000000

board/congatec/conga-qeval20-qa3-e3845/start.S line 8

Quoted 8 lines
board/congatec/conga-qeval20-qa3-e3845/start.S deleted +0 -8
@@ -1,8 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (C) 2015, Google, Inc
- */
-
-.globl early_board_init
-early_board_init:
-	jmp	early_board_init_ret

Viele Gr??e,
Stefan

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de
#6 lore raw

PATCH 4/15 x86: coreboot: Remove dead code

In reply to Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/coreboot/coreboot/Makefile |  2 +-
 board/coreboot/coreboot/start.S  | 12 ------------
 2 files changed, 1 insertion(+), 13 deletions(-)
 delete mode 100644 board/coreboot/coreboot/start.S
board/coreboot/coreboot/Makefile +1 -1
index 8db7cc62f309..d292b7032c23 100644
@@ -10,4 +10,4 @@
 # (C) Copyright 2002
 # Daniel Engstr?m, Omicron Ceti AB, daniel at omicron.se.
 
-obj-y	+= start.o coreboot.o
+obj-y	+= coreboot.o
board/coreboot/coreboot/start.S deleted +0 -12
deleted file mode 100644
index aa702622d48c..000000000000
@@ -1,12 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (c) 2011 The Chromium OS Authors.
- * (C) Copyright 2008
- * Graeme Russ, graeme.russ at gmail.com.
- */
-
-/* board early intialization */
-.globl early_board_init
-early_board_init:
-	/* No 32-bit board specific initialisation */
-	jmp	early_board_init_ret
Signature · 1 line
2.27.0
#7 lore raw

PATCH 4/15 x86: coreboot: Remove dead code

Quoted 11 lines · Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/coreboot/coreboot/Makefile |  2 +-
 board/coreboot/coreboot/start.S  | 12 ------------
 2 files changed, 1 insertion(+), 13 deletions(-)
 delete mode 100644 board/coreboot/coreboot/start.S
#8 lore raw

PATCH 5/15 x86: dfi: dfi-bt700: Remove dead code

In reply to Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/dfi/dfi-bt700/Makefile | 2 +-
 board/dfi/dfi-bt700/start.S  | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100644 board/dfi/dfi-bt700/start.S
board/dfi/dfi-bt700/Makefile +1 -1
index 99cf357b701f..50d88f295458 100644
@@ -2,5 +2,5 @@
 #
 # Copyright (C) 2015, Google, Inc
 
-obj-y	+= dfi-bt700.o start.o
+obj-y	+= dfi-bt700.o
 obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
board/dfi/dfi-bt700/start.S deleted +0 -8
deleted file mode 100644
index 65d1f7e96150..000000000000
@@ -1,8 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (C) 2015, Google, Inc
- */
-
-.globl early_board_init
-early_board_init:
-	jmp	early_board_init_ret
Signature · 1 line
2.27.0
#9 lore raw

PATCH 5/15 x86: dfi: dfi-bt700: Remove dead code

Quoted 5 lines · Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

Thanks,
Stefan

Quoted 24 lines
---
  board/dfi/dfi-bt700/Makefile | 2 +-
  board/dfi/dfi-bt700/start.S  | 8 --------
  2 files changed, 1 insertion(+), 9 deletions(-)

delete mode 100644 board/dfi/dfi-bt700/start.S

board/dfi/dfi-bt700/Makefile +1 -1
index 99cf357b701f..50d88f295458 100644
@@ -2,5 +2,5 @@
  #
  # Copyright (C) 2015, Google, Inc
 
-obj-y	+= dfi-bt700.o start.o
+obj-y	+= dfi-bt700.o
  obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
board/dfi/dfi-bt700/start.S deleted +0 -0
deleted file mode 100644
index 65d1f7e96150..000000000000

board/dfi/dfi-bt700/start.S line 8

Quoted 8 lines
board/dfi/dfi-bt700/start.S deleted +0 -8
@@ -1,8 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (C) 2015, Google, Inc
- */
-
-.globl early_board_init
-early_board_init:
-	jmp	early_board_init_ret

Viele Gr??e,
Stefan

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de
#10 lore raw

PATCH 6/15 x86: efi: efi-x86_payload: Remove dead code

In reply to Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/efi/efi-x86_payload/Makefile | 2 +-
 board/efi/efi-x86_payload/start.S  | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100644 board/efi/efi-x86_payload/start.S
board/efi/efi-x86_payload/Makefile +1 -1
index 00ef69534d00..a4ebc85aa5b3 100644
@@ -2,4 +2,4 @@
 #
 # Copyright (C) 2018, Bin Meng <[email protected]>
 
-obj-y	+= start.o payload.o
+obj-y	+= payload.o
board/efi/efi-x86_payload/start.S deleted +0 -8
deleted file mode 100644
index f7eaa7cb12a9..000000000000
@@ -1,8 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (C) 2018, Bin Meng <[email protected]>
- */
-
-.globl early_board_init
-early_board_init:
-	jmp	early_board_init_ret
Signature · 1 line
2.27.0
#11 lore raw

PATCH 6/15 x86: efi: efi-x86_payload: Remove dead code

Quoted 11 lines · Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/efi/efi-x86_payload/Makefile | 2 +-
 board/efi/efi-x86_payload/start.S  | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100644 board/efi/efi-x86_payload/start.S
#12 lore raw

PATCH 7/15 x86: intel: bayleybay: Remove dead code

In reply to Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/intel/bayleybay/Makefile | 2 +-
 board/intel/bayleybay/start.S  | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100644 board/intel/bayleybay/start.S
board/intel/bayleybay/Makefile +1 -1
index e0553f146248..d19447184a6e 100644
@@ -2,5 +2,5 @@
 #
 # Copyright (C) 2015, Bin Meng <[email protected]>
 
-obj-y	+= bayleybay.o start.o
+obj-y	+= bayleybay.o
 obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
board/intel/bayleybay/start.S deleted +0 -8
deleted file mode 100644
index e4bde561b20d..000000000000
@@ -1,8 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (C) 2015, Bin Meng <[email protected]>
- */
-
-.globl early_board_init
-early_board_init:
-	jmp	early_board_init_ret
Signature · 1 line
2.27.0
#13 lore raw

PATCH 7/15 x86: intel: bayleybay: Remove dead code

Quoted 11 lines · Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/intel/bayleybay/Makefile | 2 +-
 board/intel/bayleybay/start.S  | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100644 board/intel/bayleybay/start.S
#14 lore raw

PATCH 8/15 x86: intel: cherryhill: Remove dead code

In reply to Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/intel/cherryhill/Makefile | 2 +-
 board/intel/cherryhill/start.S  | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100644 board/intel/cherryhill/start.S
board/intel/cherryhill/Makefile +1 -1
index b09581a9195e..ff6e14836a11 100644
@@ -2,4 +2,4 @@
 #
 # Copyright (C) 2017, Bin Meng <[email protected]>
 
-obj-y	+= cherryhill.o start.o
+obj-y	+= cherryhill.o
board/intel/cherryhill/start.S deleted +0 -8
deleted file mode 100644
index 2e3e7f840944..000000000000
@@ -1,8 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (C) 2017, Bin Meng <[email protected]>
- */
-
-.globl early_board_init
-early_board_init:
-	jmp	early_board_init_ret
Signature · 1 line
2.27.0
#15 lore raw

PATCH 8/15 x86: intel: cherryhill: Remove dead code

Quoted 11 lines · Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/intel/cherryhill/Makefile | 2 +-
 board/intel/cherryhill/start.S  | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100644 board/intel/cherryhill/start.S
#16 lore raw

PATCH 9/15 x86: intel: cougarcanyon2: Remove dead code

In reply to Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/intel/cougarcanyon2/Makefile | 2 +-
 board/intel/cougarcanyon2/start.S  | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100644 board/intel/cougarcanyon2/start.S
board/intel/cougarcanyon2/Makefile +1 -1
index 75cc508f4ec0..13b19ae65389 100644
@@ -2,4 +2,4 @@
 #
 # Copyright (C) 2016, Bin Meng <[email protected]>
 
-obj-y	+= cougarcanyon2.o start.o
+obj-y	+= cougarcanyon2.o
board/intel/cougarcanyon2/start.S deleted +0 -8
deleted file mode 100644
index 8521800921e4..000000000000
@@ -1,8 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (C) 2016, Bin Meng <[email protected]>
- */
-
-.globl early_board_init
-early_board_init:
-	jmp	early_board_init_ret
Signature · 1 line
2.27.0
#17 lore raw

PATCH 9/15 x86: intel: cougarcanyon2: Remove dead code

Quoted 10 lines · Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/intel/cougarcanyon2/Makefile | 2 +-
 board/intel/cougarcanyon2/start.S  | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100644 board/intel/cougarcanyon2/start.S
#18 lore raw

PATCH 10/15 x86: intel: crownbay: Remove dead code

In reply to Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/intel/crownbay/Makefile | 2 +-
 board/intel/crownbay/start.S  | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100644 board/intel/crownbay/start.S
board/intel/crownbay/Makefile +1 -1
index b52c69aeaa1b..6abd3eeb5540 100644
@@ -2,4 +2,4 @@
 #
 # Copyright (C) 2014, Bin Meng <[email protected]>
 
-obj-y	+= crownbay.o start.o
+obj-y	+= crownbay.o
board/intel/crownbay/start.S deleted +0 -8
deleted file mode 100644
index 7faa7d05fae4..000000000000
@@ -1,8 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (C) 2014, Bin Meng <[email protected]>
- */
-
-.globl early_board_init
-early_board_init:
-	jmp	early_board_init_ret
Signature · 1 line
2.27.0
#19 lore raw

PATCH 10/15 x86: intel: crownbay: Remove dead code

Quoted 11 lines · Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/intel/crownbay/Makefile | 2 +-
 board/intel/crownbay/start.S  | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100644 board/intel/crownbay/start.S
#20 lore raw

PATCH 11/15 x86: intel: edison: Remove dead code

In reply to Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/intel/edison/Makefile |  2 +-
 board/intel/edison/start.S  | 12 ------------
 2 files changed, 1 insertion(+), 13 deletions(-)
 delete mode 100644 board/intel/edison/start.S
board/intel/edison/Makefile +1 -1
index eed8d65eb661..1eaf7ca7f8e2 100644
@@ -4,5 +4,5 @@
 # SPDX-License-Identifier:     GPL-2.0+
 #
 
-obj-y	+= start.o edison.o
+obj-y	+= edison.o
 obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
board/intel/edison/start.S deleted +0 -12
deleted file mode 100644
index aa702622d48c..000000000000
@@ -1,12 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (c) 2011 The Chromium OS Authors.
- * (C) Copyright 2008
- * Graeme Russ, graeme.russ at gmail.com.
- */
-
-/* board early intialization */
-.globl early_board_init
-early_board_init:
-	/* No 32-bit board specific initialisation */
-	jmp	early_board_init_ret
Signature · 1 line
2.27.0
#21 lore raw

PATCH 11/15 x86: intel: edison: Remove dead code

Quoted 11 lines · Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/intel/edison/Makefile |  2 +-
 board/intel/edison/start.S  | 12 ------------
 2 files changed, 1 insertion(+), 13 deletions(-)
 delete mode 100644 board/intel/edison/start.S
#22 lore raw

PATCH 12/15 x86: intel: galileo: Remove dead code

In reply to Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/intel/galileo/Makefile | 2 +-
 board/intel/galileo/start.S  | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100644 board/intel/galileo/start.S
board/intel/galileo/Makefile +1 -1
index e8f58bff9aca..4130bb023656 100644
@@ -2,5 +2,5 @@
 #
 # Copyright (C) 2015, Bin Meng <[email protected]>
 
-obj-y	+= galileo.o start.o
+obj-y	+= galileo.o
 obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
board/intel/galileo/start.S deleted +0 -8
deleted file mode 100644
index e4bde561b20d..000000000000
@@ -1,8 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (C) 2015, Bin Meng <[email protected]>
- */
-
-.globl early_board_init
-early_board_init:
-	jmp	early_board_init_ret
Signature · 1 line
2.27.0
#23 lore raw

PATCH 12/15 x86: intel: galileo: Remove dead code

Quoted 10 lines · Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/intel/galileo/Makefile | 2 +-
 board/intel/galileo/start.S  | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100644 board/intel/galileo/start.S
#24 lore raw

PATCH 13/15 x86: intel: minnowmax: Remove dead code

In reply to Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/intel/minnowmax/Makefile | 2 +-
 board/intel/minnowmax/start.S  | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100644 board/intel/minnowmax/start.S
board/intel/minnowmax/Makefile +1 -1
index 989344df1c91..d339b5ad0a54 100644
@@ -2,5 +2,5 @@
 #
 # Copyright (C) 2015, Google, Inc
 
-obj-y	+= minnowmax.o start.o
+obj-y	+= minnowmax.o
 obj-$(CONFIG_GENERATE_ACPI_TABLE) += dsdt.o
board/intel/minnowmax/start.S deleted +0 -8
deleted file mode 100644
index 65d1f7e96150..000000000000
@@ -1,8 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (C) 2015, Google, Inc
- */
-
-.globl early_board_init
-early_board_init:
-	jmp	early_board_init_ret
Signature · 1 line
2.27.0
#25 lore raw

PATCH 13/15 x86: intel: minnowmax: Remove dead code

Quoted 11 lines · Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/intel/minnowmax/Makefile | 2 +-
 board/intel/minnowmax/start.S  | 8 --------
 2 files changed, 1 insertion(+), 9 deletions(-)
 delete mode 100644 board/intel/minnowmax/start.S
#26 lore raw

PATCH 14/15 x86: intel: slimbootloader: Remove dead code

In reply to Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/intel/slimbootloader/Makefile | 2 +-
 board/intel/slimbootloader/start.S  | 9 ---------
 2 files changed, 1 insertion(+), 10 deletions(-)
 delete mode 100644 board/intel/slimbootloader/start.S
board/intel/slimbootloader/Makefile +1 -1
index fd8fa98a8d39..50330cc6e5db 100644
@@ -2,4 +2,4 @@
 #
 # Copyright (C) 2019 Intel Corporation <www.intel.com>
 
-obj-y	+= start.o slimbootloader.o
+obj-y	+= slimbootloader.o
board/intel/slimbootloader/start.S deleted +0 -9
deleted file mode 100644
index 5c3f3df09eb0..000000000000
@@ -1,9 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (C) 2019 Intel Corporation <www.intel.com>
- */
-
-/* board early initialization */
-.globl early_board_init
-early_board_init:
-	jmp	early_board_init_ret
Signature · 1 line
2.27.0
#27 lore raw

PATCH 14/15 x86: intel: slimbootloader: Remove dead code

Quoted 11 lines · Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/intel/slimbootloader/Makefile | 2 +-
 board/intel/slimbootloader/start.S  | 9 ---------
 2 files changed, 1 insertion(+), 10 deletions(-)
 delete mode 100644 board/intel/slimbootloader/start.S
#28 lore raw

PATCH 14/15 x86: intel: slimbootloader: Remove dead code

In reply to Andy Shevchenko
Quoted 48 lines

-----Original Message-----
From: Andy Shevchenko <[email protected]>
Sent: Thursday, August 6, 2020 7:55 AM
To: Simon Glass <[email protected]>; Bin Meng <[email protected]>; u- boot at lists.denx.de
Cc: Andy Shevchenko <[email protected]>; Park, Aiden <[email protected]>
Subject: [PATCH v1 14/15] x86: intel: slimbootloader: Remove dead code

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
board/intel/slimbootloader/Makefile | 2 +- board/intel/slimbootloader/start.S
| 9 ---------

 2 files changed, 1 insertion(+), 10 deletions(-)  delete mode 100644

board/intel/slimbootloader/start.S

board/intel/slimbootloader/Makefile +1 -1
index fd8fa98a8d39..50330cc6e5db 100644
@@ -2,4 +2,4 @@
 #
 # Copyright (C) 2019 Intel Corporation <www.intel.com>
 
-obj-y	+= start.o slimbootloader.o
+obj-y	+= slimbootloader.o
board/intel/slimbootloader/start.S deleted +0 -10
deleted file mode 100644
index 5c3f3df09eb0..000000000000
@@ -1,9 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (C) 2019 Intel Corporation <www.intel.com>
- */
-
-/* board early initialization */
-.globl early_board_init
-early_board_init:
-	jmp	early_board_init_ret
--
Quoted 1 line

2.27.0

#29 lore raw

PATCH 1/15 x86: Introduce USE_EARLY_BOARD_INIT option

In reply to Andy Shevchenko
Quoted 6 lines · Andy Shevchenko

Introduce USE_EARLY_BOARD_INIT option and select it by the actual users.

Cc Aiden Park <[email protected]>
Cc Stefan Roese <[email protected]>
Cc George McCollister <[email protected]>

Thanks,
Stefan

Quoted 73 lines
---
  arch/x86/Kconfig                      | 3 +++
  arch/x86/cpu/start.S                  | 3 +++
  board/google/chromebook_coral/Kconfig | 1 +
  board/google/chromebook_link/Kconfig  | 1 +
  board/google/chromebook_samus/Kconfig | 1 +
  5 files changed, 9 insertions(+)
arch/x86/Kconfig +3 -0
index ff4f06ed79cc..167cc96205c5 100644
@@ -203,6 +203,9 @@ config SPL_X86_32BIT_INIT
  	help
  	  This is enabled when 32-bit init is in SPL
 
+config USE_EARLY_BOARD_INIT
+	bool
+
  config RESET_SEG_START
  	hex
  	depends on X86_RESET_VECTOR
arch/x86/cpu/start.S +3 -0
index 4ad515ce0856..8d00c97db42c 100644
@@ -88,6 +88,7 @@ _start:
  	/* Clear the interrupt vectors */
  	lidt	blank_idt_ptr
 
+#ifdef USE_EARLY_BOARD_INIT
  	/*
  	 * Critical early platform init - generally not used, we prefer init
  	 * to happen later when we have a console, in case something goes
@@ -96,6 +97,8 @@ _start:
  	jmp	early_board_init
  .globl early_board_init_ret
  early_board_init_ret:
+#endif
+
  	post_code(POST_START)
 
  	/* Initialise Cache-As-RAM */
board/google/chromebook_coral/Kconfig +1 -0
index 940bee89b0b6..27671958e146 100644
@@ -18,6 +18,7 @@ config SYS_TEXT_BASE
  config BOARD_SPECIFIC_OPTIONS # dummy
  	def_bool y
  	select X86_RESET_VECTOR
+	select USE_EARLY_BOARD_INIT
  	select INTEL_APOLLOLAKE
  	select BOARD_ROMSIZE_KB_16384
 
board/google/chromebook_link/Kconfig +1 -0
index 944716d002c9..dd29ddf694be 100644
@@ -19,6 +19,7 @@ config SYS_TEXT_BASE
  config BOARD_SPECIFIC_OPTIONS # dummy
  	def_bool y
  	select X86_RESET_VECTOR
+	select USE_EARLY_BOARD_INIT
  	select NORTHBRIDGE_INTEL_IVYBRIDGE
  	select HAVE_INTEL_ME
  	select BOARD_ROMSIZE_KB_8192
board/google/chromebook_samus/Kconfig +0 -0
index 90c23cba1bed..9f66d7998870 100644

board/google/chromebook_samus/Kconfig config SYS_TEXT_BASE · line 25

Quoted 7 lines
board/google/chromebook_samus/Kconfig +1 -0
@@ -19,6 +19,7 @@ config SYS_TEXT_BASE
  config BOARD_SPECIFIC_OPTIONS # dummy
  	def_bool y
  	select X86_RESET_VECTOR
+	select USE_EARLY_BOARD_INIT
  	select INTEL_BROADWELL
  	select HAVE_INTEL_ME
  	select BOARD_ROMSIZE_KB_8192

Viele Gr??e,
Stefan

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de
#30 lore raw

PATCH 1/15 x86: Introduce USE_EARLY_BOARD_INIT option

In reply to Andy Shevchenko
Quoted 99 lines

-----Original Message-----
From: Andy Shevchenko <[email protected]>
Sent: Thursday, August 6, 2020 7:54 AM
To: Simon Glass <[email protected]>; Bin Meng <[email protected]>; u- boot at lists.denx.de
Cc: Andy Shevchenko <[email protected]>; Park, Aiden <[email protected]>; Stefan Roese <[email protected]>; George McCollister <[email protected]>
Subject: [PATCH v1 01/15] x86: Introduce USE_EARLY_BOARD_INIT option

Introduce USE_EARLY_BOARD_INIT option and select it by the actual users.

Cc Aiden Park <[email protected]>
Cc Stefan Roese <[email protected]>
Cc George McCollister <[email protected]>
---
 arch/x86/Kconfig                      | 3 +++
 arch/x86/cpu/start.S                  | 3 +++
 board/google/chromebook_coral/Kconfig | 1 +
board/google/chromebook_link/Kconfig  | 1 +
board/google/chromebook_samus/Kconfig | 1 +
 5 files changed, 9 insertions(+)
arch/x86/Kconfig index renamed from arch/x86/Kconfig +0 -0

ff4f06ed79cc..167cc96205c5 100644

arch/x86/Kconfig +3 -0
@@ -203,6 +203,9 @@ config SPL_X86_32BIT_INIT
 	help
 	  This is enabled when 32-bit init is in SPL
 
+config USE_EARLY_BOARD_INIT
+	bool
+
 config RESET_SEG_START
 	hex
 	depends on X86_RESET_VECTOR
arch/x86/cpu/start.S index renamed from arch/x86/cpu/start.S +0 -0

4ad515ce0856..8d00c97db42c 100644

arch/x86/cpu/start.S +3 -1
@@ -88,6 +88,7 @@ _start:
 	/* Clear the interrupt vectors */
 	lidt	blank_idt_ptr
 
+#ifdef USE_EARLY_BOARD_INIT
 	/*
 	 * Critical early platform init - generally not used, we prefer init
 	 * to happen later when we have a console, in case something goes @@
-96,6 +97,8 @@ _start:
 	jmp	early_board_init
 .globl early_board_init_ret
 early_board_init_ret:
+#endif
+
 	post_code(POST_START)
 
 	/* Initialise Cache-As-RAM */
board/google/chromebook_coral/Kconfig +1 -0
index 940bee89b0b6..27671958e146 100644
@@ -18,6 +18,7 @@ config SYS_TEXT_BASE
 config BOARD_SPECIFIC_OPTIONS # dummy
 	def_bool y
 	select X86_RESET_VECTOR
+	select USE_EARLY_BOARD_INIT
 	select INTEL_APOLLOLAKE
 	select BOARD_ROMSIZE_KB_16384
 
board/google/chromebook_link/Kconfig +1 -0
index 944716d002c9..dd29ddf694be 100644
@@ -19,6 +19,7 @@ config SYS_TEXT_BASE
 config BOARD_SPECIFIC_OPTIONS # dummy
 	def_bool y
 	select X86_RESET_VECTOR
+	select USE_EARLY_BOARD_INIT
 	select NORTHBRIDGE_INTEL_IVYBRIDGE
 	select HAVE_INTEL_ME
 	select BOARD_ROMSIZE_KB_8192
board/google/chromebook_samus/Kconfig +1 -1
index 90c23cba1bed..9f66d7998870 100644
@@ -19,6 +19,7 @@ config SYS_TEXT_BASE
 config BOARD_SPECIFIC_OPTIONS # dummy
 	def_bool y
 	select X86_RESET_VECTOR
+	select USE_EARLY_BOARD_INIT
 	select INTEL_BROADWELL
 	select HAVE_INTEL_ME
 	select BOARD_ROMSIZE_KB_8192
--
Quoted 1 line

2.27.0

#31 lore raw

PATCH 15/15 x86: qemu: Remove dead code

In reply to Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/emulation/qemu-x86/Makefile | 2 --
 board/emulation/qemu-x86/start.S  | 8 --------
 2 files changed, 10 deletions(-)
 delete mode 100644 board/emulation/qemu-x86/start.S
board/emulation/qemu-x86/Makefile +0 -2
index 782e298b74ce..5af8d31d5840 100644
@@ -1,5 +1,3 @@
 # SPDX-License-Identifier: GPL-2.0+
 #
 # Copyright (C) 2015, Bin Meng <[email protected]>
-
-obj-y	+= start.o
board/emulation/qemu-x86/start.S deleted +0 -8
deleted file mode 100644
index e4bde561b20d..000000000000
@@ -1,8 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * Copyright (C) 2015, Bin Meng <[email protected]>
- */
-
-.globl early_board_init
-early_board_init:
-	jmp	early_board_init_ret
Signature · 1 line
2.27.0
#32 lore raw

PATCH 15/15 x86: qemu: Remove dead code

Quoted 10 lines · Andy Shevchenko

start.S does nothing and can be safely removed. Makefile is still being used by the build system, so simply drop the rule from it.

---
 board/emulation/qemu-x86/Makefile | 2 --
 board/emulation/qemu-x86/start.S  | 8 --------
 2 files changed, 10 deletions(-)
 delete mode 100644 board/emulation/qemu-x86/start.S