Enable RTC on Odroid N2

Enable RTC PCF8563 node on Odroid-N2 SBC, In order to support the RTC wakealarm feature for suspend and resume. Also assign an alias to the pcf8563 to rtc0 and meson-vrtc to rtc1 timer device to prevent it being assigned to /dev/rtc0 which disto userspace tools assume is a clock device.

Cc Neil Armstrong <[email protected]>

Cc Kevin Hilman <[email protected]>

Suggested-by Christian Hewitt <[email protected]>

Signed-off-by Anand Moon <[email protected]>

---
Changes V3
--Drop the INI GPIOAO.BIT7 pinctrl.

Quoted 6 lines · Anand Moon

Enable RTC PCF8563 node on Odroid-N2 SBC, In order to support the RTC wakealarm feature for suspend and resume. Also assign an alias to the pcf8563 to rtc0 and meson-vrtc to rtc1 timer device to prevent it being assigned to /dev/rtc0 which disto userspace tools assume is a clock device.

Quoted 7 lines

Cc Neil Armstrong <[email protected]>

Cc Kevin Hilman <[email protected]>

Suggested-by Christian Hewitt <[email protected]>

Signed-off-by Anand Moon <[email protected]>

---
Changes V3
--Drop the INI GPIOAO.BIT7 pinctrl.

Why did you drop this GPIO? Isn't this the GPIO that the RTC uses to wakeup the system? If so, this should be included as part of this patch.

It probably still works because the bootloader configures this GPIO as input, but the kernel should not rely on the booloader for that, so please include as part of this patch.

Other than that, this is looking OK.

Curious how you're testing this?

When I tested with rtcwake (from buildroot), I'm getting this:

/ # rtcwake -d rtc0 -m mem -s4
rtcwake: RTC_RD_TIME: Invalid argument

Kevin

Hi Kevin,

Thanks for your review comments.

Quoted 21 lines · Kevin Hilman

Quoted 6 lines · Anand Moon

Enable RTC PCF8563 node on Odroid-N2 SBC, In order to support the RTC wakealarm feature for suspend and resume. Also assign an alias to the pcf8563 to rtc0 and meson-vrtc to rtc1 timer device to prevent it being assigned to /dev/rtc0 which disto userspace tools assume is a clock device.

Quoted 7 lines

Cc Neil Armstrong <[email protected]>

Cc Kevin Hilman <[email protected]>

Suggested-by Christian Hewitt <[email protected]>

Signed-off-by Anand Moon <[email protected]>

---
Changes V3
--Drop the INI GPIOAO.BIT7 pinctrl.

Why did you drop this GPIO? Isn't this the GPIO that the RTC uses to wakeup the system? If so, this should be included as part of this patch.

Quoted 4 lines

It probably still works because the bootloader configures this GPIO as input, but the kernel should not rely on the booloader for that, so please include as part of this patch.

Ok I will figure out the correct pinctrl need for this settings. looking into the Odroid N2 schematics.

hi All,

Quoted 32 lines · Anand Moon

Hi Kevin,

Thanks for your review comments.

Quoted 25 lines · Kevin Hilman

Quoted 6 lines · Anand Moon

Enable RTC PCF8563 node on Odroid-N2 SBC, In order to support the RTC wakealarm feature for suspend and resume. Also assign an alias to the pcf8563 to rtc0 and meson-vrtc to rtc1 timer device to prevent it being assigned to /dev/rtc0 which disto userspace tools assume is a clock device.

Quoted 7 lines

Cc Neil Armstrong <[email protected]>

Cc Kevin Hilman <[email protected]>

Suggested-by Christian Hewitt <[email protected]>

Signed-off-by Anand Moon <[email protected]>

---
Changes V3
--Drop the INI GPIOAO.BIT7 pinctrl.

Why did you drop this GPIO? Isn't this the GPIO that the RTC uses to wakeup the system? If so, this should be included as part of this patch.

It probably still works because the bootloader configures this GPIO as input, but the kernel should not rely on the booloader for that, so please include as part of this patch.

Quoted 3 lines

Ok I will figure out the correct pinctrl need for this settings. looking into the Odroid N2 schematics.

I am trying to map the RTC INT pinctrl, ie RTC INT GPIOAO.BIT7.

So from the schematics it is seen below.
RTC INT GPIOAO_7 (AV46) GPIOAO_7 (JTAG_A_TMS // TSIN_A_DIN0 //
TDMB_FS // TDMB_SLV_FS)

But the S922X datasheet this pin *AV46* shows to following settings,
AN16 DVSS AV46 GPIOAO_7 BD19 BOOT_11

From the schematics it BOOT_11 is linked to

              BOOT_11 (NAND_CE0)      BD19

So can I conclude that BOOT_11 (nand_ce0_pins) pin linked to the RTC INT setting Please can somebody help me with correct pinctrl settings.

Best Regards
-Anand Moon

Quoted 35 lines · Anand Moon

hi All,

Quoted 32 lines · Anand Moon

Hi Kevin,

Thanks for your review comments.

Quoted 25 lines · Kevin Hilman

Quoted 6 lines · Anand Moon

Enable RTC PCF8563 node on Odroid-N2 SBC, In order to support the RTC wakealarm feature for suspend and resume. Also assign an alias to the pcf8563 to rtc0 and meson-vrtc to rtc1 timer device to prevent it being assigned to /dev/rtc0 which disto userspace tools assume is a clock device.

Quoted 7 lines

Cc Neil Armstrong <[email protected]>

Cc Kevin Hilman <[email protected]>

Suggested-by Christian Hewitt <[email protected]>

Signed-off-by Anand Moon <[email protected]>

---
Changes V3
--Drop the INI GPIOAO.BIT7 pinctrl.

Why did you drop this GPIO? Isn't this the GPIO that the RTC uses to wakeup the system? If so, this should be included as part of this patch.

It probably still works because the bootloader configures this GPIO as input, but the kernel should not rely on the booloader for that, so please include as part of this patch.

Quoted 5 lines

Quoted 3 lines

Ok I will figure out the correct pinctrl need for this settings. looking into the Odroid N2 schematics.

I am trying to map the RTC INT pinctrl, ie RTC INT GPIOAO.BIT7.

Simply add:

interrupt-parent = <&gpio_intc>;
interrupts = <7 IRQ_TYPE_LEVEL_LOW>;

to reflect the interrupt connection.

No need to setup pinctrl here since the GPIO input is always connected to the gpio irq generator whatever pinctrl mode is set.

Neil

Quoted 35 lines · Anand Moon

hi All,

Quoted 32 lines · Anand Moon

Hi Kevin,

Thanks for your review comments.

Quoted 25 lines · Kevin Hilman

Quoted 6 lines · Anand Moon

Enable RTC PCF8563 node on Odroid-N2 SBC, In order to support the RTC wakealarm feature for suspend and resume. Also assign an alias to the pcf8563 to rtc0 and meson-vrtc to rtc1 timer device to prevent it being assigned to /dev/rtc0 which disto userspace tools assume is a clock device.

Quoted 7 lines

Cc Neil Armstrong <[email protected]>

Cc Kevin Hilman <[email protected]>

Suggested-by Christian Hewitt <[email protected]>

Signed-off-by Anand Moon <[email protected]>

---
Changes V3
--Drop the INI GPIOAO.BIT7 pinctrl.

Why did you drop this GPIO? Isn't this the GPIO that the RTC uses to wakeup the system? If so, this should be included as part of this patch.

It probably still works because the bootloader configures this GPIO as input, but the kernel should not rely on the booloader for that, so please include as part of this patch.

Quoted 5 lines

Quoted 3 lines

Ok I will figure out the correct pinctrl need for this settings. looking into the Odroid N2 schematics.

I am trying to map the RTC INT pinctrl, ie RTC INT GPIOAO.BIT7.

Simply add:

interrupt-parent = <&gpio_intc>;
interrupts = <7 IRQ_TYPE_LEVEL_LOW>;

to reflect the interrupt connection.

No need to setup pinctrl here since the GPIO input is always connected to the gpio irq generator whatever pinctrl mode is set.

Neil

Quoted 17 lines

So from the schematics it is seen below.
RTC INT GPIOAO_7 (AV46) GPIOAO_7 (JTAG_A_TMS // TSIN_A_DIN0 //
TDMB_FS // TDMB_SLV_FS)

But the S922X datasheet this pin *AV46* shows to following settings,
AN16 DVSS AV46 GPIOAO_7 BD19 BOOT_11

From the schematics it BOOT_11 is linked to

              BOOT_11 (NAND_CE0)      BD19

So can I conclude that BOOT_11 (nand_ce0_pins) pin linked to the RTC INT setting Please can somebody help me with correct pinctrl settings.

Best Regards
-Anand Moon

Quoted 43 lines · Neil Armstrong

Quoted 40 lines · Anand Moon

hi All,

Quoted 27 lines · Anand Moon

Hi Kevin,

Thanks for your review comments.

Quoted 21 lines · Kevin Hilman

Quoted 6 lines · Anand Moon

Enable RTC PCF8563 node on Odroid-N2 SBC, In order to support the RTC wakealarm feature for suspend and resume. Also assign an alias to the pcf8563 to rtc0 and meson-vrtc to rtc1 timer device to prevent it being assigned to /dev/rtc0 which disto userspace tools assume is a clock device.

Quoted 7 lines

Cc Neil Armstrong <[email protected]>

Cc Kevin Hilman <[email protected]>

Suggested-by Christian Hewitt <[email protected]>

Signed-off-by Anand Moon <[email protected]>

---
Changes V3
--Drop the INI GPIOAO.BIT7 pinctrl.

Why did you drop this GPIO? Isn't this the GPIO that the RTC uses to wakeup the system? If so, this should be included as part of this patch.

Quoted 8 lines

Quoted 4 lines

It probably still works because the bootloader configures this GPIO as input, but the kernel should not rely on the booloader for that, so please include as part of this patch.

Ok I will figure out the correct pinctrl need for this settings. looking into the Odroid N2 schematics.

I am trying to map the RTC INT pinctrl, ie RTC INT GPIOAO.BIT7.

Quoted 6 lines

Simply add:

interrupt-parent = <&gpio_intc>;
interrupts = <7 IRQ_TYPE_LEVEL_LOW>;

to reflect the interrupt connection.

Quoted 3 lines

No need to setup pinctrl here since the GPIO input is always connected to the gpio irq generator whatever pinctrl mode is set.

It is actually better to setup pinctrl. Yes the irq controller can work whatever the pin setup but if an output function is active it can mess with what the irq controller gets.

Think about applying/removing bias if necessary too.

Hi Jerome

Quoted 47 lines · Jerome Brunet

Quoted 43 lines · Neil Armstrong

Quoted 40 lines · Anand Moon

hi All,

Quoted 27 lines · Anand Moon

Hi Kevin,

Thanks for your review comments.

Quoted 21 lines · Kevin Hilman

Quoted 6 lines · Anand Moon

Enable RTC PCF8563 node on Odroid-N2 SBC, In order to support the RTC wakealarm feature for suspend and resume. Also assign an alias to the pcf8563 to rtc0 and meson-vrtc to rtc1 timer device to prevent it being assigned to /dev/rtc0 which disto userspace tools assume is a clock device.

Quoted 7 lines

Cc Neil Armstrong <[email protected]>

Cc Kevin Hilman <[email protected]>

Suggested-by Christian Hewitt <[email protected]>

Signed-off-by Anand Moon <[email protected]>

---
Changes V3
--Drop the INI GPIOAO.BIT7 pinctrl.

Why did you drop this GPIO? Isn't this the GPIO that the RTC uses to wakeup the system? If so, this should be included as part of this patch.

Quoted 8 lines

Quoted 4 lines

It probably still works because the bootloader configures this GPIO as input, but the kernel should not rely on the booloader for that, so please include as part of this patch.

Ok I will figure out the correct pinctrl need for this settings. looking into the Odroid N2 schematics.

I am trying to map the RTC INT pinctrl, ie RTC INT GPIOAO.BIT7.

Quoted 6 lines

Quoted 6 lines

Simply add:

interrupt-parent = <&gpio_intc>;
interrupts = <7 IRQ_TYPE_LEVEL_LOW>;

to reflect the interrupt connection.

I have tried this setting, but it is not working.

[alarm@archl-on2e ~]$ dmesg| grep rtc

[    5.378002] meson-vrtc ff8000a8.rtc: registered as rtc1
[    5.942307] rtc-pcf8563 0-0051: pcf8563_write_block_data: err=-110
addr=0e, data=03
[    5.942316] rtc-pcf8563 0-0051: pcf8563_probe: write error
[    5.945983] rtc-pcf8563: probe of 0-0051 failed with error -5

Quoted 9 lines

Quoted 4 lines

No need to setup pinctrl here since the GPIO input is always connected to the gpio irq generator whatever pinctrl mode is set.

It is actually better to setup pinctrl. Yes the irq controller can work whatever the pin setup but if an output function is active it can mess with what the irq controller gets.

Quoted 2 lines

Think about applying/removing bias if necessary too.

Ok, I am trying to add a new pinctrl configuration for TSIN_A_DIN0 // TDMB_FS // TDMB_SLV_FS
But it's still not working at my end.

-Anand

Quoted 57 lines · Anand Moon

Hi Jerome

Quoted 47 lines · Jerome Brunet

Quoted 43 lines · Neil Armstrong

Quoted 40 lines · Anand Moon

hi All,

Quoted 27 lines · Anand Moon

Hi Kevin,

Thanks for your review comments.

Quoted 21 lines · Kevin Hilman

Quoted 6 lines · Anand Moon

Enable RTC PCF8563 node on Odroid-N2 SBC, In order to support the RTC wakealarm feature for suspend and resume. Also assign an alias to the pcf8563 to rtc0 and meson-vrtc to rtc1 timer device to prevent it being assigned to /dev/rtc0 which disto userspace tools assume is a clock device.

Quoted 7 lines

Cc Neil Armstrong <[email protected]>

Cc Kevin Hilman <[email protected]>

Suggested-by Christian Hewitt <[email protected]>

Signed-off-by Anand Moon <[email protected]>

---
Changes V3
--Drop the INI GPIOAO.BIT7 pinctrl.

Why did you drop this GPIO? Isn't this the GPIO that the RTC uses to wakeup the system? If so, this should be included as part of this patch.

Quoted 8 lines

Quoted 4 lines

It probably still works because the bootloader configures this GPIO as input, but the kernel should not rely on the booloader for that, so please include as part of this patch.

Ok I will figure out the correct pinctrl need for this settings. looking into the Odroid N2 schematics.

I am trying to map the RTC INT pinctrl, ie RTC INT GPIOAO.BIT7.

Quoted 6 lines

Quoted 6 lines

Simply add:

interrupt-parent = <&gpio_intc>;
interrupts = <7 IRQ_TYPE_LEVEL_LOW>;

to reflect the interrupt connection.

Quoted 9 lines

I have tried this setting, but it is not working.

[alarm@archl-on2e ~]$ dmesg| grep rtc

[    5.378002] meson-vrtc ff8000a8.rtc: registered as rtc1
[    5.942307] rtc-pcf8563 0-0051: pcf8563_write_block_data: err=-110
addr=0e, data=03
[    5.942316] rtc-pcf8563 0-0051: pcf8563_probe: write error
[    5.945983] rtc-pcf8563: probe of 0-0051 failed with error -5

-110 is timeout ... either you i2c bus is broken and you device is not at 0x51. In both case, it has nothing to do with the interrupt configuration

Quoted 9 lines

Quoted 9 lines

Quoted 4 lines

No need to setup pinctrl here since the GPIO input is always connected to the gpio irq generator whatever pinctrl mode is set.

It is actually better to setup pinctrl. Yes the irq controller can work whatever the pin setup but if an output function is active it can mess with what the irq controller gets.

Quoted 6 lines

Quoted 2 lines

Think about applying/removing bias if necessary too.

Ok, I am trying to add a new pinctrl configuration for TSIN_A_DIN0 // TDMB_FS // TDMB_SLV_FS
But it's still not working at my end.

Either you are quite confused when it comes to pinctrl or I am.

TSIN and TDM have nothing to do with an i2c RTC.

hi Jerome

Quoted 71 lines · Jerome Brunet

Quoted 57 lines · Anand Moon

Hi Jerome

Quoted 47 lines · Jerome Brunet

Quoted 43 lines · Neil Armstrong

Quoted 40 lines · Anand Moon

hi All,

Quoted 27 lines · Anand Moon

Hi Kevin,

Thanks for your review comments.

Quoted 21 lines · Kevin Hilman

Quoted 6 lines · Anand Moon

Enable RTC PCF8563 node on Odroid-N2 SBC, In order to support the RTC wakealarm feature for suspend and resume. Also assign an alias to the pcf8563 to rtc0 and meson-vrtc to rtc1 timer device to prevent it being assigned to /dev/rtc0 which disto userspace tools assume is a clock device.

Quoted 7 lines

Cc Neil Armstrong <[email protected]>

Cc Kevin Hilman <[email protected]>

Suggested-by Christian Hewitt <[email protected]>

Signed-off-by Anand Moon <[email protected]>

---
Changes V3
--Drop the INI GPIOAO.BIT7 pinctrl.

Why did you drop this GPIO? Isn't this the GPIO that the RTC uses to wakeup the system? If so, this should be included as part of this patch.

Quoted 8 lines

Quoted 4 lines

It probably still works because the bootloader configures this GPIO as input, but the kernel should not rely on the booloader for that, so please include as part of this patch.

Ok I will figure out the correct pinctrl need for this settings. looking into the Odroid N2 schematics.

I am trying to map the RTC INT pinctrl, ie RTC INT GPIOAO.BIT7.

Quoted 6 lines

Quoted 6 lines

Simply add:

interrupt-parent = <&gpio_intc>;
interrupts = <7 IRQ_TYPE_LEVEL_LOW>;

to reflect the interrupt connection.

Quoted 9 lines

I have tried this setting, but it is not working.

[alarm@archl-on2e ~]$ dmesg| grep rtc

[    5.378002] meson-vrtc ff8000a8.rtc: registered as rtc1
[    5.942307] rtc-pcf8563 0-0051: pcf8563_write_block_data: err=-110
addr=0e, data=03
[    5.942316] rtc-pcf8563 0-0051: pcf8563_probe: write error
[    5.945983] rtc-pcf8563: probe of 0-0051 failed with error -5

Quoted 3 lines

-110 is timeout ... either you i2c bus is broken and you device is not at 0x51. In both case, it has nothing to do with the interrupt configuration

I have check the I2C bus on the device for rtc and it return correctly.

$ sudo i2cdetect -l
i2c-1   i2c             DesignWare HDMI                         I2C adapter
i2c-0   i2c             Meson I2C adapter                       I2C adapter
$
$ sudo i2cdetect -y -r 0
     0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f
00:          -- -- -- -- -- -- -- -- -- -- -- -- --
10: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
20: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
30: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
40: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
50: -- UU -- -- -- -- -- -- -- -- -- -- -- -- -- --
60: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
70: -- -- -- -- -- -- -- --

Quoted 9 lines

Quoted 9 lines

Quoted 9 lines

Quoted 4 lines

No need to setup pinctrl here since the GPIO input is always connected to the gpio irq generator whatever pinctrl mode is set.

It is actually better to setup pinctrl. Yes the irq controller can work whatever the pin setup but if an output function is active it can mess with what the irq controller gets.

Quoted 8 lines

Quoted 6 lines

Quoted 2 lines

Think about applying/removing bias if necessary too.

Ok, I am trying to add a new pinctrl configuration for TSIN_A_DIN0 // TDMB_FS // TDMB_SLV_FS
But it's still not working at my end.

Either you are quite confused when it comes to pinctrl or I am.

Basically I dont want to keep repeating silly mistakes.

Quoted 1 line

TSIN and TDM have nothing to do with an i2c RTC.

Yes I understand this clearly, that's why I have dropped the RTC INT gpio pinctrl settings.Without this setting RTC driver works fine and their is no issue rtcwakeup during suspend and resume in my testing.

Just want to clear my confusion on RTC INT gpio setting is not needed. I did not find any other example to support this changes. So I have enable the debug logs on rtc-pcf8563.c with this current patch at my end.

Hi Anand

(I haven't re-read all of this discussion, so apologies if something in my reply doesn't make sense)

On Sat, Aug 29, 2020 at 6:31 PM Anand Moon <[email protected]> wrote:
[...]

Quoted 4 lines

Just want to clear my confusion on RTC INT gpio setting is not needed. I did not find any other example to support this changes. So I have enable the debug logs on rtc-pcf8563.c with this current patch at my end.

my understanding is that your testing procedure is to simply use your original patch and see if rtc wake-up is working.
since GPIOAO_7 is not explicitly mentioned in your testing procedure I'm assuming that you're not configuring it anywhere.

Kevin's concern is what happens when that GPIO is configured incorrectly (for example by some u-boot bug, firmware issue, ...). for
example: have you tried to configure GPIOAO_7 in u-boot as output low pin and see if rtc wake-up is still working?

In your previous replies you mentioned various pin mux settings related to TSIN_A_DIN0 // TDMB_FS // TDMB_SLV_FS
I don't know how those are related to the RTC
My suggestion is to look at arch/arm64/boot/dts/amlogic/meson-gx-libretech-pc.dtsi - it has a eth_phy_irq_pins definition and apply something similar on Odroid-N2

+ bias-disable;

Hi Anand,

On Sun, Aug 30, 2020 at 3:12 PM Anand Moon <[email protected]> wrote:
[...]

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts vddao_3v3: regulator-vddao_3v3 { · line 213

Quoted 5 lines

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts +5 -0

+       /* Make sure the rtc irq pin is properly configured as input */
+       rtc_irq_pins: rtc-pin-irq {
+               mux {
+                       groups = "GPIOAO_7";
+                       function = "gpio_periphs";

check meson_g12a_aobus_functions in drivers/pinctrl/meson/pinctrl-meson-g12a.c GPIOAO_7 doesn't support "gpio_periphs", instead I think it should be "gpio_aobus"

I'm surprised that you don't seem to be getting errors from the pin controller driver about this.
On the other hand you have not attached the full kernel log, so maybe it's in there but hidden somewhere

Quoted 1 line

+ bias-disable;

shouldn't there be output-disable or input-enable here?

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts hdmi_tx_tmds_out: endpoint { · line 494

Quoted 13 lines

arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts +5 -1

+               };
+       };
+
        hdmi-connector {
                compatible = "hdmi-connector";
                type = "a";

@@ -481,7 +490,8 @@ hdmi_tx_tmds_out: endpoint {
 
 &i2c3 {
        pinctrl-0 = <&i2c3_sda_a_pins>, <&i2c3_sck_a_pins>;
-       pinctrl-names = "default";
+       pinctrl-1 = <&rtc_irq_pins>;
+       pinctrl-names = "default", "gpio_periphs";

I am not expecting this to work because it means that the I2C driver would have to manage the "gpio_periphs" pin state (but there's no pinctrl_* call in drivers/i2c/busses/i2c-meson.c)
instead I would try:
&i2c3 {
pinctrl-0 = <&i2c3_sda_a_pins>, <&i2c3_sck_a_pins>, <&rtc_irq_pins>; pinctrl-names = "default";

...
};

or even:
rtc0: rtc@51 {
pinctrl-0 = <&rtc_irq_pins>;
pinctrl-names = "default";

...
};