btrfs: tree-checker: fix the error message for transid error
PATCH 1/1 btrfs: tree-checker: fix the error message for transid error
The error message for inode transid is the same for inode generation, which makes us unable to detect the real problem.
Reported-by Tyler Richmond <[email protected]>
Fixes 496245cac57e ("btrfs: tree-checker: Verify inode item")
Signed-off-by Qu Wenruo <[email protected]>
--- fs/btrfs/tree-checker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/tree-checker.c +1 -1
@@ -984,7 +984,7 @@ static int check_inode_item(struct extent_buffer *leaf,/* Note for ROOT_TREE_DIR_ITEM, mkfs could set its transid 0 */ if (btrfs_inode_transid (leaf, iitem) > super_gen +1 ) {inode_item_err (leaf, slot, -"invalid inode generation: has %llu expect [0, %llu]" , +"invalid inode transid: has %llu expect [0, %llu]" ,btrfs_inode_transid (leaf, iitem), super_gen +1 );return -EUCLEAN ; }
Signature · 1 line
2.28.0
Quoted 2 lines · Qu Wenruo
The error message for inode transid is the same for inode generation, which makes us unable to detect the real problem.
LGTM,
Reviewed-by Marcos Paulo de Souza <[email protected]>
Quoted 25 lines
Reported-by Tyler Richmond <[email protected]>Fixes 496245cac57e ("btrfs: tree-checker: Verify inode item")Signed-off-by Qu Wenruo <[email protected]>--- fs/btrfs/tree-checker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/btrfs/tree-checker.c +1
-1@@ -984,7 +984,7 @@ static int check_inode_item(struct extent_buffer *leaf,/* Note for ROOT_TREE_DIR_ITEM, mkfs could set its transid 0 */ if (btrfs_inode_transid(leaf, iitem) > super_gen + 1) { inode_item_err(leaf, slot, - "invalid inode generation: has %llu expect [0, %llu]", + "invalid inode transid: has %llu expect [0, %llu]",
btrfs_inode_transid(leaf, iitem),super_gen+ 1);fs/btrfs/tree-checker.c +0
-0return -EUCLEAN ; }
Quoted 6 lines · Qu Wenruo
The error message for inode transid is the same for inode generation, which makes us unable to detect the real problem.
Reported-by Tyler Richmond <[email protected]>Fixes 496245cac57e ("btrfs: tree-checker: Verify inode item")Signed-off-by Qu Wenruo <[email protected]>
Added to misc-next, thanks.