Skip to contentSkip to conversation

btrfs: tree-checker: fix the error message for transid error

PATCH In review Qu Wenruo 3 participants 3 messages Aug 25, 2020 – Aug 26, 2020 Btrfs file system

lore
Share & tools
lore

Qu Wenruo

author
#0 lore raw

PATCH 1/1 btrfs: tree-checker: fix the error message for transid error

The error message for inode transid is the same for inode generation, which makes us unable to detect the real problem.

Fixes 496245cac57e ("btrfs: tree-checker: Verify inode item")
---
 fs/btrfs/tree-checker.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/tree-checker.c +1 -1
index 517b44300a05..7b1fee630f97 100644
@@ -984,7 +984,7 @@ static int check_inode_item(struct extent_buffer *leaf,
 	/* Note for ROOT_TREE_DIR_ITEM, mkfs could set its transid 0 */
 	if (btrfs_inode_transid(leaf, iitem) > super_gen + 1) {
 		inode_item_err(leaf, slot,
-			"invalid inode generation: has %llu expect [0, %llu]",
+			"invalid inode transid: has %llu expect [0, %llu]",
 			       btrfs_inode_transid(leaf, iitem), super_gen + 1);
 		return -EUCLEAN;
 	}
Signature · 1 line
2.28.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Qu Wenruo

The error message for inode transid is the same for inode generation, which makes us unable to detect the real problem.

LGTM,

Quoted 25 lines
Fixes 496245cac57e ("btrfs: tree-checker: Verify inode item")
---
 fs/btrfs/tree-checker.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/tree-checker.c +1 -1
index 517b44300a05..7b1fee630f97 100644
@@ -984,7 +984,7 @@ static int check_inode_item(struct extent_buffer
 *leaf,
 	/* Note for ROOT_TREE_DIR_ITEM, mkfs could set its transid 0 */
 	if (btrfs_inode_transid(leaf, iitem) > super_gen + 1) {
 		inode_item_err(leaf, slot,
-			"invalid inode generation: has %llu expect [0,
 %llu]",
+			"invalid inode transid: has %llu expect [0,
 %llu]",

btrfs_inode_transid(leaf, iitem),
super_gen + 1);

fs/btrfs/tree-checker.c +0 -0
 		return -EUCLEAN;
 	}