Skip to contentSkip to conversation

x86: Minor nits from previous reviews

PATCH New Simon Glass 2 participants 7 messages Aug 29, 2020 – Sep 1, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover x86: Minor nits from previous reviews

I found a few nits in my queue that were not addressed at the time. This series fixes them.

Simon Glass (2):
x86: pinctrl: Fix 'relatove' typo
x86: Drop nhlt_serialise()

 arch/x86/include/asm/acpi_nhlt.h | 8 --------
 drivers/pinctrl/intel/Kconfig    | 2 +-
 2 files changed, 1 insertion(+), 9 deletions(-)
Signature · 1 line
2.28.0.402.g5ffc5be6b7-goog
#1 lore raw

PATCH 1/2 x86: pinctrl: Fix 'relatove' typo

Fix this typo in the Kconfig help.

---

 drivers/pinctrl/intel/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/intel/Kconfig +1 -1
index 1acc5dabb01..316a8fe27fd 100644
@@ -22,7 +22,7 @@ config INTEL_PINCTRL_MULTI_ACPI_DEVICES
 	  Enable this if the pinctrl devices are modelled as multiple,
 	  separate ACPI devices in the ACPI tables. If enabled, the ACPI
 	  devices match the U-Boot pinctrl devices and the pin 'offset' is
-	  relatove to a particular pinctrl device. If disabled, there is a
+	  relative to a particular pinctrl device. If disabled, there is a
 	  single ACPI pinctrl device which includes all U-Boot pinctrl devices
 	  and the pin 'offset' is in effect a global pin number.
 
Signature · 1 line
2.28.0.402.g5ffc5be6b7-goog
#2 lore raw

PATCH 1/2 x86: pinctrl: Fix 'relatove' typo

Quoted 15 lines · Simon Glass

Fix this typo in the Kconfig help.

---

 drivers/pinctrl/intel/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/intel/Kconfig +0 -0
index 1acc5dabb01..316a8fe27fd 100644

drivers/pinctrl/intel/Kconfig config INTEL_PINCTRL_MULTI_ACPI_DEVICES

Quoted 9 lines
drivers/pinctrl/intel/Kconfig +1 -2
@@ -22,7 +22,7 @@ config INTEL_PINCTRL_MULTI_ACPI_DEVICES
          Enable this if the pinctrl devices are modelled as multiple,
          separate ACPI devices in the ACPI tables. If enabled, the ACPI
          devices match the U-Boot pinctrl devices and the pin 'offset' is
-         relatove to a particular pinctrl device. If disabled, there is a
+         relative to a particular pinctrl device. If disabled, there is a
          single ACPI pinctrl device which includes all U-Boot pinctrl devices
          and the pin 'offset' is in effect a global pin number.
 
--
#3 lore raw

PATCH 1/2 x86: pinctrl: Fix 'relatove' typo

Quoted 25 lines · Bin Meng
Quoted 23 lines · Simon Glass

Fix this typo in the Kconfig help.

---

 drivers/pinctrl/intel/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/intel/Kconfig +1 -1
index 1acc5dabb01..316a8fe27fd 100644
@@ -22,7 +22,7 @@ config INTEL_PINCTRL_MULTI_ACPI_DEVICES
          Enable this if the pinctrl devices are modelled as multiple,
          separate ACPI devices in the ACPI tables. If enabled, the ACPI
          devices match the U-Boot pinctrl devices and the pin 'offset' is
-         relatove to a particular pinctrl device. If disabled, there is a
+         relative to a particular pinctrl device. If disabled, there is a
          single ACPI pinctrl device which includes all U-Boot pinctrl devices
          and the pin 'offset' is in effect a global pin number.
 
Quoted 3 lines
Quoted 1 line

--

applied to u-boot-x86, thanks!

#4 lore raw

PATCH 2/2 x86: Drop nhlt_serialise()

In reply to Simon Glass

This function is not actually used in U-Boot. Drop it.

---

 arch/x86/include/asm/acpi_nhlt.h | 8 --------
 1 file changed, 8 deletions(-)
arch/x86/include/asm/acpi_nhlt.h +0 -8
index 47203213818..2c44196317b 100644
@@ -137,14 +137,6 @@ int nhlt_endpoint_add_formats(struct nhlt_endpoint *endpoint,
  */
 void nhlt_next_instance(struct nhlt *nhlt, int link_type);
 
-/*
- * Serialize NHLT object to ACPI table. Take in the beginning address of where
- * the table will reside and return the address of the next ACPI table. On
- * error 0 will be returned. The NHLT object is no longer valid after this
- * function is called.
- */
-uintptr_t nhlt_serialise(struct nhlt *nhlt, uintptr_t acpi_addr);
-
 /*
  * Serialize NHLT object to ACPI table. Take in the beginning address of where
  * the table will reside oem_id and oem_table_id and return the address of the
Signature · 1 line
2.28.0.402.g5ffc5be6b7-goog