x86: Minor nits from previous reviews
Subsystems (3)
cover x86: Minor nits from previous reviews
I found a few nits in my queue that were not addressed at the time. This series fixes them.
Simon Glass (2):
x86: pinctrl: Fix 'relatove' typo
x86: Drop nhlt_serialise()
arch/x86/include/asm/acpi_nhlt.h | 8 -------- drivers/pinctrl/intel/Kconfig | 2 +- 2 files changed, 1 insertion(+), 9 deletions(-)
Signature · 1 line
2.28.0.402.g5ffc5be6b7-goog
PATCH 1/2 x86: pinctrl: Fix 'relatove' typo
Fix this typo in the Kconfig help.
---
drivers/pinctrl/intel/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/intel/Kconfig +1 -1
@@ -22,7 +22,7 @@ config INTEL_PINCTRL_MULTI_ACPI_DEVICES Enable this if the pinctrl devices are modelled as multiple, separate ACPI devices in the ACPI tables. If enabled, the ACPI devices match the U-Boot pinctrl devices and the pin 'offset' is - relatove to a particular pinctrl device. If disabled, there is a + relative to a particular pinctrl device. If disabled, there is a single ACPI pinctrl device which includes all U-Boot pinctrl devices and the pin 'offset' is in effect a global pin number.
Signature · 1 line
2.28.0.402.g5ffc5be6b7-goog
PATCH 1/2 x86: pinctrl: Fix 'relatove' typo
Quoted 15 lines · Simon Glass
Fix this typo in the
Kconfighelp.Signed-off-by Simon Glass <[email protected]>Suggested-by Wolfgang Wallner <[email protected]>---
drivers/pinctrl/intel/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pinctrl/intel/Kconfig +0
-0
drivers/pinctrl/intel/Kconfig config INTEL_PINCTRL_MULTI_ACPI_DEVICES
Quoted 9 lines
drivers/pinctrl/intel/Kconfig +1
-2@@ -22,7 +22,7 @@ config INTEL_PINCTRL_MULTI_ACPI_DEVICES Enable this if the pinctrl devices are modelled as multiple, separate ACPI devices in the ACPI tables. If enabled, the ACPI devices match the U-Boot pinctrl devices and the pin 'offset' is - relatove to a particular pinctrl device. If disabled, there is a + relative to a particular pinctrl device. If disabled, there is a single ACPI pinctrl device which includes all U-Boot pinctrl devices and the pin 'offset' is in effect a global pin number. --
PATCH 1/2 x86: pinctrl: Fix 'relatove' typo
Quoted 25 lines · Bin Meng
Quoted 23 lines · Simon Glass
Fix this typo in the
Kconfighelp.Signed-off-by Simon Glass <[email protected]>Suggested-by Wolfgang Wallner <[email protected]>---
drivers/pinctrl/intel/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pinctrl/intel/Kconfig +1
-1@@ -22,7 +22,7 @@ config INTEL_PINCTRL_MULTI_ACPI_DEVICES Enable this if the pinctrl devices are modelled as multiple, separate ACPI devices in the ACPI tables. If enabled, the ACPI devices match the U-Boot pinctrl devices and the pin 'offset' is - relatove to a particular pinctrl device. If disabled, there is a + relative to a particular pinctrl device. If disabled, there is a single ACPI pinctrl device which includes all U-Boot pinctrl devices and the pin 'offset' is in effect a global pin number.
Quoted 3 lines
Quoted 1 line
--
Reviewed-by Bin Meng <[email protected]>
applied to u-boot-x86, thanks!
PATCH 2/2 x86: Drop nhlt_serialise()
In reply to Simon GlassThis function is not actually used in U-Boot. Drop it.
---
arch/x86/include/asm/acpi_nhlt.h | 8 -------- 1 file changed, 8 deletions(-)
arch/x86/include/asm/acpi_nhlt.h +0 -8
@@ -137,14 +137,6 @@ int nhlt_endpoint_add_formats(struct nhlt_endpoint *endpoint,*/ void nhlt_next_instance (struct nhlt *nhlt,int link_type); -/* -* Serialize NHLT object to ACPI table. Take in the beginning address of where -* the table will reside and return the address of the next ACPI table. On -* error 0 will be returned. The NHLT object is no longer valid after this -* function is called. -*/ -uintptr_t nhlt_serialise (struct nhlt *nhlt,uintptr_t acpi_addr); -/* * Serialize NHLT object to ACPI table. Take in the beginning address of where * the table will reside oem_id and oem_table_id and return the address of the
Signature · 1 line
2.28.0.402.g5ffc5be6b7-goog
PATCH 2/2 x86: Drop nhlt_serialise()
Quoted 11 lines · Simon Glass
This function is not actually used in U-Boot. Drop it.
Suggested-by Bin Meng <[email protected]>Signed-off-by Simon Glass <[email protected]>---
arch/x86/include/asm/acpi_nhlt.h | 8 -------- 1 file changed, 8 deletions(-)
PATCH 2/2 x86: Drop nhlt_serialise()
Quoted 7 lines · Bin Meng
Quoted 5 lines · Simon Glass
This function is not actually used in U-Boot. Drop it.
Suggested-by Bin Meng <[email protected]>
Quoted 8 lines
Quoted 6 lines
Signed-off-by Simon Glass <[email protected]>---
arch/x86/include/asm/acpi_nhlt.h | 8 -------- 1 file changed, 8 deletions(-)Reviewed-by Bin Meng <[email protected]>
applied to u-boot-x86, thanks!