f2fs: check output position in move range ioctl
v2 cover f2fs: check output position in move range ioctl
Changes in v2:
- Moved check of output position before we lock the source or destination inode.
If a negative value is provided as the output position to the F2FS_IOC_MOVE_RANGE ioctl, f2fs_get_dnode_of_data may hit a memory bug like the following:
BUG: unable to handle page fault for address: ffffed10b30435a4 [...] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009) ... [...] Call Trace: f2fs_get_dnode_of_data+0xa68/0xde0 [...] f2fs_reserve_block+0x3b/0x230 f2fs_get_new_data_page+0xf0/0x8b0 ? f2fs_get_lock_data_page+0x1f0/0x1f0 ? rwsem_down_write_slowpath+0x8d0/0x8d0 ? rwsem_down_read_slowpath+0x830/0x830 ? ___might_sleep+0xba/0xd0 ? f2fs_get_lock_data_page+0x17a/0x1f0 __exchange_data_block+0x11bf/0x24d0 ? f2fs_ioc_release_volatile_write+0x170/0x170 ? __might_sleep+0x31/0xd0 ? ___might_sleep+0xba/0xd0 ? rwsem_down_read_slowpath+0x830/0x830 ? __init_rwsem+0xa0/0xa0 f2fs_ioctl+0x469c/0x6980
Dan Robertson (1):
f2fs: check output position in move range ioctl
fs/f2fs/file.c | 3 +++ 1 file changed, 3 insertions(+)
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
PATCH v2 1/1 f2fs: check output position in move range ioctl
When the move range ioctl is used, check the output position and ensure that it is a non-negative value. Without this check f2fs_get_dnode_of_data may hit a memmory bug.
--- fs/f2fs/file.c | 3 +++ 1 file changed, 3 insertions(+)
fs/f2fs/file.c +3 -0
@@ -2783,6 +2783,9 @@ static int f2fs_move_file_range(struct file *file_in, loff_t pos_in,if (IS_ENCRYPTED (src) ||IS_ENCRYPTED (dst))return -EOPNOTSUPP ; +if (pos_out <0 ) +return -EINVAL ; +if (src == dst) {if (pos_in == pos_out)return 0 ;
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Chao Yu
maintainerQuoted 14 lines · Dan Robertson
When the move range ioctl is used, check the output position and ensure that it is a non-negative value. Without this check
f2fs_get_dnode_of_datamay hit a memmory bug.Signed-off-by Dan Robertson <[email protected]>--- fs/f2fs/file.c | 3 +++ 1 file changed, 3 insertions(+)fs/f2fs/file.c +0
-0
fs/f2fs/file.c static int f2fs_move_file_range(struct file *file_in, loff_t pos_in, · line 2786
Quoted 4 lines
fs/f2fs/file.c +1
-0@@ -2783,6 +2783,9 @@ static int f2fs_move_file_range(struct file *file_in, loff_t pos_in,if (IS_ENCRYPTED (src) ||IS_ENCRYPTED (dst))return -EOPNOTSUPP ; +if (pos_out <0 )
if (pos_out < 0 || pos_in < 0)
fs/f2fs/file.c static int f2fs_move_file_range(struct file *file_in, loff_t pos_in, · line 2791
Quoted 6 lines
fs/f2fs/file.c +2
-0+return -EINVAL ; +if (src == dst) {if (pos_in == pos_out)return 0 ;
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel