Skip to content

f2fs: check position in move range ioctl

Dan Robertson linux-f2fs-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest1 patch 1 replyIn review
  2. v21 patch 1 replySuperseded
  3. v11 patch 2 repliesSuperseded

Changes in v3 from the cover letter

- Check the input position as well as the output position.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1f2fs: check position in move range ioctlfs/f2fs/file.c+3 -01 reply

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchChao Yu
1/1R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [f2fs-dev] [PATCH v3 0/1] f2fs: check position in move range ioctl

Changes in v3:
- Check the input position as well as the output position.

Changes in v2:
- Moved check of output position before we lock the source or destination inode.

If a negative value is provided as the output position to the F2FS_IOC_MOVE_RANGE ioctl, f2fs_get_dnode_of_data may hit a memory bug like the following:

BUG: unable to handle page fault for address: ffffed10b30435a4
[...]
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009) ...
[...]
Call Trace:
 f2fs_get_dnode_of_data+0xa68/0xde0
[...]
 f2fs_reserve_block+0x3b/0x230
 f2fs_get_new_data_page+0xf0/0x8b0
 ? f2fs_get_lock_data_page+0x1f0/0x1f0
 ? rwsem_down_write_slowpath+0x8d0/0x8d0
 ? rwsem_down_read_slowpath+0x830/0x830
 ? ___might_sleep+0xba/0xd0
 ? f2fs_get_lock_data_page+0x17a/0x1f0
 __exchange_data_block+0x11bf/0x24d0
 ? f2fs_ioc_release_volatile_write+0x170/0x170
 ? __might_sleep+0x31/0xd0
 ? ___might_sleep+0xba/0xd0
 ? rwsem_down_read_slowpath+0x830/0x830
 ? __init_rwsem+0xa0/0xa0
 f2fs_ioctl+0x469c/0x6980

Dan Robertson (1):
f2fs: check position in move range ioctl

 fs/f2fs/file.c | 3 +++
 1 file changed, 3 insertions(+)

_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel