lib/bpf: remove experimental tag
PATCH 1/1 lib/bpf: remove experimental tag
The BPF lib was introduced in 18.05.
There were no changes in it's public API since 19.11. It should be mature enough to remove it's 'experimental' tag.
--- MAINTAINERS | 2 +- lib/librte_bpf/rte_bpf.h | 10 ---------- lib/librte_bpf/rte_bpf_ethdev.h | 5 ----- lib/librte_bpf/rte_bpf_version.map | 2 +- 4 files changed, 2 insertions(+), 17 deletions(-)
MAINTAINERS +1 -1
@@ -1492,7 +1492,7 @@ F: app/test/test_telemetry* F: usertools/dpdk-telemetry* F: doc/guides/howto/telemetry.rst -BPF - EXPERIMENTAL +BPF M: Konstantin Ananyev <[email protected]> F: lib/librte_bpf/ F: examples/bpf/
lib/librte_bpf/rte_bpf.h +0 -10
@@ -10,10 +10,6 @@* * RTE BPF support. * -* @warning -* @b EXPERIMENTAL: -* All functions in this file may be changed or removed without prior notice. -* * librte_bpf provides a framework to load and execute eBPF bytecode * inside user-space dpdk based applications. * It supports basic set of features from eBPF spec
@@ -117,7 +113,6 @@ struct rte_bpf;* @param bpf * BPF handle to destroy. */ -__rte_experimental void rte_bpf_destroy (struct rte_bpf *bpf);
@@ -133,7 +128,6 @@ rte_bpf_destroy(struct rte_bpf *bpf);* - EINVAL - invalid parameter passed to function * - ENOMEM - can't reserve enough memory */ -__rte_experimental struct rte_bpf *rte_bpf_load (const struct rte_bpf_prm *prm);
@@ -157,7 +151,6 @@ rte_bpf_load(const struct rte_bpf_prm *prm);* - EINVAL - invalid parameter passed to function * - ENOMEM - can't reserve enough memory */ -__rte_experimental struct rte_bpf *rte_bpf_elf_load (const struct rte_bpf_prm *prm,const char *fname,const char *sname);
@@ -171,7 +164,6 @@ rte_bpf_elf_load(const struct rte_bpf_prm *prm, const char *fname,* @return * BPF execution return value. */ -__rte_experimental uint64_t rte_bpf_exec (const struct rte_bpf *bpf,void *ctx);
@@ -189,7 +181,6 @@ rte_bpf_exec(const struct rte_bpf *bpf, void *ctx);* @return * number of successfully processed inputs. */ -__rte_experimental uint32_t rte_bpf_exec_burst (const struct rte_bpf *bpf,void *ctx[],uint64_t rc[],uint32_t num);
@@ -205,7 +196,6 @@ rte_bpf_exec_burst(const struct rte_bpf *bpf, void *ctx[], uint64_t rc[],* - -EINVAL if the parameters are invalid. * - Zero if operation completed successfully. */ -__rte_experimental int rte_bpf_get_jit (const struct rte_bpf *bpf,struct rte_bpf_jit *jit);
lib/librte_bpf/rte_bpf_ethdev.h +0 -5
@@ -7,7 +7,6 @@/** * @file rte_bpf_ethdev.h -* @b EXPERIMENTAL: this API may change without prior notice * * API to install BPF filter as RX/TX callbacks for eth devices. * Note that right now:
@@ -45,7 +44,6 @@ enum {* @param queue * The identifier of the RX queue on the given port */ -__rte_experimental void rte_bpf_eth_rx_unload (uint16_t port,uint16_t queue);
@@ -58,7 +56,6 @@ rte_bpf_eth_rx_unload(uint16_t port, uint16_t queue);* @param queue * The identifier of the TX queue on the given port */ -__rte_experimental void rte_bpf_eth_tx_unload (uint16_t port,uint16_t queue);
@@ -82,7 +79,6 @@ rte_bpf_eth_tx_unload(uint16_t port, uint16_t queue);* @return * Zero on successful completion or negative error code otherwise. */ -__rte_experimental int rte_bpf_eth_rx_elf_load(uint16_t port, uint16_t queue, const struct rte_bpf_prm *prm, const char *fname, const char *sname,
@@ -108,7 +104,6 @@ rte_bpf_eth_rx_elf_load(uint16_t port, uint16_t queue,* @return * Zero on successful completion or negative error code otherwise. */ -__rte_experimental int rte_bpf_eth_tx_elf_load(uint16_t port, uint16_t queue, const struct rte_bpf_prm *prm, const char *fname, const char *sname,
lib/librte_bpf/rte_bpf_version.map +1 -1
@@ -1,4 +1,4 @@ -EXPERIMENTAL { +DPDK_21 { global: rte_bpf_destroy;
Signature · 13 lines
2.25.1 -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
Quoted 8 lines
The BPF lib was introduced in 18.05.
There were no changes in it's public API since 19.11. It should be mature enough to remove it's 'experimental' tag.Signed-off-by Conor Walsh <[email protected]>---
Quoted 1 line
2.25.1
Quoted 4 lines · Conor Walsh
The BPF lib was introduced in 18.05.
There were no changes in it's public API since 19.11. It should be mature enough to remove it's 'experimental' tag.
Should RTE_BPF_XTYPE_NUM be dropped?
Signature · 1 line
David Marchand
Quoted 9 lines · Conor Walsh
Quoted 4 lines
The BPF lib was introduced in 18.05.
There were no changes in it's public API since 19.11. It should be mature enough to remove it's 'experimental' tag.Should
RTE_BPF_XTYPE_NUMbe dropped?
Good catch, thanks.
Yes I agree, we probably better do it now to avoid ABI problems in future.
PATCH v2 1/1 lib/bpf: remove experimental tag
In reply to Conor WalshThe BPF lib was introduced in 18.05.
There were no changes in it's public API since 19.11. It should be mature enough to remove it's 'experimental' tag. RTE_BPF_XTYPE_NUM is also being dropped from rte_bpf_xtype to avoid possible ABI problems in the future.
---
v2: RTE_BPF_XTYPE_NUM dropped from rte_bpf_xtype
--- MAINTAINERS | 2 +- doc/guides/rel_notes/release_20_11.rst | 2 +- lib/librte_bpf/rte_bpf.h | 15 ++------------- lib/librte_bpf/rte_bpf_ethdev.h | 5 ----- lib/librte_bpf/rte_bpf_version.map | 2 +- 5 files changed, 5 insertions(+), 21 deletions(-)
MAINTAINERS +1 -1
@@ -1492,7 +1492,7 @@ F: app/test/test_telemetry* F: usertools/dpdk-telemetry* F: doc/guides/howto/telemetry.rst -BPF - EXPERIMENTAL +BPF M: Konstantin Ananyev <[email protected]> F: lib/librte_bpf/ F: examples/bpf/
doc/guides/rel_notes/release_20_11.rst +1 -1
@@ -84,7 +84,6 @@ API Changes Also, make sure to start the actual text at the margin. ======================================================= - ABI Changes -----------
@@ -100,6 +99,7 @@ ABI Changes Also, make sure to start the actual text at the margin. ======================================================= +* bpf: ``RTE_BPF_XTYPE_NUM`` has been dropped from ``rte_bpf_xtype`` Known Issues ------------
lib/librte_bpf/rte_bpf.h +2 -13
@@ -10,10 +10,6 @@* * RTE BPF support. * -* @warning -* @b EXPERIMENTAL: -* All functions in this file may be changed or removed without prior notice. -* * librte_bpf provides a framework to load and execute eBPF bytecode * inside user-space dpdk based applications. * It supports basic set of features from eBPF spec
@@ -36,7 +32,7 @@ enum rte_bpf_arg_type {RTE_BPF_ARG_RAW ,/**< scalar value */ RTE_BPF_ARG_PTR =0x10 ,/**< pointer to data buffer */ RTE_BPF_ARG_PTR_MBUF ,/**< pointer to rte_mbuf */ - RTE_BPF_ARG_RESERVED, /**< reserved for internal use */ + RTE_BPF_ARG_RESERVED /**< reserved for internal use */ };/**
@@ -63,8 +59,7 @@ struct rte_bpf_arg {*/ enum rte_bpf_xtype {RTE_BPF_XTYPE_FUNC ,/**< function */ -RTE_BPF_XTYPE_VAR ,/**< variable */ -RTE_BPF_XTYPE_NUM +RTE_BPF_XTYPE_VAR /**< variable */ };/**
@@ -117,7 +112,6 @@ struct rte_bpf;* @param bpf * BPF handle to destroy. */ -__rte_experimental void rte_bpf_destroy (struct rte_bpf *bpf);
@@ -133,7 +127,6 @@ rte_bpf_destroy(struct rte_bpf *bpf);* - EINVAL - invalid parameter passed to function * - ENOMEM - can't reserve enough memory */ -__rte_experimental struct rte_bpf *rte_bpf_load (const struct rte_bpf_prm *prm);
@@ -157,7 +150,6 @@ rte_bpf_load(const struct rte_bpf_prm *prm);* - EINVAL - invalid parameter passed to function * - ENOMEM - can't reserve enough memory */ -__rte_experimental struct rte_bpf *rte_bpf_elf_load (const struct rte_bpf_prm *prm,const char *fname,const char *sname);
@@ -171,7 +163,6 @@ rte_bpf_elf_load(const struct rte_bpf_prm *prm, const char *fname,* @return * BPF execution return value. */ -__rte_experimental uint64_t rte_bpf_exec (const struct rte_bpf *bpf,void *ctx);
@@ -189,7 +180,6 @@ rte_bpf_exec(const struct rte_bpf *bpf, void *ctx);* @return * number of successfully processed inputs. */ -__rte_experimental uint32_t rte_bpf_exec_burst (const struct rte_bpf *bpf,void *ctx[],uint64_t rc[],uint32_t num);
@@ -205,7 +195,6 @@ rte_bpf_exec_burst(const struct rte_bpf *bpf, void *ctx[], uint64_t rc[],* - -EINVAL if the parameters are invalid. * - Zero if operation completed successfully. */ -__rte_experimental int rte_bpf_get_jit (const struct rte_bpf *bpf,struct rte_bpf_jit *jit);
lib/librte_bpf/rte_bpf_ethdev.h +0 -5
@@ -7,7 +7,6 @@/** * @file rte_bpf_ethdev.h -* @b EXPERIMENTAL: this API may change without prior notice * * API to install BPF filter as RX/TX callbacks for eth devices. * Note that right now:
@@ -45,7 +44,6 @@ enum {* @param queue * The identifier of the RX queue on the given port */ -__rte_experimental void rte_bpf_eth_rx_unload (uint16_t port,uint16_t queue);
@@ -58,7 +56,6 @@ rte_bpf_eth_rx_unload(uint16_t port, uint16_t queue);* @param queue * The identifier of the TX queue on the given port */ -__rte_experimental void rte_bpf_eth_tx_unload (uint16_t port,uint16_t queue);
@@ -82,7 +79,6 @@ rte_bpf_eth_tx_unload(uint16_t port, uint16_t queue);* @return * Zero on successful completion or negative error code otherwise. */ -__rte_experimental int rte_bpf_eth_rx_elf_load(uint16_t port, uint16_t queue, const struct rte_bpf_prm *prm, const char *fname, const char *sname,
@@ -108,7 +104,6 @@ rte_bpf_eth_rx_elf_load(uint16_t port, uint16_t queue,* @return * Zero on successful completion or negative error code otherwise. */ -__rte_experimental int rte_bpf_eth_tx_elf_load(uint16_t port, uint16_t queue, const struct rte_bpf_prm *prm, const char *fname, const char *sname,
lib/librte_bpf/rte_bpf_version.map +1 -1
@@ -1,4 +1,4 @@ -EXPERIMENTAL { +DPDK_21 { global: rte_bpf_destroy;
Signature · 1 line
2.25.1
PATCH v3 1/1 bpf: remove experimental tag
The BPF lib was introduced in 18.05.
There were no changes in it's public API since 19.11. It should be mature enough to remove it's 'experimental' tag. RTE_BPF_XTYPE_NUM is also being dropped from rte_bpf_xtype to avoid possible ABI problems in the future.
---
v2: RTE_BPF_XTYPE_NUM dropped from rte_bpf_xtype
---
v3: fix commit title and move from ABI to API in release notes
--- MAINTAINERS | 2 +- doc/guides/rel_notes/release_20_11.rst | 2 ++ lib/librte_bpf/rte_bpf.h | 15 ++------------- lib/librte_bpf/rte_bpf_ethdev.h | 5 ----- lib/librte_bpf/rte_bpf_version.map | 2 +- 5 files changed, 6 insertions(+), 20 deletions(-)
MAINTAINERS +1 -1
@@ -1492,7 +1492,7 @@ F: app/test/test_telemetry* F: usertools/dpdk-telemetry* F: doc/guides/howto/telemetry.rst -BPF - EXPERIMENTAL +BPF M: Konstantin Ananyev <[email protected]> F: lib/librte_bpf/ F: examples/bpf/
doc/guides/rel_notes/release_20_11.rst +2 -0
@@ -84,6 +84,8 @@ API Changes Also, make sure to start the actual text at the margin. ======================================================= +* bpf: ``RTE_BPF_XTYPE_NUM`` has been dropped from ``rte_bpf_xtype`` + ABI Changes -----------
lib/librte_bpf/rte_bpf.h +2 -13
@@ -10,10 +10,6 @@* * RTE BPF support. * -* @warning -* @b EXPERIMENTAL: -* All functions in this file may be changed or removed without prior notice. -* * librte_bpf provides a framework to load and execute eBPF bytecode * inside user-space dpdk based applications. * It supports basic set of features from eBPF spec
@@ -36,7 +32,7 @@ enum rte_bpf_arg_type {RTE_BPF_ARG_RAW ,/**< scalar value */ RTE_BPF_ARG_PTR =0x10 ,/**< pointer to data buffer */ RTE_BPF_ARG_PTR_MBUF ,/**< pointer to rte_mbuf */ - RTE_BPF_ARG_RESERVED, /**< reserved for internal use */ + RTE_BPF_ARG_RESERVED /**< reserved for internal use */ };/**
@@ -63,8 +59,7 @@ struct rte_bpf_arg {*/ enum rte_bpf_xtype {RTE_BPF_XTYPE_FUNC ,/**< function */ -RTE_BPF_XTYPE_VAR ,/**< variable */ -RTE_BPF_XTYPE_NUM +RTE_BPF_XTYPE_VAR /**< variable */ };/**
@@ -117,7 +112,6 @@ struct rte_bpf;* @param bpf * BPF handle to destroy. */ -__rte_experimental void rte_bpf_destroy (struct rte_bpf *bpf);
@@ -133,7 +127,6 @@ rte_bpf_destroy(struct rte_bpf *bpf);* - EINVAL - invalid parameter passed to function * - ENOMEM - can't reserve enough memory */ -__rte_experimental struct rte_bpf *rte_bpf_load (const struct rte_bpf_prm *prm);
@@ -157,7 +150,6 @@ rte_bpf_load(const struct rte_bpf_prm *prm);* - EINVAL - invalid parameter passed to function * - ENOMEM - can't reserve enough memory */ -__rte_experimental struct rte_bpf *rte_bpf_elf_load (const struct rte_bpf_prm *prm,const char *fname,const char *sname);
@@ -171,7 +163,6 @@ rte_bpf_elf_load(const struct rte_bpf_prm *prm, const char *fname,* @return * BPF execution return value. */ -__rte_experimental uint64_t rte_bpf_exec (const struct rte_bpf *bpf,void *ctx);
@@ -189,7 +180,6 @@ rte_bpf_exec(const struct rte_bpf *bpf, void *ctx);* @return * number of successfully processed inputs. */ -__rte_experimental uint32_t rte_bpf_exec_burst (const struct rte_bpf *bpf,void *ctx[],uint64_t rc[],uint32_t num);
@@ -205,7 +195,6 @@ rte_bpf_exec_burst(const struct rte_bpf *bpf, void *ctx[], uint64_t rc[],* - -EINVAL if the parameters are invalid. * - Zero if operation completed successfully. */ -__rte_experimental int rte_bpf_get_jit (const struct rte_bpf *bpf,struct rte_bpf_jit *jit);
lib/librte_bpf/rte_bpf_ethdev.h +0 -5
@@ -7,7 +7,6 @@/** * @file rte_bpf_ethdev.h -* @b EXPERIMENTAL: this API may change without prior notice * * API to install BPF filter as RX/TX callbacks for eth devices. * Note that right now:
@@ -45,7 +44,6 @@ enum {* @param queue * The identifier of the RX queue on the given port */ -__rte_experimental void rte_bpf_eth_rx_unload (uint16_t port,uint16_t queue);
@@ -58,7 +56,6 @@ rte_bpf_eth_rx_unload(uint16_t port, uint16_t queue);* @param queue * The identifier of the TX queue on the given port */ -__rte_experimental void rte_bpf_eth_tx_unload (uint16_t port,uint16_t queue);
@@ -82,7 +79,6 @@ rte_bpf_eth_tx_unload(uint16_t port, uint16_t queue);* @return * Zero on successful completion or negative error code otherwise. */ -__rte_experimental int rte_bpf_eth_rx_elf_load(uint16_t port, uint16_t queue, const struct rte_bpf_prm *prm, const char *fname, const char *sname,
@@ -108,7 +104,6 @@ rte_bpf_eth_rx_elf_load(uint16_t port, uint16_t queue,* @return * Zero on successful completion or negative error code otherwise. */ -__rte_experimental int rte_bpf_eth_tx_elf_load(uint16_t port, uint16_t queue, const struct rte_bpf_prm *prm, const char *fname, const char *sname,
lib/librte_bpf/rte_bpf_version.map +1 -1
@@ -1,4 +1,4 @@ -EXPERIMENTAL { +DPDK_21 { global: rte_bpf_destroy;
Signature · 1 line
2.25.1
Re: [dpdk-dev] [PATCH v3] bpf: remove experimental tag
Quoted 7 lines
The BPF lib was introduced in 18.05.
There were no changes in it's public API since 19.11. It should be mature enough to remove it's 'experimental' tag.RTE_BPF_XTYPE_NUMis also being dropped fromrte_bpf_xtypeto avoid possible ABI problems in the future.
Quoted 8 lines
---
v2:RTE_BPF_XTYPE_NUMdropped fromrte_bpf_xtype---
v3: fix commit title and move from ABI to API in release notesSigned-off-by Conor Walsh <[email protected]>---
Quoted 1 line
2.25.1
Re: [dpdk-dev] [PATCH v3] bpf: remove experimental tag
In reply to Conor WalshQuoted 7 lines · Conor Walsh
The BPF lib was introduced in 18.05.
There were no changes in it's public API since 19.11. It should be mature enough to remove it's 'experimental' tag.RTE_BPF_XTYPE_NUMis also being dropped fromrte_bpf_xtypeto avoid possible ABI problems in the future.
Quoted 7 lines
---
v2:RTE_BPF_XTYPE_NUMdropped fromrte_bpf_xtype---
v3: fix commit title and move from ABI to API in release notesSigned-off-by Conor Walsh <[email protected]>
Things after --- are recognised as annotations and ignored by git when applying.
I fixed your SoB tag and applied, thanks.
Signature · 1 line
David Marchand