Skip to contentSkip to conversation

serial: imx: Delete duplicated argument to '|' in imx_uart_probe

PATCH In review Ye Bin 3 participants 3 messages Sep 3, 2020 – Sep 4, 2020

Subsystems (2)
lore
Share & tools
lore

Ye Bin

author
#0 lore raw

PATCH v2 1/1 serial: imx: Delete duplicated argument to '|' in imx_uart_probe

When calculate "ucr1" UCR1_TRDYEN is duplicate.

Fixes c514a6f848b5b ("serial: imx: use Tx ready rather than Tx empty irq")
---
 drivers/tty/serial/imx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/tty/serial/imx.c +1 -2
index ce8c472cf385..4e6ead1f650e 100644
@@ -2389,8 +2389,7 @@ static int imx_uart_probe(struct platform_device *pdev)
 
 	/* Disable interrupts before requesting them */
 	ucr1 = imx_uart_readl(sport, UCR1);
-	ucr1 &= ~(UCR1_ADEN | UCR1_TRDYEN | UCR1_IDEN | UCR1_RRDYEN |
-		 UCR1_TRDYEN | UCR1_RTSDEN);
+	ucr1 &= ~(UCR1_ADEN | UCR1_TRDYEN | UCR1_IDEN | UCR1_RRDYEN | UCR1_RTSDEN);
 	imx_uart_writel(sport, ucr1, UCR1);
 
 	if (!imx_uart_is_imx1(sport) && sport->dte_mode) {
Signature · 1 line
2.25.4
Reviewed-by on v2 1/1
#1 lore raw

Hello,

Quoted 4 lines · Ye Bin

When calculate "ucr1" UCR1_TRDYEN is duplicate.

Fixes c514a6f848b5b ("serial: imx: use Tx ready rather than Tx empty irq")

Not sure I'd use Fixes: to reference the commit that introduced this duplication, as this fix is not critical at all.

Other than that:

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
maintainer
#2 lore raw
Quoted 10 lines · Uwe Kleine-König

Hello,

Quoted 4 lines · Ye Bin

When calculate "ucr1" UCR1_TRDYEN is duplicate.

Fixes c514a6f848b5b ("serial: imx: use Tx ready rather than Tx empty irq")

Not sure I'd use Fixes: to reference the commit that introduced this duplication, as this fix is not critical at all.

Agreed, I'm dropping that line.

thanks,

greg k-h