serial: imx: Delete duplicated argument to '|' in imx_uart_probe
Subsystems (2)
PATCH v2 1/1 serial: imx: Delete duplicated argument to '|' in imx_uart_probe
When calculate "ucr1" UCR1_TRDYEN is duplicate.
Fixes c514a6f848b5b ("serial: imx: use Tx ready rather than Tx empty irq")
Signed-off-by Ye Bin <[email protected]>
--- drivers/tty/serial/imx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/tty/serial/imx.c +1 -2
@@ -2389,8 +2389,7 @@ static int imx_uart_probe(struct platform_device *pdev)/* Disable interrupts before requesting them */ ucr1 =imx_uart_readl (sport,UCR1 ); - ucr1 &= ~(UCR1_ADEN |UCR1_TRDYEN |UCR1_IDEN |UCR1_RRDYEN | -UCR1_TRDYEN |UCR1_RTSDEN ); + ucr1 &= ~(UCR1_ADEN |UCR1_TRDYEN |UCR1_IDEN |UCR1_RRDYEN |UCR1_RTSDEN );imx_uart_writel (sport, ucr1,UCR1 );if (!imx_uart_is_imx1 (sport) && sport->dte_mode) {
Signature · 1 line
2.25.4
Hello,
Quoted 4 lines · Ye Bin
When calculate "ucr1"
UCR1_TRDYENis duplicate.Fixes c514a6f848b5b ("serial: imx: use Tx ready rather than Tx empty irq")Signed-off-by Ye Bin <[email protected]>
Not sure I'd use Fixes: to reference the commit that introduced this duplication, as this fix is not critical at all.
Other than that:
Reviewed-by Uwe Kleine-König <[email protected]>
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Greg KH
maintainerQuoted 10 lines · Uwe Kleine-König
Hello,
Quoted 4 lines · Ye Bin
When calculate "ucr1"
UCR1_TRDYENis duplicate.Fixes c514a6f848b5b ("serial: imx: use Tx ready rather than Tx empty irq")Signed-off-by Ye Bin <[email protected]>Not sure I'd use Fixes: to reference the commit that introduced this duplication, as this fix is not critical at all.
Agreed, I'm dropping that line.
thanks,
greg k-h