spl: Avoid printing boot device if silent console is enabled
PATCH 1/1 spl: Avoid printing boot device if silent console is enabled
Signed-off-by Otavio Salvador <[email protected]>
---
common/spl/spl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
common/spl/spl.c +3 -1
@@ -552,7 +552,9 @@ static int boot_from_devices(struct spl_image_info *spl_image,struct spl_image_loader *loader; loader =spl_ll_find_loader (spl_boot_list[i]); -#if defined(CONFIG_SPL_SERIAL_SUPPORT ) && defined(CONFIG_SPL_LIBCOMMON_SUPPORT ) +#if defined(CONFIG_SPL_SERIAL_SUPPORT ) \ + && defined(CONFIG_SPL_LIBCOMMON_SUPPORT ) \ + && !defined(CONFIG_SILENT_CONSOLE )if (loader)printf ("Trying to boot from %s\n" , loader->name);else
Signature · 1 line
2.28.0
PATCH 1/1 spl: Avoid printing boot device if silent console is enabled
Quoted 1 line · Otavio Salvador
Signed-off-by Otavio Salvador <[email protected]>
Reviewed-by Tom Rini <[email protected]>
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200903/089e1867/attachment.sig>
PATCH 1/1 spl: Avoid printing boot device if silent console is enabled
In reply to Otavio SalvadorQuoted 11 lines · Otavio Salvador
Signed-off-by Otavio Salvador <[email protected]>---
common/spl/spl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)common/spl/spl.c +0
-0
common/spl/spl.c static int boot_from_devices(struct spl_image_info *spl_image, · line 557
Quoted 7 lines
common/spl/spl.c +3
-1@@ -552,7 +552,9 @@ static int boot_from_devices(struct spl_image_info *spl_image,struct spl_image_loader *loader; loader =spl_ll_find_loader (spl_boot_list[i]); -#if defined(CONFIG_SPL_SERIAL_SUPPORT ) && defined(CONFIG_SPL_LIBCOMMON_SUPPORT ) +#if defined(CONFIG_SPL_SERIAL_SUPPORT ) \ + && defined(CONFIG_SPL_LIBCOMMON_SUPPORT ) \ + && !defined(CONFIG_SILENT_CONSOLE )
Nitpicking:
I think its preferred to put the "&&" (or "||") at the end of the line.
Other than that:
Reviewed-by Stefan Roese <[email protected]>
Thanks,
Stefan
PATCH 1/1 spl: Avoid printing boot device if silent console is enabled
In reply to Otavio SalvadorQuoted 3 lines · Otavio Salvador
Signed-off-by Otavio Salvador <[email protected]>Reviewed-by Tom Rini <[email protected]>Reviewed-by Stefan Roese <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20201014/f755253d/attachment.sig>