dt-bindings:iio:adc: Another set of yaml conversions.

From: Jonathan Cameron <[email protected]>

A simple conversion of this freescale ADC binding from txt to yaml. For maintainer I went with Fugang Duan as the original author of the binding. Would be great to have confirmation of this.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Fugang Duan <[email protected]>

Cc Shawn Guo <[email protected]>

Cc Sascha Hauer <[email protected]>

---
 .../bindings/iio/adc/fsl,vf610-adc.yaml       | 81 +++++++++++++++++++
 .../devicetree/bindings/iio/adc/vf610-adc.txt | 36 ---------
 2 files changed, 81 insertions(+), 36 deletions(-)

From: Jonathan Cameron <[email protected]>

A simple conversion of this freescale ADC binding from txt to yaml. For maintainer I went with Fugang Duan as the original author of the binding. Would be great to have confirmation of this.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Fugang Duan <[email protected]>

Cc Shawn Guo <[email protected]>

Cc Sascha Hauer <[email protected]>

---
 .../bindings/iio/adc/fsl,vf610-adc.yaml       | 81 +++++++++++++++++++
 .../devicetree/bindings/iio/adc/vf610-adc.txt | 36 ---------
 2 files changed, 81 insertions(+), 36 deletions(-)

Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml new file +0 -0

new file mode 100644
index 000000000000..99b6b55fd0a3

Quoted 28 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

A simple conversion of this freescale ADC binding from txt to yaml. For maintainer I went with Fugang Duan as the original author of the binding. Would be great to have confirmation of this.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Fugang Duan <[email protected]>

Cc Shawn Guo <[email protected]>

Cc Sascha Hauer <[email protected]>

---
 .../bindings/iio/adc/fsl,vf610-adc.yaml       | 81 +++++++++++++++++++
 .../devicetree/bindings/iio/adc/vf610-adc.txt | 36 ---------
 2 files changed, 81 insertions(+), 36 deletions(-)

Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml new file +6 -0

new file mode 100644
index 000000000000..99b6b55fd0a3
@@ -0,0 +1,81 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/fsl,vf610-adc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+

Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml line 10

Quoted 4 lines

Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml new file +4 -0

+title: ADC found on Freescale vf610 and similar SoCs
+
+maintainers:
+  - Fugang Duan <[email protected]>  

I assume you got a bunch of bounces on this series, too? Looks like 1, 4, 7, 9, 13, 16, 19, and 20 bounced. Please fix those addresses before applying.

Rob

Quoted 1 line · On Tue, 15 Sep 2020 14:45:58 -0600 Rob Herring <[email protected]> wrote:

On Wed, Sep 9, 2020 at 12:02 PM Jonathan Cameron <[email protected]>

Quoted 7 lines · wrote:

Quoted 7 lines

From: Jonathan Cameron <[email protected]>

A simple conversion of this freescale ADC binding from txt to yaml. For maintainer I went with Fugang Duan as the original author of the binding. Would be great to have confirmation of this.

Quoted 6 lines

Quoted 6 lines

Signed-off-by Jonathan Cameron <[email protected]>

Cc Fugang Duan <[email protected]>

Cc Shawn Guo <[email protected]>

Cc Sascha Hauer <[email protected]>

---
 .../bindings/iio/adc/fsl,vf610-adc.yaml       | 81

+++++++++++++++++++

Quoted 16 lines

Quoted 12 lines

 .../devicetree/bindings/iio/adc/vf610-adc.txt | 36 ---------
 2 files changed, 81 insertions(+), 36 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml b/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml new file mode 100644
index 000000000000..99b6b55fd0a3

Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml line 4

Quoted 4 lines

Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml new file +4 -0

@@ -0,0 +1,81 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2
+---
+$id:
+https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fde

+vicetree.org%2Fschemas%2Fiio%2Fadc%2Ffsl%2Cvf610-adc.yaml%23&amp;da

Quoted 1 line

Quoted 1 line

+ta=02%7C01%7Cfugang.duan%40nxp.com%7C750fcd8ebdf34af6655308d85a2 c41

Quoted 1 line

Quoted 1 line

+8d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63735849344455 0580&

Quoted 1 line

Quoted 1 line

+amp;sdata=SwRIWqN5caXEUZBTmnjKKHJKAZ1FQ03s1Gdpf%2FTyXzE%3D&am p;rese

Quoted 4 lines

Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml

Quoted 4 lines

Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml new file +3 -0

+rved=0
+$schema:
+https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fde

+vicetree.org%2Fmeta-schemas%2Fcore.yaml%23&amp;data=02%7C01%7Cfug an

Quoted 1 line

Quoted 1 line

+g.duan%40nxp.com%7C750fcd8ebdf34af6655308d85a2c418d%7C686ea1d3bc 2b4

Quoted 1 line

Quoted 1 line

+c6fa92cd99c5c301635%7C0%7C0%7C637358493444550580&amp;sdata=c4To ZCOG

Quoted 10 lines

Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml line 10

Quoted 6 lines

Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml new file +6 -0

+iPM0XbxCnLGJEEXvnMvFKqSgg3gtLeDYACI%3D&reserved=0
+
+title: ADC found on Freescale vf610 and similar SoCs
+
+maintainers:
+  - Fugang Duan <[email protected]>

I assume you got a bunch of bounces on this series, too? Looks like 1, 4, 7, 9, 13, 16, 19, and 20 bounced. Please fix those addresses before applying.

Yup. I missed them on v1, but have saved the set for v2 to be able to fix those I can.

for some I can make a reasonable stab at a suitable maintainer as covered by a catch all. For the others if I can't find a newer address I'll cover them myself until someone else steps up.
I think that's just 9 and 13. For 4 I didn't get a bounce but can add that to my list!

For this particular one looks like fugang duan is still active but now with an NXP address so I'll update that. I've changed the cc on this mail.

Thanks,

Jonathan

Quoted 4 lines

Rob

From: Jonathan Cameron <[email protected]> Sent: Wednesday, September 16, 2020 6:34 PM

Quoted 82 lines

Quoted 1 line · On Tue, 15 Sep 2020 14:45:58 -0600 Rob Herring <[email protected]> wrote:

On Wed, Sep 9, 2020 at 12:02 PM Jonathan Cameron <[email protected]>

Quoted 7 lines · wrote:

Quoted 7 lines

From: Jonathan Cameron <[email protected]>

A simple conversion of this freescale ADC binding from txt to yaml. For maintainer I went with Fugang Duan as the original author of the binding. Would be great to have confirmation of this.

Quoted 6 lines

Quoted 6 lines

Signed-off-by Jonathan Cameron <[email protected]>

Cc Fugang Duan <[email protected]>

Cc Shawn Guo <[email protected]>

Cc Sascha Hauer <[email protected]>

---
 .../bindings/iio/adc/fsl,vf610-adc.yaml       | 81  

+++++++++++++++++++

Quoted 16 lines

Quoted 12 lines

 .../devicetree/bindings/iio/adc/vf610-adc.txt | 36 ---------
 2 files changed, 81 insertions(+), 36 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml b/Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml new file mode 100644
index 000000000000..99b6b55fd0a3

Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml line 4

Quoted 4 lines

Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml new file +4 -0

@@ -0,0 +1,81 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2
+---
+$id:
+https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fde

+vicetree.org%2Fschemas%2Fiio%2Fadc%2Ffsl%2Cvf610-adc.yaml%23&amp;da

Quoted 1 line

Quoted 1 line

+ta=02%7C01%7Cfugang.duan%40nxp.com%7C750fcd8ebdf34af6655308d85a2 c41

Quoted 1 line

Quoted 1 line

+8d%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63735849344455 0580&

Quoted 1 line

Quoted 1 line

+amp;sdata=SwRIWqN5caXEUZBTmnjKKHJKAZ1FQ03s1Gdpf%2FTyXzE%3D&am p;rese

Quoted 4 lines

Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml

Quoted 4 lines

Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml new file +3 -0

+rved=0
+$schema:
+https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fde

+vicetree.org%2Fmeta-schemas%2Fcore.yaml%23&amp;data=02%7C01%7Cfug an

Quoted 1 line

Quoted 1 line

+g.duan%40nxp.com%7C750fcd8ebdf34af6655308d85a2c418d%7C686ea1d3bc 2b4

Quoted 1 line

Quoted 1 line

+c6fa92cd99c5c301635%7C0%7C0%7C637358493444550580&amp;sdata=c4To ZCOG

Quoted 10 lines

Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml line 10

Quoted 6 lines

Documentation/devicetree/bindings/iio/adc/fsl,vf610-adc.yaml new file +6 -0

+iPM0XbxCnLGJEEXvnMvFKqSgg3gtLeDYACI%3D&reserved=0
+
+title: ADC found on Freescale vf610 and similar SoCs
+
+maintainers:
+  - Fugang Duan <[email protected]>  

I assume you got a bunch of bounces on this series, too? Looks like 1, 4, 7, 9, 13, 16, 19, and 20 bounced. Please fix those addresses before applying.

Yup. I missed them on v1, but have saved the set for v2 to be able to fix those I can.

for some I can make a reasonable stab at a suitable maintainer as covered by a catch all. For the others if I can't find a newer address I'll cover them myself until someone else steps up.
I think that's just 9 and 13. For 4 I didn't get a bounce but can add that to my list!

For this particular one looks like fugang duan is still active but now with an NXP address so I'll update that. I've changed the cc on this mail.

Thanks,

Quoted 1 line

Jonathan

Thanks, Jonathan.

For the patch, it looks good.

Reviewed-by Fugang Duan <[email protected]>

Quoted 5 lines

Quoted 4 lines

Rob

From: Jonathan Cameron <[email protected]>

Conversion from txt to yaml as part of a general move of IIO bindings to the new format.

Signed-off-by Jonathan Cameron <[email protected]>

Acked-by Sebastian Reichel <[email protected]>

---
 .../bindings/iio/adc/ti,twl4030-madc.yaml     | 48 +++++++++++++++++++
 .../bindings/iio/adc/twl4030-madc.txt         | 24 ----------
 2 files changed, 48 insertions(+), 24 deletions(-)

Quoted 7 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Conversion from txt to yaml as part of a general move of IIO bindings to the new format.

Signed-off-by Jonathan Cameron <[email protected]>

Acked-by Sebastian Reichel <[email protected]>

Quoted 5 lines

---
 .../bindings/iio/adc/ti,twl4030-madc.yaml     | 48 +++++++++++++++++++
 .../bindings/iio/adc/twl4030-madc.txt         | 24 ----------
 2 files changed, 48 insertions(+), 24 deletions(-)

Reviewed-by Rob Herring <[email protected]>

From: Jonathan Cameron <[email protected]>

Conversion from freeform text to yaml.
One oddity in this binding is that, for historical reasons it requires the node name to be stmpe_adc. I've put that in the decription field but I'm not sure if there is a better way to specify this?

Signed-off-by Jonathan Cameron <[email protected]>

Cc Stefan Agner <[email protected]>

---
 .../bindings/iio/adc/st,stmpe-adc.yaml        | 45 +++++++++++++++++++
 .../devicetree/bindings/iio/adc/stmpe-adc.txt | 21 ---------
 2 files changed, 45 insertions(+), 21 deletions(-)

Quoted 7 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Conversion from freeform text to yaml.
One oddity in this binding is that, for historical reasons it requires the node name to be stmpe_adc. I've put that in the decription field but I'm not sure if there is a better way to specify this?

Quoted 7 lines

Signed-off-by Jonathan Cameron <[email protected]>

Cc Stefan Agner <[email protected]>

---
 .../bindings/iio/adc/st,stmpe-adc.yaml        | 45 +++++++++++++++++++
 .../devicetree/bindings/iio/adc/stmpe-adc.txt | 21 ---------
 2 files changed, 45 insertions(+), 21 deletions(-)

Reviewed-by Rob Herring <[email protected]>

From: Jonathan Cameron <[email protected]>

Simple txt to yaml conversion. Part of a general move to convert all the IIO bindings over to yaml.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Rick Altherr <[email protected]>

Cc Joel Stanley <[email protected]>

Cc Andrew Jeffery <[email protected]>

Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml new file +54 -0

@@ -0,0 +1,54 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/aspeed,ast2400-adc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ADC that forms part of an ASPEED server management processor.
+
+maintainers:
+  - Rick Altherr <[email protected]>
+
+description:
+  This device is a 10-bit converter for 16 voltage channels.  All inputs are
+  single ended.
+
+properties:
+  compatible:
+    enum:
+      - aspeed,ast2400-adc
+      - aspeed,ast2500-adc
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    description:
+      Input clock used to derive the sample clock. Expected to be the
+      SoC's APB clock.
+
+  resets: true
+
+  "#io-channel-cells":
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - resets
+  - "#io-channel-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/aspeed-clock.h>
+    adc@1e6e9000 {
+        compatible = "aspeed,ast2400-adc";
+        reg = <0x1e6e9000 0xb0>;
+        clocks = <&syscon ASPEED_CLK_APB>;
+        resets = <&syscon ASPEED_RESET_ADC>;
+        #io-channel-cells = <1>;
+    };
+...

Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt deleted +0 -23

deleted file mode 100644
index 034fc2ba100e..000000000000
@@ -1,22 +0,0 @@
-Aspeed ADC
-
-This device is a 10-bit converter for 16 voltage channels.  All inputs are
-single ended.
-
-Required properties:
-- compatible: Should be "aspeed,ast2400-adc" or "aspeed,ast2500-adc"
-- reg: memory window mapping address and length
-- clocks: Input clock used to derive the sample clock. Expected to be the
-          SoC's APB clock.
-- resets: Reset controller phandle
-- #io-channel-cells: Must be set to <1> to indicate channels are selected
-                     by index.
-
-Example:
-       adc@1e6e9000 {
-               compatible = "aspeed,ast2400-adc";
-               reg = <0x1e6e9000 0xb0>;
-               clocks = <&syscon ASPEED_CLK_APB>;
-               resets = <&syscon ASPEED_RESET_ADC>;
-               #io-channel-cells = <1>;
-       };
--

2.28.0

Quoted 10 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Simple txt to yaml conversion. Part of a general move to convert all the IIO bindings over to yaml.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Rick Altherr <[email protected]>

Cc Joel Stanley <[email protected]>

Cc Andrew Jeffery <[email protected]>

Acked-by Joel Stanley <[email protected]>

Quoted 5 lines

---
 .../bindings/iio/adc/aspeed,ast2400-adc.yaml  | 54 +++++++++++++++++++
 .../bindings/iio/adc/aspeed_adc.txt           | 22 --------
 2 files changed, 54 insertions(+), 22 deletions(-)

Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml

Quoted 5 lines

Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml new file +0 -0

new file mode 100644
index 000000000000..09018487d690

This naming doesn't make sense, as the bindings are for the ast2500 too (and they also apply for the ast2600).

Quoted 87 lines

Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml new file +54 -0

@@ -0,0 +1,54 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/aspeed,ast2400-adc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ADC that forms part of an ASPEED server management processor.
+
+maintainers:
+  - Rick Altherr <[email protected]>
+
+description:
+  This device is a 10-bit converter for 16 voltage channels.  All inputs are
+  single ended.
+
+properties:
+  compatible:
+    enum:
+      - aspeed,ast2400-adc
+      - aspeed,ast2500-adc
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    description:
+      Input clock used to derive the sample clock. Expected to be the
+      SoC's APB clock.
+
+  resets: true
+
+  "#io-channel-cells":
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - resets
+  - "#io-channel-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/aspeed-clock.h>
+    adc@1e6e9000 {
+        compatible = "aspeed,ast2400-adc";
+        reg = <0x1e6e9000 0xb0>;
+        clocks = <&syscon ASPEED_CLK_APB>;
+        resets = <&syscon ASPEED_RESET_ADC>;
+        #io-channel-cells = <1>;
+    };
+...

Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt deleted +0 -23

deleted file mode 100644
index 034fc2ba100e..000000000000
@@ -1,22 +0,0 @@
-Aspeed ADC
-
-This device is a 10-bit converter for 16 voltage channels.  All inputs are
-single ended.
-
-Required properties:
-- compatible: Should be "aspeed,ast2400-adc" or "aspeed,ast2500-adc"
-- reg: memory window mapping address and length
-- clocks: Input clock used to derive the sample clock. Expected to be the
-          SoC's APB clock.
-- resets: Reset controller phandle
-- #io-channel-cells: Must be set to <1> to indicate channels are selected
-                     by index.
-
-Example:
-       adc@1e6e9000 {
-               compatible = "aspeed,ast2400-adc";
-               reg = <0x1e6e9000 0xb0>;
-               clocks = <&syscon ASPEED_CLK_APB>;
-               resets = <&syscon ASPEED_RESET_ADC>;
-               #io-channel-cells = <1>;
-       };
--

2.28.0

Quoted 20 lines · On Thu, 10 Sep 2020 02:32:19 +0000 Joel Stanley <[email protected]> wrote:

Quoted 10 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Simple txt to yaml conversion. Part of a general move to convert all the IIO bindings over to yaml.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Rick Altherr <[email protected]>

Cc Joel Stanley <[email protected]>

Cc Andrew Jeffery <[email protected]>

Acked-by Joel Stanley <[email protected]>

Quoted 5 lines

---
 .../bindings/iio/adc/aspeed,ast2400-adc.yaml  | 54 +++++++++++++++++++
 .../bindings/iio/adc/aspeed_adc.txt           | 22 --------
 2 files changed, 54 insertions(+), 22 deletions(-)

Quoted 8 lines

Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml

Quoted 5 lines

Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml new file +0 -0

new file mode 100644
index 000000000000..09018487d690

This naming doesn't make sense, as the bindings are for the ast2500 too (and they also apply for the ast2600).

Convention is to name after a supported device and not use wild cards or generic names because the chances of it going wrong in future is far too high. Will every aspeed adc look the same? Seems impossible to predict so best we can do safely is to pick a part number.

There are enormous numbers of examples of this in dt bindings and for that matter driver naming.

Thanks,

Jonathan

Quoted 87 lines

Quoted 87 lines

Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml new file +54 -0

@@ -0,0 +1,54 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/aspeed,ast2400-adc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ADC that forms part of an ASPEED server management processor.
+
+maintainers:
+  - Rick Altherr <[email protected]>
+
+description:
+  This device is a 10-bit converter for 16 voltage channels.  All inputs are
+  single ended.
+
+properties:
+  compatible:
+    enum:
+      - aspeed,ast2400-adc
+      - aspeed,ast2500-adc
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    description:
+      Input clock used to derive the sample clock. Expected to be the
+      SoC's APB clock.
+
+  resets: true
+
+  "#io-channel-cells":
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - resets
+  - "#io-channel-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/aspeed-clock.h>
+    adc@1e6e9000 {
+        compatible = "aspeed,ast2400-adc";
+        reg = <0x1e6e9000 0xb0>;
+        clocks = <&syscon ASPEED_CLK_APB>;
+        resets = <&syscon ASPEED_RESET_ADC>;
+        #io-channel-cells = <1>;
+    };
+...

Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt deleted +0 -23

deleted file mode 100644
index 034fc2ba100e..000000000000
@@ -1,22 +0,0 @@
-Aspeed ADC
-
-This device is a 10-bit converter for 16 voltage channels.  All inputs are
-single ended.
-
-Required properties:
-- compatible: Should be "aspeed,ast2400-adc" or "aspeed,ast2500-adc"
-- reg: memory window mapping address and length
-- clocks: Input clock used to derive the sample clock. Expected to be the
-          SoC's APB clock.
-- resets: Reset controller phandle
-- #io-channel-cells: Must be set to <1> to indicate channels are selected
-                     by index.
-
-Example:
-       adc@1e6e9000 {
-               compatible = "aspeed,ast2400-adc";
-               reg = <0x1e6e9000 0xb0>;
-               clocks = <&syscon ASPEED_CLK_APB>;
-               resets = <&syscon ASPEED_RESET_ADC>;
-               #io-channel-cells = <1>;
-       };
--

2.28.0

Quoted 33 lines · Jonathan Cameron

Quoted 20 lines · On Thu, 10 Sep 2020 02:32:19 +0000 Joel Stanley <[email protected]> wrote:

Quoted 10 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Simple txt to yaml conversion. Part of a general move to convert all the IIO bindings over to yaml.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Rick Altherr <[email protected]>

Cc Joel Stanley <[email protected]>

Cc Andrew Jeffery <[email protected]>

Acked-by Joel Stanley <[email protected]>

Quoted 5 lines

---
 .../bindings/iio/adc/aspeed,ast2400-adc.yaml  | 54 +++++++++++++++++++
 .../bindings/iio/adc/aspeed_adc.txt           | 22 --------
 2 files changed, 54 insertions(+), 22 deletions(-)

Quoted 8 lines

Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml

Quoted 5 lines

Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml new file +0 -0

new file mode 100644
index 000000000000..09018487d690

This naming doesn't make sense, as the bindings are for the ast2500 too (and they also apply for the ast2600).

Quoted 5 lines

Convention is to name after a supported device and not use wild cards or generic names because the chances of it going wrong in future is far too high. Will every aspeed adc look the same? Seems impossible to predict so best we can do safely is to pick a part number.

It already supports three different generations of SoC, which I was bringing to your attention. Therefore having the name '2400' is already incorrect.

Quoted 99 lines

There are enormous numbers of examples of this in dt bindings and for that matter driver naming.

Thanks,

Jonathan

Quoted 87 lines

Quoted 87 lines

Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml new file +54 -0

@@ -0,0 +1,54 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/aspeed,ast2400-adc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ADC that forms part of an ASPEED server management processor.
+
+maintainers:
+  - Rick Altherr <[email protected]>
+
+description:
+  This device is a 10-bit converter for 16 voltage channels.  All inputs are
+  single ended.
+
+properties:
+  compatible:
+    enum:
+      - aspeed,ast2400-adc
+      - aspeed,ast2500-adc
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    description:
+      Input clock used to derive the sample clock. Expected to be the
+      SoC's APB clock.
+
+  resets: true
+
+  "#io-channel-cells":
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - resets
+  - "#io-channel-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/aspeed-clock.h>
+    adc@1e6e9000 {
+        compatible = "aspeed,ast2400-adc";
+        reg = <0x1e6e9000 0xb0>;
+        clocks = <&syscon ASPEED_CLK_APB>;
+        resets = <&syscon ASPEED_RESET_ADC>;
+        #io-channel-cells = <1>;
+    };
+...

Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt deleted +0 -23

deleted file mode 100644
index 034fc2ba100e..000000000000
@@ -1,22 +0,0 @@
-Aspeed ADC
-
-This device is a 10-bit converter for 16 voltage channels.  All inputs are
-single ended.
-
-Required properties:
-- compatible: Should be "aspeed,ast2400-adc" or "aspeed,ast2500-adc"
-- reg: memory window mapping address and length
-- clocks: Input clock used to derive the sample clock. Expected to be the
-          SoC's APB clock.
-- resets: Reset controller phandle
-- #io-channel-cells: Must be set to <1> to indicate channels are selected
-                     by index.
-
-Example:
-       adc@1e6e9000 {
-               compatible = "aspeed,ast2400-adc";
-               reg = <0x1e6e9000 0xb0>;
-               clocks = <&syscon ASPEED_CLK_APB>;
-               resets = <&syscon ASPEED_RESET_ADC>;
-               #io-channel-cells = <1>;
-       };
--

2.28.0

Quoted 41 lines · On Wed, 16 Sep 2020 12:39:36 +0000 Joel Stanley <[email protected]> wrote:

Quoted 33 lines · Jonathan Cameron

Quoted 20 lines · On Thu, 10 Sep 2020 02:32:19 +0000 Joel Stanley <[email protected]> wrote:

Quoted 10 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Simple txt to yaml conversion. Part of a general move to convert all the IIO bindings over to yaml.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Rick Altherr <[email protected]>

Cc Joel Stanley <[email protected]>

Cc Andrew Jeffery <[email protected]>

Acked-by Joel Stanley <[email protected]>

Quoted 5 lines

---
 .../bindings/iio/adc/aspeed,ast2400-adc.yaml  | 54 +++++++++++++++++++
 .../bindings/iio/adc/aspeed_adc.txt           | 22 --------
 2 files changed, 54 insertions(+), 22 deletions(-)

Quoted 8 lines

Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml

Quoted 5 lines

Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml new file +0 -0

new file mode 100644
index 000000000000..09018487d690

This naming doesn't make sense, as the bindings are for the ast2500 too (and they also apply for the ast2600).

Quoted 5 lines

Convention is to name after a supported device and not use wild cards or generic names because the chances of it going wrong in future is far too high. Will every aspeed adc look the same? Seems impossible to predict so best we can do safely is to pick a part number.

Quoted 3 lines

It already supports three different generations of SoC, which I was bringing to your attention. Therefore having the name '2400' is already incorrect.

I'm happy to change it to a specific part number of your choice but you have to chose one. The file name is not a list of all the parts supported.

There are bindings that attach to hundreds of different part numbers but the file is named after a specific one. Normally the first part supported is the one chosen (because the binding is normally written at that time).

Jonathan

Quoted 99 lines

Quoted 99 lines

There are enormous numbers of examples of this in dt bindings and for that matter driver naming.

Thanks,

Jonathan

Quoted 87 lines

Quoted 87 lines

Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml new file +54 -0

@@ -0,0 +1,54 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/aspeed,ast2400-adc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ADC that forms part of an ASPEED server management processor.
+
+maintainers:
+  - Rick Altherr <[email protected]>
+
+description:
+  This device is a 10-bit converter for 16 voltage channels.  All inputs are
+  single ended.
+
+properties:
+  compatible:
+    enum:
+      - aspeed,ast2400-adc
+      - aspeed,ast2500-adc
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    description:
+      Input clock used to derive the sample clock. Expected to be the
+      SoC's APB clock.
+
+  resets: true
+
+  "#io-channel-cells":
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - resets
+  - "#io-channel-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/aspeed-clock.h>
+    adc@1e6e9000 {
+        compatible = "aspeed,ast2400-adc";
+        reg = <0x1e6e9000 0xb0>;
+        clocks = <&syscon ASPEED_CLK_APB>;
+        resets = <&syscon ASPEED_RESET_ADC>;
+        #io-channel-cells = <1>;
+    };
+...

Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt deleted +0 -23

deleted file mode 100644
index 034fc2ba100e..000000000000
@@ -1,22 +0,0 @@
-Aspeed ADC
-
-This device is a 10-bit converter for 16 voltage channels.  All inputs are
-single ended.
-
-Required properties:
-- compatible: Should be "aspeed,ast2400-adc" or "aspeed,ast2500-adc"
-- reg: memory window mapping address and length
-- clocks: Input clock used to derive the sample clock. Expected to be the
-          SoC's APB clock.
-- resets: Reset controller phandle
-- #io-channel-cells: Must be set to <1> to indicate channels are selected
-                     by index.
-
-Example:
-       adc@1e6e9000 {
-               compatible = "aspeed,ast2400-adc";
-               reg = <0x1e6e9000 0xb0>;
-               clocks = <&syscon ASPEED_CLK_APB>;
-               resets = <&syscon ASPEED_RESET_ADC>;
-               #io-channel-cells = <1>;
-       };
--

2.28.0

Quoted 48 lines · On Wed, 16 Sep 2020 15:17:51 +0100 Jonathan Cameron…

Quoted 41 lines · On Wed, 16 Sep 2020 12:39:36 +0000 Joel Stanley <[email protected]> wrote:

Quoted 33 lines · Jonathan Cameron

Quoted 20 lines · On Thu, 10 Sep 2020 02:32:19 +0000 Joel Stanley <[email protected]> wrote:

Quoted 10 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Simple txt to yaml conversion. Part of a general move to convert all the IIO bindings over to yaml.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Rick Altherr <[email protected]>

Cc Joel Stanley <[email protected]>

Cc Andrew Jeffery <[email protected]>

Acked-by Joel Stanley <[email protected]>

Quoted 5 lines

---
 .../bindings/iio/adc/aspeed,ast2400-adc.yaml  | 54 +++++++++++++++++++
 .../bindings/iio/adc/aspeed_adc.txt           | 22 --------
 2 files changed, 54 insertions(+), 22 deletions(-)

Quoted 8 lines

Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml

Quoted 5 lines

Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml new file +0 -0

new file mode 100644
index 000000000000..09018487d690

This naming doesn't make sense, as the bindings are for the ast2500 too (and they also apply for the ast2600).

Quoted 5 lines

Convention is to name after a supported device and not use wild cards or generic names because the chances of it going wrong in future is far too high. Will every aspeed adc look the same? Seems impossible to predict so best we can do safely is to pick a part number.

Quoted 3 lines

It already supports three different generations of SoC, which I was bringing to your attention. Therefore having the name '2400' is already incorrect.

Quoted 7 lines

I'm happy to change it to a specific part number of your choice but you have to chose one. The file name is not a list of all the parts supported.

There are bindings that attach to hundreds of different part numbers but the file is named after a specific one. Normally the first part supported is the one chosen (because the binding is normally written at that time).

If we later decide to rename this then fair enough, but for now I've applied the patch as it stands to the togreg branch of iio.git and pushed out as testing for the autobuilders to possibly poke at it.

Note I made the change Rob pointed out whilst applying.

Thanks,

Jonathan

Quoted 103 lines

Jonathan

Quoted 99 lines

Quoted 99 lines

There are enormous numbers of examples of this in dt bindings and for that matter driver naming.

Thanks,

Jonathan

Quoted 87 lines

Quoted 87 lines

Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml new file +54 -0

@@ -0,0 +1,54 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/aspeed,ast2400-adc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ADC that forms part of an ASPEED server management processor.
+
+maintainers:
+  - Rick Altherr <[email protected]>
+
+description:
+  This device is a 10-bit converter for 16 voltage channels.  All inputs are
+  single ended.
+
+properties:
+  compatible:
+    enum:
+      - aspeed,ast2400-adc
+      - aspeed,ast2500-adc
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    description:
+      Input clock used to derive the sample clock. Expected to be the
+      SoC's APB clock.
+
+  resets: true
+
+  "#io-channel-cells":
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - resets
+  - "#io-channel-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/aspeed-clock.h>
+    adc@1e6e9000 {
+        compatible = "aspeed,ast2400-adc";
+        reg = <0x1e6e9000 0xb0>;
+        clocks = <&syscon ASPEED_CLK_APB>;
+        resets = <&syscon ASPEED_RESET_ADC>;
+        #io-channel-cells = <1>;
+    };
+...

Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt deleted +0 -23

deleted file mode 100644
index 034fc2ba100e..000000000000
@@ -1,22 +0,0 @@
-Aspeed ADC
-
-This device is a 10-bit converter for 16 voltage channels.  All inputs are
-single ended.
-
-Required properties:
-- compatible: Should be "aspeed,ast2400-adc" or "aspeed,ast2500-adc"
-- reg: memory window mapping address and length
-- clocks: Input clock used to derive the sample clock. Expected to be the
-          SoC's APB clock.
-- resets: Reset controller phandle
-- #io-channel-cells: Must be set to <1> to indicate channels are selected
-                     by index.
-
-Example:
-       adc@1e6e9000 {
-               compatible = "aspeed,ast2400-adc";
-               reg = <0x1e6e9000 0xb0>;
-               clocks = <&syscon ASPEED_CLK_APB>;
-               resets = <&syscon ASPEED_RESET_ADC>;
-               #io-channel-cells = <1>;
-       };
--

2.28.0

From: Jonathan Cameron <[email protected]>

Simple txt to yaml conversion. Part of a general move to convert all the IIO bindings over to yaml.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Rick Altherr <[email protected]>

Cc Joel Stanley <[email protected]>

Cc Andrew Jeffery <[email protected]>

---
 .../bindings/iio/adc/aspeed,ast2400-adc.yaml  | 54 +++++++++++++++++++
 .../bindings/iio/adc/aspeed_adc.txt           | 22 --------
 2 files changed, 54 insertions(+), 22 deletions(-)

Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml new file +20 -0

new file mode 100644
index 000000000000..09018487d690
@@ -0,0 +1,54 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/aspeed,ast2400-adc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ADC that forms part of an ASPEED server management processor.
+
+maintainers:
+  - Rick Altherr <[email protected]>
+
+description:
+  This device is a 10-bit converter for 16 voltage channels.  All inputs are
+  single ended.
+
+properties:
+  compatible:
+    enum:
+      - aspeed,ast2400-adc
+      - aspeed,ast2500-adc

Documentation/devicetree/bindings/iio/adc/aspeed,ast2400-adc.yaml new file +24 -0

+
+  "#io-channel-cells":
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - resets
+  - "#io-channel-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/aspeed-clock.h>
+    adc@1e6e9000 {
+        compatible = "aspeed,ast2400-adc";
+        reg = <0x1e6e9000 0xb0>;
+        clocks = <&syscon ASPEED_CLK_APB>;
+        resets = <&syscon ASPEED_RESET_ADC>;
+        #io-channel-cells = <1>;
+    };
+...

Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt deleted +0 -22

deleted file mode 100644
index 034fc2ba100e..000000000000
@@ -1,22 +0,0 @@
-Aspeed ADC
-
-This device is a 10-bit converter for 16 voltage channels.  All inputs are
-single ended.
-
-Required properties:
-- compatible: Should be "aspeed,ast2400-adc" or "aspeed,ast2500-adc"
-- reg: memory window mapping address and length
-- clocks: Input clock used to derive the sample clock. Expected to be the
-          SoC's APB clock.
-- resets: Reset controller phandle
-- #io-channel-cells: Must be set to <1> to indicate channels are selected
-                     by index.
-
-Example:
-	adc@1e6e9000 {
-		compatible = "aspeed,ast2400-adc";
-		reg = <0x1e6e9000 0xb0>;
-		clocks = <&syscon ASPEED_CLK_APB>;
-		resets = <&syscon ASPEED_RESET_ADC>;
-		#io-channel-cells = <1>;
-	};

Signature · 1 line

2.28.0

From: Jonathan Cameron <[email protected]>

Part of a general move of IIO bindings over to yaml.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Antoine Tenart <[email protected]>

---
 .../bindings/iio/adc/berlin2_adc.txt          | 19 -------
 .../bindings/iio/adc/marvell,berlin2-adc.yaml | 50 +++++++++++++++++++
 2 files changed, 50 insertions(+), 19 deletions(-)

Quoted 11 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Part of a general move of IIO bindings over to yaml.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Antoine Tenart <[email protected]>

---
 .../bindings/iio/adc/berlin2_adc.txt          | 19 -------
 .../bindings/iio/adc/marvell,berlin2-adc.yaml | 50 +++++++++++++++++++
 2 files changed, 50 insertions(+), 19 deletions(-)

Reviewed-by Rob Herring <[email protected]>

From: Jonathan Cameron <[email protected]>

I changed the name to reflect a specific part in line with normal naming conventions. If there is a particularly strong reason to keep the wild cards let me know.

Otherwise this was a fairly simple conversion as part of converting all the IIO bindings to yaml.

Signed-off-by Jonathan Cameron <[email protected]>

Acked-by Orson Zhai <[email protected]>

Cc Baolin Wang <[email protected]>

Cc Chunyan Zhang <[email protected]>

---
 .../bindings/iio/adc/sprd,sc2720-adc.yaml     | 72 +++++++++++++++++++
 .../bindings/iio/adc/sprd,sc27xx-adc.txt      | 40 -----------
 2 files changed, 72 insertions(+), 40 deletions(-)

Quoted 9 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

I changed the name to reflect a specific part in line with normal naming conventions. If there is a particularly strong reason to keep the wild cards let me know.

Otherwise this was a fairly simple conversion as part of converting all the IIO bindings to yaml.

Quoted 9 lines

Signed-off-by Jonathan Cameron <[email protected]>

Acked-by Orson Zhai <[email protected]>

Cc Baolin Wang <[email protected]>

Cc Chunyan Zhang <[email protected]>

---
 .../bindings/iio/adc/sprd,sc2720-adc.yaml     | 72 +++++++++++++++++++
 .../bindings/iio/adc/sprd,sc27xx-adc.txt      | 40 -----------
 2 files changed, 72 insertions(+), 40 deletions(-)

Reviewed-by Rob Herring <[email protected]>

From: Jonathan Cameron <[email protected]>

A simple conversion from txt file to yaml. I added the #io-channel-cells property as optional to allow the channels of this ADCs to be used to provide services to other drivers, for example if an analog accelerometer is connected.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Alexandre Belloni <[email protected]>

Cc Maxime Ripard <[email protected]>

---
 .../bindings/iio/adc/nuvoton,nau7802.yaml     | 50 +++++++++++++++++++
 .../bindings/iio/adc/nuvoton-nau7802.txt      | 18 -------
 2 files changed, 50 insertions(+), 18 deletions(-)

Documentation/devicetree/bindings/iio/adc/nuvoton,nau7802.yaml new file +2 -0

new file mode 100644
index 000000000000..bcd041ea28a8
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2

Documentation/devicetree/bindings/iio/adc/nuvoton,nau7802.yaml new file +38 -0

+properties:
+  compatible:
+    const: nuvoton,nau7802
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  nuvoton,vldo:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Internal reference voltage in millivolts to be configured.
+    minimum: 2400
+    maximum: 4500
+
+  "#io-channel-cells":
+    const: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        nau7802@2a {
+            compatible = "nuvoton,nau7802";
+            reg = <0x2a>;
+            nuvoton,vldo = <3000>;
+        };
+    };
+...

Documentation/devicetree/bindings/iio/adc/nuvoton-nau7802.txt deleted +0 -18

deleted file mode 100644
index e9582e6fe350..000000000000
@@ -1,18 +0,0 @@
-* Nuvoton NAU7802 Analog to Digital Converter (ADC)
-
-Required properties:
-  - compatible: Should be "nuvoton,nau7802"
-  - reg: Should contain the ADC I2C address
-
-Optional properties:
-  - nuvoton,vldo: Internal reference voltage in millivolts to be
-    configured valid values are between 2400 mV and 4500 mV.
-  - interrupts: IRQ line for the ADC. If not used the driver will use
-    polling.
-
-Example:
-adc2: nau7802@2a {
-	compatible = "nuvoton,nau7802";
-	reg = <0x2a>;
-	nuvoton,vldo = <3000>;
-};

Signature · 1 line

2.28.0

Hi,

Quoted 23 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

A simple conversion from txt file to yaml. I added the #io-channel-cells property as optional to allow the channels of this ADCs to be used to provide services to other drivers, for example if an analog accelerometer is connected.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Alexandre Belloni <[email protected]>

Cc Maxime Ripard <[email protected]>

---
 .../bindings/iio/adc/nuvoton,nau7802.yaml     | 50 +++++++++++++++++++
 .../bindings/iio/adc/nuvoton-nau7802.txt      | 18 -------
 2 files changed, 50 insertions(+), 18 deletions(-)

Documentation/devicetree/bindings/iio/adc/nuvoton,nau7802.yaml new file +2 -0

new file mode 100644
index 000000000000..bcd041ea28a8
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2

Documentation/devicetree/bindings/iio/adc/nuvoton,nau7802.yaml line 12

Quoted 10 lines

Documentation/devicetree/bindings/iio/adc/nuvoton,nau7802.yaml new file +10 -0

+---
+$id: http://devicetree.org/schemas/iio/adc/nuvoton,nau7802.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Nuvoton NAU7802 I2c Analog to Digital Converter (ADC)
+
+maintainers:
+  - Alexandre Belloni <[email protected]>
+  - Maxime Ripard <[email protected]>
+  

Sorry, I meant to reply earlier. Can you make that:

- Alexandre Belloni <[email protected]>
- Maxime Ripard <[email protected]>

Else, this seems good to me!

Quoted 66 lines

Documentation/devicetree/bindings/iio/adc/nuvoton,nau7802.yaml new file +38 -0

+properties:
+  compatible:
+    const: nuvoton,nau7802
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  nuvoton,vldo:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Internal reference voltage in millivolts to be configured.
+    minimum: 2400
+    maximum: 4500
+
+  "#io-channel-cells":
+    const: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        nau7802@2a {
+            compatible = "nuvoton,nau7802";
+            reg = <0x2a>;
+            nuvoton,vldo = <3000>;
+        };
+    };
+...

Documentation/devicetree/bindings/iio/adc/nuvoton-nau7802.txt deleted +0 -18

deleted file mode 100644
index e9582e6fe350..000000000000
@@ -1,18 +0,0 @@
-* Nuvoton NAU7802 Analog to Digital Converter (ADC)
-
-Required properties:
-  - compatible: Should be "nuvoton,nau7802"
-  - reg: Should contain the ADC I2C address
-
-Optional properties:
-  - nuvoton,vldo: Internal reference voltage in millivolts to be
-    configured valid values are between 2400 mV and 4500 mV.
-  - interrupts: IRQ line for the ADC. If not used the driver will use
-    polling.
-
-Example:
-adc2: nau7802@2a {
-	compatible = "nuvoton,nau7802";
-	reg = <0x2a>;
-	nuvoton,vldo = <3000>;
-};

Signature · 1 line

2.28.0

From: Jonathan Cameron <[email protected]>

A simple conversion from txt file to yaml. I added the #io-channel-cells property as optional to allow the channels of this ADCs to be used to provide services to other drivers, for example if an analog accelerometer is connected.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Alexandre Belloni <[email protected]>

Cc Maxime Ripard <[email protected]>

---
 .../bindings/iio/adc/nuvoton,nau7802.yaml     | 50 +++++++++++++++++++
 .../bindings/iio/adc/nuvoton-nau7802.txt      | 18 -------
 2 files changed, 50 insertions(+), 18 deletions(-)

Quoted 7 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

A simple conversion from txt file to yaml. I added the #io-channel-cells property as optional to allow the channels of this ADCs to be used to provide services to other drivers, for example if an analog accelerometer is connected.

Quoted 8 lines

Signed-off-by Jonathan Cameron <[email protected]>

Cc Alexandre Belloni <[email protected]>

Cc Maxime Ripard <[email protected]>

---
 .../bindings/iio/adc/nuvoton,nau7802.yaml     | 50 +++++++++++++++++++
 .../bindings/iio/adc/nuvoton-nau7802.txt      | 18 -------
 2 files changed, 50 insertions(+), 18 deletions(-)

Reviewed-by Rob Herring <[email protected]>

From: Jonathan Cameron <[email protected]>

Renamed the file to reflect the only compatible.
Added #io-channel-cells to make it easier to support consumers of the ADC channels this device provides.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Tomer Maimon <[email protected]>

---
 .../bindings/iio/adc/nuvoton,npcm-adc.txt     | 26 --------
 .../bindings/iio/adc/nuvoton,npcm750-adc.yaml | 64 +++++++++++++++++++
 2 files changed, 64 insertions(+), 26 deletions(-)

Quoted 6 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Renamed the file to reflect the only compatible.
Added #io-channel-cells to make it easier to support consumers of the ADC channels this device provides.

Quoted 7 lines

Signed-off-by Jonathan Cameron <[email protected]>

Cc Tomer Maimon <[email protected]>

---
 .../bindings/iio/adc/nuvoton,npcm-adc.txt     | 26 --------
 .../bindings/iio/adc/nuvoton,npcm750-adc.yaml | 64 +++++++++++++++++++
 2 files changed, 64 insertions(+), 26 deletions(-)

Reviewed-by Rob Herring <[email protected]>

From: Jonathan Cameron <[email protected]>

Most of the description in the original doc is effectively boilerplate and does not bring much value so I have not carried it over into the yaml.

Added #io-channel-cells to simplify use of channels on this ADC by consumer drivers.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Joachim Eastwood <[email protected]>

---
 .../bindings/iio/adc/lpc1850-adc.txt          | 20 ------
 .../bindings/iio/adc/nxp,lpc1850-adc.yaml     | 61 +++++++++++++++++++
 2 files changed, 61 insertions(+), 20 deletions(-)

Quoted 8 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Most of the description in the original doc is effectively boilerplate and does not bring much value so I have not carried it over into the yaml.

Added #io-channel-cells to simplify use of channels on this ADC by consumer drivers.

Quoted 7 lines

Signed-off-by Jonathan Cameron <[email protected]>

Cc Joachim Eastwood <[email protected]>

---
 .../bindings/iio/adc/lpc1850-adc.txt          | 20 ------
 .../bindings/iio/adc/nxp,lpc1850-adc.yaml     | 61 +++++++++++++++++++
 2 files changed, 61 insertions(+), 20 deletions(-)

Reviewed-by Rob Herring <[email protected]>

From: Jonathan Cameron <[email protected]>

Renamed to remove the wild cards. These go wrong far too often so in general preferred to use the name of a specific part. As this binding only provides one compatible, I went with that.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Gregory Clement <[email protected]>

---
 .../bindings/iio/adc/lpc32xx-adc.txt          | 21 --------
 .../bindings/iio/adc/nxp,lpc3220-adc.yaml     | 50 +++++++++++++++++++
 2 files changed, 50 insertions(+), 21 deletions(-)

Quoted 6 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Renamed to remove the wild cards. These go wrong far too often so in general preferred to use the name of a specific part. As this binding only provides one compatible, I went with that.

Quoted 7 lines

Signed-off-by Jonathan Cameron <[email protected]>

Cc Gregory Clement <[email protected]>

---
 .../bindings/iio/adc/lpc32xx-adc.txt          | 21 --------
 .../bindings/iio/adc/nxp,lpc3220-adc.yaml     | 50 +++++++++++++++++++
 2 files changed, 50 insertions(+), 21 deletions(-)

Reviewed-by Rob Herring <[email protected]>

From: Jonathan Cameron <[email protected]>

Conversion from txt to yaml.
Slightly expanded example to give a bit more context. Description lifted from the original driver commit.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Tony Lindgren <[email protected]>

---
 .../devicetree/bindings/iio/adc/cpcap-adc.txt | 17 -------
 .../bindings/iio/adc/motorola,cpcap-adc.yaml  | 51 +++++++++++++++++++
 2 files changed, 51 insertions(+), 17 deletions(-)

Documentation/devicetree/bindings/iio/adc/cpcap-adc.txt deleted +0 -17

deleted file mode 100644
index ec04008e8f4f..000000000000
@@ -1,17 +0,0 @@
-Motorola CPCAP PMIC ADC binding
-
-Required properties:
-- compatible: Should be "motorola,cpcap-adc" or "motorola,mapphone-cpcap-adc"
-- interrupts: The interrupt number for the ADC device
-- interrupt-names: Should be "adcdone"
-- #io-channel-cells: Number of cells in an IIO specifier
-
-Example:
-
-cpcap_adc: adc {
-	compatible = "motorola,mapphone-cpcap-adc";
-	interrupt-parent = <&cpcap>;
-	interrupts = <8 IRQ_TYPE_NONE>;
-	interrupt-names = "adcdone";
-	#io-channel-cells = <1>;
-};

Documentation/devicetree/bindings/iio/adc/motorola,cpcap-adc.yaml new file +25 -0

new file mode 100644
index 000000000000..7811c0abd5d0
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/motorola,cpcap-adc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Motorola CPCAP PMIC ADC binding
+
+maintainers:
+  - Tony Lindgren <[email protected]>
+
+description:
+  On Motorola phones like droid 4 there is a custom CPCAP PMIC. This PMIC
+  has ADCs that are used for battery charging and USB PHY VBUS and ID pin
+  detection.
+
+properties:
+  compatible:
+    enum:
+      - motorola,cpcap-adc
+      - motorola,mapphone-cpcap-adc
+
+  interrupts:
+    maxItems: 1
+

Quoted 71 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Conversion from txt to yaml.
Slightly expanded example to give a bit more context. Description lifted from the original driver commit.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Tony Lindgren <[email protected]>

---
 .../devicetree/bindings/iio/adc/cpcap-adc.txt | 17 -------
 .../bindings/iio/adc/motorola,cpcap-adc.yaml  | 51 +++++++++++++++++++
 2 files changed, 51 insertions(+), 17 deletions(-)

Documentation/devicetree/bindings/iio/adc/cpcap-adc.txt deleted +0 -17

deleted file mode 100644
index ec04008e8f4f..000000000000
@@ -1,17 +0,0 @@
-Motorola CPCAP PMIC ADC binding
-
-Required properties:
-- compatible: Should be "motorola,cpcap-adc" or "motorola,mapphone-cpcap-adc"
-- interrupts: The interrupt number for the ADC device
-- interrupt-names: Should be "adcdone"
-- #io-channel-cells: Number of cells in an IIO specifier
-
-Example:
-
-cpcap_adc: adc {
-	compatible = "motorola,mapphone-cpcap-adc";
-	interrupt-parent = <&cpcap>;
-	interrupts = <8 IRQ_TYPE_NONE>;
-	interrupt-names = "adcdone";
-	#io-channel-cells = <1>;
-};

Documentation/devicetree/bindings/iio/adc/motorola,cpcap-adc.yaml new file +29 -0

new file mode 100644
index 000000000000..7811c0abd5d0
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/motorola,cpcap-adc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Motorola CPCAP PMIC ADC binding
+
+maintainers:
+  - Tony Lindgren <[email protected]>
+
+description:
+  On Motorola phones like droid 4 there is a custom CPCAP PMIC. This PMIC
+  has ADCs that are used for battery charging and USB PHY VBUS and ID pin
+  detection.
+
+properties:
+  compatible:
+    enum:
+      - motorola,cpcap-adc
+      - motorola,mapphone-cpcap-adc
+
+  interrupts:
+    maxItems: 1
+
+  interrupt-names:
+    const: adcdone
+
+  "#io-channel-cells":

Documentation/devicetree/bindings/iio/adc/motorola,cpcap-adc.yaml line 35

Quoted 6 lines

Documentation/devicetree/bindings/iio/adc/motorola,cpcap-adc.yaml new file +6 -0

+    const: 1
+
+required:
+  - compatible
+  - interrupts
+  - "#io-channel-cells"  

additionalProperties: false

With that,

Reviewed-by Rob Herring <[email protected]>

From: Jonathan Cameron <[email protected]>

This is a small part of an MFD so perhaps ultimately it makes more sense to document it with that MFD binding rather than separately.

In the meantime it's a straightforward conversion from txt to yaml.

Signed-off-by Jonathan Cameron <[email protected]>

Acked-by Adam Thomson <[email protected]>

---
 .../bindings/iio/adc/da9150-gpadc.txt         | 16 ---------
 .../bindings/iio/adc/dlg,da9150-gpadc.yaml    | 33 +++++++++++++++++++
 2 files changed, 33 insertions(+), 16 deletions(-)

Documentation/devicetree/bindings/iio/adc/da9150-gpadc.txt deleted +0 -16

deleted file mode 100644
index c07228da92ac..000000000000
@@ -1,16 +0,0 @@
-Dialog Semiconductor DA9150 IIO GPADC bindings
-
-Required properties:
-- compatible: "dlg,da9150-gpadc" for DA9150 IIO GPADC
-- #io-channel-cells: Should be set to <1>
-  (See Documentation/devicetree/bindings/iio/iio-bindings.txt for further info)
-
-For further information on GPADC channels, see device datasheet.
-
-
-Example:
-
-	gpadc: da9150-gpadc {
-		compatible = "dlg,da9150-gpadc";
-		#io-channel-cells = <1>;
-	};

Documentation/devicetree/bindings/iio/adc/dlg,da9150-gpadc.yaml new file +15 -0

new file mode 100644
index 000000000000..15c51d337108
@@ -0,0 +1,33 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/dlg,da9150-gpadc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Dialog Semiconductor DA9150 IIO GPADC
+
+maintainers:
+  - Adam Thomson <[email protected]>
+
+description:
+  This patch adds support for general purpose ADC within the
+  DA9150 Charger & Fuel-Gauge IC.
+

Documentation/devicetree/bindings/iio/adc/dlg,da9150-gpadc.yaml new file +8 -0

+
+examples:
+  - |
+    adc {
+        compatible = "dlg,da9150-gpadc";
+        #io-channel-cells = <1>;
+    };
+...

Signature · 1 line

2.28.0

Quoted 61 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

This is a small part of an MFD so perhaps ultimately it makes more sense to document it with that MFD binding rather than separately.

In the meantime it's a straightforward conversion from txt to yaml.

Signed-off-by Jonathan Cameron <[email protected]>

Acked-by Adam Thomson <[email protected]>

---
 .../bindings/iio/adc/da9150-gpadc.txt         | 16 ---------
 .../bindings/iio/adc/dlg,da9150-gpadc.yaml    | 33 +++++++++++++++++++
 2 files changed, 33 insertions(+), 16 deletions(-)

Documentation/devicetree/bindings/iio/adc/da9150-gpadc.txt deleted +0 -16

deleted file mode 100644
index c07228da92ac..000000000000
@@ -1,16 +0,0 @@
-Dialog Semiconductor DA9150 IIO GPADC bindings
-
-Required properties:
-- compatible: "dlg,da9150-gpadc" for DA9150 IIO GPADC
-- #io-channel-cells: Should be set to <1>
-  (See Documentation/devicetree/bindings/iio/iio-bindings.txt for further info)
-
-For further information on GPADC channels, see device datasheet.
-
-
-Example:
-
-	gpadc: da9150-gpadc {
-		compatible = "dlg,da9150-gpadc";
-		#io-channel-cells = <1>;
-	};

Documentation/devicetree/bindings/iio/adc/dlg,da9150-gpadc.yaml new file +19 -0

new file mode 100644
index 000000000000..15c51d337108
@@ -0,0 +1,33 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/dlg,da9150-gpadc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Dialog Semiconductor DA9150 IIO GPADC
+
+maintainers:
+  - Adam Thomson <[email protected]>
+
+description:
+  This patch adds support for general purpose ADC within the
+  DA9150 Charger & Fuel-Gauge IC.
+
+properties:
+  compatible:
+    const: dlg,da9150-gpadc
+

Documentation/devicetree/bindings/iio/adc/dlg,da9150-gpadc.yaml line 25

Quoted 6 lines

Documentation/devicetree/bindings/iio/adc/dlg,da9150-gpadc.yaml new file +6 -0

+  "#io-channel-cells":
+    const: 1
+
+required:
+  - compatible
+  - "#io-channel-cells"  

additionalProperties...

With that,

Reviewed-by Rob Herring <[email protected]>

Quoted 12 lines

Documentation/devicetree/bindings/iio/adc/dlg,da9150-gpadc.yaml new file +8 -0

+
+examples:
+  - |
+    adc {
+        compatible = "dlg,da9150-gpadc";
+        #io-channel-cells = <1>;
+    };
+...

Signature · 1 line

2.28.0

From: Jonathan Cameron <[email protected]>

I don't really know much about this one, hence the binding is a simple conversion of what was in the txt file.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Phani Movva <[email protected]>

---
 .../bindings/iio/adc/cc10001_adc.txt          | 22 -------
 .../bindings/iio/adc/cosmic,10001-adc.yaml    | 59 +++++++++++++++++++
 2 files changed, 59 insertions(+), 22 deletions(-)

Quoted 5 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

I don't really know much about this one, hence the binding is a simple conversion of what was in the txt file.

Quoted 7 lines

Signed-off-by Jonathan Cameron <[email protected]>

Cc Phani Movva <[email protected]>

---
 .../bindings/iio/adc/cc10001_adc.txt          | 22 -------
 .../bindings/iio/adc/cosmic,10001-adc.yaml    | 59 +++++++++++++++++++
 2 files changed, 59 insertions(+), 22 deletions(-)

Reviewed-by Rob Herring <[email protected]>

From: Jonathan Cameron <[email protected]>

Simple SPI driver. I've added the #io-channel-cells
as an optional parameter to allow use of this device as a provider of ADC capabilities to other devices.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Charles-Antoine Couret <[email protected]>

---
 .../devicetree/bindings/iio/adc/ad7949.txt    | 16 ------
 .../bindings/iio/adc/adi,ad7949.yaml          | 57 +++++++++++++++++++
 2 files changed, 57 insertions(+), 16 deletions(-)

Quoted 6 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Simple SPI driver. I've added the #io-channel-cells
as an optional parameter to allow use of this device as a provider of ADC capabilities to other devices.

Quoted 7 lines

Signed-off-by Jonathan Cameron <[email protected]>

Cc Charles-Antoine Couret <[email protected]>

---
 .../devicetree/bindings/iio/adc/ad7949.txt    | 16 ------
 .../bindings/iio/adc/adi,ad7949.yaml          | 57 +++++++++++++++++++
 2 files changed, 57 insertions(+), 16 deletions(-)

Reviewed-by Rob Herring <[email protected]>

From: Jonathan Cameron <[email protected]>

Fairly straight conversion. The one oddity in the original binding is that spi-cpha and spi-cpol were not marked as required, but were in the example. Looking at the datasheet, there isn't any documented flexibility in the possible SPI modes, so I have moved these to requires. For spi-max-frequency I have gone the other way. I absolutely agree that it is good to specify this in the dt-binding, but it's not strictly required.

As Stefan's email is bouncing I have gone with Michael as maintainer of this one as it falls under the ADI catch all entry in MAINTAINERS.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Michael Hennerich <[email protected]>

---
 .../bindings/iio/adc/adi,ad7768-1.txt         | 41 ---------
 .../bindings/iio/adc/adi,ad7768-1.yaml        | 89 +++++++++++++++++++
 2 files changed, 89 insertions(+), 41 deletions(-)

Quoted 13 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Fairly straight conversion. The one oddity in the original binding is that spi-cpha and spi-cpol were not marked as required, but were in the example. Looking at the datasheet, there isn't any documented flexibility in the possible SPI modes, so I have moved these to requires. For spi-max-frequency I have gone the other way. I absolutely agree that it is good to specify this in the dt-binding, but it's not strictly required.

As Stefan's email is bouncing I have gone with Michael as maintainer of this one as it falls under the ADI catch all entry in MAINTAINERS.

Quoted 7 lines

Signed-off-by Jonathan Cameron <[email protected]>

Cc Michael Hennerich <[email protected]>

---
 .../bindings/iio/adc/adi,ad7768-1.txt         | 41 ---------
 .../bindings/iio/adc/adi,ad7768-1.yaml        | 89 +++++++++++++++++++
 2 files changed, 89 insertions(+), 41 deletions(-)

Reviewed-by Rob Herring <[email protected]>

From: Jonathan Cameron <[email protected]>

This binding was moved over from hwmon some time ago so is a bit unusual in terms of IIO bindings. However, conversion was fairly straight forwards.

I've listed both Dirk (who think wrote original binding) and Daniel who added the IIO driver for this device.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Dirk Eibach <[email protected]>

Cc Daniel Baluta <[email protected]>

---
 .../devicetree/bindings/iio/adc/ads1015.txt   |  73 -----------
 .../bindings/iio/adc/ti,ads1015.yaml          | 113 ++++++++++++++++++
 2 files changed, 113 insertions(+), 73 deletions(-)

Quoted 9 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

This binding was moved over from hwmon some time ago so is a bit unusual in terms of IIO bindings. However, conversion was fairly straight forwards.

I've listed both Dirk (who think wrote original binding) and Daniel who added the IIO driver for this device.

Quoted 8 lines

Signed-off-by Jonathan Cameron <[email protected]>

Cc Dirk Eibach <[email protected]>

Cc Daniel Baluta <[email protected]>

---
 .../devicetree/bindings/iio/adc/ads1015.txt   |  73 -----------
 .../bindings/iio/adc/ti,ads1015.yaml          | 113 ++++++++++++++++++
 2 files changed, 113 insertions(+), 73 deletions(-)

Reviewed-by Rob Herring <[email protected]>

From: Jonathan Cameron <[email protected]>

Very simple binding. I've changed the example to use the node name threshold-detector@0 as sensor@0 seemed too generic.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Vladimir Barinov <[email protected]>

---
 .../devicetree/bindings/iio/adc/hi8435.txt    | 21 --------
 .../bindings/iio/adc/holt,hi8435.yaml         | 49 +++++++++++++++++++
 2 files changed, 49 insertions(+), 21 deletions(-)

Documentation/devicetree/bindings/iio/adc/hi8435.txt deleted +0 -21

deleted file mode 100644
index 3b0348c5e516..000000000000
@@ -1,21 +0,0 @@
-Holt Integrated Circuits HI-8435 threshold detector bindings
-
-Required properties:
- - compatible: should be "holt,hi8435"
- - reg: spi chip select number for the device
-
-Recommended properties:
- - spi-max-frequency: definition as per
-		Documentation/devicetree/bindings/spi/spi-bus.txt
-
-Optional properties:
- - gpios: GPIO used for controlling the reset pin
-
-Example:
-sensor@0 {
-	compatible = "holt,hi8435";
-	reg = <0>;
-	gpios = <&gpio6 1 0>;
-
-	spi-max-frequency = <1000000>;
-};

Documentation/devicetree/bindings/iio/adc/holt,hi8435.yaml new file +14 -0

new file mode 100644
index 000000000000..a35cf3876b86
@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/holt,hi8435.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Holt Integrated Circuits HI-8435 SPI threshold detector
+
+maintainers:
+  - Vladimir Barinov <[email protected]>
+
+description: |
+  Datasheet: http://www.holtic.com/documents/427-hi-8435_v-rev-lpdf.do
+

Documentation/devicetree/bindings/iio/adc/holt,hi8435.yaml new file +25 -0

+
+  spi-max-frequency: true
+
+  "#io-channel-cells":
+    const: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        threshold-detector@0 {
+            compatible = "holt,hi8435";
+            reg = <0>;
+            gpios = <&gpio6 1 0>;
+            spi-max-frequency = <1000000>;
+        };
+    };
+...

Signature · 1 line

2.28.0

Quoted 63 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

Very simple binding. I've changed the example to use the node name threshold-detector@0 as sensor@0 seemed too generic.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Vladimir Barinov <[email protected]>

---
 .../devicetree/bindings/iio/adc/hi8435.txt    | 21 --------
 .../bindings/iio/adc/holt,hi8435.yaml         | 49 +++++++++++++++++++
 2 files changed, 49 insertions(+), 21 deletions(-)

Documentation/devicetree/bindings/iio/adc/hi8435.txt deleted +0 -21

deleted file mode 100644
index 3b0348c5e516..000000000000
@@ -1,21 +0,0 @@
-Holt Integrated Circuits HI-8435 threshold detector bindings
-
-Required properties:
- - compatible: should be "holt,hi8435"
- - reg: spi chip select number for the device
-
-Recommended properties:
- - spi-max-frequency: definition as per
-		Documentation/devicetree/bindings/spi/spi-bus.txt
-
-Optional properties:
- - gpios: GPIO used for controlling the reset pin
-
-Example:
-sensor@0 {
-	compatible = "holt,hi8435";
-	reg = <0>;
-	gpios = <&gpio6 1 0>;
-
-	spi-max-frequency = <1000000>;
-};

Documentation/devicetree/bindings/iio/adc/holt,hi8435.yaml new file +18 -0

new file mode 100644
index 000000000000..a35cf3876b86
@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/holt,hi8435.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Holt Integrated Circuits HI-8435 SPI threshold detector
+
+maintainers:
+  - Vladimir Barinov <[email protected]>
+
+description: |
+  Datasheet: http://www.holtic.com/documents/427-hi-8435_v-rev-lpdf.do
+
+properties:
+  compatible:
+    const: holt,hi8435
+

Documentation/devicetree/bindings/iio/adc/holt,hi8435.yaml line 24

Quoted 6 lines

Documentation/devicetree/bindings/iio/adc/holt,hi8435.yaml new file +6 -0

+  reg:
+    maxItems: 1
+
+  gpios:
+    description:
+       GPIO used for controlling the reset pin  

maxItems: 1

With that,

Reviewed-by Rob Herring <[email protected]>

Quoted 29 lines

Documentation/devicetree/bindings/iio/adc/holt,hi8435.yaml new file +25 -0

+
+  spi-max-frequency: true
+
+  "#io-channel-cells":
+    const: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        threshold-detector@0 {
+            compatible = "holt,hi8435";
+            reg = <0>;
+            gpios = <&gpio6 1 0>;
+            spi-max-frequency = <1000000>;
+        };
+    };
+...

Signature · 1 line

2.28.0

From: Jonathan Cameron <[email protected]>

This binding is non trivial due to the range of different parts supported having several subtle quirks. Martin has helped clarify some of them.

Note, I haven't restricted the amlogic,hhi-sysctrl to only be present on the relevant parts if nvmem stuff also is, but it would seem to be rather odd if it were otherwise.

Perhaps we look to make this binding more restrictive at a later date.

Signed-off-by Jonathan Cameron <[email protected]>

Cc Martin Blumenstingl <[email protected]>

Cc Kevin Hilman <[email protected]>

Cc Neil Armstrong <[email protected]>

Cc Jerome Brunet <[email protected]>

---
 .../bindings/iio/adc/amlogic,meson-saradc.txt |  48 ------
 .../iio/adc/amlogic,meson-saradc.yaml         | 149 ++++++++++++++++++
 2 files changed, 149 insertions(+), 48 deletions(-)

Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.txt deleted +0 -48

deleted file mode 100644
index d57e9df25f4f..000000000000
@@ -1,48 +0,0 @@
-* Amlogic Meson SAR (Successive Approximation Register) A/D converter
-
-Required properties:
-- compatible:	depending on the SoC this should be one of:
-			- "amlogic,meson8-saradc" for Meson8
-			- "amlogic,meson8b-saradc" for Meson8b
-			- "amlogic,meson8m2-saradc" for Meson8m2
-			- "amlogic,meson-gxbb-saradc" for GXBB
-			- "amlogic,meson-gxl-saradc" for GXL
-			- "amlogic,meson-gxm-saradc" for GXM
-			- "amlogic,meson-axg-saradc" for AXG
-			- "amlogic,meson-g12a-saradc" for AXG
-		along with the generic "amlogic,meson-saradc"
-- reg:		the physical base address and length of the registers
-- interrupts:	the interrupt indicating end of sampling
-- clocks:	phandle and clock identifier (see clock-names)
-- clock-names:	mandatory clocks:
-			- "clkin" for the reference clock (typically XTAL)
-			- "core" for the SAR ADC core clock
-		optional clocks:
-			- "adc_clk" for the ADC (sampling) clock
-			- "adc_sel" for the ADC (sampling) clock mux
-- vref-supply:	the regulator supply for the ADC reference voltage
-- #io-channel-cells: must be 1, see ../iio-bindings.txt
-
-Optional properties:
-- amlogic,hhi-sysctrl:	phandle to the syscon which contains the 5th bit
-			of the TSC (temperature sensor coefficient) on
-			Meson8b and Meson8m2 (which used to calibrate the
-			temperature sensor)
-- nvmem-cells:		phandle to the temperature_calib eFuse cells
-- nvmem-cell-names:	if present (to enable the temperature sensor
-			calibration) this must contain "temperature_calib"
-
-
-Example:
-	saradc: adc@8680 {
-		compatible = "amlogic,meson-gxl-saradc", "amlogic,meson-saradc";
-		#io-channel-cells = <1>;
-		reg = <0x0 0x8680 0x0 0x34>;
-		interrupts = <GIC_SPI 73 IRQ_TYPE_EDGE_RISING>;
-		clocks = <&xtal>,
-			 <&clkc CLKID_SAR_ADC>,
-			 <&clkc CLKID_SANA>,
-			 <&clkc CLKID_SAR_ADC_CLK>,
-			 <&clkc CLKID_SAR_ADC_SEL>;
-		clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
-	};

Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml new file +30 -0

new file mode 100644
index 000000000000..6d94bf76900e
@@ -0,0 +1,149 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/amlogic,meson-saradc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Amlogic Meson SAR (Successive Approximation Register) A/D converter
+
+maintainers:
+  - Martin Blumenstingl <[email protected]>
+
+description:
+  Binding covers a range of ADCs found on amlogic meson SoCs.
+
+properties:
+  compatible:
+    oneOf:
+      - const: amlogic,meson-saradc
+      - items:
+          - enum:
+              - amlogic,meson8-saradc
+              - amlogic,meson8b-saradc
+              - amlogic,meson8m2-saradc
+              - amlogic,meson-gxbb-saradc
+              - amlogic,meson-gxl-saradc
+              - amlogic,meson-gxm-saradc
+              - amlogic,meson-axg-saradc
+              - amlogic,meson-g12a-saradc
+          - const: amlogic,meson-saradc
+

Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml new file +5 -0

+
+  vref-supply: true
+
+  "#io-channel-cells":
+    const: 1

Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml new file +7 -0

+
+  nvmem-cell-names:
+    const: temperature_calib
+
+allOf:
+  - if:
+      properties:

Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml new file +59 -0

+        clocks:
+          minItems: 4
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - amlogic,meson8b-saradc
+              - amlogic,meson8m2-saradc
+    then:
+      properties:
+        amlogic,hhi-sysctrl: true
+    else:
+      properties:
+        amlogic,hhi-sysctrl: false
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+  - "#io-channel-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/clock/gxbb-clkc.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    soc {
+        #address-cells = <2>;
+        #size-cells = <2>;
+        adc@8680 {
+            compatible = "amlogic,meson-gxl-saradc", "amlogic,meson-saradc";
+            #io-channel-cells = <1>;
+            reg = <0x0 0x8680 0x0 0x34>;
+            interrupts = <GIC_SPI 73 IRQ_TYPE_EDGE_RISING>;
+            clocks = <&xtal>,
+                <&clkc CLKID_SAR_ADC>,
+                <&clkc CLKID_SAR_ADC_CLK>,
+                <&clkc CLKID_SAR_ADC_SEL>;
+            clock-names = "clkin", "core", "adc_clk", "adc_sel";
+        };
+        adc@9680 {
+            compatible = "amlogic,meson8b-saradc", "amlogic,meson-saradc";
+            #io-channel-cells = <1>;
+            reg = <0x0 0x9680 0x0 0x34>;
+            interrupts = <GIC_SPI 73 IRQ_TYPE_EDGE_RISING>;
+            clocks = <&xtal>, <&clkc CLKID_SAR_ADC>;
+            clock-names = "clkin", "core";
+            nvmem-cells = <&tsens_caldata>;
+            nvmem-cell-names = "temperature_calib";
+            amlogic,hhi-sysctrl = <&hhi>;
+        };
+    };
+...

Signature · 1 line

2.28.0

From: Jonathan Cameron <[email protected]>

A nice simple binding. Only real different from txt is that I dropped some descriptions where the naming of the parameter was self explanatory

Signed-off-by Jonathan Cameron <[email protected]>

Cc Haibo Chen <[email protected]>

Cc Shawn Guo <[email protected]>

Cc Sascha Hauer <[email protected]>

---
 .../bindings/iio/adc/fsl,imx7d-adc.yaml       | 62 +++++++++++++++++++
 .../devicetree/bindings/iio/adc/imx7d-adc.txt | 24 -------
 2 files changed, 62 insertions(+), 24 deletions(-)

From: Jonathan Cameron <[email protected]>

A nice simple binding. Only real different from txt is that I dropped some descriptions where the naming of the parameter was self explanatory

Signed-off-by Jonathan Cameron <[email protected]>

Cc Haibo Chen <[email protected]>

Cc Shawn Guo <[email protected]>

Cc Sascha Hauer <[email protected]>

---
 .../bindings/iio/adc/fsl,imx7d-adc.yaml       | 62 +++++++++++++++++++
 .../devicetree/bindings/iio/adc/imx7d-adc.txt | 24 -------
 2 files changed, 62 insertions(+), 24 deletions(-)

Documentation/devicetree/bindings/iio/adc/fsl,imx7d-adc.yaml new file +62 -0

new file mode 100644
index 000000000000..dc5eacb38046
@@ -0,0 +1,62 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/fsl,imx7d-adc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale ADC found on the imx7d SoC
+
+maintainers:
+  - Haibo Chen <[email protected]>
+
+properties:
+  compatible:
+    const: fsl,imx7d-adc
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    const: adc
+
+  vref-supply: true
+
+  "#io-channel-cells":
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+  - vref-supply
+  - "#io-channel-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/clock/imx7d-clock.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    soc {
+        #address-cells = <1>;
+        #size-cells = <1>;
+        adc@30610000 {
+            compatible = "fsl,imx7d-adc";
+            reg = <0x30610000 0x10000>;
+            interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
+            clocks = <&clks IMX7D_ADC_ROOT_CLK>;
+            clock-names = "adc";
+            vref-supply = <&reg_vcc_3v3_mcu>;
+            #io-channel-cells = <1>;
+        };
+    };
+...

Documentation/devicetree/bindings/iio/adc/imx7d-adc.txt deleted +0 -24

deleted file mode 100644
index f1f3a552459b..000000000000
@@ -1,24 +0,0 @@
-Freescale imx7d ADC bindings
-
-The devicetree bindings are for the ADC driver written for
-imx7d SoC.
-
-Required properties:
-- compatible: Should be "fsl,imx7d-adc"
-- reg: Offset and length of the register set for the ADC device
-- interrupts: The interrupt number for the ADC device
-- clocks: The root clock of the ADC controller
-- clock-names: Must contain "adc", matching entry in the clocks property
-- vref-supply: The regulator supply ADC reference voltage
-- #io-channel-cells: Must be 1 as per ../iio-bindings.txt
-
-Example:
-adc1: adc@30610000 {
-	compatible = "fsl,imx7d-adc";
-	reg = <0x30610000 0x10000>;
-	interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
-	clocks = <&clks IMX7D_ADC_ROOT_CLK>;
-	clock-names = "adc";
-	vref-supply = <&reg_vcc_3v3_mcu>;
-	#io-channel-cells = <1>;
-};

Quoted 5 lines · On Wed, 9 Sep 2020 18:59:45 +0100 Jonathan Cameron <[email protected]> wrote:

From: Jonathan Cameron <[email protected]>

A nice simple binding. Only real different from txt is that I dropped some descriptions where the naming of the parameter was self explanatory

Quoted 4 lines

Signed-off-by Jonathan Cameron <[email protected]>

Cc Haibo Chen <[email protected]>

Cc Shawn Guo <[email protected]>

Cc Sascha Hauer <[email protected]>

Update Haibo Chen's email address. I'll also fix it whilst applying the patch if this version goes in!

Thanks,

Jonathan

Quoted 103 lines

---
 .../bindings/iio/adc/fsl,imx7d-adc.yaml       | 62 +++++++++++++++++++
 .../devicetree/bindings/iio/adc/imx7d-adc.txt | 24 -------
 2 files changed, 62 insertions(+), 24 deletions(-)

Documentation/devicetree/bindings/iio/adc/fsl,imx7d-adc.yaml new file +62 -0

new file mode 100644
index 000000000000..dc5eacb38046
@@ -0,0 +1,62 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/fsl,imx7d-adc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale ADC found on the imx7d SoC
+
+maintainers:
+  - Haibo Chen <[email protected]>
+
+properties:
+  compatible:
+    const: fsl,imx7d-adc
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    const: adc
+
+  vref-supply: true
+
+  "#io-channel-cells":
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+  - vref-supply
+  - "#io-channel-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/clock/imx7d-clock.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    soc {
+        #address-cells = <1>;
+        #size-cells = <1>;
+        adc@30610000 {
+            compatible = "fsl,imx7d-adc";
+            reg = <0x30610000 0x10000>;
+            interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
+            clocks = <&clks IMX7D_ADC_ROOT_CLK>;
+            clock-names = "adc";
+            vref-supply = <&reg_vcc_3v3_mcu>;
+            #io-channel-cells = <1>;
+        };
+    };
+...

Documentation/devicetree/bindings/iio/adc/imx7d-adc.txt deleted +0 -24

deleted file mode 100644
index f1f3a552459b..000000000000
@@ -1,24 +0,0 @@
-Freescale imx7d ADC bindings
-
-The devicetree bindings are for the ADC driver written for
-imx7d SoC.
-
-Required properties:
-- compatible: Should be "fsl,imx7d-adc"
-- reg: Offset and length of the register set for the ADC device
-- interrupts: The interrupt number for the ADC device
-- clocks: The root clock of the ADC controller
-- clock-names: Must contain "adc", matching entry in the clocks property
-- vref-supply: The regulator supply ADC reference voltage
-- #io-channel-cells: Must be 1 as per ../iio-bindings.txt
-
-Example:
-adc1: adc@30610000 {
-	compatible = "fsl,imx7d-adc";
-	reg = <0x30610000 0x10000>;
-	interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
-	clocks = <&clks IMX7D_ADC_ROOT_CLK>;
-	clock-names = "adc";
-	vref-supply = <&reg_vcc_3v3_mcu>;
-	#io-channel-cells = <1>;
-};  

From: Jonathan Cameron <[email protected]>

This binding has a few corners that would have been done different today but hopefully the yaml schema captures the constraints correctly.

The child node names are not constrained hence the fairly open regexp. I've also documented the defaults for the two references that the driver seems to use and copied the value descriptions from the header because I think they should be in the dt-binding itself.

This is part of a general effort to convert all the IIO bindings over to yaml

Signed-off-by Jonathan Cameron <[email protected]>

Cc Markus Pargmann <[email protected]>

Cc Shawn Guo <[email protected]>

Cc Sascha Hauer <[email protected]>

---
 .../bindings/iio/adc/fsl,imx25-gcq.txt        |  57 --------
 .../bindings/iio/adc/fsl,imx25-gcq.yaml       | 129 ++++++++++++++++++
 2 files changed, 129 insertions(+), 57 deletions(-)

Documentation/devicetree/bindings/iio/adc/fsl,imx25-gcq.txt deleted +0 -57

deleted file mode 100644
index eebdcec3dab5..000000000000
@@ -1,57 +0,0 @@
-Freescale i.MX25 ADC GCQ device
-
-This is a generic conversion queue device that can convert any of the
-analog inputs using the ADC unit of the i.MX25.
-
-Required properties:
- - compatible: Should be "fsl,imx25-gcq".
- - reg: Should be the register range of the module.
- - interrupts: Should be the interrupt number of the module.
-   Typically this is <1>.
- - #address-cells: Should be <1> (setting for the subnodes)
- - #size-cells: Should be <0> (setting for the subnodes)
-
-Optional properties:
- - vref-ext-supply: The regulator supplying the ADC reference voltage.
-   Required when at least one subnode uses the this reference.
- - vref-xp-supply: The regulator supplying the ADC reference voltage on pin XP.
-   Required when at least one subnode uses this reference.
- - vref-yp-supply: The regulator supplying the ADC reference voltage on pin YP.
-   Required when at least one subnode uses this reference.
-
-Sub-nodes:
-Optionally you can define subnodes which define the reference voltage
-for the analog inputs.
-
-Required properties for subnodes:
- - reg: Should be the number of the analog input.
-     0: xp
-     1: yp
-     2: xn
-     3: yn
-     4: wiper
-     5: inaux0
-     6: inaux1
-     7: inaux2
-Optional properties for subnodes:
- - fsl,adc-refp: specifies the positive reference input as defined in
-     <dt-bindings/iio/adc/fsl-imx25-gcq.h>
- - fsl,adc-refn: specifies the negative reference input as defined in
-     <dt-bindings/iio/adc/fsl-imx25-gcq.h>
-
-Example:
-
-	adc: adc@50030800 {
-		compatible = "fsl,imx25-gcq";
-		reg = <0x50030800 0x60>;
-		interrupt-parent = <&tscadc>;
-		interrupts = <1>;
-		#address-cells = <1>;
-		#size-cells = <0>;
-
-		inaux@5 {
-			reg = <5>;
-			fsl,adc-refp = <MX25_ADC_REFP_INT>;
-			fsl,adc-refn = <MX25_ADC_REFN_NGND>;
-		};
-	};

Documentation/devicetree/bindings/iio/adc/fsl,imx25-gcq.yaml new file +94 -0

new file mode 100644
index 000000000000..6c4e3ef0862c
@@ -0,0 +1,129 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/fsl,imx25-gcq.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Freescale ADC GCQ device
+
+description:
+  This is a generic conversion queue device that can convert any of the
+  analog inputs using the ADC unit of the i.MX25.
+
+maintainers:
+  - Markus Pargmann <[email protected]>
+
+properties:
+  compatible:
+    const: fsl,imx25-gcq
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  vref-ext-supply:
+    description:
+      The regulator supplying the ADC reference voltage.
+      Required when at least one subnode uses the this reference.
+
+  vref-xp-supply:
+    description:
+      The regulator supplying the ADC reference voltage on pin XP.
+      Required when at least one subnode uses this reference.
+
+  vref-yp-supply:
+    description:
+      The regulator supplying the ADC reference voltage on pin YP.
+      Required when at least one subnode uses this reference.
+
+  "#io-channel-cells":
+    const: 1
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 0
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - "#address-cells"
+  - "#size-cells"
+
+patternProperties:
+  "[a-z][a-z0-9]+@[0-9a-f]+$":
+    type: object
+    description:
+      Child nodes used to define the reference voltages used for each channel
+
+    properties:
+      reg:
+        description: |
+          Number of the analog input.
+          0: xp
+          1: yp
+          2: xn
+          3: yn
+          4: wiper
+          5: inaux0
+          6: inaux1
+          7: inaux2
+        items:
+          - minimum: 0
+            maximum: 7
+
+      fsl,adc-refp:
+        $ref: /schemas/types.yaml#/definitions/uint32
+        description: |
+          Specifies the positive reference input as defined in
+          <dt-bindings/iio/adc/fsl-imx25-gcq.h>
+          0: YP voltage reference
+          1: XP voltage reference
+          2: External voltage reference
+          3: Internal voltage reference (default)
+        minimum: 0
+        maximum: 3
+
+      fsl,adc-refn:
+        $ref: /schemas/types.yaml#/definitions/uint32
+        description: |
+          Specifies the negative reference input as defined in