Skip to contentSkip to conversation

libs: Add linking dependencies to libcopperplate and libsmokey

PATCH Applied Vitaly Chikunov 3 participants 5 messages Sep 14, 2020 – Sep 15, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libs: Add linking dependencies to libcopperplate and libsmokey

ALT rpmbuild QA script detects that libsmokey and libcopperplate is improperly linked (when built for Mercury core).

Excerpt from the error message:
verify-elf: ERROR: ./usr/lib64/libsmokey.so.0.0.0: undefined symbol: get_mem_size
verify-elf: ERROR: ./usr/lib64/libcopperplate.so.0.0.0: undefined symbol: get_mem_size

---
 lib/copperplate/Makefile.am | 3 ++-
 lib/smokey/Makefile.am      | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)
lib/copperplate/Makefile.am +2 -1
index f832d1c89..c7104eb02 100644
@@ -2,7 +2,8 @@
 lib_LTLIBRARIES = libcopperplate.la
 
 libcopperplate_la_LDFLAGS = @XENO_LIB_LDFLAGS@ -lpthread -lrt -version-info 0:0:0
-libcopperplate_la_LIBADD =
+libcopperplate_la_LIBADD = @XENO_CORE_LDADD@
+
 noinst_LTLIBRARIES =
 
 libcopperplate_la_SOURCES =	\
lib/smokey/Makefile.am +1 -0
index 53c775c68..4ecae1f16 100644
@@ -1,6 +1,7 @@
 lib_LTLIBRARIES = libsmokey.la
 
 libsmokey_la_LDFLAGS = @XENO_LIB_LDFLAGS@ -version-info 0:0:0
+libsmokey_la_LIBADD = @XENO_CORE_LDADD@
 
 libsmokey_la_SOURCES =	\
 	helpers.c	\
Signature · 1 line
2.21.0
Applied
#1 lore raw
Quoted 7 lines · Vitaly Chikunov

ALT rpmbuild QA script detects that libsmokey and libcopperplate is improperly linked (when built for Mercury core).

Excerpt from the error message:
verify-elf: ERROR: ./usr/lib64/libsmokey.so.0.0.0: undefined symbol: get_mem_size
verify-elf: ERROR: ./usr/lib64/libcopperplate.so.0.0.0: undefined symbol: get_mem_size

Could such a test be added to our regular build, or is it depending on rpm or altlinux?

Quoted 26 lines
---
  lib/copperplate/Makefile.am | 3 ++-
  lib/smokey/Makefile.am      | 1 +
  2 files changed, 3 insertions(+), 1 deletion(-)
lib/copperplate/Makefile.am +2 -1
index f832d1c89..c7104eb02 100644
@@ -2,7 +2,8 @@
  lib_LTLIBRARIES = libcopperplate.la
 
  libcopperplate_la_LDFLAGS = @XENO_LIB_LDFLAGS@ -lpthread -lrt -version-info 0:0:0
-libcopperplate_la_LIBADD =
+libcopperplate_la_LIBADD = @XENO_CORE_LDADD@
+
  noinst_LTLIBRARIES =
 
  libcopperplate_la_SOURCES =	\
lib/smokey/Makefile.am +0 -0
index 53c775c68..4ecae1f16 100644

lib/smokey/Makefile.am line 7

Quoted 7 lines
lib/smokey/Makefile.am +1 -0
@@ -1,6 +1,7 @@
  lib_LTLIBRARIES = libsmokey.la
 
  libsmokey_la_LDFLAGS = @XENO_LIB_LDFLAGS@ -version-info 0:0:0
+libsmokey_la_LIBADD = @XENO_CORE_LDADD@
 
  libsmokey_la_SOURCES =	\
  	helpers.c	\

Thanks, applied to next.

Jan

Signature · 2 lines
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
#2 lore raw

Jan,

Quoted 11 lines · Jan Kiszka
Quoted 7 lines · Vitaly Chikunov

ALT rpmbuild QA script detects that libsmokey and libcopperplate is improperly linked (when built for Mercury core).

Excerpt from the error message:
verify-elf: ERROR: ./usr/lib64/libsmokey.so.0.0.0: undefined symbol: get_mem_size
verify-elf: ERROR: ./usr/lib64/libcopperplate.so.0.0.0: undefined symbol: get_mem_size

Could such a test be added to our regular build, or is it depending on rpm or altlinux?

It's tightly integrated into our rpmbuild system so it would be not easy to make it independent. But, I will think about it.

Quoted 24 lines
Quoted 24 lines
---
  lib/copperplate/Makefile.am | 3 ++-
  lib/smokey/Makefile.am      | 1 +
  2 files changed, 3 insertions(+), 1 deletion(-)
lib/copperplate/Makefile.am +2 -1
index f832d1c89..c7104eb02 100644
@@ -2,7 +2,8 @@
  lib_LTLIBRARIES = libcopperplate.la
  libcopperplate_la_LDFLAGS = @XENO_LIB_LDFLAGS@ -lpthread -lrt -version-info 0:0:0
-libcopperplate_la_LIBADD =
+libcopperplate_la_LIBADD = @XENO_CORE_LDADD@
+
  noinst_LTLIBRARIES =
  libcopperplate_la_SOURCES =	\
lib/smokey/Makefile.am +0 -0
index 53c775c68..4ecae1f16 100644
@@ -1,6 +1,7 @@
Quoted 8 lines

lib/smokey/Makefile.am

Quoted 6 lines
lib/smokey/Makefile.am +1 -0
  lib_LTLIBRARIES = libsmokey.la
  libsmokey_la_LDFLAGS = @XENO_LIB_LDFLAGS@ -version-info 0:0:0
+libsmokey_la_LIBADD = @XENO_CORE_LDADD@
  libsmokey_la_SOURCES =	\
  	helpers.c	\
 

Thanks, applied to next.

Thanks!

Quoted 6 lines

Jan

Signature · 2 lines
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
#3 lore raw
In reply to Jan Kiszka

On debian, dh_shlibdeps (dpkg-shlibdeps) should be able to diagnose this aswell.

Norbert

Quoted 62 lines

-----Original Message-----
From: Xenomai <[email protected]> On Behalf Of Jan Kiszka via Xenomai
Sent: Dienstag, 15. September 2020 12:39
To: Vitaly Chikunov <[email protected]>; Xenomai <[email protected]>
Subject: Re: [PATCH] libs: Add linking dependencies to libcopperplate and libsmokey

NON-ANDRITZ SOURCE: BE CAUTIOUS WITH CONTENT, LINKS OR ATTACHMENTS.

Quoted 5 lines · Vitaly Chikunov

ALT rpmbuild QA script detects that libsmokey and libcopperplate is improperly linked (when built for Mercury core).

Excerpt from the error message:

   verify-elf: ERROR: ./usr/lib64/libsmokey.so.0.0.0: undefined symbol:

get_mem_size

Quoted 3 lines
   verify-elf: ERROR: ./usr/lib64/libcopperplate.so.0.0.0: undefined

symbol: get_mem_size

Could such a test be added to our regular build, or is it depending on rpm or altlinux?

Quoted 26 lines
---
  lib/copperplate/Makefile.am | 3 ++-
  lib/smokey/Makefile.am      | 1 +
  2 files changed, 3 insertions(+), 1 deletion(-)
lib/copperplate/Makefile.am +2 -1
index f832d1c89..c7104eb02 100644
@@ -2,7 +2,8 @@
  lib_LTLIBRARIES = libcopperplate.la
 
  libcopperplate_la_LDFLAGS = @XENO_LIB_LDFLAGS@ -lpthread -lrt
-version-info 0:0:0 -libcopperplate_la_LIBADD =
+libcopperplate_la_LIBADD = @XENO_CORE_LDADD@
+
  noinst_LTLIBRARIES =
 
  libcopperplate_la_SOURCES = \
lib/smokey/Makefile.am index renamed from lib/smokey/Makefile.am +0 -0

53c775c68..4ecae1f16 100644

lib/smokey/Makefile.am line 7

Quoted 7 lines
lib/smokey/Makefile.am +1 -0
@@ -1,6 +1,7 @@
  lib_LTLIBRARIES = libsmokey.la
 
  libsmokey_la_LDFLAGS = @XENO_LIB_LDFLAGS@ -version-info 0:0:0
+libsmokey_la_LIBADD = @XENO_CORE_LDADD@
 
  libsmokey_la_SOURCES =      \
      helpers.c       \

Thanks, applied to next.

Quoted 5 lines

Jan

--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux

________________________________

This message and any attachments are solely for the use of the intended recipients. They may contain privileged and/or confidential information or other information protected from disclosure. If you are not an intended recipient, you are hereby notified that you received this email in error and that any review, dissemination, distribution or copying of this email and any attachment is strictly prohibited. If you have received this email in error, please contact the sender and delete the message and any attachment from your system.

ANDRITZ HYDRO GmbH

Rechtsform/ Legal form: Gesellschaft mit beschränkter Haftung / Corporation

Firmensitz/ Registered seat: Wien

Firmenbuchgericht/ Court of registry: Handelsgericht Wien

Firmenbuchnummer/ Company registration: FN 61833 g

DVR: 0605077

UID-Nr.: ATU14756806

Thank You
________________________________

#4 lore raw
Quoted 1 line · Lange Norbert

On debian, dh_shlibdeps (dpkg-shlibdeps) should be able to diagnose this aswell.

Then we must be missing something, or it only warns, because we are performing package builds regularly for it.

Jan

Signature · 2 lines
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux