Skip to contentSkip to conversation

virtiofsd: document cache=auto default

PATCH In review Stefan Hajnoczi 2 participants 3 messages Sep 16, 2020 – Sep 24, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtiofsd: document cache=auto default

From: "Harry G. Coin" <[email protected]>

The virtiofsd --help output documents the cache=auto default value but the man page does not. Fix this.

---
 docs/tools/virtiofsd.rst | 1 +
 1 file changed, 1 insertion(+)
docs/tools/virtiofsd.rst +1 -0
index e33c81ed41..352a29ce3c 100644
@@ -103,6 +103,7 @@ Options
   forbids the FUSE client from caching to achieve best coherency at the cost of
   performance.  ``auto`` acts similar to NFS with a 1 second metadata cache
   timeout.  ``always`` sets a long cache lifetime at the expense of coherency.
+  The default is ``auto``.
 
 Examples
 --------
Signature · 1 line
2.26.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · * Stefan Hajnoczi ([email protected]) wrote:

From: "Harry G. Coin" <[email protected]>

The virtiofsd --help output documents the cache=auto default value but the man page does not. Fix this.

Thanks, I'll add it to the next pull.

Dave

Quoted 19 lines
---
 docs/tools/virtiofsd.rst | 1 +
 1 file changed, 1 insertion(+)
docs/tools/virtiofsd.rst +1 -0
index e33c81ed41..352a29ce3c 100644
@@ -103,6 +103,7 @@ Options
   forbids the FUSE client from caching to achieve best coherency at the cost of
   performance.  ``auto`` acts similar to NFS with a 1 second metadata cache
   timeout.  ``always`` sets a long cache lifetime at the expense of coherency.
+  The default is ``auto``.
 
 Examples
 --------
Signature · 1 line
2.26.2
Signature · 1 line
Dr. David Alan Gilbert / [email protected] / Manchester, UK
#2 lore raw
In reply to Stefan Hajnoczi
Quoted 7 lines · * Stefan Hajnoczi ([email protected]) wrote:

From: "Harry G. Coin" <[email protected]>

The virtiofsd --help output documents the cache=auto default value but the man page does not. Fix this.

Queued

Quoted 19 lines
---
 docs/tools/virtiofsd.rst | 1 +
 1 file changed, 1 insertion(+)
docs/tools/virtiofsd.rst +1 -0
index e33c81ed41..352a29ce3c 100644
@@ -103,6 +103,7 @@ Options
   forbids the FUSE client from caching to achieve best coherency at the cost of
   performance.  ``auto`` acts similar to NFS with a 1 second metadata cache
   timeout.  ``always`` sets a long cache lifetime at the expense of coherency.
+  The default is ``auto``.
 
 Examples
 --------
Signature · 1 line
2.26.2
Signature · 1 line
Dr. David Alan Gilbert / [email protected] / Manchester, UK