Skip to contentSkip to conversation

c6x: pll: Convert to DEFINE_SHOW_ATTRIBUTE

PATCH Superseded Qinglang Miao 1 participant 1 message Sep 19, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 c6x: pll: Convert to DEFINE_SHOW_ATTRIBUTE

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

---
v2: based on linux-next(20200917), and can be applied to
mainline cleanly now.

 arch/c6x/platforms/pll.c | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)
arch/c6x/platforms/pll.c +2 -12
index 6fdf20d64..366c9fe6a 100644
@@ -417,22 +417,12 @@ static int c6x_ck_show(struct seq_file *m, void *v)
 	return 0;
 }
 
-static int c6x_ck_open(struct inode *inode, struct file *file)
-{
-	return single_open(file, c6x_ck_show, NULL);
-}
-
-static const struct file_operations c6x_ck_operations = {
-	.open		= c6x_ck_open,
-	.read		= seq_read,
-	.llseek		= seq_lseek,
-	.release	= single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(c6x_ck);
 
 static int __init c6x_clk_debugfs_init(void)
 {
 	debugfs_create_file("c6x_clocks", S_IFREG | S_IRUGO, NULL, NULL,
-			    &c6x_ck_operations);
+			    &c6x_ck_fops);
 
 	return 0;
 }
Signature · 1 line
2.23.0