mips: Convert to DEFINE_SHOW_ATTRIBUTE
Subsystems (2)
PATCH v2 1/1 mips: Convert to DEFINE_SHOW_ATTRIBUTE
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by Qinglang Miao <[email protected]>
---
v2: based on linux-next(20200917), and can be applied to
mainline cleanly now.
arch/mips/cavium-octeon/oct_ilm.c | 16 +++------------- arch/mips/kernel/segment.c | 14 ++------------ arch/mips/ralink/bootrom.c | 14 ++------------ 3 files changed, 7 insertions(+), 37 deletions(-)
arch/mips/cavium-octeon/oct_ilm.c +3 -13
@@ -28,7 +28,7 @@ struct latency_info {static struct latency_info li;static struct dentry *dir; -static int show_latency (struct seq_file *m,void *v) +static int oct_ilm_show (struct seq_file *m,void *v) {u64 cpuclk, avg, max, min;struct latency_info curr_li = li;
@@ -44,17 +44,7 @@ static int show_latency(struct seq_file *m, void *v)return 0 ; } -static int oct_ilm_open (struct inode *inode,struct file *file) -{ -return single_open (file, show_latency,NULL ); -} - -static const struct file_operations oct_ilm_ops = { - .open = oct_ilm_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; +DEFINE_SHOW_ATTRIBUTE (oct_ilm);static int reset_statistics (void *data,u64 value) {
@@ -67,7 +57,7 @@ DEFINE_SIMPLE_ATTRIBUTE(reset_statistics_ops, NULL, reset_statistics, "%llu\n");static void init_debugfs (void ) { dir =debugfs_create_dir ("oct_ilm" ,0 ); -debugfs_create_file ("statistics" ,0222 , dir,NULL , &oct_ilm_ops); +debugfs_create_file ("statistics" ,0222 , dir,NULL , &oct_ilm_fops);debugfs_create_file ("reset" ,0222 , dir,NULL , &reset_statistics_ops); }
arch/mips/kernel/segment.c +2 -12
@@ -46,7 +46,7 @@ static void build_segment_config(char *str, unsigned int cfg) ((cfg & MIPS_SEGCFG_EU) >> MIPS_SEGCFG_EU_SHIFT)); } -static int show_segments (struct seq_file *m,void *v) +static int segments_show (struct seq_file *m,void *v) {unsigned int segcfg;char str[42 ];
@@ -81,17 +81,7 @@ static int show_segments(struct seq_file *m, void *v)return 0 ; } -static int segments_open (struct inode *inode,struct file *file) -{ -return single_open (file, show_segments,NULL ); -} - -static const struct file_operations segments_fops = { - .open = segments_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; +DEFINE_SHOW_ATTRIBUTE (segments);static int __init segments_info (void ) {
arch/mips/ralink/bootrom.c +2 -12
@@ -19,21 +19,11 @@ static int bootrom_show(struct seq_file *s, void *unused)return 0 ; } -static int bootrom_open (struct inode *inode,struct file *file) -{ -return single_open (file, bootrom_show,NULL ); -} - -static const struct file_operations bootrom_file_ops = { - .open = bootrom_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; +DEFINE_SHOW_ATTRIBUTE (bootrom);static int __init bootrom_setup (void ) { -debugfs_create_file ("bootrom" ,0444 ,NULL ,NULL , &bootrom_file_ops); +debugfs_create_file ("bootrom" ,0444 ,NULL ,NULL , &bootrom_fops);return 0 ; }
Signature · 1 line
2.23.0