Skip to contentSkip to conversation

dt-bindings:iio:adc: Another set of yaml conversions.

PATCH In review Jonathan Cameron 3 participants 6 messages Sep 20, 2020 – Sep 25, 2020

Subsystems (3)
Device tree bindings Arm/Amlogic Meson SoC support IIO
lore
Share & tools
lore

Jonathan Cameron

author maintainer
#0 lore raw

v3 cover dt-bindings:iio:adc: Another set of yaml conversions.

From: Jonathan Cameron <[email protected]>

The only has a cover letter to match up with the earlier sets. I wouldn't normally put one on a single patch!

Changes since v2:
* Apply all but one patch.
* amlogic,meson-saradc:
- consistent capitalization
- clock names etc all shared, only the number of them changed dependent on type.

Jonathan Cameron (1):
dt-bindings:iio:adc:amlogic,meson-saradc yaml conversion

 .../bindings/iio/adc/amlogic,meson-saradc.txt |  48 ------
 .../iio/adc/amlogic,meson-saradc.yaml         | 149 ++++++++++++++++++
 2 files changed, 149 insertions(+), 48 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.txt
 create mode 100644 Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml
Signature · 1 line
2.28.0
author maintainer
#1 lore raw

PATCH v3 1/1 dt-bindings:iio:adc:amlogic,meson-saradc yaml conversion

From: Jonathan Cameron <[email protected]>

This binding is non trivial due to the range of different parts supported having several subtle quirks. Martin has helped clarify some of them.

Note, I haven't restricted the amlogic,hhi-sysctrl to only be present on the relevant parts if nvmem stuff also is, but it would seem to be rather odd if it were otherwise.

Perhaps we look to make this binding more restrictive at a later date.

Signed-off-by Jonathan Cameron <[email protected]>
Cc Martin Blumenstingl <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Neil Armstrong <[email protected]>
Cc Jerome Brunet <[email protected]>

---
Changes since v2
(thanks Rob and Martin)
- consistent capitalization
- clock names etc all shared, only the number of them changed dependent on type.
- missing maxItems for nvmem-cells.

 .../bindings/iio/adc/amlogic,meson-saradc.txt |  48 ------
 .../iio/adc/amlogic,meson-saradc.yaml         | 149 ++++++++++++++++++
 2 files changed, 149 insertions(+), 48 deletions(-)
Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.txt deleted +0 -48
deleted file mode 100644
index d57e9df25f4f..000000000000
@@ -1,48 +0,0 @@
-* Amlogic Meson SAR (Successive Approximation Register) A/D converter
-
-Required properties:
-- compatible:	depending on the SoC this should be one of:
-			- "amlogic,meson8-saradc" for Meson8
-			- "amlogic,meson8b-saradc" for Meson8b
-			- "amlogic,meson8m2-saradc" for Meson8m2
-			- "amlogic,meson-gxbb-saradc" for GXBB
-			- "amlogic,meson-gxl-saradc" for GXL
-			- "amlogic,meson-gxm-saradc" for GXM
-			- "amlogic,meson-axg-saradc" for AXG
-			- "amlogic,meson-g12a-saradc" for AXG
-		along with the generic "amlogic,meson-saradc"
-- reg:		the physical base address and length of the registers
-- interrupts:	the interrupt indicating end of sampling
-- clocks:	phandle and clock identifier (see clock-names)
-- clock-names:	mandatory clocks:
-			- "clkin" for the reference clock (typically XTAL)
-			- "core" for the SAR ADC core clock
-		optional clocks:
-			- "adc_clk" for the ADC (sampling) clock
-			- "adc_sel" for the ADC (sampling) clock mux
-- vref-supply:	the regulator supply for the ADC reference voltage
-- #io-channel-cells: must be 1, see ../iio-bindings.txt
-
-Optional properties:
-- amlogic,hhi-sysctrl:	phandle to the syscon which contains the 5th bit
-			of the TSC (temperature sensor coefficient) on
-			Meson8b and Meson8m2 (which used to calibrate the
-			temperature sensor)
-- nvmem-cells:		phandle to the temperature_calib eFuse cells
-- nvmem-cell-names:	if present (to enable the temperature sensor
-			calibration) this must contain "temperature_calib"
-
-
-Example:
-	saradc: adc@8680 {
-		compatible = "amlogic,meson-gxl-saradc", "amlogic,meson-saradc";
-		#io-channel-cells = <1>;
-		reg = <0x0 0x8680 0x0 0x34>;
-		interrupts = <GIC_SPI 73 IRQ_TYPE_EDGE_RISING>;
-		clocks = <&xtal>,
-			 <&clkc CLKID_SAR_ADC>,
-			 <&clkc CLKID_SANA>,
-			 <&clkc CLKID_SAR_ADC_CLK>,
-			 <&clkc CLKID_SAR_ADC_SEL>;
-		clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
-	};
Documentation/devicetree/bindings/iio/adc/amlogic,meson-saradc.yaml new file +149 -0

149 lines not on this page · raw message

Signature · 1 line
2.28.0
Reviewed-by on v3 1/1
#2 lore raw

Re: [PATCH v3 1/1] dt-bindings:iio:adc:amlogic,meson-saradc yaml conversion

Quoted 27 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

This binding is non trivial due to the range of different parts supported having several subtle quirks. Martin has helped clarify some of them.

Note, I haven't restricted the amlogic,hhi-sysctrl to only be present on the relevant parts if nvmem stuff also is, but it would seem to be rather odd if it were otherwise.

Perhaps we look to make this binding more restrictive at a later date.

Signed-off-by Jonathan Cameron <[email protected]>
Cc Martin Blumenstingl <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Neil Armstrong <[email protected]>
Cc Jerome Brunet <[email protected]>

---
Changes since v2
(thanks Rob and Martin)
- consistent capitalization
- clock names etc all shared, only the number of them changed dependent on type.
- missing maxItems for nvmem-cells.

Quoted 3 lines
 .../bindings/iio/adc/amlogic,meson-saradc.txt |  48 ------
 .../iio/adc/amlogic,meson-saradc.yaml         | 149 ++++++++++++++++++
 2 files changed, 149 insertions(+), 48 deletions(-)
Reviewed-by Rob Herring <[email protected]>
author maintainer Applied
#3 lore raw

Re: [PATCH v3 1/1] dt-bindings:iio:adc:amlogic,meson-saradc yaml conversion

Quoted 28 lines · On Tue, 22 Sep 2020 08:08:48 -0600 Rob Herring <[email protected]> wrote:
Quoted 27 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

This binding is non trivial due to the range of different parts supported having several subtle quirks. Martin has helped clarify some of them.

Note, I haven't restricted the amlogic,hhi-sysctrl to only be present on the relevant parts if nvmem stuff also is, but it would seem to be rather odd if it were otherwise.

Perhaps we look to make this binding more restrictive at a later date.

Signed-off-by Jonathan Cameron <[email protected]>
Cc Martin Blumenstingl <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Neil Armstrong <[email protected]>
Cc Jerome Brunet <[email protected]>

---
Changes since v2
(thanks Rob and Martin)
- consistent capitalization
- clock names etc all shared, only the number of them changed dependent on type.
- missing maxItems for nvmem-cells.

Quoted 5 lines
Quoted 3 lines
 .../bindings/iio/adc/amlogic,meson-saradc.txt |  48 ------
 .../iio/adc/amlogic,meson-saradc.yaml         | 149 ++++++++++++++++++
 2 files changed, 149 insertions(+), 48 deletions(-)
Reviewed-by Rob Herring <[email protected]>

Applied. Thanks,

Jonathan

reviewer Reviewed-by on v3 1/1
#4 lore raw

Re: [PATCH v3 1/1] dt-bindings:iio:adc:amlogic,meson-saradc yaml conversion

In reply to Jonathan Cameron

Hi Jonathan,

Quoted 7 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

This binding is non trivial due to the range of different parts supported having several subtle quirks. Martin has helped clarify some of them.

Quoted 7 lines

Note, I haven't restricted the amlogic,hhi-sysctrl to only be present on the relevant parts if nvmem stuff also is, but it would seem to be rather odd if it were otherwise.

Perhaps we look to make this binding more restrictive at a later date.

Signed-off-by Jonathan Cameron <[email protected]>

this is looking great - so in case it's not too late please add my:

Reviewed-by Martin Blumenstingl <[email protected]>

Best regards,
Martin

author maintainer
#5 lore raw

Re: [PATCH v3 1/1] dt-bindings:iio:adc:amlogic,meson-saradc yaml conversion

Quoted 14 lines · On Thu, 24 Sep 2020 15:02:02 +0200 Martin Blumenstingl…

Hi Jonathan,

Quoted 11 lines · Jonathan Cameron

From: Jonathan Cameron <[email protected]>

This binding is non trivial due to the range of different parts supported having several subtle quirks. Martin has helped clarify some of them.

Note, I haven't restricted the amlogic,hhi-sysctrl to only be present on the relevant parts if nvmem stuff also is, but it would seem to be rather odd if it were otherwise.

Quoted 7 lines
Quoted 3 lines

Perhaps we look to make this binding more restrictive at a later date.

Signed-off-by Jonathan Cameron <[email protected]>

this is looking great - so in case it's not too late please add my:

Reviewed-by Martin Blumenstingl <[email protected]>

Thanks Martin, I've added your tag.

Jonathan

Quoted 2 lines

Best regards,
Martin