Skip to contentSkip to conversation

ARM: dts: imx6ul: segin: Fix stmpe touchscreen subnode name

PATCH Applied Stefan Riedmueller 2 participants 12 messages Sep 22, 2020 – Oct 28, 2020

Subsystems (3)

v1 of 2 Applied Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/6 ARM: dts: imx6ul: segin: Fix stmpe touchscreen subnode name

The touchscreen subnode name needs to be stmpe_touchscreen as mentioned in the dt-bindings.

---
 arch/arm/boot/dts/imx6ul-phytec-segin.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx6ul-phytec-segin.dtsi +1 -1
index f1412df89173..2a3801e349b6 100644
@@ -139,7 +139,7 @@ stmpe: touchscreen@44 {
 		pinctrl-0 = <&pinctrl_stmpe>;
 		status = "disabled";
 
-		touchscreen {
+		stmpe_touchscreen {
 			compatible = "st,stmpe-ts";
 			st,sample-time = <4>;
 			st,mod-12b = <1>;
Signature · 1 line
2.25.1
#1 lore raw

PATCH 2/6 ARM: dts: imx6: phytec: Set correct eeprom compatible

Set the correct EEPROM compatible for phyCORE-i.MX 6 and phyFLEX-i.MX 6, as stated in the device tree bindings.

---
 arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi      | 2 +-
 arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi +1 -1
index bc43c75f1745..aa7fdb9ea5bd 100644
@@ -116,7 +116,7 @@ &i2c1 {
 	status = "okay";
 
 	som_eeprom: eeprom@50 {
-		compatible = "atmel,24c32";
+		compatible = "catalyst,24c32", "atmel,24c32";
 		reg = <0x50>;
 	};
 
arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi +1 -1
index 41ebe4599e43..a3f4e8f6cc9e 100644
@@ -84,7 +84,7 @@ &i2c3 {
 	status = "okay";
 
 	eeprom@50 {
-		compatible = "atmel,24c32";
+		compatible = "st,24c32", "atmel,24c32";
 		reg = <0x50>;
 	};
 
Signature · 1 line
2.25.1
#3 lore raw

PATCH 3/6 ARM: dts: imx6: phytec: Add eeprom pagesize

In reply to Stefan Riedmueller

Defining the EEPROM pagesize can increase the write speed significantly. Set it to the pagesize stated in the EEPROM's datasheet for phyCORE-i.MX 6UL, phyCORE-i.MX 6 and phyFLEX-i.MX 6.

---
 arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi      | 1 +
 arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 1 +
 arch/arm/boot/dts/imx6ul-phytec-phycore-som.dtsi  | 1 +
 3 files changed, 3 insertions(+)
arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi +1 -0
index aa7fdb9ea5bd..87adfb735f95 100644
@@ -117,6 +117,7 @@ &i2c1 {
 
 	som_eeprom: eeprom@50 {
 		compatible = "catalyst,24c32", "atmel,24c32";
+		pagesize = <32>;
 		reg = <0x50>;
 	};
 
arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi +1 -0
index a3f4e8f6cc9e..a80aa08a37cb 100644
@@ -85,6 +85,7 @@ &i2c3 {
 
 	eeprom@50 {
 		compatible = "st,24c32", "atmel,24c32";
+		pagesize = <32>;
 		reg = <0x50>;
 	};
 
arch/arm/boot/dts/imx6ul-phytec-phycore-som.dtsi +1 -0
index ce14ce685d12..11fa3fb5947b 100644
@@ -75,6 +75,7 @@ &i2c1 {
 
 	eeprom@52 {
 		compatible = "catalyst,24c32", "atmel,24c32";
+		pagesize = <32>;
 		reg = <0x52>;
 	};
 };
Signature · 1 line
2.25.1
Applied
#4 lore raw

Re: [PATCH 3/6] ARM: dts: imx6: phytec: Add eeprom pagesize

Quoted 5 lines · Stefan Riedmueller

Defining the EEPROM pagesize can increase the write speed significantly. Set it to the pagesize stated in the EEPROM's datasheet for phyCORE-i.MX 6UL, phyCORE-i.MX 6 and phyFLEX-i.MX 6.

Applied, thanks.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#5 lore raw

PATCH 4/6 ARM: dts: imx6ul: segin: Add phyBOARD-Segin with eMMC phyCORE-i.MX6UL

In reply to Stefan Riedmueller

From: Yunus Bas <[email protected]>

Add a PHYTEC phyBOARD-Segin full featured with phyCORE-i.MX 6UL with eMMC and following features:
- i.MX 6UL
- 512 MB RAM
- eMMC
- USB Host/OTG
- 2x 100 Mbit/s Ethernet
- RS232
- CAN

---
 arch/arm/boot/dts/Makefile                    |  1 +
 .../dts/imx6ul-phytec-segin-ff-rdk-emmc.dts   | 93 +++++++++++++++++++
 2 files changed, 94 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dts
arch/arm/boot/dts/Makefile +1 -0
index 4572db3fa5ae..81ede0707a51 100644
@@ -615,6 +615,7 @@ dtb-$(CONFIG_SOC_IMX6UL) += \
 	imx6ul-pico-dwarf.dtb \
 	imx6ul-pico-hobbit.dtb \
 	imx6ul-pico-pi.dtb \
+	imx6ul-phytec-segin-ff-rdk-emmc.dtb \
 	imx6ul-phytec-segin-ff-rdk-nand.dtb \
 	imx6ul-tx6ul-0010.dtb \
 	imx6ul-tx6ul-0011.dtb \
arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dts new file +93 -0

93 lines not on this page · raw message

Signature · 1 line
2.25.1
#6 lore raw

Re: [PATCH 4/6] ARM: dts: imx6ul: segin: Add phyBOARD-Segin with eMMC phyCORE-i.MX6UL

Quoted 57 lines · Stefan Riedmueller

From: Yunus Bas <[email protected]>

Add a PHYTEC phyBOARD-Segin full featured with phyCORE-i.MX 6UL with eMMC and following features:
- i.MX 6UL
- 512 MB RAM
- eMMC
- USB Host/OTG
- 2x 100 Mbit/s Ethernet
- RS232
- CAN

---
 arch/arm/boot/dts/Makefile                    |  1 +
 .../dts/imx6ul-phytec-segin-ff-rdk-emmc.dts   | 93 +++++++++++++++++++
 2 files changed, 94 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dts
arch/arm/boot/dts/Makefile +1 -0
index 4572db3fa5ae..81ede0707a51 100644
@@ -615,6 +615,7 @@ dtb-$(CONFIG_SOC_IMX6UL) += \
 	imx6ul-pico-dwarf.dtb \
 	imx6ul-pico-hobbit.dtb \
 	imx6ul-pico-pi.dtb \
+	imx6ul-phytec-segin-ff-rdk-emmc.dtb \
 	imx6ul-phytec-segin-ff-rdk-nand.dtb \
 	imx6ul-tx6ul-0010.dtb \
 	imx6ul-tx6ul-0011.dtb \
arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dts new file +19 -0
new file mode 100644
index 000000000000..934c05fad615
@@ -0,0 +1,93 @@
+// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
+/*
+ * Copyright (C) 2020 PHYTEC Messtechnik GmbH
+ * Author: Yunus Bas <[email protected]>
+ */
+
+/dts-v1/;
+#include "imx6ul.dtsi"
+#include "imx6ul-phytec-phycore-som.dtsi"
+#include "imx6ul-phytec-segin.dtsi"
+#include "imx6ul-phytec-segin-peb-eval-01.dtsi"
+
+/ {
+	model = "PHYTEC phyBOARD-Segin i.MX6 UltraLite Full Featured with eMMC";
+	compatible = "phytec,imx6ul-pbacd10-emmc", "phytec,imx6ul-pbacd10",
+		     "phytec,imx6ul-pcl063","fsl,imx6ul";
+};
+
+&adc1 {

arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dts line 29

Quoted 10 lines
arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dts new file +10 -0
+	status = "okay";
+};
+
+&can1 {
+	status = "okay";
+};
+
+&tlv320 {
+	status = "okay";
+};

It breaks the alphabetic order.

Shawn

Quoted 67 lines
arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dts new file +64 -0
+
+&ecspi3 {
+	status = "okay";
+};
+
+&ethphy1 {
+	status = "okay";
+};
+
+&ethphy2 {
+	status = "okay";
+};
+
+&fec1 {
+	status = "okay";
+};
+
+&fec2 {
+	status = "okay";
+};
+
+&i2c_rtc {
+	status = "okay";
+};
+
+&reg_can1_en {
+	status = "okay";
+};
+
+&reg_sound_1v8 {
+	status = "okay";
+};
+
+&reg_sound_3v3 {
+	status = "okay";
+};
+
+&sai2 {
+	status = "okay";
+};
+
+&sound {
+	status = "okay";
+};
+
+&uart5 {
+	status = "okay";
+};
+
+&usbotg1 {
+	status = "okay";
+};
+
+&usbotg2 {
+	status = "okay";
+};
+
+&usdhc1 {
+	status = "okay";
+};
+
+&usdhc2 {
+	status = "okay";
+};
Signature · 1 line
2.25.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#7 lore raw

Re: [PATCH 4/6] ARM: dts: imx6ul: segin: Add phyBOARD-Segin with eMMC phyCORE-i.MX6UL

Hi Shawn,

Quoted 62 lines · Shawn Guo
Quoted 61 lines · Stefan Riedmueller

From: Yunus Bas <[email protected]>

Add a PHYTEC phyBOARD-Segin full featured with phyCORE-i.MX 6UL with eMMC and following features:
- i.MX 6UL
- 512 MB RAM
- eMMC
- USB Host/OTG
- 2x 100 Mbit/s Ethernet
- RS232
- CAN

---
  arch/arm/boot/dts/Makefile                    |  1 +
  .../dts/imx6ul-phytec-segin-ff-rdk-emmc.dts   | 93 +++++++++++++++++++
  2 files changed, 94 insertions(+)

create mode 100644 arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dts

arch/arm/boot/dts/Makefile +1 -0
index 4572db3fa5ae..81ede0707a51 100644
@@ -615,6 +615,7 @@ dtb-$(CONFIG_SOC_IMX6UL) += \
  	imx6ul-pico-dwarf.dtb \
  	imx6ul-pico-hobbit.dtb \
  	imx6ul-pico-pi.dtb \
+	imx6ul-phytec-segin-ff-rdk-emmc.dtb \
  	imx6ul-phytec-segin-ff-rdk-nand.dtb \
  	imx6ul-tx6ul-0010.dtb \
  	imx6ul-tx6ul-0011.dtb \
arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dts new file +23 -0
new file mode 100644
index 000000000000..934c05fad615
@@ -0,0 +1,93 @@
+// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
+/*
+ * Copyright (C) 2020 PHYTEC Messtechnik GmbH
+ * Author: Yunus Bas <[email protected]>
+ */
+
+/dts-v1/;
+#include "imx6ul.dtsi"
+#include "imx6ul-phytec-phycore-som.dtsi"
+#include "imx6ul-phytec-segin.dtsi"
+#include "imx6ul-phytec-segin-peb-eval-01.dtsi"
+
+/ {
+	model = "PHYTEC phyBOARD-Segin i.MX6 UltraLite Full Featured with eMMC";
+	compatible = "phytec,imx6ul-pbacd10-emmc", "phytec,imx6ul-pbacd10",
+		     "phytec,imx6ul-pcl063","fsl,imx6ul";
+};
+
+&adc1 {
+	status = "okay";
+};
+
+&can1 {
Quoted 8 lines

arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dts line 29

Quoted 6 lines
arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dts new file +6 -0
+	status = "okay";
+};
+
+&tlv320 {
+	status = "okay";
+};

It breaks the alphabetic order.

Ah sorry, I missed that. I'll send a v2.

Thanks,
Stefan

Quoted 62 lines

Shawn

Quoted 59 lines
arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dts new file +59 -0
+
+&ecspi3 {
+	status = "okay";
+};
+
+&ethphy1 {
+	status = "okay";
+};
+
+&ethphy2 {
+	status = "okay";
+};
+
+&fec1 {
+	status = "okay";
+};
+
+&fec2 {
+	status = "okay";
+};
+
+&i2c_rtc {
+	status = "okay";
+};
+
+&reg_can1_en {
+	status = "okay";
+};
+
+&reg_sound_1v8 {
+	status = "okay";
+};
+
+&reg_sound_3v3 {
+	status = "okay";
+};
+
+&sai2 {
+	status = "okay";
+};
+
+&sound {
+	status = "okay";
+};
+
+&uart5 {
+	status = "okay";
+};
+
+&usbotg1 {
+	status = "okay";
+};
+
+&usbotg2 {
+	status = "okay";
+};
+
+&usdhc1 {
+	status = "okay";
Quoted 8 lines
Quoted 8 lines
arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dts new file +5 -0
+};
+
+&usdhc2 {
+	status = "okay";
+};
Signature · 1 line
2.25.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#8 lore raw

PATCH 5/6 ARM: dts: imx6ul: phytec: Add support for optional PEB-AV-02 LCD adapter

In reply to Stefan Riedmueller

The PHYTEC PEB-AV-02 adapter adds the capability to connect a parallel LCD display to the phyBOARD-Segin full featured, either with capacitive or resistive touch.

---
 .../dts/imx6ul-phytec-segin-ff-rdk-emmc.dts   |   1 +
 .../dts/imx6ul-phytec-segin-ff-rdk-nand.dts   |   1 +
 .../dts/imx6ul-phytec-segin-peb-av-02.dtsi    | 150 ++++++++++++++++++
 arch/arm/boot/dts/imx6ul-phytec-segin.dtsi    |  43 -----
 .../dts/imx6ull-phytec-segin-ff-rdk-emmc.dts  |   1 +
 .../dts/imx6ull-phytec-segin-ff-rdk-nand.dts  |   1 +
 .../dts/imx6ull-phytec-segin-peb-av-02.dtsi   |  26 +++
 arch/arm/boot/dts/imx6ull-phytec-segin.dtsi   |   7 -
 8 files changed, 180 insertions(+), 50 deletions(-)
 create mode 100644 arch/arm/boot/dts/imx6ul-phytec-segin-peb-av-02.dtsi
 create mode 100644 arch/arm/boot/dts/imx6ull-phytec-segin-peb-av-02.dtsi
arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-emmc.dts +1 -0
index 934c05fad615..83ef5af0501e 100644
@@ -9,6 +9,7 @@
 #include "imx6ul-phytec-phycore-som.dtsi"
 #include "imx6ul-phytec-segin.dtsi"
 #include "imx6ul-phytec-segin-peb-eval-01.dtsi"
+#include "imx6ul-phytec-segin-peb-av-02.dtsi"
 
 / {
 	model = "PHYTEC phyBOARD-Segin i.MX6 UltraLite Full Featured with eMMC";
arch/arm/boot/dts/imx6ul-phytec-segin-ff-rdk-nand.dts +1 -0
index bfda5eda7a25..8296059c0084 100644
@@ -9,6 +9,7 @@
 #include "imx6ul-phytec-phycore-som.dtsi"
 #include "imx6ul-phytec-segin.dtsi"
 #include "imx6ul-phytec-segin-peb-eval-01.dtsi"
+#include "imx6ul-phytec-segin-peb-av-02.dtsi"
 
 / {
 	model = "PHYTEC phyBOARD-Segin i.MX6 UltraLite Full Featured with NAND";
arch/arm/boot/dts/imx6ul-phytec-segin-peb-av-02.dtsi new file +150 -0

150 lines not on this page · raw message

arch/arm/boot/dts/imx6ul-phytec-segin.dtsi +0 -43

67 lines not on this page · raw message

arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-emmc.dts +1 -0
index 9648d4ecaf58..8e2a4c5d7765 100644
@@ -9,6 +9,7 @@
 #include "imx6ull-phytec-phycore-som.dtsi"
 #include "imx6ull-phytec-segin.dtsi"
 #include "imx6ull-phytec-segin-peb-eval-01.dtsi"
+#include "imx6ull-phytec-segin-peb-av-02.dtsi"
 
 / {
 	model = "PHYTEC phyBOARD-Segin i.MX6 ULL Full Featured with eMMC";
arch/arm/boot/dts/imx6ull-phytec-segin-ff-rdk-nand.dts +1 -0
index 656baf846453..c8d3eff9ed4b 100644
@@ -9,6 +9,7 @@
 #include "imx6ull-phytec-phycore-som.dtsi"
 #include "imx6ull-phytec-segin.dtsi"
 #include "imx6ull-phytec-segin-peb-eval-01.dtsi"
+#include "imx6ull-phytec-segin-peb-av-02.dtsi"
 
 / {
 	model = "PHYTEC phyBOARD-Segin i.MX6 ULL Full Featured with NAND";
arch/arm/boot/dts/imx6ull-phytec-segin-peb-av-02.dtsi new file +26 -0
new file mode 100644
index 000000000000..06bb7f327780
@@ -0,0 +1,26 @@
+// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
+/*
+ * Copyright (C) 2018 PHYTEC Messtechnik GmbH
+ * Author: Stefan Riedmueller <[email protected]>
+ */
+
+#include "imx6ul-phytec-segin-peb-av-02.dtsi"
+
+&iomuxc {
+	/delete-node/ edtft5406grp;
+	/delete-node/ stmpegrp;
+};
+
+&iomuxc_snvs {
+	pinctrl_edt_ft5406: edtft5406grp {
+		fsl,pins = <
+			MX6ULL_PAD_SNVS_TAMPER5__GPIO5_IO05	0x1b0b0
+		>;
+	};
+
+	pinctrl_stmpe: stmpegrp {
+		fsl,pins = <
+			MX6ULL_PAD_SNVS_TAMPER3__GPIO5_IO03	0x17059
+		>;
+	};
+};
arch/arm/boot/dts/imx6ull-phytec-segin.dtsi +0 -7
index c1595fc785f7..e287a0453b5f 100644
@@ -14,7 +14,6 @@ / {
 &iomuxc {
 	/delete-node/ flexcan1engrp;
 	/delete-node/ rtcintgrp;
-	/delete-node/ stmpegrp;
 };
 
 &iomuxc_snvs {
@@ -29,10 +28,4 @@ pinctrl_rtc_int: rtcintgrp {
 			MX6ULL_PAD_SNVS_TAMPER1__GPIO5_IO01	0x17059
 		>;
 	};
-
-	pinctrl_stmpe: stmpegrp {
-		fsl,pins = <
-			MX6ULL_PAD_SNVS_TAMPER3__GPIO5_IO03	0x17059
-		>;
-	};
 };
Signature · 1 line
2.25.1
#9 lore raw

PATCH 6/6 ARM: dts: imx6ul: segin: peb-av-02: Mark stmpe touch as wakeup-source

In reply to Stefan Riedmueller

Mark the STMPE resistive touch controller as a wakeup-source.

---
 arch/arm/boot/dts/imx6ul-phytec-segin-peb-av-02.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/imx6ul-phytec-segin-peb-av-02.dtsi +1 -0
index 86898546627c..610b778c753a 100644
@@ -70,6 +70,7 @@ stmpe: touchscreen@44 {
 		pinctrl-0 = <&pinctrl_stmpe>;
 		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
 		interrupt-parent = <&gpio5>;
+		wakeup-source;
 		status = "disabled";
 
 		stmpe_touchscreen {
Signature · 1 line
2.25.1
#10 lore raw
In reply to Stefan Riedmueller

Hi,

just a gentle ping for this series.

Stefan

Quoted 14 lines · Stefan Riedmueller

The touchscreen subnode name needs to be stmpe_touchscreen as mentioned in the dt-bindings.

---
  arch/arm/boot/dts/imx6ul-phytec-segin.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx6ul-phytec-segin.dtsi +0 -0
index f1412df89173..2a3801e349b6 100644

arch/arm/boot/dts/imx6ul-phytec-segin.dtsi stmpe: touchscreen@44 { · line 145

Quoted 8 lines
arch/arm/boot/dts/imx6ul-phytec-segin.dtsi +1 -1
@@ -139,7 +139,7 @@ stmpe: touchscreen@44 {
  		pinctrl-0 = <&pinctrl_stmpe>;
  		status = "disabled";
 
-		touchscreen {
+		stmpe_touchscreen {
  			compatible = "st,stmpe-ts";
  			st,sample-time = <4>;
  			st,mod-12b = <1>;

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel