kdump: append uts_namespace.name offset to VMCOREINFO
Subsystems (3)
PATCH v2 1/1 kdump: append uts_namespace.name offset to VMCOREINFO
The offset of the field 'init_uts_ns.name' has changed since
commit 9a56493f6942c0e2df1579986128721da96e00d8
Author: Kirill Tkhai <[email protected]> Date: Mon Aug 3 13:16:21 2020 +0300
uts: Use generic ns_common::count
Make the offset of the field 'uts_namespace.name' available in VMCOREINFO because tools like 'crash-utility' and 'makedumpfile' must be able to read it from crash dumps.
--- kernel/crash_core.c | 1 + 1 file changed, 1 insertion(+)
kernel/crash_core.c +1 -0
@@ -447,6 +447,7 @@ static int __init crash_save_vmcoreinfo_init(void)VMCOREINFO_PAGESIZE (PAGE_SIZE );VMCOREINFO_SYMBOL (init_uts_ns); +VMCOREINFO_OFFSET (uts_namespace, name);VMCOREINFO_SYMBOL (node_online_map);#ifdef CONFIG_MMU VMCOREINFO_SYMBOL_ARRAY (swapper_pg_dir);
Signature · 7 lines
2.26.2 _______________________________________________ kexec mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kexec
Quoted 10 lines · Alexander Egorenkov
The offset of the field 'init_uts_ns.name' has changed since
commit
9a56493f6942c0e2df1579986128721da96e00d8Author: Kirill Tkhai <[email protected]> Date: Mon Aug 3 13:16:21 2020 +0300uts: Use generic
ns_common::count
Seems there's some argument about the generic ns_common::count in the thread of above link. While except of it, the adding the offset of uts_namespace.name looks good to me.
Quoted 25 lines
Make the offset of the field 'uts_namespace.name' available in VMCOREINFO because tools like 'crash-utility' and 'makedumpfile' must be able to read it from crash dumps.
Signed-off-by Alexander Egorenkov <[email protected]>--- kernel/crash_core.c | 1 + 1 file changed, 1 insertion(+)kernel/crash_core.c +1
-0@@ -447,6 +447,7 @@ static int __init crash_save_vmcoreinfo_init(void)VMCOREINFO_PAGESIZE (PAGE_SIZE );VMCOREINFO_SYMBOL (init_uts_ns); +VMCOREINFO_OFFSET (uts_namespace, name);VMCOREINFO_SYMBOL (node_online_map);#ifdef CONFIG_MMU VMCOREINFO_SYMBOL_ARRAY (swapper_pg_dir);Signature · 1 line
2.26.2
Hi Alexander,
Quoted 9 lines · Alexander Egorenkov
The offset of the field 'init_uts_ns.name' has changed since
commit
9a56493f6942c0e2df1579986128721da96e00d8Author: Kirill Tkhai <[email protected]> Date: Mon Aug 3 13:16:21 2020 +0300uts: Use generic
ns_common::count
A minor nitpick:
You can add the following line to your .gitconfig:
one = show -s --pretty='format:%h (\"%s\")'
running a command '$ git one <SHA-ID>' will then give you an abbreviated form to be used while referring to existing git commits in the log message. For e.g. in this case, the output would be something like:
$ git one 9a56493f6942c0e2df1579986128721da96e00d8
9a56493f6942 ("uts: Use generic ns_common::count")Then you can use '9a56493f6942 ("uts: Use generic ns_common::count")' to refer to an existing upstream patch in the log message.
But I think this can be fixed while applying the patch (if there are no further revisions required).
Quoted 24 lines
Make the offset of the field 'uts_namespace.name' available in VMCOREINFO because tools like 'crash-utility' and 'makedumpfile' must be able to read it from crash dumps.
Signed-off-by Alexander Egorenkov <[email protected]>--- kernel/crash_core.c | 1 + 1 file changed, 1 insertion(+)kernel/crash_core.c +1
-1@@ -447,6 +447,7 @@ static int __init crash_save_vmcoreinfo_init(void)VMCOREINFO_PAGESIZE (PAGE_SIZE );VMCOREINFO_SYMBOL (init_uts_ns); +VMCOREINFO_OFFSET (uts_namespace, name);VMCOREINFO_SYMBOL (node_online_map);#ifdef CONFIG_MMU VMCOREINFO_SYMBOL_ARRAY (swapper_pg_dir); --
Quoted 1 line
2.26.2
Thanks for making the changes we discussed in the v1 review. Otherwise the patch looks fine to me, so:
Hi, Alexander
Quoted 25 lines · Alexander Egorenkov
The offset of the field 'init_uts_ns.name' has changed since
commit
9a56493f6942c0e2df1579986128721da96e00d8Author: Kirill Tkhai <[email protected]> Date: Mon Aug 3 13:16:21 2020 +0300uts: Use generic
ns_common::countMake the offset of the field 'uts_namespace.name' available in VMCOREINFO because tools like 'crash-utility' and 'makedumpfile' must be able to read it from crash dumps.
Signed-off-by Alexander Egorenkov <[email protected]>--- kernel/crash_core.c | 1 + 1 file changed, 1 insertion(+)kernel/crash_core.c +0
-0
kernel/crash_core.c static int __init crash_save_vmcoreinfo_init(void) · line 450
Quoted 4 lines
kernel/crash_core.c +1
-0@@ -447,6 +447,7 @@ static int __init crash_save_vmcoreinfo_init(void)VMCOREINFO_PAGESIZE (PAGE_SIZE );VMCOREINFO_SYMBOL (init_uts_ns); +VMCOREINFO_OFFSET (uts_namespace, name);
Since the new symbol is exported, would you mind adding it to Documentation/kdump/vmcoreinfo.txt ?
Thanks.
Lianbo
Quoted 4 lines
kernel/crash_core.c +0
-0VMCOREINFO_SYMBOL (node_online_map);#ifdef CONFIG_MMU VMCOREINFO_SYMBOL_ARRAY (swapper_pg_dir);