Skip to contentSkip to conversation

kdump: append uts_namespace.name offset to VMCOREINFO

PATCH Superseded Alexander Egorenkov 4 participants 4 messages Sep 24, 2020 – Sep 30, 2020

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 kdump: append uts_namespace.name offset to VMCOREINFO

The offset of the field 'init_uts_ns.name' has changed since

commit 9a56493f6942c0e2df1579986128721da96e00d8

Author: Kirill Tkhai <[email protected]>
Date:   Mon Aug 3 13:16:21 2020 +0300

uts: Use generic ns_common::count

Make the offset of the field 'uts_namespace.name' available in VMCOREINFO because tools like 'crash-utility' and 'makedumpfile' must be able to read it from crash dumps.

---
 kernel/crash_core.c | 1 +
 1 file changed, 1 insertion(+)
kernel/crash_core.c +1 -0
index 106e4500fd53..173fdc261882 100644
@@ -447,6 +447,7 @@ static int __init crash_save_vmcoreinfo_init(void)
 	VMCOREINFO_PAGESIZE(PAGE_SIZE);
 
 	VMCOREINFO_SYMBOL(init_uts_ns);
+	VMCOREINFO_OFFSET(uts_namespace, name);
 	VMCOREINFO_SYMBOL(node_online_map);
 #ifdef CONFIG_MMU
 	VMCOREINFO_SYMBOL_ARRAY(swapper_pg_dir);
Signature · 7 lines
2.26.2


_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
Acked-by on v2 1/1
#1 lore raw
Quoted 10 lines · Alexander Egorenkov

The offset of the field 'init_uts_ns.name' has changed since

commit 9a56493f6942c0e2df1579986128721da96e00d8

Author: Kirill Tkhai <[email protected]>
Date:   Mon Aug 3 13:16:21 2020 +0300

uts: Use generic ns_common::count

Seems there's some argument about the generic ns_common::count in the thread of above link. While except of it, the adding the offset of uts_namespace.name looks good to me.

Quoted 25 lines

Make the offset of the field 'uts_namespace.name' available in VMCOREINFO because tools like 'crash-utility' and 'makedumpfile' must be able to read it from crash dumps.

---
 kernel/crash_core.c | 1 +
 1 file changed, 1 insertion(+)
kernel/crash_core.c +1 -0
index 106e4500fd53..173fdc261882 100644
@@ -447,6 +447,7 @@ static int __init crash_save_vmcoreinfo_init(void)
 	VMCOREINFO_PAGESIZE(PAGE_SIZE);
 
 	VMCOREINFO_SYMBOL(init_uts_ns);
+	VMCOREINFO_OFFSET(uts_namespace, name);
 	VMCOREINFO_SYMBOL(node_online_map);
 #ifdef CONFIG_MMU
 	VMCOREINFO_SYMBOL_ARRAY(swapper_pg_dir);
Signature · 1 line
2.26.2
Reviewed-by on v2 1/1
#2 lore raw
In reply to Alexander Egorenkov

Hi Alexander,

Quoted 9 lines · Alexander Egorenkov

The offset of the field 'init_uts_ns.name' has changed since

commit 9a56493f6942c0e2df1579986128721da96e00d8

Author: Kirill Tkhai <[email protected]>
Date:   Mon Aug 3 13:16:21 2020 +0300

uts: Use generic ns_common::count

A minor nitpick:
You can add the following line to your .gitconfig:
one = show -s --pretty='format:%h (\"%s\")'

running a command '$ git one <SHA-ID>' will then give you an abbreviated form to be used while referring to existing git commits in the log message. For e.g. in this case, the output would be something like:

$ git one 9a56493f6942c0e2df1579986128721da96e00d8
9a56493f6942 ("uts: Use generic ns_common::count")

Then you can use '9a56493f6942 ("uts: Use generic ns_common::count")' to refer to an existing upstream patch in the log message.

But I think this can be fixed while applying the patch (if there are no further revisions required).

Quoted 24 lines

Make the offset of the field 'uts_namespace.name' available in VMCOREINFO because tools like 'crash-utility' and 'makedumpfile' must be able to read it from crash dumps.

---
 kernel/crash_core.c | 1 +
 1 file changed, 1 insertion(+)
kernel/crash_core.c +1 -1
index 106e4500fd53..173fdc261882 100644
@@ -447,6 +447,7 @@ static int __init crash_save_vmcoreinfo_init(void)
        VMCOREINFO_PAGESIZE(PAGE_SIZE);
 
        VMCOREINFO_SYMBOL(init_uts_ns);
+       VMCOREINFO_OFFSET(uts_namespace, name);
        VMCOREINFO_SYMBOL(node_online_map);
 #ifdef CONFIG_MMU
        VMCOREINFO_SYMBOL_ARRAY(swapper_pg_dir);
--
Quoted 1 line

2.26.2

Thanks for making the changes we discussed in the v1 review. Otherwise the patch looks fine to me, so:

#3 lore raw
In reply to Alexander Egorenkov

Hi, Alexander

Quoted 25 lines · Alexander Egorenkov

The offset of the field 'init_uts_ns.name' has changed since

commit 9a56493f6942c0e2df1579986128721da96e00d8

Author: Kirill Tkhai <[email protected]>
Date:   Mon Aug 3 13:16:21 2020 +0300

uts: Use generic ns_common::count

Make the offset of the field 'uts_namespace.name' available in VMCOREINFO because tools like 'crash-utility' and 'makedumpfile' must be able to read it from crash dumps.

---
 kernel/crash_core.c | 1 +
 1 file changed, 1 insertion(+)
kernel/crash_core.c +0 -0
index 106e4500fd53..173fdc261882 100644

kernel/crash_core.c static int __init crash_save_vmcoreinfo_init(void) · line 450

Quoted 4 lines
kernel/crash_core.c +1 -0
@@ -447,6 +447,7 @@ static int __init crash_save_vmcoreinfo_init(void)
 	VMCOREINFO_PAGESIZE(PAGE_SIZE);
 
 	VMCOREINFO_SYMBOL(init_uts_ns);
+	VMCOREINFO_OFFSET(uts_namespace, name);

Since the new symbol is exported, would you mind adding it to Documentation/kdump/vmcoreinfo.txt ?

Thanks.
Lianbo

Quoted 4 lines
kernel/crash_core.c +0 -0
 	VMCOREINFO_SYMBOL(node_online_map);
 #ifdef CONFIG_MMU
 	VMCOREINFO_SYMBOL_ARRAY(swapper_pg_dir);