Skip to contentSkip to conversation

arm64: dts: imx8mm-var-som: fix missing PMIC's interrupt line pull-up

PATCH Applied Krzysztof Kozlowski 5 participants 13 messages Sep 27, 2020 – Oct 30, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/6 arm64: dts: imx8mm-var-som: fix missing PMIC's interrupt line pull-up

The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration. The actual problem in DTS was pointed out by Felix Radensky from Variscite.

Fixes 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")
---
 arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi +3 -6
index 4107fe914d08..49082529764f 100644
@@ -135,13 +135,10 @@
 	pmic@4b {
 		compatible = "rohm,bd71847";
 		reg = <0x4b>;
+		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_pmic>;
 		interrupt-parent = <&gpio2>;
-		/*
-		 * The interrupt is not correct. It should be level low,
-		 * however with internal pull up this causes IRQ storm.
-		 */
-		interrupts = <8 IRQ_TYPE_EDGE_RISING>;
+		interrupts = <8 IRQ_TYPE_LEVEL_LOW>;
 		rohm,reset-snvs-powered;
 
 		#clock-cells = <0>;
@@ -398,7 +395,7 @@
 
 	pinctrl_pmic: pmicirqgrp {
 		fsl,pins = <
-			MX8MM_IOMUXC_SD1_DATA6_GPIO2_IO8	0x41
+			MX8MM_IOMUXC_SD1_DATA6_GPIO2_IO8	0x141
 		>;
 	};
 
Signature · 1 line
2.17.1
#1 lore raw

PATCH 2/6 arm64: dts: imx8mm-beacon-som: fix missing PMIC's interrupt line pull-up

The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration.

Fixes 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")
Fixes 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")
---
 arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi +1 -0
index 6de86a4f0ec4..55b36bddd513 100644
@@ -72,6 +72,7 @@
 	pmic@4b {
 		compatible = "rohm,bd71847";
 		reg = <0x4b>;
+		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_pmic>;
 		interrupt-parent = <&gpio1>;
 		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
Signature · 1 line
2.17.1
Tested-by on v1 2/6
#2 lore raw

Re: [PATCH 2/6] arm64: dts: imx8mm-beacon-som: fix missing PMIC's interrupt line pull-up

Quoted 5 lines · Krzysztof Kozlowski

The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration.

Thanks for the fixes!

Quoted 3 lines
Fixes 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")
Fixes 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")
Quoted 19 lines
---
 arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi +1 -1
index 6de86a4f0ec4..55b36bddd513 100644
@@ -72,6 +72,7 @@
        pmic@4b {
                compatible = "rohm,bd71847";
                reg = <0x4b>;
+               pinctrl-names = "default";
                pinctrl-0 = <&pinctrl_pmic>;
                interrupt-parent = <&gpio1>;
                interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
--

2.17.1

#3 lore raw

Re: [PATCH 2/6] arm64: dts: imx8mm-beacon-som: fix missing PMIC's interrupt line pull-up

Quoted 8 lines · Adam Ford
Quoted 5 lines · Krzysztof Kozlowski

The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration.

Quoted 8 lines

Thanks for the fixes!

Quoted 3 lines
Fixes 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")
Fixes 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")

Shawn,

Any chance you can apply this series? Without this patch, the pmic driver throws some splat due to a previous fix.

thanks

adam

Quoted 19 lines
Quoted 19 lines
---
 arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi +1 -1
index 6de86a4f0ec4..55b36bddd513 100644
@@ -72,6 +72,7 @@
        pmic@4b {
                compatible = "rohm,bd71847";
                reg = <0x4b>;
+               pinctrl-names = "default";
                pinctrl-0 = <&pinctrl_pmic>;
                interrupt-parent = <&gpio1>;
                interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
--

2.17.1

#4 lore raw

Re: [PATCH 2/6] arm64: dts: imx8mm-beacon-som: fix missing PMIC's interrupt line pull-up

Quoted 16 lines · Adam Ford
Quoted 14 lines · Adam Ford
Quoted 5 lines · Krzysztof Kozlowski

The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration.

Thanks for the fixes!

Quoted 3 lines
Fixes 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")
Fixes 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")
Quoted 7 lines
Quoted 2 lines

Shawn,

Any chance you can apply this series? Without this patch, the pmic driver throws some splat due to a previous fix.

I think Shawn applied it already yesterday or today.

Thanks for checking back on this.

Best regards,
Krzysztof

#5 lore raw

PATCH 3/6 arm64: dts: imx8mm-evk: fix missing PMIC's interrupt line pull-up

In reply to Krzysztof Kozlowski

The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration.

Fixes 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")
Fixes aa71d0648318 ("arm64: dts: imx8mm: Split the imx8mm evk board dts to a common dtsi")
---
 arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi +1 -0
index f305a530ff6f..521eb3a5a12e 100644
@@ -121,6 +121,7 @@
 	pmic@4b {
 		compatible = "rohm,bd71847";
 		reg = <0x4b>;
+		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_pmic>;
 		interrupt-parent = <&gpio1>;
 		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
Signature · 1 line
2.17.1
#6 lore raw

RE: [PATCH 3/6] arm64: dts: imx8mm-evk: fix missing PMIC's interrupt line pull-up

Add Robin Gong.

Quoted 29 lines

Subject: [PATCH 3/6] arm64: dts: imx8mm-evk: fix missing PMIC's interrupt line pull-up

The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration.

Fixes 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")
Fixes aa71d0648318 ("arm64: dts: imx8mm: Split the imx8mm evk board dts to

a common dtsi")

---
 arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi +1 -1
index f305a530ff6f..521eb3a5a12e 100644
@@ -121,6 +121,7 @@
 	pmic@4b {
 		compatible = "rohm,bd71847";
 		reg = <0x4b>;
+		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_pmic>;
 		interrupt-parent = <&gpio1>;
 		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
--
Quoted 1 line

2.17.1

Peter

Reviewed-by on v1 3/6
#7 lore raw

RE: [PATCH 3/6] arm64: dts: imx8mm-evk: fix missing PMIC's interrupt line pull-up

In reply to Krzysztof Kozlowski
Quoted 8 lines · On 2020/09/28 1:00 Krzysztof Kozlowski <[email protected]> wrote:

The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration.

Fixes 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")
Fixes aa71d0648318 ("arm64: dts: imx8mm: Split the imx8mm evk board dts

to a common dtsi")

Please tag me with the whole patch set, thanks.

Quoted 19 lines
---
 arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi +1 -1
index f305a530ff6f..521eb3a5a12e 100644
@@ -121,6 +121,7 @@
 	pmic@4b {
 		compatible = "rohm,bd71847";
 		reg = <0x4b>;
+		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_pmic>;
 		interrupt-parent = <&gpio1>;
 		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
--

2.17.1

#8 lore raw

PATCH 4/6 arm64: dts: imx8mn-var-som: fix missing PMIC's interrupt line pull-up

In reply to Krzysztof Kozlowski

The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration. The actual problem in DTS was pointed out by Felix Radensky from Variscite.

Fixes ade0176dd8a0 ("arm64: dts: imx8mn-var-som: Add Variscite VAR-SOM-MX8MN System on Module")
---
 arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi +3 -6
index a2d0190921e4..7f356edf9f91 100644
@@ -116,13 +116,10 @@
 	pmic@4b {
 		compatible = "rohm,bd71847";
 		reg = <0x4b>;
+		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_pmic>;
 		interrupt-parent = <&gpio2>;
-		/*
-		 * The interrupt is not correct. It should be level low,
-		 * however with internal pull up this causes IRQ storm.
-		 */
-		interrupts = <8 IRQ_TYPE_EDGE_RISING>;
+		interrupts = <8 IRQ_TYPE_LEVEL_LOW>;
 		rohm,reset-snvs-powered;
 
 		regulators {
@@ -388,7 +385,7 @@
 
 	pinctrl_pmic: pmicirqgrp {
 		fsl,pins = <
-			MX8MN_IOMUXC_SD1_DATA6_GPIO2_IO8	0x101
+			MX8MN_IOMUXC_SD1_DATA6_GPIO2_IO8	0x141
 		>;
 	};
 
Signature · 1 line
2.17.1
#9 lore raw

PATCH 5/6 arm64: dts: imx8mn-ddr4-evk: fix missing PMIC's interrupt line pull-up

In reply to Krzysztof Kozlowski

The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration.

Fixes 4153f7811a9b ("arm64: dts: imx8mn: correct interrupt flags")
Fixes 3e44dd09736d ("arm64: dts: imx8mn-ddr4-evk: Add rohm,bd71847 PMIC support")
---
 arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts +1 -0
index 46e76cf32b2f..7dfee715a2c4 100644
@@ -53,6 +53,7 @@
 	pmic@4b {
 		compatible = "rohm,bd71847";
 		reg = <0x4b>;
+		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_pmic>;
 		interrupt-parent = <&gpio1>;
 		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
Signature · 1 line
2.17.1
#10 lore raw

RE: [PATCH 5/6] arm64: dts: imx8mn-ddr4-evk: fix missing PMIC's interrupt line pull-up

Add Robin Gong.

Quoted 29 lines

Subject: [PATCH 5/6] arm64: dts: imx8mn-ddr4-evk: fix missing PMIC's interrupt line pull-up

The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration.

Fixes 4153f7811a9b ("arm64: dts: imx8mn: correct interrupt flags")
Fixes 3e44dd09736d ("arm64: dts: imx8mn-ddr4-evk: Add rohm,bd71847 PMIC

support")

---
 arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts +1 -1
index 46e76cf32b2f..7dfee715a2c4 100644
@@ -53,6 +53,7 @@
 	pmic@4b {
 		compatible = "rohm,bd71847";
 		reg = <0x4b>;
+		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_pmic>;
 		interrupt-parent = <&gpio1>;
 		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
--
Quoted 1 line

2.17.1

Peter

#11 lore raw

PATCH 6/6 arm64: dts: imx8mn-evk: fix missing PMIC's interrupt line pull-up

In reply to Krzysztof Kozlowski

The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration.

Fixes 4153f7811a9b ("arm64: dts: imx8mn: correct interrupt flags")
Fixes 6386156eb279 ("arm64: dts: imx8mn-evk: add pca9450 for i.mx8mn-evk board")
---
 arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/freescale/imx8mn-evk.dts +1 -0
index 707d8486b4d8..8311b95dee49 100644
@@ -18,6 +18,7 @@
 	pmic: pmic@25 {
 		compatible = "nxp,pca9450b";
 		reg = <0x25>;
+		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_pmic>;
 		interrupt-parent = <&gpio1>;
 		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
Signature · 1 line
2.17.1
Applied
#12 lore raw
In reply to Krzysztof Kozlowski
Quoted 8 lines · Krzysztof Kozlowski

The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration. The actual problem in DTS was pointed out by Felix Radensky from Variscite.

Fixes 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")

Applied all, thanks.