arm64: dts: imx8mm-var-som: fix missing PMIC's interrupt line pull-up
Subsystems (2)
PATCH 1/6 arm64: dts: imx8mm-var-som: fix missing PMIC's interrupt line pull-up
The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration. The actual problem in DTS was pointed out by Felix Radensky from Variscite.
--- arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi +3 -6
@@ -135,13 +135,10 @@ pmic@4b { compatible = "rohm,bd71847"; reg = <0x4b>; + pinctrl-names = "default"; pinctrl-0 = <&pinctrl_pmic>; interrupt-parent = <&gpio2>; - /* - * The interrupt is not correct. It should be level low, - * however with internal pull up this causes IRQ storm. - */ - interrupts = <8 IRQ_TYPE_EDGE_RISING>; + interrupts = <8 IRQ_TYPE_LEVEL_LOW>; rohm,reset-snvs-powered; #clock-cells = <0>;
@@ -398,7 +395,7 @@ pinctrl_pmic: pmicirqgrp { fsl,pins = < - MX8MM_IOMUXC_SD1_DATA6_GPIO2_IO8 0x41 + MX8MM_IOMUXC_SD1_DATA6_GPIO2_IO8 0x141 >; };
Signature · 1 line
2.17.1
PATCH 2/6 arm64: dts: imx8mm-beacon-som: fix missing PMIC's interrupt line pull-up
The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration.
--- arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi +1 -0
@@ -72,6 +72,7 @@ pmic@4b { compatible = "rohm,bd71847"; reg = <0x4b>; + pinctrl-names = "default"; pinctrl-0 = <&pinctrl_pmic>; interrupt-parent = <&gpio1>; interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
Signature · 1 line
2.17.1
PATCH 3/6 arm64: dts: imx8mm-evk: fix missing PMIC's interrupt line pull-up
In reply to Krzysztof KozlowskiThe PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration.
--- arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi +1 -0
@@ -121,6 +121,7 @@ pmic@4b { compatible = "rohm,bd71847"; reg = <0x4b>; + pinctrl-names = "default"; pinctrl-0 = <&pinctrl_pmic>; interrupt-parent = <&gpio1>; interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
Signature · 1 line
2.17.1
PATCH 4/6 arm64: dts: imx8mn-var-som: fix missing PMIC's interrupt line pull-up
In reply to Krzysztof KozlowskiThe PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration. The actual problem in DTS was pointed out by Felix Radensky from Variscite.
--- arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi +3 -6
@@ -116,13 +116,10 @@ pmic@4b { compatible = "rohm,bd71847"; reg = <0x4b>; + pinctrl-names = "default"; pinctrl-0 = <&pinctrl_pmic>; interrupt-parent = <&gpio2>; - /* - * The interrupt is not correct. It should be level low, - * however with internal pull up this causes IRQ storm. - */ - interrupts = <8 IRQ_TYPE_EDGE_RISING>; + interrupts = <8 IRQ_TYPE_LEVEL_LOW>; rohm,reset-snvs-powered; regulators {
@@ -388,7 +385,7 @@ pinctrl_pmic: pmicirqgrp { fsl,pins = < - MX8MN_IOMUXC_SD1_DATA6_GPIO2_IO8 0x101 + MX8MN_IOMUXC_SD1_DATA6_GPIO2_IO8 0x141 >; };
Signature · 1 line
2.17.1
PATCH 5/6 arm64: dts: imx8mn-ddr4-evk: fix missing PMIC's interrupt line pull-up
In reply to Krzysztof KozlowskiThe PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration.
--- arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts +1 -0
@@ -53,6 +53,7 @@ pmic@4b { compatible = "rohm,bd71847"; reg = <0x4b>; + pinctrl-names = "default"; pinctrl-0 = <&pinctrl_pmic>; interrupt-parent = <&gpio1>; interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
Signature · 1 line
2.17.1
PATCH 6/6 arm64: dts: imx8mn-evk: fix missing PMIC's interrupt line pull-up
In reply to Krzysztof KozlowskiThe PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration.
--- arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm64/boot/dts/freescale/imx8mn-evk.dts +1 -0
@@ -18,6 +18,7 @@ pmic: pmic@25 { compatible = "nxp,pca9450b"; reg = <0x25>; + pinctrl-names = "default"; pinctrl-0 = <&pinctrl_pmic>; interrupt-parent = <&gpio1>; interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
Signature · 1 line
2.17.1
RE: [PATCH 3/6] arm64: dts: imx8mm-evk: fix missing PMIC's interrupt line pull-up
In reply to Krzysztof KozlowskiAdd Robin Gong.
Quoted 29 lines
Subject: [PATCH 3/6] arm64: dts: imx8mm-evk: fix missing PMIC's interrupt line pull-up
The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration.
Fixes 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")Fixes aa71d0648318 ("arm64: dts: imx8mm: Split the imx8mm evk board dts toa common dtsi")
Signed-off-by Krzysztof Kozlowski <[email protected]>--- arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 1 + 1 file changed, 1 insertion(+)arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi +1
-1@@ -121,6 +121,7 @@ pmic@4b { compatible = "rohm,bd71847"; reg = <0x4b>; + pinctrl-names = "default"; pinctrl-0 = <&pinctrl_pmic>; interrupt-parent = <&gpio1>; interrupts = <3 IRQ_TYPE_LEVEL_LOW>; --
Quoted 1 line
2.17.1
Peter
RE: [PATCH 5/6] arm64: dts: imx8mn-ddr4-evk: fix missing PMIC's interrupt line pull-up
In reply to Krzysztof KozlowskiAdd Robin Gong.
Quoted 29 lines
Subject: [PATCH 5/6] arm64: dts: imx8mn-ddr4-evk: fix missing PMIC's interrupt line pull-up
The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration.
Fixes 4153f7811a9b ("arm64: dts: imx8mn: correct interrupt flags")Fixes 3e44dd09736d ("arm64: dts: imx8mn-ddr4-evk: Add rohm,bd71847 PMICsupport")
Signed-off-by Krzysztof Kozlowski <[email protected]>--- arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts | 1 + 1 file changed, 1 insertion(+)arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts +1
-1@@ -53,6 +53,7 @@ pmic@4b { compatible = "rohm,bd71847"; reg = <0x4b>; + pinctrl-names = "default"; pinctrl-0 = <&pinctrl_pmic>; interrupt-parent = <&gpio1>; interrupts = <3 IRQ_TYPE_LEVEL_LOW>; --
Quoted 1 line
2.17.1
Peter
RE: [PATCH 3/6] arm64: dts: imx8mm-evk: fix missing PMIC's interrupt line pull-up
In reply to Krzysztof KozlowskiQuoted 8 lines · On 2020/09/28 1:00 Krzysztof Kozlowski <[email protected]> wrote:
The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration.
Fixes 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")Fixes aa71d0648318 ("arm64: dts: imx8mm: Split the imx8mm evk board dtsto a common dtsi")
Signed-off-by Krzysztof Kozlowski <[email protected]>
Please tag me with the whole patch set, thanks.
Quoted 19 lines
--- arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 1 + 1 file changed, 1 insertion(+)arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi +1
-1@@ -121,6 +121,7 @@ pmic@4b { compatible = "rohm,bd71847"; reg = <0x4b>; + pinctrl-names = "default"; pinctrl-0 = <&pinctrl_pmic>; interrupt-parent = <&gpio1>; interrupts = <3 IRQ_TYPE_LEVEL_LOW>; --2.17.1
Re: [PATCH 2/6] arm64: dts: imx8mm-beacon-som: fix missing PMIC's interrupt line pull-up
In reply to Krzysztof KozlowskiQuoted 5 lines · Krzysztof Kozlowski
The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration.
Thanks for the fixes!
Quoted 3 lines
Fixes 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")Fixes 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")Signed-off-by Krzysztof Kozlowski <[email protected]>
Quoted 19 lines
--- arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi | 1 + 1 file changed, 1 insertion(+)arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi +1
-1@@ -72,6 +72,7 @@ pmic@4b { compatible = "rohm,bd71847"; reg = <0x4b>; + pinctrl-names = "default"; pinctrl-0 = <&pinctrl_pmic>; interrupt-parent = <&gpio1>; interrupts = <3 IRQ_TYPE_LEVEL_LOW>; --2.17.1
Shawn Guo
AppliedQuoted 8 lines · Krzysztof Kozlowski
The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration. The actual problem in DTS was pointed out by Felix Radensky from Variscite.
Reported-by Felix Radensky <[email protected]>Fixes 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")Signed-off-by Krzysztof Kozlowski <[email protected]>
Applied all, thanks.
Re: [PATCH 2/6] arm64: dts: imx8mm-beacon-som: fix missing PMIC's interrupt line pull-up
In reply to Adam FordQuoted 8 lines · Adam Ford
Quoted 5 lines · Krzysztof Kozlowski
The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration.
Quoted 8 lines
Thanks for the fixes!
Quoted 3 lines
Fixes 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")Fixes 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")Signed-off-by Krzysztof Kozlowski <[email protected]>Tested-by Adam Ford <[email protected]>
Shawn,
Any chance you can apply this series? Without this patch, the pmic driver throws some splat due to a previous fix.
thanks
adam
Quoted 19 lines
Quoted 19 lines
--- arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi | 1 + 1 file changed, 1 insertion(+)arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi +1
-1@@ -72,6 +72,7 @@ pmic@4b { compatible = "rohm,bd71847"; reg = <0x4b>; + pinctrl-names = "default"; pinctrl-0 = <&pinctrl_pmic>; interrupt-parent = <&gpio1>; interrupts = <3 IRQ_TYPE_LEVEL_LOW>; --2.17.1
Re: [PATCH 2/6] arm64: dts: imx8mm-beacon-som: fix missing PMIC's interrupt line pull-up
Quoted 16 lines · Adam Ford
Quoted 14 lines · Adam Ford
Quoted 5 lines · Krzysztof Kozlowski
The PMIC's interrupt is level low and should be pulled up. The PMIC's device node had pinctrl-0 property but it lacked pinctrl-names which is required to apply the pin configuration.
Thanks for the fixes!
Quoted 3 lines
Fixes 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")Fixes 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")Signed-off-by Krzysztof Kozlowski <[email protected]>
Quoted 7 lines
Quoted 2 lines
Tested-by Adam Ford <[email protected]>Shawn,
Any chance you can apply this series? Without this patch, the pmic driver throws some splat due to a previous fix.
I think Shawn applied it already yesterday or today.
Thanks for checking back on this.
Best regards,
Krzysztof