Documentation: dt: binding: fsl: Add 'fsl,ippdexpcr1-alt-reg' property
Subsystems (2)
PATCH v3 1/5 Documentation: dt: binding: fsl: Add 'fsl,ippdexpcr1-alt-reg' property
From: Biwen Li <[email protected]>
The 'fsl,ippdexpcr1-alt-reg' property is used to handle an errata A-008646 on LS1021A.
---
Change in v3:
- Simplize related proterty definition and rename it.
Change in v2:
- None
Documentation/devicetree/bindings/soc/fsl/rcpm.txt | 12 ++++++++++++ 1 file changed, 12 insertions(+)
Documentation/devicetree/bindings/soc/fsl/rcpm.txt +12 -0
@@ -34,6 +34,9 @@ Chassis Version Example Chips Optional properties: - little-endian : RCPM register block is Little Endian. Without it RCPM will be Big Endian (default case). + - fsl,ippdexpcr1-alt-reg : The property is trying to workaround a + hardware issue (found on SoC LS1021A only), if pressent, RCPM driver + will use SCFG_SPARECR8 as a shadow register for RCPM_IPPDEXPCR1. Example: The RCPM node for T4240:
@@ -43,6 +46,15 @@ The RCPM node for T4240: #fsl,rcpm-wakeup-cells = <2>; }; +The RCPM node for LS1021A: + rcpm: rcpm@1ee2140 { + compatible = "fsl,ls1021a-rcpm", "fsl,qoriq-rcpm-2.1+"; + reg = <0x0 0x1ee2140 0x0 0x8>; + #fsl,rcpm-wakeup-cells = <2>; + fsl,ippdexpcr1-alt-reg; + }; + + * Freescale RCPM Wakeup Source Device Tree Bindings ------------------------------------------- Required fsl,rcpm-wakeup property should be added to a device node if the device
Signature · 1 line
2.7.4
PATCH v3 2/5 soc: fsl: handle RCPM errata A-008646 on SoC LS1021A
From: Biwen Li <[email protected]>
Hardware issue:
- Reading register RCPM_IPPDEXPCR1 always return zero, this causes system firmware could not get correct information and wrongly do clock gating for all wakeup source IP during system suspend. Then those IPs will never get chance to wake system.
Workaround:
- Copy register RCPM_IPPDEXPCR1's setting to register SCFG_SPARECR8 to allow system firmware's psci method read it and do things accordingly.
---
Change in v3:
- Add copy_ippdexpcr1_setting(), simplize workaournd's implementation according to binding update.
- Minor update on commit message.
Change in v2:
- Update commit message to be more clear.
- Replace device_property_read_u32_array() with syscon_regmap_lookup_by_phandle_args() to make code simpler.
drivers/soc/fsl/rcpm.c | 35 ++++++++++++++++++++++++++++++++++- 1 file changed, 34 insertions(+), 1 deletion(-)
drivers/soc/fsl/rcpm.c +34 -1
@@ -2,7 +2,7 @@// // rcpm.c - Freescale QorIQ RCPM driver // -// Copyright 2019 NXP +// Copyright 2019-2020 NXP // // Author: Ran Wang <[email protected]>
@@ -22,6 +22,28 @@ struct rcpm {bool little_endian; }; +#define SCFG_SPARECR8 0x051c + +static void copy_ippdexpcr1_setting (u32 val) +{ +struct device_node *np; +void __iomem *regs; +u32 reg_val; + + np =of_find_compatible_node (NULL ,NULL ,"fsl,ls1021a-scfg" ); +if (!np) +return ; + + regs =of_iomap (np,0 ); +if (!regs) +return ; + + reg_val =ioread32be (regs +SCFG_SPARECR8 ); +iowrite32be (val | reg_val, regs +SCFG_SPARECR8 ); + +iounmap (regs); +} +/** * rcpm_pm_prepare - performs device-level tasks associated with power * management, such as programming related to the wakeup source control.
@@ -90,6 +112,17 @@ static int rcpm_pm_prepare(struct device *dev) tmp |=ioread32be (address);iowrite32be (tmp, address); } +/* +* Workaround of errata A-008646 on SoC LS1021A: +* There is a bug of register ippdexpcr1. +* Reading configuration register RCPM_IPPDEXPCR1 +* always return zero. So save ippdexpcr1's value +* to register SCFG_SPARECR8.And the value of +* ippdexpcr1 will be read from SCFG_SPARECR8. +*/ +if (dev_of_node (dev) && (i ==1 )) +if (device_property_read_bool (dev,"fsl,ippdexpcr1-alt-reg" )) +copy_ippdexpcr1_setting (tmp); }return 0 ;
Signature · 1 line
2.7.4
PATCH v3 3/5 arm: dts: ls1021a: enable RCPM workaround for erratum A-008646
In reply to Ran WangFrom: Biwen Li <[email protected]>
The patch fixes a bug that FlexTimer cannot
wakeup system in deep sleep.
---
Change in v3:
- Update proterty according to binding and driver change.
Change in v2:
- Change subject of commit message to be consistent with other related patches.
arch/arm/boot/dts/ls1021a.dtsi | 1 + 1 file changed, 1 insertion(+)
arch/arm/boot/dts/ls1021a.dtsi +1 -0
@@ -1007,6 +1007,7 @@ compatible = "fsl,ls1021a-rcpm", "fsl,qoriq-rcpm-2.1+"; reg = <0x0 0x1ee2140 0x0 0x8>; #fsl,rcpm-wakeup-cells = <2>; + fsl,ippdexpcr1-alt-reg; }; ftm_alarm0: timer0@29d0000 {
Signature · 1 line
2.7.4
PATCH v3 4/5 arm: dts: ls1021a: fix flextimer failed to wake system
In reply to Ran WangThe data of property 'fsl,rcpm-wakeup' is not corrcet, which causing RCPM driver incorrectly program register IPPDEXPCR1, then flextimer is wrongly clock gated during system suspend, can't send interrupt to wake.
---
Change in v3:
- None
Change in v2:
- None
arch/arm/boot/dts/ls1021a.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/ls1021a.dtsi +1 -1
@@ -1014,7 +1014,7 @@ compatible = "fsl,ls1021a-ftm-alarm"; reg = <0x0 0x29d0000 0x0 0x10000>; reg-names = "ftm"; - fsl,rcpm-wakeup = <&rcpm 0x20000 0x0>; + fsl,rcpm-wakeup = <&rcpm 0x0 0x20000000>; interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>; big-endian; };
Signature · 1 line
2.7.4
PATCH v3 5/5 arm: dts: ls1021a: fix rcpm failed to claim resource
In reply to Ran WangThe range of dcfg reg is wrong, which overlap with other device, such as rcpm. This issue causing rcpm driver failed to claim reg resource when calling devm_ioremap_resource().
---
Change in v3:
- None
Change in v2:
- None
arch/arm/boot/dts/ls1021a.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/ls1021a.dtsi +1 -1
@@ -173,7 +173,7 @@ dcfg: dcfg@1ee0000 { compatible = "fsl,ls1021a-dcfg", "syscon"; - reg = <0x0 0x1ee0000 0x0 0x10000>; + reg = <0x0 0x1ee0000 0x0 0x1000>; big-endian; };
Signature · 1 line
2.7.4
Hi Rob,
Quoted 11 lines · Ran Wang
From: Biwen Li <[email protected]>
The 'fsl,ippdexpcr1-alt-reg' property is used to handle an errata A-008646 on LS1021A.
Signed-off-by Biwen Li <[email protected]>Signed-off-by Ran Wang <[email protected]>---
Change in v3:
- Simplize related proterty definition and rename it.
Could you please comment for this version? Thanks in advance.
Regards,
Ran
Quoted 37 lines
Change in v2:
- NoneDocumentation/devicetree/bindings/soc/fsl/rcpm.txt | 12 ++++++++++++ 1 file changed, 12 insertions(+)Documentation/devicetree/bindings/soc/fsl/rcpm.txt +12
-0@@ -34,6 +34,9 @@ Chassis Version Example Chips Optional properties: - little-endian : RCPM register block is Little Endian. Without it RCPM will be Big Endian (default case). + - fsl,ippdexpcr1-alt-reg : The property is trying to workaround a + hardware issue (found on SoC LS1021A only), if pressent, RCPM driver + will use SCFG_SPARECR8 as a shadow register for RCPM_IPPDEXPCR1. Example: The RCPM node for T4240:@@ -43,6 +46,15 @@ The RCPM node for T4240: #fsl,rcpm-wakeup-cells = <2>; }; +The RCPM node for LS1021A: + rcpm: rcpm@1ee2140 { + compatible = "fsl,ls1021a-rcpm", "fsl,qoriq-rcpm-2.1+"; + reg = <0x0 0x1ee2140 0x0 0x8>; + #fsl,rcpm-wakeup-cells = <2>; + fsl,ippdexpcr1-alt-reg; + }; + + * Freescale RCPM Wakeup Source Device Tree Bindings ------------------------------------------- Required fsl,rcpm-wakeup property should be added to a device node if the
Quoted 3 lines
device
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel