Skip to contentSkip to conversation

hw/char/serial: remove duplicate .class_init in serial_mm_info

PATCH Applied Laurent Vivier 5 participants 8 messages Oct 9, 2020 – Oct 12, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 hw/char/serial: remove duplicate .class_init in serial_mm_info

.class_init is already set to serial_mm_class_init.

Remove the duplicate entry.

Fixes 17fd1a6490b1 ("serial-mm: add "regshift" property")
---
 hw/char/serial.c | 1 -
 1 file changed, 1 deletion(-)
hw/char/serial.c +0 -1
index 4386adabd466..97f71879ff2a 100644
@@ -1120,7 +1120,6 @@ static const TypeInfo serial_mm_info = {
     .class_init = serial_mm_class_init,
     .instance_init = serial_mm_instance_init,
     .instance_size = sizeof(SerialMM),
-    .class_init = serial_mm_class_init,
 };
 
 static void serial_register_types(void)
Signature · 1 line
2.26.2
#1 lore raw

PATCH 2/2 goldfish_rtc: change MemoryRegionOps endianness to DEVICE_NATIVE_ENDIAN

The doc [1] doesn't define the endianness, but the kernel driver uses readl() to access the registers, so we can guess it depends on the architecture endianness.

As riscv architecture endianness is little it might not change anything for it.

Moreover, android implementation uses DEVICE_NATIVE_ENDIAN [2]

[1] https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-HARDWARE.TXT
[2] https://android.googlesource.com/platform/external/qemu/+/refs/heads/emu-master-dev/hw/timer/goldfish_timer.c#177

Fixes 9a5b40b84279 ("hw: rtc: Add Goldfish RTC device")
---
 hw/rtc/goldfish_rtc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/rtc/goldfish_rtc.c +1 -1
index 6ddd45cce039..0f4e8185a796 100644
@@ -217,7 +217,7 @@ static int goldfish_rtc_post_load(void *opaque, int version_id)
 static const MemoryRegionOps goldfish_rtc_ops = {
     .read = goldfish_rtc_read,
     .write = goldfish_rtc_write,
-    .endianness = DEVICE_LITTLE_ENDIAN,
+    .endianness = DEVICE_NATIVE_ENDIAN,
     .valid = {
         .min_access_size = 4,
         .max_access_size = 4
Signature · 1 line
2.26.2
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] goldfish_rtc: change MemoryRegionOps endianness to DEVICE_NATIVE_ENDIAN

Quoted 8 lines · Laurent Vivier

The doc [1] doesn't define the endianness, but the kernel driver uses readl() to access the registers, so we can guess it depends on the architecture endianness.

As riscv architecture endianness is little it might not change anything for it.

Quoted 8 lines

Moreover, android implementation uses DEVICE_NATIVE_ENDIAN [2]

[1] https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-HARDWARE.TXT
[2] https://android.googlesource.com/platform/external/qemu/+/refs/heads/emu-master-dev/hw/timer/goldfish_timer.c#177

Fixes 9a5b40b84279 ("hw: rtc: Add Goldfish RTC device")

Alistair

Quoted 21 lines
---
 hw/rtc/goldfish_rtc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/rtc/goldfish_rtc.c +1 -2
index 6ddd45cce039..0f4e8185a796 100644
@@ -217,7 +217,7 @@ static int goldfish_rtc_post_load(void *opaque, int version_id)
 static const MemoryRegionOps goldfish_rtc_ops = {
     .read = goldfish_rtc_read,
     .write = goldfish_rtc_write,
-    .endianness = DEVICE_LITTLE_ENDIAN,
+    .endianness = DEVICE_NATIVE_ENDIAN,
     .valid = {
         .min_access_size = 4,
         .max_access_size = 4
--

2.26.2

#3 lore raw

Re: [PATCH 2/2] goldfish_rtc: change MemoryRegionOps endianness to DEVICE_NATIVE_ENDIAN

In reply to Laurent Vivier

Le 09/10/2020 à 13:38, Laurent Vivier a écrit :

Quoted 25 lines

The doc [1] doesn't define the endianness, but the kernel driver uses readl() to access the registers, so we can guess it depends on the architecture endianness.

As riscv architecture endianness is little it might not change anything for it.

Moreover, android implementation uses DEVICE_NATIVE_ENDIAN [2]

[1] https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-HARDWARE.TXT
[2] https://android.googlesource.com/platform/external/qemu/+/refs/heads/emu-master-dev/hw/timer/goldfish_timer.c#177

Fixes 9a5b40b84279 ("hw: rtc: Add Goldfish RTC device")
---
 hw/rtc/goldfish_rtc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/rtc/goldfish_rtc.c +0 -0
index 6ddd45cce039..0f4e8185a796 100644

hw/rtc/goldfish_rtc.c static int goldfish_rtc_post_load(void *opaque, int version_id) · line 223

Quoted 8 lines
hw/rtc/goldfish_rtc.c +1 -1
@@ -217,7 +217,7 @@ static int goldfish_rtc_post_load(void *opaque, int version_id)
 static const MemoryRegionOps goldfish_rtc_ops = {
     .read = goldfish_rtc_read,
     .write = goldfish_rtc_write,
-    .endianness = DEVICE_LITTLE_ENDIAN,
+    .endianness = DEVICE_NATIVE_ENDIAN,
     .valid = {
         .min_access_size = 4,
         .max_access_size = 4

Applied to my trivial-patches branch.

Thanks,
Laurent

Reviewed-by on v1 1/2
#4 lore raw
In reply to Laurent Vivier
Quoted 6 lines · Laurent Vivier

.class_init is already set to serial_mm_class_init.

Remove the duplicate entry.

Fixes 17fd1a6490b1 ("serial-mm: add "regshift" property")

I was going to send exactly the same one tomorrow =)

Quoted 18 lines
---
  hw/char/serial.c | 1 -
  1 file changed, 1 deletion(-)
hw/char/serial.c +0 -1
index 4386adabd466..97f71879ff2a 100644
@@ -1120,7 +1120,6 @@ static const TypeInfo serial_mm_info = {
      .class_init = serial_mm_class_init,
      .instance_init = serial_mm_instance_init,
      .instance_size = sizeof(SerialMM),
-    .class_init = serial_mm_class_init,
  };
 
  static void serial_register_types(void)
Reviewed-by on v1 1/2
#5 lore raw
In reply to Laurent Vivier
Quoted 8 lines · Laurent Vivier <[email protected]> 于2020年10月9日周五 下午7:40写道:

.class_init is already set to serial_mm_class_init.

Remove the duplicate entry.

Fixes 17fd1a6490b1 ("serial-mm: add "regshift" property")
Quoted 20 lines
---
 hw/char/serial.c | 1 -
 1 file changed, 1 deletion(-)
hw/char/serial.c +0 -2
index 4386adabd466..97f71879ff2a 100644
@@ -1120,7 +1120,6 @@ static const TypeInfo serial_mm_info = {
     .class_init = serial_mm_class_init,
     .instance_init = serial_mm_instance_init,
     .instance_size = sizeof(SerialMM),
-    .class_init = serial_mm_class_init,
 };
 
 static void serial_register_types(void)
--

2.26.2

Reviewed-by on v1 1/2
#6 lore raw
In reply to Laurent Vivier
Quoted 8 lines · Laurent Vivier

.class_init is already set to serial_mm_class_init.

Remove the duplicate entry.

Fixes 17fd1a6490b1 ("serial-mm: add "regshift" property")

Alistair

Quoted 20 lines
---
 hw/char/serial.c | 1 -
 1 file changed, 1 deletion(-)
hw/char/serial.c +0 -2
index 4386adabd466..97f71879ff2a 100644
@@ -1120,7 +1120,6 @@ static const TypeInfo serial_mm_info = {
     .class_init = serial_mm_class_init,
     .instance_init = serial_mm_instance_init,
     .instance_size = sizeof(SerialMM),
-    .class_init = serial_mm_class_init,
 };
 
 static void serial_register_types(void)
--

2.26.2

#7 lore raw
In reply to Laurent Vivier

Le 09/10/2020 à 13:38, Laurent Vivier a écrit :

Quoted 17 lines

.class_init is already set to serial_mm_class_init.

Remove the duplicate entry.

Fixes 17fd1a6490b1 ("serial-mm: add "regshift" property")
---
 hw/char/serial.c | 1 -
 1 file changed, 1 deletion(-)
hw/char/serial.c +0 -0
index 4386adabd466..97f71879ff2a 100644

hw/char/serial.c static const TypeInfo serial_mm_info = { · line 1125

Quoted 7 lines
hw/char/serial.c +0 -1
@@ -1120,7 +1120,6 @@ static const TypeInfo serial_mm_info = {
     .class_init = serial_mm_class_init,
     .instance_init = serial_mm_instance_init,
     .instance_size = sizeof(SerialMM),
-    .class_init = serial_mm_class_init,
 };
 
 static void serial_register_types(void)

Applied to my trivial-patches branch.

Thanks,
Laurent