Skip to contentSkip to conversation

dt-bindings: gpio: pca953x: Add support for the NXP PCAL9554B/C

PATCH Superseded Mike Looijmans 4 participants 6 messages Oct 9, 2020 – Nov 10, 2020 1 message not in the archive

Subsystems (2)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 dt-bindings: gpio: pca953x: Add support for the NXP PCAL9554B/C

The NXP PCAL9554B is a variant of the PCA953x GPIO expander, with 8 GPIOs, latched interrupts and some advanced configuration options. The "C" version only differs in I2C address.

This adds the entry to the devicetree bindings.

---
v2: Split devicetree and code into separate patches
v3: Devicetree bindings in yaml format

 Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml +1 -0
index 183ec23eda39..f5ee23c2df60 100644
@@ -48,6 +48,7 @@ properties:
       - nxp,pcal6416
       - nxp,pcal6524
       - nxp,pcal9535
+      - nxp,pcal9554b
       - nxp,pcal9555a
       - onnn,cat9554
       - onnn,pca9654
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 6 lines · Mike Looijmans

The NXP PCAL9554B is a variant of the PCA953x GPIO expander, with 8 GPIOs, latched interrupts and some advanced configuration options. The "C" version only differs in I2C address.

This adds the entry to the devicetree bindings.

Quoted 8 lines

---
v2: Split devicetree and code into separate patches
v3: Devicetree bindings in yaml format

 Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 1 +
 1 file changed, 1 insertion(+)

Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply.

If a tag was not added on purpose, please state why and what changed.

#2 lore raw
In reply to Mike Looijmans
Quoted 28 lines · Mike Looijmans

The NXP PCAL9554B is a variant of the PCA953x GPIO expander, with 8 GPIOs, latched interrupts and some advanced configuration options. The "C" version only differs in I2C address.

This adds the entry to the devicetree bindings.

---
v2: Split devicetree and code into separate patches
v3: Devicetree bindings in yaml format

 Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml +1 -1
index 183ec23eda39..f5ee23c2df60 100644
@@ -48,6 +48,7 @@ properties:
       - nxp,pcal6416
       - nxp,pcal6524
       - nxp,pcal9535
+      - nxp,pcal9554b
       - nxp,pcal9555a
       - onnn,cat9554
       - onnn,pca9654
--
Quoted 2 lines

2.17.1

Hi Mike,

please resend this rebased on top of v5.10-rc1 with tags collected if you still want it merged.

Bartosz

#3 lore raw
In reply to Mike Looijmans

Hi Mike!

thanks for your patch.

Quoted 3 lines · Mike Looijmans

- nxp,pcal9535
+ - nxp,pcal9554b
- nxp,pcal9555a

This triggers my OCD. Putting B before A? Please make it alphabetic.

No big deal, but...

Yours,
Linus Walleij

#4 lore raw

Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert

TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands

T: +31 (0) 499 33 69 69
E: [email protected]
W: www.topicproducts.com

Please consider the environment before printing this e-mail

Quoted 11 lines · Linus Walleij

Hi Mike!

thanks for your patch.

Quoted 3 lines · Mike Looijmans

- nxp,pcal9535
+ - nxp,pcal9554b
- nxp,pcal9555a

This triggers my OCD. Putting B before A? Please make it alphabetic.

Nothing wrong with a bit of OCD, it's probably in our job description :)

But there's a "4" before the "5" too.

Quoted 6 lines

No big deal, but...

Yours,
Linus Walleij

#5 lore raw
Quoted 7 lines · Mike Looijmans
Quoted 6 lines · Linus Walleij
Quoted 3 lines · Mike Looijmans

- nxp,pcal9535
+ - nxp,pcal9554b
- nxp,pcal9555a

Quoted 5 lines
Quoted 1 line

This triggers my OCD. Putting B before A? Please make it alphabetic.

Nothing wrong with a bit of OCD, it's probably in our job description :)

But there's a "4" before the "5" too.

My perception isn't as good as my OCD apparently :D

This is already merged anyways, no big deal.

Yours,
Linus Walleij