dt-bindings: fxas21002c: convert bindings to yaml

PATCH In review Rui Miguel Silva 3 participants 5 messages Oct 14, 2020 – Oct 19, 2020

Subsystems (3)

Device tree bindings IIO NXP FXAS21002C driver

lore

Share & tools

lore

Rui Miguel Silva

author

2020-10-14 10:51 UTC #0 lore raw

PATCH v2 1/1 dt-bindings: fxas21002c: convert bindings to yaml

Convert fxas21002c gyroscope sensor bindings documentation to
yaml schema, remove the textual bindings document and update MAINTAINERS entry.

Signed-off-by Rui Miguel Silva <[email protected]>

---
v1 -> v2:
Jonathan Cameron:
https://lore.kernel.org/linux-iio/[email protected]/
- remove Unit from tittle
- reword interrupts description
- drop interrupt-name description
- add spi example and bindings
- remove vddxx from required list

 .../bindings/iio/gyroscope/nxp,fxas21002c.txt | 31 ------
 .../iio/gyroscope/nxp,fxas21002c.yaml         | 95 +++++++++++++++++++
 MAINTAINERS                                   |  2 +-
 3 files changed, 96 insertions(+), 32 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.txt
 create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.yaml

Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.txt deleted +0 ~~-31~~

deleted file mode 100644
index 465e104bbf14..000000000000
@@ -1,31 +0,0 @@
-* NXP FXAS21002C Gyroscope device tree bindings
-
-http://www.nxp.com/products/sensors/gyroscopes/3-axis-digital-gyroscope:FXAS21002C
-
-Required properties:
-  - compatible : should be "nxp,fxas21002c"
-  - reg : the I2C address of the sensor or SPI chip select number for the
-          device.
-  - vdd-supply: phandle to the regulator that provides power to the sensor.
-  - vddio-supply: phandle to the regulator that provides power to the bus.
-
-Optional properties:
-  - reset-gpios : gpio used to reset the device, see gpio/gpio.txt
-  - interrupts : device support 2 interrupts, INT1 and INT2,
-                 the interrupts can be triggered on rising or falling edges.
-                 See interrupt-controller/interrupts.txt
-  - interrupt-names: should contain "INT1" or "INT2", the gyroscope interrupt
-                     line in use.
-  - drive-open-drain: the interrupt/data ready line will be configured
-                      as open drain, which is useful if several sensors share
-                      the same interrupt line. This is a boolean property.
-                      (This binding is taken from pinctrl/pinctrl-bindings.txt)
-
-Example:
-
-gyroscope@20 {
-	compatible = "nxp,fxas21002c";
-	reg = <0x20>;
-	vdd-supply = <&reg_peri_3p15v>;
-	vddio-supply = <&reg_peri_3p15v>;
-};

Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.yaml new file +95 -0

95 lines not on this page · raw message

MAINTAINERS +1 -1

index 6594f0966716..2e85e114c9c3 100644
@@ -12469,7 +12469,7 @@ NXP FXAS21002C DRIVER
 M:	Rui Miguel Silva <[email protected]>
 L:	[email protected]
 S:	Maintained
-F:	Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.txt
+F:	Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.yaml
 F:	drivers/iio/gyro/fxas21002c.h
 F:	drivers/iio/gyro/fxas21002c_core.c
 F:	drivers/iio/gyro/fxas21002c_i2c.c

Signature · 1 line

2.28.0

Rob Herring

maintainer Reviewed-by on v2 1/1

2020-10-16 19:00 UTC #1 lore raw

Quoted 14 lines · Rui Miguel Silva

Convert fxas21002c gyroscope sensor bindings documentation to
yaml schema, remove the textual bindings document and update MAINTAINERS entry.
Signed-off-by Rui Miguel Silva <[email protected]>
---
v1 -> v2:
Jonathan Cameron:
https://lore.kernel.org/linux-iio/[email protected]/
- remove Unit from tittle
- reword interrupts description
- drop interrupt-name description
- add spi example and bindings
- remove vddxx from required list

Quoted 7 lines

 .../bindings/iio/gyroscope/nxp,fxas21002c.txt | 31 ------
 .../iio/gyroscope/nxp,fxas21002c.yaml         | 95 +++++++++++++++++++
 MAINTAINERS                                   |  2 +-
 3 files changed, 96 insertions(+), 32 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.txt
 create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.yaml

Reviewed-by Rob Herring <[email protected]>

Jonathan Cameron

maintainer

2020-10-18 11:00 UTC #2 lore raw

Quoted 23 lines · On Fri, 16 Oct 2020 13:57:07 -0500 Rob Herring <[email protected]> wrote:

Quoted 14 lines · Rui Miguel Silva
Convert fxas21002c gyroscope sensor bindings documentation to
yaml schema, remove the textual bindings document and update MAINTAINERS entry.
Signed-off-by Rui Miguel Silva <[email protected]>
---
v1 -> v2:
Jonathan Cameron:
https://lore.kernel.org/linux-iio/[email protected]/
- remove Unit from tittle
- reword interrupts description
- drop interrupt-name description
- add spi example and bindings
- remove vddxx from required list
Quoted 7 lines
 .../bindings/iio/gyroscope/nxp,fxas21002c.txt | 31 ------
 .../iio/gyroscope/nxp,fxas21002c.yaml         | 95 +++++++++++++++++++
 MAINTAINERS                                   |  2 +-
 3 files changed, 96 insertions(+), 32 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.txt
 create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.yaml

Quoted 1 line

Reviewed-by Rob Herring <[email protected]>

Nice patch.

Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to maybe poke at.

I'm still not 100% sure if unevaluatedProperties or additionalProperties makes sense here, but as Rob's happy, I'm happy :)

Thanks,

Jonathan

Rui Miguel Silva

author

2020-10-18 21:18 UTC #3 lore raw

Hi,

Quoted 30 lines · Jonathan Cameron

Quoted 23 lines · On Fri, 16 Oct 2020 13:57:07 -0500 Rob Herring <[email protected]> wrote:
Quoted 14 lines · Rui Miguel Silva
Convert fxas21002c gyroscope sensor bindings documentation to
yaml schema, remove the textual bindings document and update MAINTAINERS entry.
Signed-off-by Rui Miguel Silva <[email protected]>
---
v1 -> v2:
Jonathan Cameron:
https://lore.kernel.org/linux-iio/[email protected]/
- remove Unit from tittle
- reword interrupts description
- drop interrupt-name description
- add spi example and bindings
- remove vddxx from required list
Quoted 7 lines
 .../bindings/iio/gyroscope/nxp,fxas21002c.txt | 31 ------
 .../iio/gyroscope/nxp,fxas21002c.yaml         | 95 +++++++++++++++++++
 MAINTAINERS                                   |  2 +-
 3 files changed, 96 insertions(+), 32 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.txt
 create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.yaml
Quoted 1 line
Reviewed-by Rob Herring <[email protected]>
Nice patch.

Quoted 7 lines

Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to maybe poke at.
I'm still not 100% sure if unevaluatedProperties or additionalProperties makes sense here, but as Rob's happy, I'm happy :)
Thanks,

Thanks for the review and taking this.

------
Cheers,
Rui

Rob Herring

maintainer

2020-10-19 14:39 UTC #4 lore raw

In reply to Jonathan Cameron

Quoted 29 lines · Jonathan Cameron

Quoted 23 lines · On Fri, 16 Oct 2020 13:57:07 -0500 Rob Herring <[email protected]> wrote:
Quoted 14 lines · Rui Miguel Silva
Convert fxas21002c gyroscope sensor bindings documentation to
yaml schema, remove the textual bindings document and update MAINTAINERS entry.
Signed-off-by Rui Miguel Silva <[email protected]>
---
v1 -> v2:
Jonathan Cameron:
https://lore.kernel.org/linux-iio/[email protected]/
- remove Unit from tittle
- reword interrupts description
- drop interrupt-name description
- add spi example and bindings
- remove vddxx from required list
Quoted 7 lines
 .../bindings/iio/gyroscope/nxp,fxas21002c.txt | 31 ------
 .../iio/gyroscope/nxp,fxas21002c.yaml         | 95 +++++++++++++++++++
 MAINTAINERS                                   |  2 +-
 3 files changed, 96 insertions(+), 32 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.txt
 create mode 100644 Documentation/devicetree/bindings/iio/gyroscope/nxp,fxas21002c.yaml
Quoted 1 line
Reviewed-by Rob Herring <[email protected]>

Quoted 7 lines

Nice patch.
Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to maybe poke at.
I'm still not 100% sure if unevaluatedProperties or additionalProperties makes sense here, but as Rob's happy, I'm happy :)

It could be additionalProperties instead if you want to fixup.

Rob