Skip to contentSkip to conversation

hash: use x86 common flag for jhash

PATCH In review David Marchand 2 participants 3 messages Oct 22, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hash: use x86 common flag for jhash

jhash has been forgotten when factorising the x86 arch check.

Fixes dbf17d44f375 ("hash: use common x86 flag")
---
 lib/librte_hash/rte_jhash.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_hash/rte_jhash.h +1 -1
index 7a1eeff74e..f2446f081e 100644
@@ -91,7 +91,7 @@ __rte_jhash_2hashes(const void *key, uint32_t length, uint32_t *pc,
 	 * Check key alignment. For x86 architecture, first case is always optimal
 	 * If check_align is not set, first case will be used
 	 */
-#if defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_I686) || defined(RTE_ARCH_X86_X32)
+#if defined(RTE_ARCH_X86)
 	const uint32_t *k = (const uint32_t *)key;
 	const uint32_t s = 0;
 #else
Signature · 1 line
2.23.0
Acked-by on v1 1/1
#1 lore raw
Quoted 14 lines · David Marchand

jhash has been forgotten when factorising the x86 arch check.

Fixes dbf17d44f375 ("hash: use common x86 flag")
---
 lib/librte_hash/rte_jhash.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_hash/rte_jhash.h +0 -0
index 7a1eeff74e..f2446f081e 100644

lib/librte_hash/rte_jhash.h __rte_jhash_2hashes(const void *key, uint32_t length, uint32_t *pc, · line 95

Quoted 6 lines
lib/librte_hash/rte_jhash.h +1 -1
@@ -91,7 +91,7 @@ __rte_jhash_2hashes(const void *key, uint32_t length, uint32_t *pc,
 	 * Check key alignment. For x86 architecture, first case is always optimal
 	 * If check_align is not set, first case will be used
 	 */
-#if defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_I686) || defined(RTE_ARCH_X86_X32)
+#if defined(RTE_ARCH_X86)
 	const uint32_t *k = (const uint32_t *)key;