Skip to contentSkip to conversation

mlx5: add ConnectX-7 and Bluefield-3 device IDs

PATCH In review Raslan Darawsheh 3 participants 6 messages Oct 26, 2020 – Nov 2, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mlx5: add ConnectX-7 and Bluefield-3 device IDs

This adds the ConnectX-7 and Bluefield-3 device ids to the list of supported Mellanox devices that run the MLX5 PMDs.
The devices is still in development stage.

---
 drivers/common/mlx5/mlx5_common.h | 2 ++
 drivers/net/mlx5/mlx5.c           | 8 ++++++++
 drivers/regex/mlx5/mlx5_regex.c   | 4 ++++
 drivers/vdpa/mlx5/mlx5_vdpa.c     | 8 ++++++++
 4 files changed, 22 insertions(+)
drivers/common/mlx5/mlx5_common.h +2 -0
index ed44a45a81..93985bf2c9 100644
@@ -132,6 +132,8 @@ enum {
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXVF = 0x101e,
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF = 0xa2d6,
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6LX = 0x101f,
+	PCI_DEVICE_ID_MELLANOX_CONNECTX7 = 0x1021,
+	PCI_DEVICE_ID_MELLANOX_CONNECTX7BF = 0Xa2dc,
 };
 
 /* Maximum number of simultaneous unicast MAC addresses. */
drivers/net/mlx5/mlx5.c +8 -0
index 77aeac85c5..0316253ca8 100644
@@ -2122,6 +2122,14 @@ static const struct rte_pci_id mlx5_pci_id_map[] = {
 		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
 				PCI_DEVICE_ID_MELLANOX_CONNECTX6LX)
 	},
+	{
+		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+				PCI_DEVICE_ID_MELLANOX_CONNECTX7)
+	},
+	{
+		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+				PCI_DEVICE_ID_MELLANOX_CONNECTX7BF)
+	},
 	{
 		.vendor_id = 0
 	}
drivers/regex/mlx5/mlx5_regex.c +4 -0
index 35e8ea0a9a..17590b937c 100644
@@ -254,6 +254,10 @@ static const struct rte_pci_id mlx5_regex_pci_id_map[] = {
 		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
 				PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF)
 	},
+	{
+		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+				PCI_DEVICE_ID_MELLANOX_CONNECTX7BF)
+	},
 	{
 		.vendor_id = 0
 	}
drivers/vdpa/mlx5/mlx5_vdpa.c +8 -0
index a8f3e4b1de..2d88633bfd 100644
@@ -825,6 +825,14 @@ static const struct rte_pci_id mlx5_vdpa_pci_id_map[] = {
 		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
 				PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF)
 	},
+	{
+		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+				PCI_DEVICE_ID_MELLANOX_CONNECTX7)
+	},
+	{
+		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+				PCI_DEVICE_ID_MELLANOX_CONNECTX7BF)
+	},
 	{
 		.vendor_id = 0
 	}
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines

-----Original Message-----
From: Raslan Darawsheh <[email protected]>
Sent: Monday, October 26, 2020 13:42
To: [email protected]
Cc: Matan Azrad <[email protected]>; Slava Ovsiienko <[email protected]>; Shy Shyman <[email protected]>
Subject: [PATCH] mlx5: add ConnectX-7 and Bluefield-3 device IDs

Quoted 6 lines

This adds the ConnectX-7 and Bluefield-3 device ids to the list of supported Mellanox devices that run the MLX5 PMDs.
The devices is still in development stage.

---

#2 lore raw
In reply to Raslan Darawsheh

Hi,

Quoted 96 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Raslan Darawsheh
Sent: Monday, October 26, 2020 1:42 PM
To: [email protected]
Cc: Matan Azrad <[email protected]>; Slava Ovsiienko <[email protected]>; Shy Shyman <[email protected]>
Subject: [dpdk-dev] [PATCH] mlx5: add ConnectX-7 and Bluefield-3 device IDs

This adds the ConnectX-7 and Bluefield-3 device ids to the list of supported Mellanox devices that run the MLX5 PMDs.
The devices is still in development stage.

---
 drivers/common/mlx5/mlx5_common.h | 2 ++
 drivers/net/mlx5/mlx5.c           | 8 ++++++++
 drivers/regex/mlx5/mlx5_regex.c   | 4 ++++
 drivers/vdpa/mlx5/mlx5_vdpa.c     | 8 ++++++++
 4 files changed, 22 insertions(+)
drivers/common/mlx5/mlx5_common.h +2 -0
index ed44a45a81..93985bf2c9 100644
@@ -132,6 +132,8 @@ enum {
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXVF = 0x101e,
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF = 0xa2d6,
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6LX = 0x101f,
+	PCI_DEVICE_ID_MELLANOX_CONNECTX7 = 0x1021,
+	PCI_DEVICE_ID_MELLANOX_CONNECTX7BF = 0Xa2dc,
 };
 
 /* Maximum number of simultaneous unicast MAC addresses. */
drivers/net/mlx5/mlx5.c +8 -0
index 77aeac85c5..0316253ca8 100644
@@ -2122,6 +2122,14 @@ static const struct rte_pci_id mlx5_pci_id_map[] =
 {
 		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
 				PCI_DEVICE_ID_MELLANOX_CONNECTX6LX)
 	},
+	{
+		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+				PCI_DEVICE_ID_MELLANOX_CONNECTX7)
+	},
+	{
+		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+				PCI_DEVICE_ID_MELLANOX_CONNECTX7BF)
+	},
 	{
 		.vendor_id = 0
drivers/net/mlx5/mlx5.c +0 -0
 	}
drivers/regex/mlx5/mlx5_regex.c +4 -0
index 35e8ea0a9a..17590b937c 100644
@@ -254,6 +254,10 @@ static const struct rte_pci_id
 mlx5_regex_pci_id_map[] = {
 		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
 
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF)
 	},
+	{
+		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+				PCI_DEVICE_ID_MELLANOX_CONNECTX7BF)
+	},
 	{
drivers/regex/mlx5/mlx5_regex.c +0 -0
 		.vendor_id = 0
 	}
drivers/vdpa/mlx5/mlx5_vdpa.c +8 -0
index a8f3e4b1de..2d88633bfd 100644
@@ -825,6 +825,14 @@ static const struct rte_pci_id
 mlx5_vdpa_pci_id_map[] = {
 		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
 
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF)
 	},
+	{
+		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+				PCI_DEVICE_ID_MELLANOX_CONNECTX7)
+	},
+	{
+		RTE_PCI_DEVICE(PCI_VENDOR_ID_MELLANOX,
+				PCI_DEVICE_ID_MELLANOX_CONNECTX7BF)
+	},
 	{
drivers/vdpa/mlx5/mlx5_vdpa.c +0 -1
 		.vendor_id = 0
 	}
--
Quoted 1 line

2.17.1

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

#3 lore raw
In reply to Raslan Darawsheh
Quoted 4 lines · Raslan Darawsheh

This adds the ConnectX-7 and Bluefield-3 device ids to the list of supported Mellanox devices that run the MLX5 PMDs.
The devices is still in development stage.

I assume you don't want to add these new device support to the documentation or to the web page, but what do you think adding it to the driver documentation with this device under development note, or experimental support etc?

Quoted 1 line

<...>

#4 lore raw

Hi Ferruh,

Quoted 15 lines

-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Thursday, October 29, 2020 5:26 PM
To: Raslan Darawsheh <[email protected]>; [email protected]
Cc: Matan Azrad <[email protected]>; Slava Ovsiienko <[email protected]>; Shy Shyman <[email protected]>
Subject: Re: [dpdk-dev] [PATCH] mlx5: add ConnectX-7 and Bluefield-3 device IDs

Quoted 4 lines · Raslan Darawsheh

This adds the ConnectX-7 and Bluefield-3 device ids to the list of supported Mellanox devices that run the MLX5 PMDs.
The devices is still in development stage.

Quoted 6 lines

I assume you don't want to add these new device support to the documentation or
to the web page, but what do you think adding it to the driver documentation
with this device under development note, or experimental support etc?

It's about that we haven't tried the PMD with these NIC's yet, so announcing that it has support for them without knowing that we don't really have any issues (even 0 level issue) I don't think its OK to add such documentation.

I think once we'll have the proper testing done for them, we can add them to all necessary documentations

Quoted 3 lines
Quoted 1 line

<...>

Kindest regards,
Raslan Darawsheh

#5 lore raw
Quoted 23 lines · Raslan Darawsheh

Hi Ferruh,

Quoted 15 lines

-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Thursday, October 29, 2020 5:26 PM
To: Raslan Darawsheh <[email protected]>; [email protected]
Cc: Matan Azrad <[email protected]>; Slava Ovsiienko <[email protected]>; Shy Shyman <[email protected]>
Subject: Re: [dpdk-dev] [PATCH] mlx5: add ConnectX-7 and Bluefield-3 device IDs

Quoted 4 lines · Raslan Darawsheh

This adds the ConnectX-7 and Bluefield-3 device ids to the list of supported Mellanox devices that run the MLX5 PMDs.
The devices is still in development stage.

Quoted 6 lines

I assume you don't want to add these new device support to the documentation or
to the web page, but what do you think adding it to the driver documentation
with this device under development note, or experimental support etc?

Quoted 5 lines

It's about that we haven't tried the PMD with these NIC's yet, so announcing that it has support for them without knowing that we don't really have any issues (even 0 level issue) I don't think its OK to add such documentation.

I think once we'll have the proper testing done for them, we can add them to all necessary documentations

OK