drm/i915/dp: Some reshuffling in mode_valid as prep for bigjoiner modes
Subsystems (3)
PATCH v2 1/5 drm/i915/dp: Some reshuffling in mode_valid as prep for bigjoiner modes
No functional changes. This patch just moves some mode checks around to prepare for adding bigjoiner related mode validation
--- drivers/gpu/drm/i915/display/intel_dp.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +6 -6
@@ -721,6 +721,9 @@ intel_dp_mode_valid(struct drm_connector *connector,if (mode->flags &DRM_MODE_FLAG_DBLSCAN )return MODE_NO_DBLESCAN ; +if (mode->flags &DRM_MODE_FLAG_DBLCLK ) +return MODE_H_ILLEGAL ; +if (intel_dp_is_edp (intel_dp) && fixed_mode) {if (mode->hdisplay > fixed_mode->hdisplay)return MODE_PANEL ;
@@ -731,6 +734,9 @@ intel_dp_mode_valid(struct drm_connector *connector, target_clock = fixed_mode->clock; } +if (mode->clock <10000 ) +return MODE_CLOCK_LOW ; + max_link_clock =intel_dp_max_link_rate (intel_dp); max_lanes =intel_dp_max_lane_count (intel_dp);
@@ -771,12 +777,6 @@ intel_dp_mode_valid(struct drm_connector *connector, target_clock > max_dotclk)return MODE_CLOCK_HIGH ; -if (mode->clock <10000 ) -return MODE_CLOCK_LOW ; - -if (mode->flags &DRM_MODE_FLAG_DBLCLK ) -return MODE_H_ILLEGAL ; - status =intel_dp_mode_valid_downstream (intel_connector, mode, target_clock);if (status !=MODE_OK )
Signature · 6 lines
2.19.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 2/5 drm/i915: Add hw.pipe_mode to allow bigjoiner pipe/transcoder split
From: Maarten Lankhorst <[email protected]>
With bigjoiner, there will be 2 pipes driving 2 halfs of 1 transcoder, because of this, we need a pipe_mode for various calculations, including for example watermarks, plane clipping, etc.
v7:
* Remove redundant comment (Ville)
* Just keep mode instead of pipe_mode (Ville)
v6:
* renaming in separate function, only pipe_mode here (Ville)
* Add description (Maarten)
v5:
* Rebase (Manasi)
v4:
* Manual rebase (Manasi)
v3:
* Change state to crtc_state, fix rebase err (Manasi) v2:
* Manual Rebase (Manasi)
--- drivers/gpu/drm/i915/display/intel_display.c | 38 +++++----- .../drm/i915/display/intel_display_types.h | 11 ++- drivers/gpu/drm/i915/intel_pm.c | 76 +++++++++---------- 3 files changed, 68 insertions(+), 57 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +21 -17
@@ -6167,18 +6167,16 @@ skl_update_scaler(struct intel_crtc_state *crtc_state, bool force_detach,static int skl_update_scaler_crtc (struct intel_crtc_state *crtc_state) { -const struct drm_display_mode *adjusted_mode = - &crtc_state->hw.adjusted_mode; +const struct drm_display_mode *pipe_mode = &crtc_state->hw.pipe_mode;int width, height;if (crtc_state->pch_pfit.enabled) { width =drm_rect_width (&crtc_state->pch_pfit.dst); height =drm_rect_height (&crtc_state->pch_pfit.dst); }else { - width = adjusted_mode->crtc_hdisplay; - height = adjusted_mode->crtc_vdisplay; + width = pipe_mode->crtc_hdisplay; + height = pipe_mode->crtc_vdisplay; } - return skl_update_scaler(crtc_state, !crtc_state->hw.active, SKL_CRTC_INDEX, &crtc_state->scaler_state.scaler_id,
@@ -8192,7 +8190,7 @@ static bool intel_crtc_supports_double_wide(const struct intel_crtc *crtc)static u32 ilk_pipe_pixel_rate (const struct intel_crtc_state *crtc_state) { -u32 pixel_rate = crtc_state->hw.adjusted_mode.crtc_clock; +u32 pixel_rate = crtc_state->hw.pipe_mode.crtc_clock;unsigned int pipe_w, pipe_h, pfit_w, pfit_h;/*
@@ -8229,7 +8227,7 @@ static void intel_crtc_compute_pixel_rate(struct intel_crtc_state *crtc_state)if (HAS_GMCH (dev_priv))/* FIXME calculate proper pipe pixel rate for GMCH pfit */ crtc_state->pixel_rate = - crtc_state->hw.adjusted_mode.crtc_clock; + crtc_state->hw.pipe_mode.crtc_clock;else crtc_state->pixel_rate =ilk_pipe_pixel_rate (crtc_state);
@@ -8239,7 +8237,7 @@ static int intel_crtc_compute_config(struct intel_crtc *crtc, struct intel_crtc_state *pipe_config) {struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev); -const struct drm_display_mode *adjusted_mode = &pipe_config->hw.adjusted_mode; +const struct drm_display_mode *pipe_mode = &pipe_config->hw.pipe_mode;int clock_limit = dev_priv->max_dotclk_freq;if (INTEL_GEN (dev_priv) <4 ) {
@@ -8250,16 +8248,16 @@ static int intel_crtc_compute_config(struct intel_crtc *crtc,* is > 90% of the (display) core speed. */ if (intel_crtc_supports_double_wide (crtc) && - adjusted_mode->crtc_clock > clock_limit) { + pipe_mode->crtc_clock > clock_limit) { clock_limit = dev_priv->max_dotclk_freq; pipe_config->double_wide = true; } } -if (adjusted_mode->crtc_clock > clock_limit) { +if (pipe_mode->crtc_clock > clock_limit) {drm_dbg_kms (&dev_priv->drm,"requested pixel clock (%d kHz) too high (max: %d kHz, double wide: %s)\n" , - adjusted_mode->crtc_clock, clock_limit, + pipe_mode->crtc_clock, clock_limit,yesno (pipe_config->double_wide));return -EINVAL ; }
@@ -8302,7 +8300,7 @@ static int intel_crtc_compute_config(struct intel_crtc *crtc,* WaPruneModeWithIncorrectHsyncOffset:ctg,elk,ilk,snb,ivb,vlv,hsw. */ if ((INTEL_GEN (dev_priv) >4 ||IS_G4X (dev_priv)) && - adjusted_mode->crtc_hsync_start == adjusted_mode->crtc_hdisplay) + pipe_mode->crtc_hsync_start == pipe_mode->crtc_hdisplay)return -EINVAL ;intel_crtc_compute_pixel_rate (pipe_config);
@@ -12821,15 +12819,15 @@ static bool c8_planes_changed(const struct intel_crtc_state *new_crtc_state)static u16 hsw_linetime_wm (const struct intel_crtc_state *crtc_state) { -const struct drm_display_mode *adjusted_mode = - &crtc_state->hw.adjusted_mode; +const struct drm_display_mode *pipe_mode = + &crtc_state->hw.pipe_mode;int linetime_wm;if (!crtc_state->hw.enable)return 0 ; - linetime_wm =DIV_ROUND_CLOSEST (adjusted_mode->crtc_htotal *1000 *8 , - adjusted_mode->crtc_clock); + linetime_wm =DIV_ROUND_CLOSEST (pipe_mode->crtc_htotal *1000 *8 , + pipe_mode->crtc_clock);return min (linetime_wm,0x1ff ); }
@@ -13459,8 +13457,9 @@ intel_crtc_copy_uapi_to_hw_state(struct intel_crtc_state *crtc_state) crtc_state->hw.enable = crtc_state->uapi.enable; crtc_state->hw.active = crtc_state->uapi.active; crtc_state->hw.mode = crtc_state->uapi.mode; - crtc_state->hw.adjusted_mode = crtc_state->uapi.adjusted_mode; + crtc_state->hw.pipe_mode = crtc_state->hw.adjusted_mode = crtc_state->uapi.adjusted_mode; crtc_state->hw.scaling_filter = crtc_state->uapi.scaling_filter; +intel_crtc_copy_uapi_to_hw_state_nomodeset (crtc_state); }
@@ -13657,6 +13656,9 @@ intel_modeset_pipe_config(struct intel_crtc_state *pipe_config)"hw max bpp: %i, pipe bpp: %i, dithering: %i\n" , base_bpp, pipe_config->pipe_bpp, pipe_config->dither); +/* without bigjoiner, pipe_mode == adjusted_mode */ + pipe_config->hw.pipe_mode = pipe_config->hw.adjusted_mode; +return 0 ; }
@@ -18914,6 +18916,8 @@ static void intel_modeset_readout_hw_state(struct drm_device *dev)*/ crtc_state->inherited = true; + crtc_state->hw.pipe_mode = crtc_state->hw.adjusted_mode; +intel_crtc_compute_pixel_rate (crtc_state);intel_crtc_update_active_timings (crtc_state);
drivers/gpu/drm/i915/display/intel_display_types.h +9 -2
@@ -817,15 +817,22 @@ struct intel_crtc_state {* The following members are used to verify the hardware state: * - enable * - active -* - mode / adjusted_mode +* - mode/adjusted_mode * - color property blobs. * * During initial hw readout, they need to be copied to uapi. +* +* Bigjoiner will allow a transcoder mode that spans 2 pipes; +* Use the pipe_mode for calculations like watermarks, pipe +* scaler, and bandwidth. +* +* Use adjusted_mode for things that need to know the full +* mode on the transcoder, which spans all pipes. */ struct {bool active, enable;struct drm_property_blob *degamma_lut, *gamma_lut, *ctm; -struct drm_display_mode mode, adjusted_mode; +struct drm_display_mode mode, pipe_mode, adjusted_mode;enum drm_scaling_filter scaling_filter; } hw;
drivers/gpu/drm/i915/intel_pm.c +38 -38
215 lines not on this page · raw message
Signature · 6 lines
2.19.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 3/5 drm/i915: Pass intel_atomic_state instead of drm_atomic_state
In reply to Manasi NavareNo functional changes, to align with previous cleanups pass intel_atomic_state instead of drm_atomic_state. Also pass this intel_atomic_state with crtc_state to some of the atomic_check functions.
--- drivers/gpu/drm/i915/display/intel_display.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +7 -7
@@ -12661,7 +12661,7 @@ static bool encoders_cloneable(const struct intel_encoder *a, b->cloneable & (1 << a->type)); } -static bool check_single_encoder_cloning (struct drm_atomic_state *state, +static bool check_single_encoder_cloning (struct intel_atomic_state *state,struct intel_crtc *crtc,struct intel_encoder *encoder) {
@@ -12670,7 +12670,7 @@ static bool check_single_encoder_cloning(struct drm_atomic_state *state,struct drm_connector_state *connector_state;int i; -for_each_new_connector_in_state (state, connector, connector_state, i) { +for_each_new_connector_in_state (&state->base, connector, connector_state, i) {if (connector_state->crtc != &crtc->base)continue ;
@@ -13521,10 +13521,10 @@ intel_crtc_prepare_cleared_state(struct intel_crtc_state *crtc_state) }static int -intel_modeset_pipe_config (struct intel_crtc_state *pipe_config) +intel_modeset_pipe_config (struct intel_atomic_state *state, +struct intel_crtc_state *pipe_config) {struct drm_crtc *crtc = pipe_config->uapi.crtc; -struct drm_atomic_state *state = pipe_config->uapi.state;struct drm_i915_private *i915 =to_i915 (pipe_config->uapi.crtc->dev);struct drm_connector *connector;struct drm_connector_state *connector_state;
@@ -13566,7 +13566,7 @@ intel_modeset_pipe_config(struct intel_crtc_state *pipe_config) &pipe_config->pipe_src_w, &pipe_config->pipe_src_h); -for_each_new_connector_in_state (state, connector, connector_state, i) { +for_each_new_connector_in_state (&state->base, connector, connector_state, i) {struct intel_encoder *encoder =to_intel_encoder (connector_state->best_encoder);
@@ -13604,7 +13604,7 @@ intel_modeset_pipe_config(struct intel_crtc_state *pipe_config)* adjust it according to limitations or connector properties, and also * a chance to reject the mode entirely. */ -for_each_new_connector_in_state (state, connector, connector_state, i) { +for_each_new_connector_in_state (&state->base, connector, connector_state, i) {struct intel_encoder *encoder =to_intel_encoder (connector_state->best_encoder);
@@ -15228,7 +15228,7 @@ static int intel_atomic_check(struct drm_device *dev,if (!new_crtc_state->hw.enable)continue ; - ret =intel_modeset_pipe_config (new_crtc_state); + ret =intel_modeset_pipe_config (state, new_crtc_state);if (ret) goto fail; }
Signature · 6 lines
2.19.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 4/5 drm/i915/dp: Prep for bigjoiner atomic check
In reply to Manasi NavareNo functional changes here. Just pass intel_atomic_state along with crtc_state to certain atomic_check functions. This will lay the foundation for adding bigjoiner master/slave states in atomic check.
v2:
* More prep with intel_atomic_state (Ville)
--- drivers/gpu/drm/i915/display/intel_atomic.c | 9 +++++---- drivers/gpu/drm/i915/display/intel_atomic.h | 3 ++- drivers/gpu/drm/i915/display/intel_display.c | 21 ++++++++++++-------- 3 files changed, 20 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/display/intel_atomic.c +5 -4
@@ -270,14 +270,15 @@ void intel_crtc_free_hw_state(struct intel_crtc_state *crtc_state)intel_crtc_put_color_blobs (crtc_state); } -void intel_crtc_copy_color_blobs (struct intel_crtc_state *crtc_state) +void intel_crtc_copy_color_blobs (struct intel_crtc_state *crtc_state, +const struct intel_crtc_state *from_crtc_state) {drm_property_replace_blob (&crtc_state->hw.degamma_lut, - crtc_state->uapi.degamma_lut); + from_crtc_state->uapi.degamma_lut);drm_property_replace_blob (&crtc_state->hw.gamma_lut, - crtc_state->uapi.gamma_lut); + from_crtc_state->uapi.gamma_lut);drm_property_replace_blob (&crtc_state->hw.ctm, - crtc_state->uapi.ctm); + from_crtc_state->uapi.ctm); }/**
drivers/gpu/drm/i915/display/intel_atomic.h +2 -1
@@ -43,7 +43,8 @@ struct drm_crtc_state *intel_crtc_duplicate_state(struct drm_crtc *crtc);void intel_crtc_destroy_state (struct drm_crtc *crtc,struct drm_crtc_state *state);void intel_crtc_free_hw_state (struct intel_crtc_state *crtc_state); -void intel_crtc_copy_color_blobs (struct intel_crtc_state *crtc_state); +void intel_crtc_copy_color_blobs (struct intel_crtc_state *crtc_state, +const struct intel_crtc_state *from_crtc_state);struct drm_atomic_state *intel_atomic_state_alloc (struct drm_device *dev);void intel_atomic_state_free (struct drm_atomic_state *state);void intel_atomic_state_clear (struct drm_atomic_state *state);
drivers/gpu/drm/i915/display/intel_display.c +13 -8
@@ -13446,13 +13446,17 @@ static bool check_digital_port_conflicts(struct intel_atomic_state *state) }static void -intel_crtc_copy_uapi_to_hw_state_nomodeset (struct intel_crtc_state *crtc_state) +intel_crtc_copy_uapi_to_hw_state_nomodeset (struct intel_atomic_state *state, +struct intel_crtc_state *crtc_state) { -intel_crtc_copy_color_blobs (crtc_state); +const struct intel_crtc_state *from_crtc_state = crtc_state; + +intel_crtc_copy_color_blobs (crtc_state, from_crtc_state); }static void -intel_crtc_copy_uapi_to_hw_state (struct intel_crtc_state *crtc_state) +intel_crtc_copy_uapi_to_hw_state (struct intel_atomic_state *state, +struct intel_crtc_state *crtc_state) { crtc_state->hw.enable = crtc_state->uapi.enable; crtc_state->hw.active = crtc_state->uapi.active;
@@ -13460,7 +13464,7 @@ intel_crtc_copy_uapi_to_hw_state(struct intel_crtc_state *crtc_state) crtc_state->hw.pipe_mode = crtc_state->hw.adjusted_mode = crtc_state->uapi.adjusted_mode; crtc_state->hw.scaling_filter = crtc_state->uapi.scaling_filter; -intel_crtc_copy_uapi_to_hw_state_nomodeset (crtc_state); +intel_crtc_copy_uapi_to_hw_state_nomodeset (state, crtc_state); }static void intel_crtc_copy_hw_to_uapi_state (struct intel_crtc_state *crtc_state)
@@ -13483,7 +13487,8 @@ static void intel_crtc_copy_hw_to_uapi_state(struct intel_crtc_state *crtc_state }static int -intel_crtc_prepare_cleared_state (struct intel_crtc_state *crtc_state) +intel_crtc_prepare_cleared_state (struct intel_atomic_state *state, +struct intel_crtc_state *crtc_state) {struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc);struct drm_i915_private *dev_priv =to_i915 (crtc->base.dev);
@@ -13515,7 +13520,7 @@ intel_crtc_prepare_cleared_state(struct intel_crtc_state *crtc_state)memcpy (crtc_state, saved_state,sizeof (*crtc_state));kfree (saved_state); -intel_crtc_copy_uapi_to_hw_state (crtc_state); +intel_crtc_copy_uapi_to_hw_state (state, crtc_state);return 0 ; }
@@ -15216,12 +15221,12 @@ static int intel_atomic_check(struct drm_device *dev, new_crtc_state, i) {if (!needs_modeset (new_crtc_state)) {/* Light copy */ -intel_crtc_copy_uapi_to_hw_state_nomodeset (new_crtc_state); +intel_crtc_copy_uapi_to_hw_state_nomodeset (state, new_crtc_state);continue ; } - ret =intel_crtc_prepare_cleared_state (new_crtc_state); + ret =intel_crtc_prepare_cleared_state (state, new_crtc_state);if (ret) goto fail;
Signature · 6 lines
2.19.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 5/5 drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid(), v3.
In reply to Manasi NavareFrom: Maarten Lankhorst <[email protected]>
Small changes to intel_dp_mode_valid(), allow listing modes that can only be supported in the bigjoiner configuration, which is not supported yet.
v12:
* slice_count logic simplify (Ville)
* Fix unnecessary changes in downstream_mode_valid (Ville) v11:
* Make intel_dp_can_bigjoiner non static
so it can be used in intel_display (Manasi)
v10:
* Simplify logic (Ville)
* Allow bigjoiner on edp (Ville)
v9:
* Restric Bigjoiner on PORT A (Ville)
v8:
* use source dotclock for max dotclock (Manasi)
v7:
* Add can_bigjoiner() helper (Ville)
* Pass bigjoiner to plane_size validation (Ville)
v6:
* Rebase after dp_downstream mode valid changes (Manasi) v5:
* Increase max plane width to support 8K with bigjoiner (Maarten) v4:
* Rebase (Manasi)
Changes since v1:
- Disallow bigjoiner on eDP.
Changes since v2:
- Rename intel_dp_downstream_max_dotclock to intel_dp_max_dotclock, and split off the downstream and source checking to its own function. (Ville)
v3:
* Rebase (Manasi)
--- drivers/gpu/drm/i915/display/intel_display.c | 5 +- drivers/gpu/drm/i915/display/intel_display.h | 3 +- drivers/gpu/drm/i915/display/intel_dp.c | 77 ++++++++++++++++---- drivers/gpu/drm/i915/display/intel_dp.h | 1 + drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- drivers/gpu/drm/i915/display/intel_dsi.c | 2 +- drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +- 7 files changed, 72 insertions(+), 20 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +3 -2
@@ -17760,7 +17760,8 @@ intel_mode_valid(struct drm_device *dev,enum drm_mode_status intel_mode_valid_max_plane_size (struct drm_i915_private *dev_priv, -const struct drm_display_mode *mode) +const struct drm_display_mode *mode, +bool bigjoiner) {int plane_width_max, plane_height_max;
@@ -17777,7 +17778,7 @@ intel_mode_valid_max_plane_size(struct drm_i915_private *dev_priv,* too big for that. */ if (INTEL_GEN (dev_priv) >=11 ) { - plane_width_max =5120 ; + plane_width_max =5120 << bigjoiner; plane_height_max =4320 ; }else { plane_width_max =5120 ;
drivers/gpu/drm/i915/display/intel_display.h +2 -1
@@ -497,7 +497,8 @@ u32 intel_plane_fb_max_stride(struct drm_i915_private *dev_priv,bool intel_plane_can_remap (const struct intel_plane_state *plane_state);enum drm_mode_status intel_mode_valid_max_plane_size (struct drm_i915_private *dev_priv, -const struct drm_display_mode *mode); +const struct drm_display_mode *mode, +bool bigjoiner);enum phy intel_port_to_phy (struct drm_i915_private *i915,enum port port);bool is_trans_port_sync_mode (const struct intel_crtc_state *state);
drivers/gpu/drm/i915/display/intel_dp.c +63 -14
153 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_dp.h +1 -0
@@ -106,6 +106,7 @@ bool intel_dp_source_supports_hbr3(struct intel_dp *intel_dp);bool intel_dp_get_colorimetry_status (struct intel_dp *intel_dp);int intel_dp_link_required (int pixel_clock,int bpp);int intel_dp_max_data_rate (int max_link_clock,int max_lanes); +bool intel_dp_can_bigjoiner (struct intel_dp *intel_dp);bool intel_dp_needs_vsc_sdp (const struct intel_crtc_state *crtc_state,const struct drm_connector_state *conn_state); void intel_dp_compute_psr_vsc_sdp(struct intel_dp *intel_dp,
drivers/gpu/drm/i915/display/intel_dp_mst.c +1 -1
@@ -714,7 +714,7 @@ intel_dp_mst_mode_valid_ctx(struct drm_connector *connector,return 0 ; } - *status =intel_mode_valid_max_plane_size (dev_priv, mode); + *status =intel_mode_valid_max_plane_size (dev_priv, mode, false);return 0 ; }
drivers/gpu/drm/i915/display/intel_dsi.c +1 -1
@@ -75,7 +75,7 @@ enum drm_mode_status intel_dsi_mode_valid(struct drm_connector *connector,return MODE_CLOCK_HIGH ; } -return intel_mode_valid_max_plane_size (dev_priv, mode); +return intel_mode_valid_max_plane_size (dev_priv, mode, false); } struct intel_dsi_host *intel_dsi_host_init(struct intel_dsi *intel_dsi,
drivers/gpu/drm/i915/display/intel_hdmi.c +1 -1
@@ -2274,7 +2274,7 @@ intel_hdmi_mode_valid(struct drm_connector *connector,if (status !=MODE_OK )return status; -return intel_mode_valid_max_plane_size (dev_priv, mode); +return intel_mode_valid_max_plane_size (dev_priv, mode, false); } bool intel_hdmi_deep_color_possible(const struct intel_crtc_state *crtc_state,
Signature · 6 lines
2.19.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/5] drm/i915/dp: Some reshuffling in mode_valid as prep for bigjoiner modes
In reply to Manasi Navare== Series Details ==
== Series Details ==
Series: series starting with [v2,1/5] drm/i915/dp: Some reshuffling in mode_valid as prep for bigjoiner modes
URL : https://patchwork.freedesktop.org/series/83118/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip 10e42fe832c7 drm/i915/dp: Some reshuffling in mode_valid as prep for bigjoiner modes 2ceb0c198f7f drm/i915: Add hw.pipe_mode to allow bigjoiner pipe/transcoder split -:10: WARNING:TYPO_SPELLING: 'halfs' may be misspelled - perhaps 'halves'? #10: With bigjoiner, there will be 2 pipes driving 2 halfs of 1 transcoder,
-:141: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #141: FILE: drivers/gpu/drm/i915/display/intel_display.c:13460:
+ crtc_state->hw.pipe_mode = crtc_state->hw.adjusted_mode = crtc_state->uapi.adjusted_mode;
total: 0 errors, 1 warnings, 1 checks, 357 lines checked 5e1144da1fea drm/i915: Pass intel_atomic_state instead of drm_atomic_state 9b263ae72e3f drm/i915/dp: Prep for bigjoiner atomic check 156703ae1a81 drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid(), v3.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/5] drm/i915/dp: Some reshuffling in mode_valid as prep for bigjoiner modes
In reply to Manasi Navare== Series Details ==
== Series Details ==
Series: series starting with [v2,1/5] drm/i915/dp: Some reshuffling in mode_valid as prep for bigjoiner modes
URL : https://patchwork.freedesktop.org/series/83118/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9206 -> Patchwork_18792
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18792 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_18792, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18792/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18792:
### IGT changes ###
#### Possible regressions ####
* igt@runner@aborted:
- fi-ilk-650: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18792/fi-ilk-650/igt@[email protected]
- fi-pnv-d510: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18792/fi-pnv-d510/igt@[email protected]
- fi-gdg-551: NOTRUN -> [FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18792/fi-gdg-551/igt@[email protected]
- fi-snb-2520m: NOTRUN -> [FAIL][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18792/fi-snb-2520m/igt@[email protected]
- fi-skl-lmem: NOTRUN -> [FAIL][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18792/fi-skl-lmem/igt@[email protected]
- fi-bwr-2160: NOTRUN -> [FAIL][6]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18792/fi-bwr-2160/igt@[email protected]
- fi-kbl-guc: NOTRUN -> [FAIL][7]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18792/fi-kbl-guc/igt@[email protected]
- fi-snb-2600: NOTRUN -> [FAIL][8]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18792/fi-snb-2600/igt@[email protected]
- fi-cml-u2: NOTRUN -> [FAIL][9]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18792/fi-cml-u2/igt@[email protected]
- fi-ivb-3770: NOTRUN -> [FAIL][10]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18792/fi-ivb-3770/igt@[email protected]
- fi-byt-j1900: NOTRUN -> [FAIL][11]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18792/fi-byt-j1900/igt@[email protected]
- fi-elk-e7500: NOTRUN -> [FAIL][12]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18792/fi-elk-e7500/igt@[email protected]
- fi-cml-s: NOTRUN -> [FAIL][13]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18792/fi-cml-s/igt@[email protected]
- fi-skl-guc: NOTRUN -> [FAIL][14]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18792/fi-skl-guc/igt@[email protected]
- fi-skl-6700k2: NOTRUN -> [FAIL][15]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18792/fi-skl-6700k2/igt@[email protected]
- fi-blb-e6850: NOTRUN -> [FAIL][16]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18792/fi-blb-e6850/igt@[email protected]
#### Warnings ####
* igt@runner@aborted:
- fi-skl-6600u: [FAIL][17] ([i915#1814]) -> [FAIL][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9206/fi-skl-6600u/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18792/fi-skl-6600u/igt@[email protected]
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@runner@aborted:
- {fi-ehl-1}: NOTRUN -> [FAIL][19]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18792/fi-ehl-1/igt@[email protected]
New tests
---------
New tests have been introduced between CI_DRM_9206 and Patchwork_18792:
### New CI tests (1) ###
* boot:
- Statuses : 41 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18792 that come from known issues:
### IGT changes ###
#### Warnings ####
* igt@runner@aborted:
- fi-icl-u2: [FAIL][20] ([i915#1814]) -> [FAIL][21] ([i915#1569] / [k.org#202973])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9206/fi-icl-u2/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18792/fi-icl-u2/igt@[email protected]
- fi-kbl-r: [FAIL][22] ([fdo#109271] / [i915#1784] / [i915#1814]) -> [FAIL][23] ([i915#1569] / [i915#192] / [i915#193] / [i915#194])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9206/fi-kbl-r/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18792/fi-kbl-r/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1569]: https://gitlab.freedesktop.org/drm/intel/issues/1569
[i915#1784]: https://gitlab.freedesktop.org/drm/intel/issues/1784
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#192]: https://gitlab.freedesktop.org/drm/intel/issues/192
[i915#193]: https://gitlab.freedesktop.org/drm/intel/issues/193
[i915#194]: https://gitlab.freedesktop.org/drm/intel/issues/194
[k.org#202973]: https://bugzilla.kernel.org/show_bug.cgi?id=202973
Participating hosts (43 -> 41)
------------------------------
Missing (2): fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9206 -> Patchwork_18792
CI-20190529: 20190529
CI_DRM_9206: 85ce674ff932ed7ca41aef52d8bb42c04fbe2171 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5827: 7fd7e3fb8b42eb4e62a4575f6edc5a048e5bec3d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18792: 156703ae1a818a3d868a20434592048d54e8786f @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
156703ae1a81 drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid(), v3. 9b263ae72e3f drm/i915/dp: Prep for bigjoiner atomic check5e1144da1fea drm/i915: Pass intel_atomic_state instead of drm_atomic_state 2ceb0c198f7f drm/i915: Add hw.pipe_mode to allow bigjoiner pipe/transcoder split 10e42fe832c7 drm/i915/dp: Some reshuffling in mode_valid as prep for bigjoiner modes
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18792/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx