net: ethernet: mscc: fix missing brace warning for old compilers
Subsystems (3)
PATCH v2 1/1 net: ethernet: mscc: fix missing brace warning for old compilers
For older versions of gcc, the array = {0}; will cause warnings:
drivers/net/ethernet/mscc/ocelot_vcap.c: In function 'is1_entry_set':drivers/net/ethernet/mscc/ocelot_vcap.c:755:11: warning: missing braces around initializer [-Wmissing-braces]
struct ocelot_vcap_u16 etype = {0};
^drivers/net/ethernet/mscc/ocelot_vcap.c:755:11: warning: (near initialization for 'etype.value') [-Wmissing-braces]
1 warnings generated
--- drivers/net/ethernet/mscc/ocelot_vcap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/mscc/ocelot_vcap.c +1 -1
@@ -752,7 +752,7 @@ static void is1_entry_set(struct ocelot *ocelot, int ix, dport); }else {/* IPv4 "other" frame */ -struct ocelot_vcap_u16 etype = {0 }; +struct ocelot_vcap_u16 etype = {{0 }};/* Overloaded field */ etype.value[0 ] = proto.value[0 ];
Signature · 1 line
2.18.1
Jakub Kicinski
maintainerQuoted 1 line · On Tue, 3 Nov 2020 10:55:19 +0800 Pujin Shi wrote:
For older versions of gcc, the array = {0}; will cause warnings:
Please include the version of gcc which generates this warning here.
Quoted 19 lines
drivers/net/ethernet/mscc/ocelot_vcap.c: In function 'is1_entry_set':drivers/net/ethernet/mscc/ocelot_vcap.c:755:11: warning: missing braces around initializer [-Wmissing-braces]struct ocelot_vcap_u16 etype = {0}; ^
drivers/net/ethernet/mscc/ocelot_vcap.c:755:11: warning: (near initialization for 'etype.value') [-Wmissing-braces]1 warnings generated
Fixes 75944fda1dfe ("net: mscc: ocelot: offload ingress skbedit and vlan actions to VCAP IS1")Signed-off-by Pujin Shi <[email protected]>--- drivers/net/ethernet/mscc/ocelot_vcap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/ethernet/mscc/ocelot_vcap.c +0
-0
drivers/net/ethernet/mscc/ocelot_vcap.c static void is1_entry_set(struct ocelot *ocelot, int ix, · line 755
Quoted 5 lines
drivers/net/ethernet/mscc/ocelot_vcap.c +1
-1@@ -752,7 +752,7 @@ static void is1_entry_set(struct ocelot *ocelot, int ix, dport); }else {/* IPv4 "other" frame */ -struct ocelot_vcap_u16 etype = {0 }; +struct ocelot_vcap_u16 etype = {{0 }};
I believe Vladimir asked to use a memset instead;
struct ocelot_vcap_u16 etype; memset(&etype, 0, sizeof(etype));
Quoted 2 lines
drivers/net/ethernet/mscc/ocelot_vcap.c +0
-0/* Overloaded field */ etype.value[0 ] = proto.value[0 ];
Vladimir Oltean
maintainerQuoted 5 lines · Jakub Kicinski
I believe Vladimir asked to use a memset instead;
struct ocelot_vcap_u16 etype; memset(&etype, 0, sizeof(etype));
Thanks, Jakub.