Skip to contentSkip to conversation

net: ethernet: mscc: fix missing brace warning for old compilers

PATCH In review Pujin Shi 3 participants 3 messages Nov 3, 2020

Subsystems (3)
lore
Share & tools
lore

Pujin Shi

author
#0 lore raw

PATCH v2 1/1 net: ethernet: mscc: fix missing brace warning for old compilers

For older versions of gcc, the array = {0}; will cause warnings:

drivers/net/ethernet/mscc/ocelot_vcap.c: In function 'is1_entry_set':
drivers/net/ethernet/mscc/ocelot_vcap.c:755:11: warning: missing braces around initializer [-Wmissing-braces]

    struct ocelot_vcap_u16 etype = {0};
           ^

drivers/net/ethernet/mscc/ocelot_vcap.c:755:11: warning: (near initialization for 'etype.value') [-Wmissing-braces]

1 warnings generated

Fixes 75944fda1dfe ("net: mscc: ocelot: offload ingress skbedit and vlan actions to VCAP IS1")
---
 drivers/net/ethernet/mscc/ocelot_vcap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/mscc/ocelot_vcap.c +1 -1
index d8c778ee6f1b..b5167570521c 100644
@@ -752,7 +752,7 @@ static void is1_entry_set(struct ocelot *ocelot, int ix,
 					     dport);
 		} else {
 			/* IPv4 "other" frame */
-			struct ocelot_vcap_u16 etype = {0};
+			struct ocelot_vcap_u16 etype = {{0}};
 
 			/* Overloaded field */
 			etype.value[0] = proto.value[0];
Signature · 1 line
2.18.1
maintainer
#1 lore raw
Quoted 1 line · On Tue, 3 Nov 2020 10:55:19 +0800 Pujin Shi wrote:

For older versions of gcc, the array = {0}; will cause warnings:

Please include the version of gcc which generates this warning here.

Quoted 19 lines

drivers/net/ethernet/mscc/ocelot_vcap.c: In function 'is1_entry_set':
drivers/net/ethernet/mscc/ocelot_vcap.c:755:11: warning: missing braces around initializer [-Wmissing-braces]

    struct ocelot_vcap_u16 etype = {0};
           ^

drivers/net/ethernet/mscc/ocelot_vcap.c:755:11: warning: (near initialization for 'etype.value') [-Wmissing-braces]

1 warnings generated

Fixes 75944fda1dfe ("net: mscc: ocelot: offload ingress skbedit and vlan actions to VCAP IS1")
---
 drivers/net/ethernet/mscc/ocelot_vcap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/mscc/ocelot_vcap.c +0 -0
index d8c778ee6f1b..b5167570521c 100644

drivers/net/ethernet/mscc/ocelot_vcap.c static void is1_entry_set(struct ocelot *ocelot, int ix, · line 755

Quoted 5 lines
drivers/net/ethernet/mscc/ocelot_vcap.c +1 -1
@@ -752,7 +752,7 @@ static void is1_entry_set(struct ocelot *ocelot, int ix,
 					     dport);
 		} else {
 			/* IPv4 "other" frame */
-			struct ocelot_vcap_u16 etype = {0};
+			struct ocelot_vcap_u16 etype = {{0}};

I believe Vladimir asked to use a memset instead;

			struct ocelot_vcap_u16 etype;

			memset(&etype, 0, sizeof(etype));
Quoted 2 lines
drivers/net/ethernet/mscc/ocelot_vcap.c +0 -0
 			/* Overloaded field */
 			etype.value[0] = proto.value[0];
maintainer
#2 lore raw
Quoted 5 lines · Jakub Kicinski

I believe Vladimir asked to use a memset instead;

			struct ocelot_vcap_u16 etype;

			memset(&etype, 0, sizeof(etype));

Thanks, Jakub.