Skip to contentSkip to conversation

ARM: dts: sun8i: h3: Add initial NanoPi R1 support

PATCH In review Yu-Tung Chang 3 participants 8 messages Nov 2, 2020 – Nov 6, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover ARM: dts: sun8i: h3: Add initial NanoPi R1 support

This patch add FriendlyArm NanoPi R1 support.

Wiki:
http://wiki.friendlyarm.com/wiki/index.php/NanoPi_R1

Schematic:
http://wiki.friendlyarm.com/wiki/images/a/ab/NanoPi_R1_V1.0_1809-Schematic.pdf

v1:
- use SPDX header
- rename led node to led-[0-9]
- rename sdio-wifi node to wifi
- use "function" and "color" properties for led node
- modify usb_otg->dr_mode property to otg
- add aliases for uart1, emac, wifi

Yu-Tung Chang (1):
ARM: dts: sun8i: h3: Add initial NanoPi R1 support

 .../devicetree/bindings/arm/sunxi.yaml        |   5 +
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts      | 169 ++++++++++++++++++
 3 files changed, 175 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts
Signature · 1 line
2.29.0
#1 lore raw

PATCH 1/1 ARM: dts: sun8i: h3: Add initial NanoPi R1 support

The NanoPi R1 is a complete open source board developed by FriendlyElec for makers, hobbyists, fans and etc.

NanoPi R1 key features
- Allwinner H3, Quad-core [email protected]
- 512MB/1GB DDR3 RAM
- 8GB eMMC
- microSD slot
- 10/100/1000M Ethernet x 1
- 10/100 Ethernet x 1
- Wifi 802.11b/g/n
- Bluetooth 4.0
- Serial Debug Port
- 5V 2A DC power-supply

---
 .../devicetree/bindings/arm/sunxi.yaml        |   5 +
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts      | 169 ++++++++++++++++++
 3 files changed, 175 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts
Documentation/devicetree/bindings/arm/sunxi.yaml +5 -0
index 0f23133672a3..54a1aaee7e22 100644
@@ -251,6 +251,11 @@ properties:
           - const: friendlyarm,nanopi-neo-plus2
           - const: allwinner,sun50i-h5
 
+      - description: FriendlyARM NanoPi R1
+        items:
+          - const: friendlyarm,nanopi-r1
+          - const: allwinner,sun8i-h3
+
       - description: FriendlyARM ZeroPi
         items:
           - const: friendlyarm,zeropi
arch/arm/boot/dts/Makefile +1 -0
index 4f0adfead547..aabaf67f86ed 100644
@@ -1192,6 +1192,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \
 	sun8i-h3-nanopi-m1-plus.dtb \
 	sun8i-h3-nanopi-neo.dtb \
 	sun8i-h3-nanopi-neo-air.dtb \
+	sun8i-h3-nanopi-r1.dtb \
 	sun8i-h3-orangepi-2.dtb \
 	sun8i-h3-orangepi-lite.dtb \
 	sun8i-h3-orangepi-one.dtb \
arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts new file +169 -0

169 lines not on this page · raw message

Signature · 1 line
2.29.0
#2 lore raw

Hi!

Quoted 185 lines · Yu-Tung Chang

The NanoPi R1 is a complete open source board developed by FriendlyElec for makers, hobbyists, fans and etc.

NanoPi R1 key features
- Allwinner H3, Quad-core [email protected]
- 512MB/1GB DDR3 RAM
- 8GB eMMC
- microSD slot
- 10/100/1000M Ethernet x 1
- 10/100 Ethernet x 1
- Wifi 802.11b/g/n
- Bluetooth 4.0
- Serial Debug Port
- 5V 2A DC power-supply

---
 .../devicetree/bindings/arm/sunxi.yaml        |   5 +
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts      | 169 ++++++++++++++++++
 3 files changed, 175 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts
Documentation/devicetree/bindings/arm/sunxi.yaml +5 -0
index 0f23133672a3..54a1aaee7e22 100644
@@ -251,6 +251,11 @@ properties:
           - const: friendlyarm,nanopi-neo-plus2
           - const: allwinner,sun50i-h5
 
+      - description: FriendlyARM NanoPi R1
+        items:
+          - const: friendlyarm,nanopi-r1
+          - const: allwinner,sun8i-h3
+
       - description: FriendlyARM ZeroPi
         items:
           - const: friendlyarm,zeropi
arch/arm/boot/dts/Makefile +1 -0
index 4f0adfead547..aabaf67f86ed 100644
@@ -1192,6 +1192,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \
 	sun8i-h3-nanopi-m1-plus.dtb \
 	sun8i-h3-nanopi-neo.dtb \
 	sun8i-h3-nanopi-neo-air.dtb \
+	sun8i-h3-nanopi-r1.dtb \
 	sun8i-h3-orangepi-2.dtb \
 	sun8i-h3-orangepi-lite.dtb \
 	sun8i-h3-orangepi-one.dtb \
arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts new file +128 -0
new file mode 100644
index 000000000000..204a39f93f4e
@@ -0,0 +1,169 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2019 Igor Pecovnik <[email protected]>
+ * Copyright (C) 2020 Jayantajit Gogoi <[email protected]>
+ * Copyright (C) 2020 Yu-Tung Chang <[email protected]>
+*/
+
+#include "sun8i-h3-nanopi.dtsi"
+#include <dt-bindings/leds/common.h>
+
+/ {
+	model = "FriendlyARM NanoPi R1";
+	compatible = "friendlyarm,nanopi-r1", "allwinner,sun8i-h3";
+
+	aliases {
+		serial1 = &uart1;
+		ethernet0 = &emac;
+		ethernet1 = &wifi;
+	};
+
+	reg_gmac_3v3: gmac-3v3 {
+		compatible = "regulator-fixed";
+		regulator-name = "gmac-3v3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		startup-delay-us = <100000>;
+		enable-active-high;
+		gpio = <&pio 3 6 GPIO_ACTIVE_HIGH>; /* PD6 */
+	};
+
+	reg_vdd_cpux: gpio-regulator {
+		compatible = "regulator-gpio";
+		regulator-name = "vdd-cpux";
+		regulator-type = "voltage";
+		regulator-boot-on;
+		regulator-always-on;
+		regulator-min-microvolt = <1100000>;
+		regulator-max-microvolt = <1300000>;
+		regulator-ramp-delay = <50>;
+		gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */
+		gpios-states = <0x1>;
+		states = <1100000 0x0
+			  1300000 0x1>;
+	};
+
+	wifi_pwrseq: wifi_pwrseq {
+		compatible = "mmc-pwrseq-simple";
+		reset-gpios = <&r_pio 0 7 GPIO_ACTIVE_LOW>; /* PL7 */
+		clocks = <&rtc 1>;
+		clock-names = "ext_clock";
+	};
+
+	leds {
+		led-2 {
+			function = LED_FUNCTION_WAN;
+			color = <LED_COLOR_ID_GREEN>;
+			gpios = <&pio 6 11 GPIO_ACTIVE_HIGH>; /* PG11 */
+		};
+
+		led-3 {
+			function = LED_FUNCTION_LAN;
+			color = <LED_COLOR_ID_GREEN>;
+			gpios = <&pio 0 9 GPIO_ACTIVE_HIGH>; /* PA9 */
+		};
+	};
+};
+
+&cpu0 {
+	cpu-supply = <&reg_vdd_cpux>;
+};
+
+&ehci1 {
+	status = "okay";
+};
+
+&ehci2 {
+	status = "okay";
+};
+
+&emac {
+	pinctrl-names = "default";
+	pinctrl-0 = <&emac_rgmii_pins>;
+	phy-supply = <&reg_gmac_3v3>;
+	phy-handle = <&ext_rgmii_phy>;
+	phy-mode = "rgmii-id";
+	status = "okay";
+};
+
+&external_mdio {
+	ext_rgmii_phy: ethernet-phy@7 {
+		compatible = "ethernet-phy-ieee802.3-c22";
+		reg = <7>;
+	};
+};
+
+&mmc1 {
+	vmmc-supply = <&reg_vcc3v3>;
+	vqmmc-supply = <&reg_vcc3v3>;
+	mmc-pwrseq = <&wifi_pwrseq>;
+	bus-width = <4>;
+	non-removable;
+	status = "okay";
+
+	wifi: wifi@1 {
+		reg = <1>;
+		compatible = "brcm,bcm4329-fmac";
+		interrupt-parent = <&pio>;
+		interrupts = <6 10 IRQ_TYPE_LEVEL_LOW>; /* PG10 / EINT10 */
+		interrupt-names = "host-wake";
+	};
+};
+
+&mmc2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&mmc2_8bit_pins>;
+	vmmc-supply = <&reg_vcc3v3>;
+	vqmmc-supply = <&reg_vcc3v3>;
+	bus-width = <8>;
+	non-removable;
+	status = "okay";
+};
+
+&ohci1 {
+	status = "okay";
+};
+
+&ohci2 {
+	status = "okay";

arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts line 138

Quoted 10 lines
arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts new file +10 -0
+};
+
+&reg_usb0_vbus {
+	gpio = <&r_pio 0 2 GPIO_ACTIVE_HIGH>; /* PL2 */
+	status = "okay";
+};
+
+&uart1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&uart1_pins>;

This should be already set in the DTSI

arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts line 140

Quoted 2 lines
arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts new file +2 -0
+	status = "okay";
+};

What is this UART used for?

Thanks!
Maxime

#3 lore raw
Quoted 193 lines · Maxime Ripard <[email protected]> 于2020年11月3日周二 下午7:37写道:

Hi!

Quoted 189 lines · Yu-Tung Chang

The NanoPi R1 is a complete open source board developed by FriendlyElec for makers, hobbyists, fans and etc.

NanoPi R1 key features
- Allwinner H3, Quad-core [email protected]
- 512MB/1GB DDR3 RAM
- 8GB eMMC
- microSD slot
- 10/100/1000M Ethernet x 1
- 10/100 Ethernet x 1
- Wifi 802.11b/g/n
- Bluetooth 4.0
- Serial Debug Port
- 5V 2A DC power-supply

---
 .../devicetree/bindings/arm/sunxi.yaml        |   5 +
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts      | 169 ++++++++++++++++++
 3 files changed, 175 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts
Documentation/devicetree/bindings/arm/sunxi.yaml +5 -0
index 0f23133672a3..54a1aaee7e22 100644
@@ -251,6 +251,11 @@ properties:
           - const: friendlyarm,nanopi-neo-plus2
           - const: allwinner,sun50i-h5
 
+      - description: FriendlyARM NanoPi R1
+        items:
+          - const: friendlyarm,nanopi-r1
+          - const: allwinner,sun8i-h3
+
       - description: FriendlyARM ZeroPi
         items:
           - const: friendlyarm,zeropi
arch/arm/boot/dts/Makefile +1 -0
index 4f0adfead547..aabaf67f86ed 100644
@@ -1192,6 +1192,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \
      sun8i-h3-nanopi-m1-plus.dtb \
      sun8i-h3-nanopi-neo.dtb \
      sun8i-h3-nanopi-neo-air.dtb \
+     sun8i-h3-nanopi-r1.dtb \
      sun8i-h3-orangepi-2.dtb \
      sun8i-h3-orangepi-lite.dtb \
      sun8i-h3-orangepi-one.dtb \
arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts new file +132 -0
new file mode 100644
index 000000000000..204a39f93f4e
@@ -0,0 +1,169 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2019 Igor Pecovnik <[email protected]>
+ * Copyright (C) 2020 Jayantajit Gogoi <[email protected]>
+ * Copyright (C) 2020 Yu-Tung Chang <[email protected]>
+*/
+
+#include "sun8i-h3-nanopi.dtsi"
+#include <dt-bindings/leds/common.h>
+
+/ {
+     model = "FriendlyARM NanoPi R1";
+     compatible = "friendlyarm,nanopi-r1", "allwinner,sun8i-h3";
+
+     aliases {
+             serial1 = &uart1;
+             ethernet0 = &emac;
+             ethernet1 = &wifi;
+     };
+
+     reg_gmac_3v3: gmac-3v3 {
+             compatible = "regulator-fixed";
+             regulator-name = "gmac-3v3";
+             regulator-min-microvolt = <3300000>;
+             regulator-max-microvolt = <3300000>;
+             startup-delay-us = <100000>;
+             enable-active-high;
+             gpio = <&pio 3 6 GPIO_ACTIVE_HIGH>; /* PD6 */
+     };
+
+     reg_vdd_cpux: gpio-regulator {
+             compatible = "regulator-gpio";
+             regulator-name = "vdd-cpux";
+             regulator-type = "voltage";
+             regulator-boot-on;
+             regulator-always-on;
+             regulator-min-microvolt = <1100000>;
+             regulator-max-microvolt = <1300000>;
+             regulator-ramp-delay = <50>;
+             gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */
+             gpios-states = <0x1>;
+             states = <1100000 0x0
+                       1300000 0x1>;
+     };
+
+     wifi_pwrseq: wifi_pwrseq {
+             compatible = "mmc-pwrseq-simple";
+             reset-gpios = <&r_pio 0 7 GPIO_ACTIVE_LOW>; /* PL7 */
+             clocks = <&rtc 1>;
+             clock-names = "ext_clock";
+     };
+
+     leds {
+             led-2 {
+                     function = LED_FUNCTION_WAN;
+                     color = <LED_COLOR_ID_GREEN>;
+                     gpios = <&pio 6 11 GPIO_ACTIVE_HIGH>; /* PG11 */
+             };
+
+             led-3 {
+                     function = LED_FUNCTION_LAN;
+                     color = <LED_COLOR_ID_GREEN>;
+                     gpios = <&pio 0 9 GPIO_ACTIVE_HIGH>; /* PA9 */
+             };
+     };
+};
+
+&cpu0 {
+     cpu-supply = <&reg_vdd_cpux>;
+};
+
+&ehci1 {
+     status = "okay";
+};
+
+&ehci2 {
+     status = "okay";
+};
+
+&emac {
+     pinctrl-names = "default";
+     pinctrl-0 = <&emac_rgmii_pins>;
+     phy-supply = <&reg_gmac_3v3>;
+     phy-handle = <&ext_rgmii_phy>;
+     phy-mode = "rgmii-id";
+     status = "okay";
+};
+
+&external_mdio {
+     ext_rgmii_phy: ethernet-phy@7 {
+             compatible = "ethernet-phy-ieee802.3-c22";
+             reg = <7>;
+     };
+};
+
+&mmc1 {
+     vmmc-supply = <&reg_vcc3v3>;
+     vqmmc-supply = <&reg_vcc3v3>;
+     mmc-pwrseq = <&wifi_pwrseq>;
+     bus-width = <4>;
+     non-removable;
+     status = "okay";
+
+     wifi: wifi@1 {
+             reg = <1>;
+             compatible = "brcm,bcm4329-fmac";
+             interrupt-parent = <&pio>;
+             interrupts = <6 10 IRQ_TYPE_LEVEL_LOW>; /* PG10 / EINT10 */
+             interrupt-names = "host-wake";
+     };
+};
+
+&mmc2 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&mmc2_8bit_pins>;
+     vmmc-supply = <&reg_vcc3v3>;
+     vqmmc-supply = <&reg_vcc3v3>;
+     bus-width = <8>;
+     non-removable;
+     status = "okay";
+};
+
+&ohci1 {
+     status = "okay";
+};
+
+&ohci2 {
+     status = "okay";
+};
+
+&reg_usb0_vbus {
+     gpio = <&r_pio 0 2 GPIO_ACTIVE_HIGH>; /* PL2 */
Quoted 9 lines

arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts line 138

Quoted 6 lines
arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts new file +6 -0
+     status = "okay";
+};
+
+&uart1 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&uart1_pins>;

This should be already set in the DTSI

uart0 as the debugging interface, uart1 as the external uart port, uart3 as the bluetooth.

Quoted 5 lines

arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts line 140

Quoted 2 lines
arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts new file +2 -0
+     status = "okay";
+};

What is this UART used for?

uart1 as the external uart port, use a separate physical interface.

Quoted 2 lines

Thanks!
Maxime

Quoted 209 lines · Maxime Ripard <[email protected]> 于2020年11月3日周二 下午7:37写道:

Hi!

Quoted 185 lines · Yu-Tung Chang

The NanoPi R1 is a complete open source board developed by FriendlyElec for makers, hobbyists, fans and etc.

NanoPi R1 key features
- Allwinner H3, Quad-core [email protected]
- 512MB/1GB DDR3 RAM
- 8GB eMMC
- microSD slot
- 10/100/1000M Ethernet x 1
- 10/100 Ethernet x 1
- Wifi 802.11b/g/n
- Bluetooth 4.0
- Serial Debug Port
- 5V 2A DC power-supply

---
 .../devicetree/bindings/arm/sunxi.yaml        |   5 +
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts      | 169 ++++++++++++++++++
 3 files changed, 175 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts
Documentation/devicetree/bindings/arm/sunxi.yaml +5 -0
index 0f23133672a3..54a1aaee7e22 100644
@@ -251,6 +251,11 @@ properties:
           - const: friendlyarm,nanopi-neo-plus2
           - const: allwinner,sun50i-h5
 
+      - description: FriendlyARM NanoPi R1
+        items:
+          - const: friendlyarm,nanopi-r1
+          - const: allwinner,sun8i-h3
+
       - description: FriendlyARM ZeroPi
         items:
           - const: friendlyarm,zeropi
arch/arm/boot/dts/Makefile +1 -0
index 4f0adfead547..aabaf67f86ed 100644
@@ -1192,6 +1192,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \
      sun8i-h3-nanopi-m1-plus.dtb \
      sun8i-h3-nanopi-neo.dtb \
      sun8i-h3-nanopi-neo-air.dtb \
+     sun8i-h3-nanopi-r1.dtb \
      sun8i-h3-orangepi-2.dtb \
      sun8i-h3-orangepi-lite.dtb \
      sun8i-h3-orangepi-one.dtb \
arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts new file +128 -0
new file mode 100644
index 000000000000..204a39f93f4e
@@ -0,0 +1,169 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2019 Igor Pecovnik <[email protected]>
+ * Copyright (C) 2020 Jayantajit Gogoi <[email protected]>
+ * Copyright (C) 2020 Yu-Tung Chang <[email protected]>
+*/
+
+#include "sun8i-h3-nanopi.dtsi"
+#include <dt-bindings/leds/common.h>
+
+/ {
+     model = "FriendlyARM NanoPi R1";
+     compatible = "friendlyarm,nanopi-r1", "allwinner,sun8i-h3";
+
+     aliases {
+             serial1 = &uart1;
+             ethernet0 = &emac;
+             ethernet1 = &wifi;
+     };
+
+     reg_gmac_3v3: gmac-3v3 {
+             compatible = "regulator-fixed";
+             regulator-name = "gmac-3v3";
+             regulator-min-microvolt = <3300000>;
+             regulator-max-microvolt = <3300000>;
+             startup-delay-us = <100000>;
+             enable-active-high;
+             gpio = <&pio 3 6 GPIO_ACTIVE_HIGH>; /* PD6 */
+     };
+
+     reg_vdd_cpux: gpio-regulator {
+             compatible = "regulator-gpio";
+             regulator-name = "vdd-cpux";
+             regulator-type = "voltage";
+             regulator-boot-on;
+             regulator-always-on;
+             regulator-min-microvolt = <1100000>;
+             regulator-max-microvolt = <1300000>;
+             regulator-ramp-delay = <50>;
+             gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */
+             gpios-states = <0x1>;
+             states = <1100000 0x0
+                       1300000 0x1>;
+     };
+
+     wifi_pwrseq: wifi_pwrseq {
+             compatible = "mmc-pwrseq-simple";
+             reset-gpios = <&r_pio 0 7 GPIO_ACTIVE_LOW>; /* PL7 */
+             clocks = <&rtc 1>;
+             clock-names = "ext_clock";
+     };
+
+     leds {
+             led-2 {
+                     function = LED_FUNCTION_WAN;
+                     color = <LED_COLOR_ID_GREEN>;
+                     gpios = <&pio 6 11 GPIO_ACTIVE_HIGH>; /* PG11 */
+             };
+
+             led-3 {
+                     function = LED_FUNCTION_LAN;
+                     color = <LED_COLOR_ID_GREEN>;
+                     gpios = <&pio 0 9 GPIO_ACTIVE_HIGH>; /* PA9 */
+             };
+     };
+};
+
+&cpu0 {
+     cpu-supply = <&reg_vdd_cpux>;
+};
+
+&ehci1 {
+     status = "okay";
+};
+
+&ehci2 {
+     status = "okay";
+};
+
+&emac {
+     pinctrl-names = "default";
+     pinctrl-0 = <&emac_rgmii_pins>;
+     phy-supply = <&reg_gmac_3v3>;
+     phy-handle = <&ext_rgmii_phy>;
+     phy-mode = "rgmii-id";
+     status = "okay";
+};
+
+&external_mdio {
+     ext_rgmii_phy: ethernet-phy@7 {
+             compatible = "ethernet-phy-ieee802.3-c22";
+             reg = <7>;
+     };
+};
+
+&mmc1 {
+     vmmc-supply = <&reg_vcc3v3>;
+     vqmmc-supply = <&reg_vcc3v3>;
+     mmc-pwrseq = <&wifi_pwrseq>;
+     bus-width = <4>;
+     non-removable;
+     status = "okay";
+
+     wifi: wifi@1 {
+             reg = <1>;
+             compatible = "brcm,bcm4329-fmac";
+             interrupt-parent = <&pio>;
+             interrupts = <6 10 IRQ_TYPE_LEVEL_LOW>; /* PG10 / EINT10 */
+             interrupt-names = "host-wake";
+     };
+};
+
+&mmc2 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&mmc2_8bit_pins>;
+     vmmc-supply = <&reg_vcc3v3>;
+     vqmmc-supply = <&reg_vcc3v3>;
+     bus-width = <8>;
+     non-removable;
+     status = "okay";
+};
+
+&ohci1 {
+     status = "okay";
+};
+
+&ohci2 {
+     status = "okay";

arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts line 138

Quoted 10 lines
arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts new file +10 -0
+};
+
+&reg_usb0_vbus {
+     gpio = <&r_pio 0 2 GPIO_ACTIVE_HIGH>; /* PL2 */
+     status = "okay";
+};
+
+&uart1 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&uart1_pins>;

This should be already set in the DTSI

arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts line 140

Quoted 2 lines
arch/arm/boot/dts/sun8i-h3-nanopi-r1.dts new file +2 -0
+     status = "okay";
+};

What is this UART used for?

Thanks!
Maxime

#4 lore raw
Quoted 8 lines · Yu-Tung Chang
Quoted 6 lines

Review

Quoted 3 lines

+&uart1 {

(quoted diff) +2 -0
+     pinctrl-names = "default";
+     pinctrl-0 = <&uart1_pins>;

This should be already set in the DTSI

uart0 as the debugging interface, uart1 as the external uart port, uart3 as the bluetooth.

What I mean is that since it's the only muxing option, the pinctrl properties should already be set in the DTSI, so it's redundant to put them in the DTS.

Maxime

#5 lore raw
Quoted 6 lines · Maxime Ripard <[email protected]> 于2020年11月6日周五 上午1:10写道:
Quoted 4 lines · Yu-Tung Chang
Quoted 4 lines
Quoted 3 lines

+&uart1 {

(quoted diff) +2 -0
+     pinctrl-names = "default";
+     pinctrl-0 = <&uart1_pins>;
Quoted 9 lines
Quoted 4 lines
Quoted 2 lines

This should be already set in the DTSI

uart0 as the debugging interface, uart1 as the external uart port, uart3 as the bluetooth.

What I mean is that since it's the only muxing option, the pinctrl properties should already be set in the DTSI, so it's redundant to put them in the DTS.

I can only see the definition of uart0 in the DTSI, because uart1 as the extension interface is exclusive to NanoPi R1.

Quoted 1 line

Maxime

#6 lore raw
Quoted 13 lines · Yu-Tung Chang
Quoted 11 lines · Maxime Ripard <[email protected]> 于2020年11月6日周五 上午1:10写道:
Quoted 8 lines · Yu-Tung Chang
Quoted 6 lines

Review

Quoted 3 lines

+&uart1 {

(quoted diff) +2 -0
+     pinctrl-names = "default";
+     pinctrl-0 = <&uart1_pins>;

This should be already set in the DTSI

uart0 as the debugging interface, uart1 as the external uart port, uart3 as the bluetooth.

Quoted 6 lines
Quoted 4 lines

What I mean is that since it's the only muxing option, the pinctrl properties should already be set in the DTSI, so it's redundant to put them in the DTS.

I can only see the definition of uart0 in the DTSI, because uart1 as the extension interface is exclusive to NanoPi R1.

Maxime, to clarify, UART1 can be used with or without RTS/CTS, so there is no default muxing in the DTSI.

ChenYu

#7 lore raw
Quoted 18 lines · Chen-Yu Tsai
Quoted 17 lines · Yu-Tung Chang
Quoted 15 lines · Maxime Ripard <[email protected]> 于2020年11月6日周五 上午1:10写道:
Quoted 8 lines · Yu-Tung Chang
Quoted 6 lines

Review

Quoted 3 lines

+&uart1 {

(quoted diff) +2 -0
+     pinctrl-names = "default";
+     pinctrl-0 = <&uart1_pins>;

This should be already set in the DTSI

uart0 as the debugging interface, uart1 as the external uart port, uart3 as the bluetooth.

What I mean is that since it's the only muxing option, the pinctrl properties should already be set in the DTSI, so it's redundant to put them in the DTS.

Quoted 5 lines
Quoted 2 lines

I can only see the definition of uart0 in the DTSI, because uart1 as the extension interface is exclusive to NanoPi R1.

Maxime, to clarify, UART1 can be used with or without RTS/CTS, so there is no default muxing in the DTSI.

Ah, right. I've applied the patch, thanks!
Maxime