PM / Domains: replace -ENOTSUPP with -EOPNOTSUPP

PATCH Superseded Lina Iyer 2 participants 4 messages Nov 6, 2020 – Nov 9, 2020

Subsystems (3)

Arm Qualcomm mailing list Power management core Generic PM domains

lore

Share & tools

lore

Lina Iyer

author

2020-11-06 16:49 UTC #0 lore raw

PATCH 1/1 PM / Domains: replace -ENOTSUPP with -EOPNOTSUPP

While submitting a patch to add next_wakeup, checkpatch reported this -

WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
+ return -ENOTSUPP;

Address the above warning in other functions in pm_domain.h.

Signed-off-by Lina Iyer <[email protected]>

---
 include/linux/pm_domain.h | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

include/linux/pm_domain.h +7 -7

index 49982cd58bfd..e390388e6c17 100644
@@ -259,24 +259,24 @@ static inline int pm_genpd_init(struct generic_pm_domain *genpd,
 }
 static inline int pm_genpd_remove(struct generic_pm_domain *genpd)
 {
-	return -ENOTSUPP;
+	return -EOPNOTSUPP;
 }
 
 static inline int dev_pm_genpd_set_performance_state(struct device *dev,
 						     unsigned int state)
 {
-	return -ENOTSUPP;
+	return -EOPNOTSUPP;
 }
 
 static inline int dev_pm_genpd_add_notifier(struct device *dev,
 					    struct notifier_block *nb)
 {
-	return -ENOTSUPP;
+	return -EOPNOTSUPP;
 }
 
 static inline int dev_pm_genpd_remove_notifier(struct device *dev)
 {
-	return -ENOTSUPP;
+	return -EOPNOTSUPP;
 }
 
 static inline int dev_pm_genpd_set_next_wakeup(struct device *dev, ktime_t next)

@@ -334,13 +334,13 @@ struct device *genpd_dev_pm_attach_by_name(struct device *dev,
 static inline int of_genpd_add_provider_simple(struct device_node *np,
 					struct generic_pm_domain *genpd)
 {
-	return -ENOTSUPP;
+	return -EOPNOTSUPP;
 }
 
 static inline int of_genpd_add_provider_onecell(struct device_node *np,
 					struct genpd_onecell_data *data)
 {
-	return -ENOTSUPP;
+	return -EOPNOTSUPP;
 }
 
 static inline void of_genpd_del_provider(struct device_node *np) {}

@@ -396,7 +396,7 @@ static inline struct device *genpd_dev_pm_attach_by_name(struct device *dev,
 static inline
 struct generic_pm_domain *of_genpd_remove_last(struct device_node *np)
 {
-	return ERR_PTR(-ENOTSUPP);
+	return ERR_PTR(-EOPNOTSUPP);
 }
 #endif /* CONFIG_PM_GENERIC_DOMAINS_OF */

Signature · 2 lines

The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

Ulf Hansson

Reviewed-by on v1 1/1

2020-11-09 11:40 UTC #1 lore raw

Quoted 9 lines · Lina Iyer

While submitting a patch to add next_wakeup, checkpatch reported this -
WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
+ return -ENOTSUPP;
Address the above warning in other functions in pm_domain.h.
Signed-off-by Lina Iyer <[email protected]>

I assume you have looked at callers of these functions too, to make sure they don't explicitly look at -ENOTSUPP?

Reviewed-by Ulf Hansson <[email protected]>

Kind regards
Uffe

Quoted 66 lines

---
 include/linux/pm_domain.h | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

include/linux/pm_domain.h +7 -8

index 49982cd58bfd..e390388e6c17 100644
@@ -259,24 +259,24 @@ static inline int pm_genpd_init(struct generic_pm_domain *genpd,
 }
 static inline int pm_genpd_remove(struct generic_pm_domain *genpd)
 {
-       return -ENOTSUPP;
+       return -EOPNOTSUPP;
 }
 
 static inline int dev_pm_genpd_set_performance_state(struct device *dev,
                                                     unsigned int state)
 {
-       return -ENOTSUPP;
+       return -EOPNOTSUPP;
 }
 
 static inline int dev_pm_genpd_add_notifier(struct device *dev,
                                            struct notifier_block *nb)
 {
-       return -ENOTSUPP;
+       return -EOPNOTSUPP;
 }
 
 static inline int dev_pm_genpd_remove_notifier(struct device *dev)
 {
-       return -ENOTSUPP;
+       return -EOPNOTSUPP;
 }
 
 static inline int dev_pm_genpd_set_next_wakeup(struct device *dev, ktime_t next)

@@ -334,13 +334,13 @@ struct device *genpd_dev_pm_attach_by_name(struct device *dev,
 static inline int of_genpd_add_provider_simple(struct device_node *np,
                                        struct generic_pm_domain *genpd)
 {
-       return -ENOTSUPP;
+       return -EOPNOTSUPP;
 }
 
 static inline int of_genpd_add_provider_onecell(struct device_node *np,
                                        struct genpd_onecell_data *data)
 {
-       return -ENOTSUPP;
+       return -EOPNOTSUPP;
 }
 
 static inline void of_genpd_del_provider(struct device_node *np) {}

@@ -396,7 +396,7 @@ static inline struct device *genpd_dev_pm_attach_by_name(struct device *dev,
 static inline
 struct generic_pm_domain *of_genpd_remove_last(struct device_node *np)
 {
-       return ERR_PTR(-ENOTSUPP);
+       return ERR_PTR(-EOPNOTSUPP);
 }
 #endif /* CONFIG_PM_GENERIC_DOMAINS_OF */
 
--

The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

Lina Iyer

author

2020-11-09 15:24 UTC #2 lore raw

Quoted 7 lines · Ulf Hansson

Quoted 6 lines · Lina Iyer
While submitting a patch to add next_wakeup, checkpatch reported this -
WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
+ return -ENOTSUPP;

Quoted 7 lines

Quoted 3 lines
Address the above warning in other functions in pm_domain.h.
Signed-off-by Lina Iyer <[email protected]>
I assume you have looked at callers of these functions too, to make sure they don't explicitly look at -ENOTSUPP?

Yes, the first level callers at least. Most of them seem to return from probe calls etc. Is there a nice way to make sure the second level functions and the callers of those are not using -ENOTSUPP return from these functions.

Quoted 2 lines

Reviewed-by Ulf Hansson <[email protected]>

Thanks.

-- Lina

Quoted 69 lines

Kind regards
Uffe

Quoted 66 lines

---
 include/linux/pm_domain.h | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

include/linux/pm_domain.h +7 -8

index 49982cd58bfd..e390388e6c17 100644
@@ -259,24 +259,24 @@ static inline int pm_genpd_init(struct generic_pm_domain *genpd,
 }
 static inline int pm_genpd_remove(struct generic_pm_domain *genpd)
 {
-       return -ENOTSUPP;
+       return -EOPNOTSUPP;
 }
 
 static inline int dev_pm_genpd_set_performance_state(struct device *dev,
                                                     unsigned int state)
 {
-       return -ENOTSUPP;
+       return -EOPNOTSUPP;
 }
 
 static inline int dev_pm_genpd_add_notifier(struct device *dev,
                                            struct notifier_block *nb)
 {
-       return -ENOTSUPP;
+       return -EOPNOTSUPP;
 }
 
 static inline int dev_pm_genpd_remove_notifier(struct device *dev)
 {
-       return -ENOTSUPP;
+       return -EOPNOTSUPP;
 }
 
 static inline int dev_pm_genpd_set_next_wakeup(struct device *dev, ktime_t next)

@@ -334,13 +334,13 @@ struct device *genpd_dev_pm_attach_by_name(struct device *dev,
 static inline int of_genpd_add_provider_simple(struct device_node *np,
                                        struct generic_pm_domain *genpd)
 {
-       return -ENOTSUPP;
+       return -EOPNOTSUPP;
 }
 
 static inline int of_genpd_add_provider_onecell(struct device_node *np,
                                        struct genpd_onecell_data *data)
 {
-       return -ENOTSUPP;
+       return -EOPNOTSUPP;
 }
 
 static inline void of_genpd_del_provider(struct device_node *np) {}

@@ -396,7 +396,7 @@ static inline struct device *genpd_dev_pm_attach_by_name(struct device *dev,
 static inline
 struct generic_pm_domain *of_genpd_remove_last(struct device_node *np)
 {
-       return ERR_PTR(-ENOTSUPP);
+       return ERR_PTR(-EOPNOTSUPP);
 }
 #endif /* CONFIG_PM_GENERIC_DOMAINS_OF */
 
--

The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project

Ulf Hansson

2020-11-09 15:30 UTC #3 lore raw

Quoted 13 lines · Lina Iyer

Quoted 11 lines · Ulf Hansson
Quoted 9 lines · Lina Iyer
While submitting a patch to add next_wakeup, checkpatch reported this -
WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
+ return -ENOTSUPP;
Address the above warning in other functions in pm_domain.h.
Signed-off-by Lina Iyer <[email protected]>

Quoted 7 lines

Quoted 3 lines
I assume you have looked at callers of these functions too, to make sure they don't explicitly look at -ENOTSUPP?
Yes, the first level callers at least. Most of them seem to return from probe calls etc. Is there a nice way to make sure the second level functions and the callers of those are not using -ENOTSUPP return from these functions.

Good question. But I can't think of one (besides code inspection) - unless you have a running system.

Quoted 2 lines

Quoted 2 lines
Reviewed-by Ulf Hansson <[email protected]>

Anyway, let's give this a try and see what happens!

Kind regards
Uffe

Quoted 64 lines

 1 file changed, 7 insertions(+), 7 deletions(-)

include/linux/pm_domain.h +7 -8

index 49982cd58bfd..e390388e6c17 100644
@@ -259,24 +259,24 @@ static inline int pm_genpd_init(struct generic_pm_domain *genpd,
 }
 static inline int pm_genpd_remove(struct generic_pm_domain *genpd)
 {
-       return -ENOTSUPP;
+       return -EOPNOTSUPP;
 }
 
 static inline int dev_pm_genpd_set_performance_state(struct device *dev,
                                                     unsigned int state)
 {
-       return -ENOTSUPP;
+       return -EOPNOTSUPP;
 }
 
 static inline int dev_pm_genpd_add_notifier(struct device *dev,
                                            struct notifier_block *nb)
 {
-       return -ENOTSUPP;
+       return -EOPNOTSUPP;
 }
 
 static inline int dev_pm_genpd_remove_notifier(struct device *dev)
 {
-       return -ENOTSUPP;
+       return -EOPNOTSUPP;
 }
 
 static inline int dev_pm_genpd_set_next_wakeup(struct device *dev, ktime_t next)

@@ -334,13 +334,13 @@ struct device *genpd_dev_pm_attach_by_name(struct device *dev,
 static inline int of_genpd_add_provider_simple(struct device_node *np,
                                        struct generic_pm_domain *genpd)
 {
-       return -ENOTSUPP;
+       return -EOPNOTSUPP;
 }
 
 static inline int of_genpd_add_provider_onecell(struct device_node *np,
                                        struct genpd_onecell_data *data)
 {
-       return -ENOTSUPP;
+       return -EOPNOTSUPP;
 }
 
 static inline void of_genpd_del_provider(struct device_node *np) {}

@@ -396,7 +396,7 @@ static inline struct device *genpd_dev_pm_attach_by_name(struct device *dev,
 static inline
 struct generic_pm_domain *of_genpd_remove_last(struct device_node *np)
 {
-       return ERR_PTR(-ENOTSUPP);
+       return ERR_PTR(-EOPNOTSUPP);
 }
 #endif /* CONFIG_PM_GENERIC_DOMAINS_OF */
 
--

The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project