Skip to contentSkip to conversation

ath11k: fix ZERO address in probe request

PATCH In review Carl Huang 2 participants 3 messages Oct 12, 2020 – Nov 7, 2020 Qualcomm Atheros ATH11K wireless driver

lore
Share & tools
lore

Carl Huang

author
#0 lore raw

PATCH 1/1 ath11k: fix ZERO address in probe request

Host needs to pass at least on bssid with all 0xff to firmware in WMI_START_SCAN_CMDID, otherwise the bssid and receiver address in probe requeste are all ZEROs.

This also fixed some hidden AP connection issue because some AP doesn't respond to probe request which receiver address are all ZEROs.

Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1

---
 drivers/net/wireless/ath/ath11k/wmi.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/net/wireless/ath/ath11k/wmi.c +5 -0
index adde14a390ec..9e56544e2cb9 100644
@@ -1946,6 +1946,11 @@ void ath11k_wmi_start_scan_init(struct ath11k *ar,
 				  WMI_SCAN_EVENT_DEQUEUED;
 	arg->scan_flags |= WMI_SCAN_CHAN_STAT_EVENT;
 	arg->num_bssid = 1;
+	/* fill bssid_list[0] with 0xff, otherwise
+	 * bssid and RA will be ZEROs in probe request.
+	 */
+	eth_broadcast_addr(arg->bssid_list[0].addr);
+
 }
 
 static inline void
Signature · 1 line
2.28.0
#1 lore raw
Quoted 4 lines · Carl Huang

Host needs to pass at least on bssid with all 0xff to firmware in WMI_START_SCAN_CMDID, otherwise the bssid and receiver address in probe requeste are all ZEROs.

Quoted 8 lines

This also fixed some hidden AP connection issue because some AP doesn't respond to probe request which receiver address are all ZEROs.

Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1

Patch applied to ath-next branch of ath.git, thanks.

fa7572c2cfe0 ath11k: fix ZERO address in probe request

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#2 lore raw
In reply to Carl Huang
Quoted 4 lines · Carl Huang

Host needs to pass at least on bssid with all 0xff to firmware in WMI_START_SCAN_CMDID, otherwise the bssid and receiver address in probe requeste are all ZEROs.

Quoted 8 lines

This also fixed some hidden AP connection issue because some AP doesn't respond to probe request which receiver address are all ZEROs.

Tested-on: QCA6390 hw2.0 PCI WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1

Patch applied to ath-next branch of ath.git, thanks.

fa7572c2cfe0 ath11k: fix ZERO address in probe request

Signature · 9 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


-- 
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k