drivers: rtc: retire RTC_DRV_GOLDFISH
Subsystems (3)
PATCH 1/1 drivers: rtc: retire RTC_DRV_GOLDFISH
From: Roman Kiryanov <[email protected]>
The only user of RTC_DRV_GOLDFISH is
the MIPS flavor of Android Studio Emulator
(goldfish) which should be also retired.
--- arch/riscv/Kconfig.socs | 1 - drivers/rtc/Kconfig | 10 -- drivers/rtc/Makefile | 1 - drivers/rtc/rtc-goldfish.c | 216 ------------------------------------- 4 files changed, 228 deletions(-) delete mode 100644 drivers/rtc/rtc-goldfish.c
arch/riscv/Kconfig.socs +0 -1
@@ -17,7 +17,6 @@ config SOC_VIRT select POWER_RESET_SYSCON select POWER_RESET_SYSCON_POWEROFF select GOLDFISH - select RTC_DRV_GOLDFISH if RTC_CLASS select SIFIVE_PLIC help This enables support for QEMU Virt Machine.
drivers/rtc/Kconfig +0 -10
@@ -1932,16 +1932,6 @@ config RTC_DRV_HID_SENSOR_TIME If this driver is compiled as a module, it will be named rtc-hid-sensor-time. -config RTC_DRV_GOLDFISH - tristate "Goldfish Real Time Clock" - depends on OF && HAS_IOMEM - depends on GOLDFISH || COMPILE_TEST - help - Say yes to enable RTC driver for the Goldfish based virtual platform. - - Goldfish is a code name for the virtual platform developed by Google - for Android emulation. - config RTC_DRV_WILCO_EC tristate "Wilco EC RTC" depends on WILCO_EC
drivers/rtc/Makefile +0 -1
@@ -71,7 +71,6 @@ obj-$(CONFIG_RTC_DRV_FM3130) += rtc-fm3130.o obj-$(CONFIG_RTC_DRV_FSL_FTM_ALARM) += rtc-fsl-ftm-alarm.o obj-$(CONFIG_RTC_DRV_FTRTC010) += rtc-ftrtc010.o obj-$(CONFIG_RTC_DRV_GENERIC) += rtc-generic.o -obj-$(CONFIG_RTC_DRV_GOLDFISH) += rtc-goldfish.o obj-$(CONFIG_RTC_DRV_HID_SENSOR_TIME) += rtc-hid-sensor-time.o obj-$(CONFIG_RTC_DRV_HYM8563) += rtc-hym8563.o obj-$(CONFIG_RTC_DRV_IMXDI) += rtc-imxdi.o
drivers/rtc/rtc-goldfish.c deleted +0 -216
216 lines not on this page · raw message
Signature · 1 line
2.29.2.299.gdc1121823c-goog
Quoted 6 lines · On Fri, Nov 13, 2020 at 12:52:33PM -0800, [email protected] wrote:
From: Roman Kiryanov <[email protected]>
The only user of
RTC_DRV_GOLDFISHis
the MIPS flavor of Android Studio Emulator
(goldfish) which should be also retired.
Quoted 8 lines
Signed-off-by Roman Kiryanov <[email protected]>--- arch/riscv/Kconfig.socs | 1 - drivers/rtc/Kconfig | 10 -- drivers/rtc/Makefile | 1 - drivers/rtc/rtc-goldfish.c | 216 ------------------------------------- 4 files changed, 228 deletions(-) delete mode 100644 drivers/rtc/rtc-goldfish.c
What about the binding and MAINTAINERS?
Hi Rob, thank you for looking into this.
Quoted 17 lines · Rob Herring
Quoted 6 lines · On Fri, Nov 13, 2020 at 12:52:33PM -0800, [email protected] wrote:
From: Roman Kiryanov <[email protected]>
The only user of
RTC_DRV_GOLDFISHis
the MIPS flavor of Android Studio Emulator
(goldfish) which should be also retired.Quoted 8 lines
Signed-off-by Roman Kiryanov <[email protected]>--- arch/riscv/Kconfig.socs | 1 - drivers/rtc/Kconfig | 10 -- drivers/rtc/Makefile | 1 - drivers/rtc/rtc-goldfish.c | 216 ------------------------------------- 4 files changed, 228 deletions(-) delete mode 100644 drivers/rtc/rtc-goldfish.c
Quoted 1 line
What about the binding and
MAINTAINERS?
My bad, I will update those files too.
Regards,
Roman.
Quoted 21 lines · Roman Kiryanov
Hi Rob, thank you for looking into this.
Quoted 17 lines · Rob Herring
Quoted 14 lines · On Fri, Nov 13, 2020 at 12:52:33PM -0800, [email protected] wrote:
From: Roman Kiryanov <[email protected]>
The only user of
RTC_DRV_GOLDFISHis
the MIPS flavor of Android Studio Emulator
(goldfish) which should be also retired.Signed-off-by Roman Kiryanov <[email protected]>--- arch/riscv/Kconfig.socs | 1 - drivers/rtc/Kconfig | 10 -- drivers/rtc/Makefile | 1 - drivers/rtc/rtc-goldfish.c | 216 ------------------------------------- 4 files changed, 228 deletions(-) delete mode 100644 drivers/rtc/rtc-goldfish.c
Quoted 3 lines
Quoted 1 line
What about the binding and
MAINTAINERS?My bad, I will update those files too.
Though the binding is still used in arch/mips/generic/board-ranchu.c and arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts. The latter was just added recently, so maybe premature to remove things?
Rob
Hi Hancai,
I see you added /arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts which refers to goldfish-rtc in 39c1485c8baa47aa20caefc1ec0a3410fbad6c81. We (Android Studio Emulator aka "goldfish") do not support MIPS anymore. Do you know if goldfish-rtc still works and is assumed to be available?
Quoted 8 lines · Rob Herring
Quoted 4 lines
Quoted 2 lines
What about the binding and
MAINTAINERS?My bad, I will update those files too.
Though the binding is still used in
arch/mips/generic/board-ranchu.candarch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts. The latter was just added recently, so maybe premature to remove things?
Thank you for catching this.
Regards,
Roman.
+Greg KH
Quoted 22 lines · Roman Kiryanov
Hi Hancai,
I see you added /arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts which refers to goldfish-rtc in
39c1485c8baa47aa20caefc1ec0a3410fbad6c81. We (Android Studio Emulator aka "goldfish") do not support MIPS anymore. Do you know if goldfish-rtc still works and is assumed to be available?Quoted 8 lines · Rob Herring
Quoted 4 lines
Quoted 2 lines
What about the binding and
MAINTAINERS?My bad, I will update those files too.
Though the binding is still used in
arch/mips/generic/board-ranchu.candarch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts. The latter was just added recently, so maybe premature to remove things?Thank you for catching this.
Regards,
Roman.
Quoted 10 lines · Roman Kiryanov
+Greg KH
Quoted 7 lines · Roman Kiryanov
Hi Hancai,
I see you added /arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts which refers to goldfish-rtc in
39c1485c8baa47aa20caefc1ec0a3410fbad6c81. We (Android Studio Emulator aka "goldfish") do not support MIPS anymore. Do you know if goldfish-rtc still works and is assumed to be available?
I've dropped this patch from my trees now, please feel free to resend when you have an updated version.
thanks,
greg k-h
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 4 lines · 陈华才
Hi, All,
Goldfish RTC works well on MIPS, and QEMU RISC-V emulator use Goldfish as well, so I think we should keep it in kernel.
But does anyone actually use it for anything? Having something in qemu is nice, but not required if it doesn't provide something that is already there for other virtual devices, right?
thanks,
greg k-h
Jiaxun Yang
maintainer在 2020/11/14 下午4:15, Greg KH 写道:
+ qemu-riscv list and QEMU device maintainers of goldfish_rtc
Quoted 8 lines · 陈华才
Quoted 4 lines
Hi, All,
Goldfish RTC works well on MIPS, and QEMU RISC-V emulator use Goldfish as well, so I think we should keep it in kernel.
But does anyone actually use it for anything? Having something in qemu is nice, but not required if it doesn't provide something that is already there for other virtual devices, right?
Hi all,
Both QEMU MIPS loongson3-virt and riscv virt machine are using goldfish_rtc as sole RTC device, it have been hardcoded in QEMU for a long while and sudden drop in kernel would break these machines.
RTC is essential for virt machines to keep time synchronized with host.
Given that it is the simplest RTC implementation for now, it won't give us much maintenance overhead.
Thus I do think it shouldn't be retired as for now. If nobody comes in I'd also willing to maintain it.
Thanks
- Jiaxun
Quoted 5 lines
thanks,
greg k-h
Quoted 24 lines · Jiaxun Yang
在 2020/11/14 下午4:15, Greg KH 写道:
+ qemu-riscv list and QEMU device maintainers of
goldfish_rtcQuoted 8 lines · 陈华才
Quoted 4 lines
Hi, All,
Goldfish RTC works well on MIPS, and QEMU RISC-V emulator use Goldfish as well, so I think we should keep it in kernel.
But does anyone actually use it for anything? Having something in qemu is nice, but not required if it doesn't provide something that is already there for other virtual devices, right?
Hi all,
Both QEMU MIPS loongson3-virt and riscv virt machine are using
goldfish_rtcas sole RTC
device, it have been hardcoded in QEMU for a long while and sudden drop in kernel would
break these machines.
RTC is essential for virt machines to keep time synchronized with host.
Quoted 7 lines
Given that it is the simplest RTC implementation for now, it won't give us much maintenance
overhead.Thus I do think it shouldn't be retired as for now. If nobody comes in I'd also willing to maintain
it.
Ok, can someone submit a patch to update the MAINTAINERS file for this so we know who to route issues to over time?
thanks,
greg k-h
Quoted 6 lines
Quoted 3 lines
Thus I do think it shouldn't be retired as for now. If nobody comes in I'd also willing to maintain
it.Ok, can someone submit a patch to update the
MAINTAINERSfile for this so we know who to route issues to over time?
I will send a patch to update MAINTAINERS for goldfish-rtc.
Quoted 2 lines · Jiaxun Yang
Thus I do think it shouldn't be retired as for now. If nobody comes in I'd also willing to maintain
Hi Jiaxun and Hancai,
I sent a patch to add you to MAINTAINERS for goldfish-rtc. Could you please ack there?
Regards,
Roman.
Jiaxun Yang
maintainer于 2020年12月9日 GMT+08:00 上午6:28:11, Roman Kiryanov <[email protected]> 写到:
Quoted 8 lines · Jiaxun Yang
Quoted 2 lines
Thus I do think it shouldn't be retired as for now. If nobody comes in I'd also willing to maintain
Hi Jiaxun and Hancai,
I sent a patch to add you to
MAINTAINERSfor goldfish-rtc. Could you please ack there?
Hi Roman,
My patch modifying Maintainers had been accepted by rtc tree.
Thanks.
- Jiaxun
Quoted 3 lines
Regards,
Roman.
Quoted 4 lines · 陈华才
Hi, All,
Goldfish RTC works well on MIPS, and QEMU RISC-V emulator use Goldfish as well, so I think we should keep it in kernel.
And more importantly, if you rely on this, are you willing to maintain it?
thanks,
gre gk-h
Hi, Greg,
Quoted 9 lines · Greg KH
Quoted 4 lines · 陈华才
Hi, All,
Goldfish RTC works well on MIPS, and QEMU RISC-V emulator use Goldfish as well, so I think we should keep it in kernel.
And more importantly, if you rely on this, are you willing to maintain it?
I think it will break the booting of MIPS/RISCV QEMU virtual machines, because RTC is an necessary device.
For the maintenance, I don't know whether Goldfish RTC depends on the code under drivers/platform/goldfish. If not, I think I can maintain it (I think other parts of Goldfish will be removed, I'm able to maintain RTC but I'm not able to maintain the whole).
Huacai
Quoted 4 lines
thanks,
gre gk-h
Hi Hancai,
do you know if CONFIG_GOLDFISH_AUDIO is required for MIPS? I sent a patch to retire it.
Regards,
Roman.
Quoted 35 lines · 陈华才
Hi, All,
Goldfish RTC works well on MIPS, and QEMU RISC-V emulator use Goldfish as well, so I think we should keep it in kernel.
Huacai
------------------ Original ------------------
From: "Greg KH"<[email protected]>; Date: Sat, Nov 14, 2020 07:43 AM To: "Roman Kiryanov"<[email protected]>;Cc: "chenhc"<[email protected]>; "Paul Walmsley"<[email protected]>; "LKML"<[email protected]>; "Lingfeng Yang"<[email protected]>; "Rob Herring"<[email protected]>;
Subject: Re: [PATCH] drivers: rtc: retireRTC_DRV_GOLDFISHQuoted 10 lines · Roman Kiryanov
+Greg KH
Quoted 7 lines · Roman Kiryanov
Hi Hancai,
I see you added /arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts which refers to goldfish-rtc in
39c1485c8baa47aa20caefc1ec0a3410fbad6c81. We (Android Studio Emulator aka "goldfish") do not support MIPS anymore. Do you know if goldfish-rtc still works and is assumed to be available?I've dropped this patch from my trees now, please feel free to resend when you have an updated version.
thanks,
greg k-h
Hi, Roman,
Quoted 5 lines · Roman Kiryanov
Hi Hancai,
do you know if
CONFIG_GOLDFISH_AUDIOis required for MIPS? I sent a patch to retire it.
Not required for MIPS.
Huacai
Quoted 40 lines
Regards,
Roman.Quoted 35 lines · 陈华才
Hi, All,
Goldfish RTC works well on MIPS, and QEMU RISC-V emulator use Goldfish as well, so I think we should keep it in kernel.
Huacai
------------------ Original ------------------
From: "Greg KH"<[email protected]>; Date: Sat, Nov 14, 2020 07:43 AM To: "Roman Kiryanov"<[email protected]>;Cc: "chenhc"<[email protected]>; "Paul Walmsley"<[email protected]>; "LKML"<[email protected]>; "Lingfeng Yang"<[email protected]>; "Rob Herring"<[email protected]>;
Subject: Re: [PATCH] drivers: rtc: retireRTC_DRV_GOLDFISHQuoted 10 lines · Roman Kiryanov
+Greg KH
Quoted 7 lines · Roman Kiryanov
Hi Hancai,
I see you added /arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts which refers to goldfish-rtc in
39c1485c8baa47aa20caefc1ec0a3410fbad6c81. We (Android Studio Emulator aka "goldfish") do not support MIPS anymore. Do you know if goldfish-rtc still works and is assumed to be available?I've dropped this patch from my trees now, please feel free to resend when you have an updated version.
thanks,
greg k-h