memory: tegra20-emc: remove redundant error message
PATCH 1/1 memory: tegra20-emc: remove redundant error message
There is no need for dev_err() since irq already prints an error. Eliminate unnecessary curly braces for single statement block.
--- drivers/memory/tegra/tegra20-emc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/memory/tegra/tegra20-emc.c +1 -3
@@ -959,10 +959,8 @@ static int tegra_emc_probe(struct platform_device *pdev)int irq, err; irq =platform_get_irq (pdev,0 ); -if (irq <0 ) { -dev_err (&pdev->dev,"please update your device tree\n" ); +if (irq <0 )return irq; - } emc =devm_kzalloc (&pdev->dev,sizeof (*emc),GFP_KERNEL );if (!emc)
Signature · 1 line
2.28.0
14.11.2020 08:12, Nigel Christian пишет:
Quoted 15 lines
There is no need for
dev_err()since irq already prints an error. Eliminate unnecessary curly braces for single statement block.Signed-off-by Nigel Christian <[email protected]>--- drivers/memory/tegra/tegra20-emc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/memory/tegra/tegra20-emc.c +0
-0@@ -959,10 +959,8 @@ static int tegra_emc_probe(struct platform_device *pdev)int irq, err;
drivers/memory/tegra/tegra20-emc.c static int tegra_emc_probe(struct platform_device *pdev) · line 966
Quoted 10 lines
drivers/memory/tegra/tegra20-emc.c +1
-3irq =platform_get_irq (pdev,0 ); -if (irq <0 ) { -dev_err (&pdev->dev,"please update your device tree\n" ); +if (irq <0 )return irq; - } emc =devm_kzalloc (&pdev->dev,sizeof (*emc),GFP_KERNEL );if (!emc)
This message has a special purpose, it shouldn't be removed. Please always check what auto-generated patches actually do.
Quoted 23 lines · Dmitry Osipenko
14.11.2020 08:12, Nigel Christian пишет:
Quoted 22 lines
There is no need for
dev_err()since irq already prints an error. Eliminate unnecessary curly braces for single statement block.Signed-off-by Nigel Christian <[email protected]>--- drivers/memory/tegra/tegra20-emc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/memory/tegra/tegra20-emc.c +1
-3@@ -959,10 +959,8 @@ static int tegra_emc_probe(struct platform_device *pdev)int irq, err; irq =platform_get_irq (pdev,0 ); -if (irq <0 ) { -dev_err (&pdev->dev,"please update your device tree\n" ); +if (irq <0 )return irq; - }
Quoted 6 lines
drivers/memory/tegra/tegra20-emc.c static int tegra_emc_probe(struct platform_device *pdev) · line 966
Quoted 3 lines
drivers/memory/tegra/tegra20-emc.c +0
-0emc =devm_kzalloc (&pdev->dev,sizeof (*emc),GFP_KERNEL );if (!emc)This message has a special purpose, it shouldn't be removed. Please always check what auto-generated patches actually do.
Apologies, understood. Thank you for your time.