Skip to contentSkip to conversation

drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL

PATCH Superseded David Gow 3 participants 6 messages Nov 19, 2020 – Nov 20, 2020

Subsystems (2)
User-mode Linux (UML) FPGA manager framework

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

David Gow

author
#0 lore raw

PATCH 1/1 drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL

Because dfl.c uses the 'devm_ioremap', 'devm_iounmap', 'devm_ioremap_resource', and 'devm_platform_ioremap_resource' functions, it should depend on HAS_IOMEM.

This fixes make allyesconfig under UML (ARCH=um), which doesn't provide HAS_IOMEM.

Signed-off-by David Gow <[email protected]>
---
 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/fpga/Kconfig +1 -0
index 7cd5a29fc437..5645226ca3ce 100644
@@ -142,6 +142,7 @@ config FPGA_DFL
 	tristate "FPGA Device Feature List (DFL) support"
 	select FPGA_BRIDGE
 	select FPGA_REGION
+	depends on HAS_IOMEM
 	help
 	  Device Feature List (DFL) defines a feature list structure that
 	  creates a linked list of feature headers within the MMIO space
Signature · 7 lines
2.29.2.454.gaff20da3a2-goog


_______________________________________________
linux-um mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-um
maintainer
#1 lore raw

Thanks for the fix, looks good to me.

Thanks,
Yilun

Quoted 26 lines · David Gow

Because dfl.c uses the 'devm_ioremap', 'devm_iounmap', 'devm_ioremap_resource', and 'devm_platform_ioremap_resource' functions, it should depend on HAS_IOMEM.

This fixes make allyesconfig under UML (ARCH=um), which doesn't provide HAS_IOMEM.

Signed-off-by David Gow <[email protected]>
---
 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/fpga/Kconfig +1 -0
index 7cd5a29fc437..5645226ca3ce 100644
@@ -142,6 +142,7 @@ config FPGA_DFL
 	tristate "FPGA Device Feature List (DFL) support"
 	select FPGA_BRIDGE
 	select FPGA_REGION
+	depends on HAS_IOMEM
 	help
 	  Device Feature List (DFL) defines a feature list structure that
 	  creates a linked list of feature headers within the MMIO space
Signature · 1 line
2.29.2.454.gaff20da3a2-goog
maintainer
#2 lore raw
In reply to David Gow

Hi David,

Quoted 27 lines · David Gow

Because dfl.c uses the 'devm_ioremap', 'devm_iounmap', 'devm_ioremap_resource', and 'devm_platform_ioremap_resource' functions, it should depend on HAS_IOMEM.

This fixes make allyesconfig under UML (ARCH=um), which doesn't provide HAS_IOMEM.

Signed-off-by David Gow <[email protected]>
---
 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/fpga/Kconfig +1 -0
index 7cd5a29fc437..5645226ca3ce 100644
@@ -142,6 +142,7 @@ config FPGA_DFL
 	tristate "FPGA Device Feature List (DFL) support"
 	select FPGA_BRIDGE
 	select FPGA_REGION
+	depends on HAS_IOMEM
 	help
 	  Device Feature List (DFL) defines a feature list structure that
 	  creates a linked list of feature headers within the MMIO space
Signature · 1 line
2.29.2.454.gaff20da3a2-goog

Do you think we can add a Fixes: tag for this?

Thanks,
Moritz

author
#3 lore raw
Quoted 16 lines · Moritz Fischer

Hi David,

Quoted 12 lines · David Gow

Because dfl.c uses the 'devm_ioremap', 'devm_iounmap', 'devm_ioremap_resource', and 'devm_platform_ioremap_resource' functions, it should depend on HAS_IOMEM.

This fixes make allyesconfig under UML (ARCH=um), which doesn't provide HAS_IOMEM.

Signed-off-by David Gow <[email protected]>
---
 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)
Quoted 16 lines
Quoted 13 lines
drivers/fpga/Kconfig +1 -1
index 7cd5a29fc437..5645226ca3ce 100644
@@ -142,6 +142,7 @@ config FPGA_DFL
      tristate "FPGA Device Feature List (DFL) support"
      select FPGA_BRIDGE
      select FPGA_REGION
+     depends on HAS_IOMEM
      help
        Device Feature List (DFL) defines a feature list structure that
        creates a linked list of feature headers within the MMIO space
--
Quoted 2 lines

2.29.2.454.gaff20da3a2-goog

Do you think we can add a Fixes: tag for this?

Sure. I think it should be:

Fixes 543be3d ("fpga: add device feature list support")

Let me know if you want me to re-send the patch with that included.

Cheers,
-- David

maintainer
#4 lore raw
Quoted 34 lines · David Gow
Quoted 16 lines · Moritz Fischer

Hi David,

Quoted 12 lines · David Gow

Because dfl.c uses the 'devm_ioremap', 'devm_iounmap', 'devm_ioremap_resource', and 'devm_platform_ioremap_resource' functions, it should depend on HAS_IOMEM.

This fixes make allyesconfig under UML (ARCH=um), which doesn't provide HAS_IOMEM.

Signed-off-by David Gow <[email protected]>
---
 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)
Quoted 16 lines
Quoted 13 lines
drivers/fpga/Kconfig +1 -1
index 7cd5a29fc437..5645226ca3ce 100644
@@ -142,6 +142,7 @@ config FPGA_DFL
      tristate "FPGA Device Feature List (DFL) support"
      select FPGA_BRIDGE
      select FPGA_REGION
+     depends on HAS_IOMEM
      help
        Device Feature List (DFL) defines a feature list structure that
        creates a linked list of feature headers within the MMIO space
--
Quoted 2 lines

2.29.2.454.gaff20da3a2-goog

Do you think we can add a Fixes: tag for this?

Quoted 3 lines

Sure. I think it should be:

Fixes 543be3d ("fpga: add device feature list support")

I think it should be:

Fixes 89eb35e810a8 ("fpga: dfl: map feature mmio resources in their own feature drivers")

Thanks,
Yilun

Quoted 5 lines

Let me know if you want me to re-send the patch with that included.

Cheers,
-- David

_______________________________________________
linux-um mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-um

maintainer
#5 lore raw

Hi David,

Quoted 35 lines · Xu Yilun
Quoted 34 lines · David Gow
Quoted 32 lines · Moritz Fischer

Hi David,

Quoted 25 lines · David Gow

Because dfl.c uses the 'devm_ioremap', 'devm_iounmap', 'devm_ioremap_resource', and 'devm_platform_ioremap_resource' functions, it should depend on HAS_IOMEM.

This fixes make allyesconfig under UML (ARCH=um), which doesn't provide HAS_IOMEM.

Signed-off-by David Gow <[email protected]>
---
 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/fpga/Kconfig +1 -1
index 7cd5a29fc437..5645226ca3ce 100644
@@ -142,6 +142,7 @@ config FPGA_DFL
      tristate "FPGA Device Feature List (DFL) support"
      select FPGA_BRIDGE
      select FPGA_REGION
+     depends on HAS_IOMEM
      help
        Device Feature List (DFL) defines a feature list structure that
        creates a linked list of feature headers within the MMIO space
--
Quoted 2 lines

2.29.2.454.gaff20da3a2-goog

Do you think we can add a Fixes: tag for this?

Quoted 7 lines
Quoted 3 lines

Sure. I think it should be:

Fixes 543be3d ("fpga: add device feature list support")

I think it should be:

Fixes 89eb35e810a8 ("fpga: dfl: map feature mmio resources in their own feature drivers")

I think so, yes.

Can you resend?

Cheers