Skip to contentSkip to conversation

add support for Dragonboard410c

PATCH New Mike Frampton 3 participants 11 messages Nov 19, 2020 – Jan 22, 2021

lore
Share & tools
lore
#0 lore raw

v2 cover add support for Dragonboard410c

Hi Buildroot devs,

This is my second attempt at submitting a config for the Qualcomm Dragonboard 410c. Thomas Petazzoni gave me some feedback on the last series which I have tried to address in this patch.

I have built an image using the defconfig below and tested that it boots on the DB410c. I also tested that the Wifi works.

Thomas suggested that I change the post-image.sh script so that it doesn't reference the kernel build path. I was not able to achieve this because my dtb and Image.gz were not copied to output/images. I found that only the uncompressed kernel image was copied by the kernel package, and I think my dts wasn't copied because I had BR2_LINUX_KERNEL_DTB_IS_SELF_BUILT=y. Is this expected behaviour?

Mike Frampton (3):
package/qcom-db410c-firmware: new package
package/abootimg: add host build
configs/qcom_db410c: new defconfig

 DEVELOPERS                                    |  5 +
 board/qcom/db410c/post-image.sh               | 20 ++++
 board/qcom/db410c/readme.txt                  | 93 +++++++++++++++++++
 configs/qcom_db410c_defconfig                 | 28 ++++++
 package/Config.in                             |  1 +
 package/Config.in.host                        |  1 +
 package/abootimg/Config.in.host               |  8 ++
 package/abootimg/abootimg.mk                  | 10 ++
 package/qcom-db410c-firmware/Config.in        |  6 ++
 .../qcom-db410c-firmware.hash                 |  3 +
 .../qcom-db410c-firmware.mk                   | 41 ++++++++
 11 files changed, 216 insertions(+)
 create mode 100755 board/qcom/db410c/post-image.sh
 create mode 100644 board/qcom/db410c/readme.txt
 create mode 100644 configs/qcom_db410c_defconfig
 create mode 100644 package/abootimg/Config.in.host
 create mode 100644 package/qcom-db410c-firmware/Config.in
 create mode 100644 package/qcom-db410c-firmware/qcom-db410c-firmware.hash
 create mode 100644 package/qcom-db410c-firmware/qcom-db410c-firmware.mk
Signature · 1 line
2.25.1
#1 lore raw

PATCH v2 1/3 package/qcom-db410c-firmware: new package

Installs the required Wifi/BT firmware blobs for the Qualcomm Dragonboard 410c SBC.

---
 DEVELOPERS                                    |  3 ++
 package/Config.in                             |  1 +
 package/qcom-db410c-firmware/Config.in        |  6 +++
 .../qcom-db410c-firmware.hash                 |  3 ++
 .../qcom-db410c-firmware.mk                   | 41 +++++++++++++++++++
 5 files changed, 54 insertions(+)
 create mode 100644 package/qcom-db410c-firmware/Config.in
 create mode 100644 package/qcom-db410c-firmware/qcom-db410c-firmware.hash
 create mode 100644 package/qcom-db410c-firmware/qcom-db410c-firmware.mk
DEVELOPERS +3 -0
index 9ab1e125f4..57a84a3604 100644
@@ -1863,6 +1863,9 @@ N:	Michel Stempin <[email protected]>
 F:	board/licheepi/
 F:	configs/licheepi_zero_defconfig
 
+N:	Mike Frampton <[email protected]>
+F:	package/qcom-db410c-firmware/
+
 N:	Mike Harmony <[email protected]>
 F:	board/sinovoip/m2-plus/
 F:	configs/bananapi_m2_plus_defconfig
package/Config.in +1 -0
index 016a99ed1a..7b49db0683 100644
@@ -402,6 +402,7 @@ menu "Firmware"
 	source "package/linux-firmware/Config.in"
 	source "package/murata-cyw-fw/Config.in"
 	source "package/odroidc2-firmware/Config.in"
+	source "package/qcom-db410c-firmware/Config.in"
 	source "package/rpi-bt-firmware/Config.in"
 	source "package/rpi-firmware/Config.in"
 	source "package/rpi-wifi-firmware/Config.in"
package/qcom-db410c-firmware/Config.in new file +6 -0
new file mode 100644
index 0000000000..7b615a67bf
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_QCOM_DB410C_FIRMWARE
+	bool "qcom-db410c-firmware"
+	select BR2_PACKAGE_HOST_MTOOLS
+	help
+	  Wifi/BT firmware for Qualcomm Dragonboard 410c SBC.
+
package/qcom-db410c-firmware/qcom-db410c-firmware.hash new file +3 -0
new file mode 100644
index 0000000000..e8ac31eb39
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256  46953b974c5c58c7ca66db414437c0268b033ac9d28127e98d9c4e1a49359da5  linux-board-support-package-r1034.2.1.zip
+sha256  11e60ad6f83c2a86e40dca374c24230b53650dd3e0adf2e72c15f8cafedc2e5a  LICENSE
package/qcom-db410c-firmware/qcom-db410c-firmware.mk new file +41 -0

41 lines not on this page · raw message

Signature · 1 line
2.25.1
#2 lore raw

PATCH v2 1/3 package/qcom-db410c-firmware: new package

Hello Mike,

Thanks for this new iteration!

Quoted 15 lines · On Thu, 19 Nov 2020 22:08:52 +1300 Mike Frampton <[email protected]> wrote:
package/qcom-db410c-firmware/qcom-db410c-firmware.hash new file +3 -0
new file mode 100644
index 0000000000..e8ac31eb39
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256  46953b974c5c58c7ca66db414437c0268b033ac9d28127e98d9c4e1a49359da5  linux-board-support-package-r1034.2.1.zip
+sha256  11e60ad6f83c2a86e40dca374c24230b53650dd3e0adf2e72c15f8cafedc2e5a  LICENSE
package/qcom-db410c-firmware/qcom-db410c-firmware.mk new file +0 -0
new file mode 100644
index 0000000000..15c97e9dc2

package/qcom-db410c-firmware/qcom-db410c-firmware.mk line 10

Quoted 10 lines
package/qcom-db410c-firmware/qcom-db410c-firmware.mk new file +10 -0
@@ -0,0 +1,41 @@
+################################################################################
+#
+# qcom-db410c-firmware
+#
+################################################################################
+
+QCOM_DB410C_FIRMWARE_VERSION = 1034.2.1
+QCOM_DB410C_FIRMWARE_BASE = linux-board-support-package-r$(QCOM_DB410C_FIRMWARE_VERSION)
+QCOM_DB410C_FIRMWARE_SOURCE = $(QCOM_DB410C_FIRMWARE_BASE).zip
+QCOM_DB410C_FIRMWARE_SITE = https://releases.linaro.org/96boards/dragonboard410c/qualcomm/firmware

I think you're missing

QCOM_DB410C_FIRMWARE_DEPENDENCIES = host-mtools

here, as your INSTALL_TARGET_CMDS is using $(HOST_DIR)/bin/mcopy.

Otherwise, it looks good to me!

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH v2 1/3 package/qcom-db410c-firmware: new package

In reply to Mike Frampton
Quoted 4 lines · On Thu, 19 Nov 2020 22:08:52 +1300 Mike Frampton <[email protected]> wrote:

Installs the required Wifi/BT firmware blobs for the Qualcomm Dragonboard 410c SBC.

Quoted 10 lines
---
 DEVELOPERS                                    |  3 ++
 package/Config.in                             |  1 +
 package/qcom-db410c-firmware/Config.in        |  6 +++
 .../qcom-db410c-firmware.hash                 |  3 ++
 .../qcom-db410c-firmware.mk                   | 41 +++++++++++++++++++
 5 files changed, 54 insertions(+)
 create mode 100644 package/qcom-db410c-firmware/Config.in
 create mode 100644 package/qcom-db410c-firmware/qcom-db410c-firmware.hash
 create mode 100644 package/qcom-db410c-firmware/qcom-db410c-firmware.mk

In fact, I fixed up the minor issues that remained, and applied your patch to next. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH v2 2/3 package/abootimg: add host build

In reply to Mike Frampton

Enabling package host build for abootimg so that boot images can be created for boards which boot from this format.

---
 package/Config.in.host          |  1 +
 package/abootimg/Config.in.host |  8 ++++++++
 package/abootimg/abootimg.mk    | 10 ++++++++++
 3 files changed, 19 insertions(+)
 create mode 100644 package/abootimg/Config.in.host
package/Config.in.host +1 -0
index c69c756f3a..4f69785810 100644
@@ -1,5 +1,6 @@
 menu "Host utilities"
 
+	source "package/abootimg/Config.in.host"
 	source "package/aespipe/Config.in.host"
 	source "package/android-tools/Config.in.host"
 	source "package/asn1c/Config.in.host"
package/abootimg/Config.in.host new file +8 -0
new file mode 100644
index 0000000000..1e178bc8bf
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_HOST_ABOOTIMG
+	bool "host abootimg"
+	select BR2_PACKAGE_HOST_UTIL_LINUX
+	help
+	  Tool to manipulate Android Boot Images, either on files
+	  or directly on /dev block devices.
+	  
+	  https://github.com/ggrandou/abootimg
package/abootimg/abootimg.mk +10 -0
index e906546948..64cee13c32 100644
@@ -11,6 +11,7 @@ ABOOTIMG_LICENSE_FILES = LICENSE
 
 # depends on libblkid from util-linux
 ABOOTIMG_DEPENDENCIES = util-linux
+ABOOTIMG_HOST_DEPENDENCIES = host-util-linux
 
 define ABOOTIMG_BUILD_CMDS
 	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
@@ -20,4 +21,13 @@ define ABOOTIMG_INSTALL_TARGET_CMDS
 	$(INSTALL) -m 0755 $(@D)/abootimg $(TARGET_DIR)/usr/bin/abootimg
 endef
 
+define HOST_ABOOTIMG_BUILD_CMDS
+	$(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D)
+endef
+
+define HOST_ABOOTIMG_INSTALL_CMDS
+	$(INSTALL) -m 0755 $(@D)/abootimg $(HOST_DIR)/usr/bin/abootimg
+endef
+
 $(eval $(generic-package))
+$(eval $(host-generic-package))
Signature · 1 line
2.25.1
#5 lore raw

PATCH v2 2/3 package/abootimg: add host build

Quoted 10 lines · On Thu, 19 Nov 2020 22:08:53 +1300 Mike Frampton <[email protected]> wrote:

Enabling package host build for abootimg so that boot images can be created for boards which boot from this format.

---
 package/Config.in.host          |  1 +
 package/abootimg/Config.in.host |  8 ++++++++
 package/abootimg/abootimg.mk    | 10 ++++++++++
 3 files changed, 19 insertions(+)
 create mode 100644 package/abootimg/Config.in.host

Applied to next, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#6 lore raw

PATCH v2 3/3 configs/qcom_db410c: new defconfig

In reply to Mike Frampton

Adds a defconfig for the Qualcomm Dragonboard 410c SBC. This config builds the qcom kernel 5.4 arm64 and assembles it into an abootimg which can be booted on the device. Further instructions are provided in the included readme.txt

---
 DEVELOPERS                      |  2 +
 board/qcom/db410c/post-image.sh | 20 +++++++
 board/qcom/db410c/readme.txt    | 93 +++++++++++++++++++++++++++++++++
 configs/qcom_db410c_defconfig   | 28 ++++++++++
 4 files changed, 143 insertions(+)
 create mode 100755 board/qcom/db410c/post-image.sh
 create mode 100644 board/qcom/db410c/readme.txt
 create mode 100644 configs/qcom_db410c_defconfig
DEVELOPERS +2 -0
index 57a84a3604..caec89a1df 100644
@@ -1864,6 +1864,8 @@ F:	board/licheepi/
 F:	configs/licheepi_zero_defconfig
 
 N:	Mike Frampton <[email protected]>
+F:	board/qcom/db410c/
+F:	configs/qcom_db410c_defconfig
 F:	package/qcom-db410c-firmware/
 
 N:	Mike Harmony <[email protected]>
board/qcom/db410c/post-image.sh new file +20 -0
new file mode 100755
index 0000000000..b33a219104
@@ -0,0 +1,20 @@
+#!/bin/bash
+
+set -e
+
+OUTIMG=$BINARIES_DIR/boot-db410c.img
+KERNEL_BUILD=$BUILD_DIR/linux-release_qcomlt-5.4
+
+cp $KERNEL_BUILD/arch/arm64/boot/dts/qcom/apq8016-sbc.dtb $BINARIES_DIR
+cp $KERNEL_BUILD/arch/arm64/boot/Image.gz $BINARIES_DIR
+
+# now assemble the bootimg
+cat $BINARIES_DIR/Image.gz $BINARIES_DIR/apq8016-sbc.dtb > $BINARIES_DIR/Image.gz+dtb
+echo "not a ramdisk" > $BINARIES_DIR/ramdisk.img
+
+abootimg --create $OUTIMG -k $BINARIES_DIR/Image.gz+dtb -r $BINARIES_DIR/ramdisk.img \
+	-c pagesize=2048 -c kerneladdr=0x80008000 -c ramdiskaddr=0x81000000 \
+	-c cmdline="root=/dev/mmcblk1p13 rw rootwait console=tty0 console=ttyMSM0,115200n8"
+
+echo "boot img written to $OUTIMG"
+
board/qcom/db410c/readme.txt new file +93 -0

93 lines not on this page · raw message

configs/qcom_db410c_defconfig new file +28 -0
new file mode 100644
index 0000000000..732751c787
@@ -0,0 +1,28 @@
+# Architecture
+BR2_aarch64=y
+BR2_cortex_a53=y
+
+# Toolchain options
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_4=y
+
+# Firmware
+BR2_PACKAGE_LINUX_FIRMWARE=y
+BR2_PACKAGE_LINUX_FIRMWARE_QCOM_VENUS=y
+BR2_PACKAGE_LINUX_FIRMWARE_QCOM_ADRENO=y
+BR2_PACKAGE_QCOM_DB410C_FIRMWARE=y
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_GIT=y
+BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://git.linaro.org/landing-teams/working/qualcomm/kernel.git"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="release/qcomlt-5.4"
+BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_DTB_IS_SELF_BUILT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="apq8016-sbc"
+
+# Filesystem/Image
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_PACKAGE_HOST_ABOOTIMG=y
+BR2_ROOTFS_POST_IMAGE_SCRIPT="board/qcom/db410c/post-image.sh"
+
Signature · 1 line
2.25.1
#7 lore raw

PATCH v2 3/3 configs/qcom_db410c: new defconfig

Hello Mike,

Thanks as well for this new iteration!

board/qcom/db410c/post-image.sh line 9

Quoted 5 lines · On Thu, 19 Nov 2020 22:08:54 +1300 Mike Frampton <[email protected]> wrote:
board/qcom/db410c/post-image.sh new file +5 -0
+OUTIMG=$BINARIES_DIR/boot-db410c.img
+KERNEL_BUILD=$BUILD_DIR/linux-release_qcomlt-5.4
+
+cp $KERNEL_BUILD/arch/arm64/boot/dts/qcom/apq8016-sbc.dtb $BINARIES_DIR
+cp $KERNEL_BUILD/arch/arm64/boot/Image.gz $BINARIES_DIR

Why is this needed ? Buildroot should have already copied the DT and kernel image to BINARIES_DIR.

board/qcom/db410c/post-image.sh line 19

Quoted 9 lines
board/qcom/db410c/post-image.sh new file +9 -0
+# now assemble the bootimg
+cat $BINARIES_DIR/Image.gz $BINARIES_DIR/apq8016-sbc.dtb > $BINARIES_DIR/Image.gz+dtb
+echo "not a ramdisk" > $BINARIES_DIR/ramdisk.img
+
+abootimg --create $OUTIMG -k $BINARIES_DIR/Image.gz+dtb -r $BINARIES_DIR/ramdisk.img \
+	-c pagesize=2048 -c kerneladdr=0x80008000 -c ramdiskaddr=0x81000000 \
+	-c cmdline="root=/dev/mmcblk1p13 rw rootwait console=tty0 console=ttyMSM0,115200n8"
+
+echo "boot img written to $OUTIMG"

The echo here is probably not needed ?

board/qcom/db410c/readme.txt line 48

Quoted 6 lines
board/qcom/db410c/readme.txt new file +6 -0
+How to set up the SD card
+=========================
+
+The bootloader on the DB410c expects the SD card to be formatted in a 
+particular way. The simplest way to set up the SD card correctly is to flash
+a prebuilt Debian image on to the card to set up the required partitions.

This is a bit annoying, having to depend on flashing the SD card with another system first. What is so special that we can't do in Buildroot ?

Quoted 14 lines
configs/qcom_db410c_defconfig new file +8 -0
new file mode 100644
index 0000000000..732751c787
@@ -0,0 +1,28 @@
+# Architecture
+BR2_aarch64=y
+BR2_cortex_a53=y
+
+# Toolchain options
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_4=y
+
+# Firmware

configs/qcom_db410c_defconfig line 18

Quoted 10 lines
configs/qcom_db410c_defconfig new file +10 -0
+BR2_PACKAGE_LINUX_FIRMWARE=y
+BR2_PACKAGE_LINUX_FIRMWARE_QCOM_VENUS=y
+BR2_PACKAGE_LINUX_FIRMWARE_QCOM_ADRENO=y
+BR2_PACKAGE_QCOM_DB410C_FIRMWARE=y
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_GIT=y
+BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://git.linaro.org/landing-teams/working/qualcomm/kernel.git"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="release/qcomlt-5.4"

This is a branch, which is a moving target, and we prefer to point to a specific tag or commit to make sure this defconfig always builds the same kernel version. Could you adjust this ?

Thanks a lot!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#8 lore raw

PATCH v2 3/3 configs/qcom_db410c: new defconfig

Hi Thomas,

Thanks very much for the feedback.

Quoted 8 lines · Thomas Petazzoni

Hello Mike,

Thanks as well for this new iteration!

On Thu, 19 Nov 2020 22:08:54 +1300
Mike Frampton <[email protected]> wrote:

Quoted 8 lines

board/qcom/db410c/post-image.sh line 9

Quoted 5 lines
board/qcom/db410c/post-image.sh new file +5 -0
+OUTIMG=$BINARIES_DIR/boot-db410c.img
+KERNEL_BUILD=$BUILD_DIR/linux-release_qcomlt-5.4
+
+cp $KERNEL_BUILD/arch/arm64/boot/dts/qcom/apq8016-sbc.dtb $BINARIES_DIR
+cp $KERNEL_BUILD/arch/arm64/boot/Image.gz $BINARIES_DIR

Why is this needed ? Buildroot should have already copied the DT and kernel image to BINARIES_DIR.

For some reason it doesn't in my configuration. When I look in linux/linux.mk, I found that
LINUX_INSTALL_DTB is only defined if BR2_LINUX_KERNEL_DTB_IS_SELF_BUILT is not set. I'm not sure why?

Quoted 9 lines

board/qcom/db410c/readme.txt line 48

Quoted 6 lines
board/qcom/db410c/readme.txt new file +6 -0
+How to set up the SD card
+=========================
+
+The bootloader on the DB410c expects the SD card to be formatted in a
+particular way. The simplest way to set up the SD card correctly is to flash
+a prebuilt Debian image on to the card to set up the required partitions.

This is a bit annoying, having to depend on flashing the SD card with another system first. What is so special that we can't do in Buildroot ?

I agree. I know that linaro have some tools for setting up the SD card, I just haven't had much
success with them in the past :-/. I'll have another look and see if I can get them working.

#9 lore raw

PATCH v2 3/3 configs/qcom_db410c: new defconfig

Hi Thomas,

Quoted 9 lines
Quoted 8 lines

Review

Quoted 5 lines
(quoted diff) +5 -0
+OUTIMG=$BINARIES_DIR/boot-db410c.img
+KERNEL_BUILD=$BUILD_DIR/linux-release_qcomlt-5.4
+
+cp $KERNEL_BUILD/arch/arm64/boot/dts/qcom/apq8016-sbc.dtb $BINARIES_DIR
+cp $KERNEL_BUILD/arch/arm64/boot/Image.gz $BINARIES_DIR

Why is this needed ? Buildroot should have already copied the DT and kernel image to BINARIES_DIR.

Quoted 4 lines

For some reason it doesn't in my configuration. When I look in linux/linux.mk, I found that
LINUX_INSTALL_DTB is only defined if BR2_LINUX_KERNEL_DTB_IS_SELF_BUILT is not set. I'm not sure why?

I've done a bit more investigation into this. I was able to get the dtb to copy to the output/images
folder by unsetting the BR2_LINUX_KERNEL_DTB_IS_SELF_BUILT. I thought that setting was
needed.

The Image.gz file was not being copied to the images/ folder. I was able to get this to copy by
adding the following code. I think gmail has messed up the whitespace, but I'm sure you get the
idea. If you think this is a useful thing to add, then I can expand it to work for all the supported
output image formats and submit a patch.

linux/linux.mk +6 -1
index e07e014d1e..71e6805ab7 100644
@@ -245,6 +245,12 @@ else
 LINUX_IMAGE_PATH = $(LINUX_ARCH_PATH)/boot/$(LINUX_IMAGE_NAME)
 endif # BR2_LINUX_KERNEL_VMLINUX
 
+LINUX_OUTPUT_IMAGES=$(LINUX_IMAGE_PATH)
+
+ifeq ($(BR2_LINUX_KERNEL_GZIP),y)
+    LINUX_OUTPUT_IMAGES += $(LINUX_IMAGE_PATH).gz
+endif
+
 define LINUX_APPLY_LOCAL_PATCHES
     for p in $(filter-out ftp://% http://% https://%,$(LINUX_PATCHES)) ; do \
         if test -d $$p ; then \
@@ -451,7 +457,9 @@ else
 # Otherwise, just install the unique image generated by the kernel
 # build process.
 define LINUX_INSTALL_IMAGE
-    $(INSTALL) -m 0644 -D $(LINUX_IMAGE_PATH) $(1)/$(notdir

$(LINUX_IMAGE_NAME))
+ $(foreach img,$(LINUX_OUTPUT_IMAGES), \
+ $(INSTALL) -m 0644 -D $(img) $(1)
+ )
endef
endif

#10 lore raw

PATCH v2 3/3 configs/qcom_db410c: new defconfig

Quoted 17 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Mike" == Mike Frampton <[email protected]> writes:

Hi Thomas,

Quoted 9 lines
Quoted 8 lines

Review

Quoted 5 lines
(quoted diff) +5 -0
+OUTIMG=$BINARIES_DIR/boot-db410c.img
+KERNEL_BUILD=$BUILD_DIR/linux-release_qcomlt-5.4
+
+cp $KERNEL_BUILD/arch/arm64/boot/dts/qcom/apq8016-sbc.dtb $BINARIES_DIR
+cp $KERNEL_BUILD/arch/arm64/boot/Image.gz $BINARIES_DIR

Why is this needed ? Buildroot should have already copied the DT and kernel image to BINARIES_DIR.

Quoted 4 lines

For some reason it doesn't in my configuration. When I look in linux/linux.mk, I found that
LINUX_INSTALL_DTB is only defined if BR2_LINUX_KERNEL_DTB_IS_SELF_BUILT is not set. I'm not sure why?

Quoted 5 lines

I've done a bit more investigation into this. I was able to get the dtb to copy to the output/images
folder by unsetting the BR2_LINUX_KERNEL_DTB_IS_SELF_BUILT. I thought that setting was
needed.

No, that is for a special case where the DTB is embedded inside the kernel image. E.G. as we tried to explain in the help text:

Normally, the device tree(s) to be built have to be passed explicitly to the kernel build system. For some binary formats, however, the kernel build system links in the device tree directly in the kernel binary. Select this option if you have such a kernel binary format.

Quoted 13 lines

The Image.gz file was not being copied to the images/ folder. I was able to get this to copy by
adding the following code. I think gmail has messed up the whitespace, but I'm sure you get the
idea. If you think this is a useful thing to add, then I can expand it to work for all the supported
output image formats and submit a patch.

linux/linux.mk +0 -0
index e07e014d1e..71e6805ab7 100644

linux/linux.mk else · line 252

Quoted 8 lines
linux/linux.mk +5 -0
@@ -245,6 +245,12 @@ else
 LINUX_IMAGE_PATH = $(LINUX_ARCH_PATH)/boot/$(LINUX_IMAGE_NAME)
 endif # BR2_LINUX_KERNEL_VMLINUX
 
+LINUX_OUTPUT_IMAGES=$(LINUX_IMAGE_PATH)
+
+ifeq ($(BR2_LINUX_KERNEL_GZIP),y)
+    LINUX_OUTPUT_IMAGES += $(LINUX_IMAGE_PATH).gz
+endif

This may work but isn't really right. The compression options don't apply to the 'Image' kernel format used on arm64 (as it is a "raw" kernel without a bootloader in front), so keying off BR2_LINUX_KERNEL_GZIP isn't good. Ideally we should hide those options when the Image format is used.

The issue is actually that aarch64 (and riscv, where the logic is copied) builds Image + Image.gz by default. From arch/arm64/Makefile:

all: Image.gz

Image: vmlinux

	$(Q)$(MAKE) $(build)=$(boot) $(boot)/$@

Image.%: Image

	$(Q)$(MAKE) $(build)=$(boot) $(boot)/$@

So we could either extend the Image handling to copy both Image and Image.gz, or add an Image.gz format option to get the Image.gz file copied. For flexibility, the separate Image.gz format is probably the nicest option. I'll send a patch for that.

Signature · 1 line
Bye, Peter Korsgaard