Skip to contentSkip to conversation

libsdl2: Add directfb to PACKAGECONFIG rdepends

PATCH Superseded Mark Jonas 3 participants 5 messages Nov 23, 2020 – Nov 24, 2020

lore
Share & tools
lore

Mark Jonas

author
#0 lore raw

PATCH 1/1 libsdl2: Add directfb to PACKAGECONFIG rdepends

When building libsdl2 with PACKAGECONFIG[directfb] then directfb is added to the DEPENDS. But the automatically generated runtime dependencies do not add the directfb package to the runtime dependencies. Most likely this happens because libsdl2 does not link against directfb but uses dlopen() or similar. Thus, the runtime dependency to directfb needs to be declared explicitly.

Here, a runtime recommendation is used to allow ignoring the runtime dependency using NO_RECOMMENDATIONS.

---
 meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb +1 -1
index 2ef7d2e5ef..ae42db2610 100644
@@ -58,7 +58,7 @@ PACKAGECONFIG ??= " \
 "
 PACKAGECONFIG[alsa]       = "--enable-alsa --disable-alsatest,--disable-alsa,alsa-lib,"
 PACKAGECONFIG[arm-neon]   = "--enable-arm-neon,--disable-arm-neon"
-PACKAGECONFIG[directfb]   = "--enable-video-directfb,--disable-video-directfb,directfb"
+PACKAGECONFIG[directfb]   = "--enable-video-directfb,--disable-video-directfb,directfb,,directfb"
 PACKAGECONFIG[gles2]      = "--enable-video-opengles,--disable-video-opengles,virtual/libgles2"
 PACKAGECONFIG[jack]       = "--enable-jack,--disable-jack,jack"
 PACKAGECONFIG[kmsdrm]     = "--enable-video-kmsdrm,--disable-video-kmsdrm,libdrm virtual/libgbm"
Signature · 1 line
2.25.1
#1 lore raw
Quoted 10 lines · Mark Jonas

When building libsdl2 with PACKAGECONFIG[directfb] then directfb is added to the DEPENDS. But the automatically generated runtime dependencies do not add the directfb package to the runtime dependencies. Most likely this happens because libsdl2 does not link against directfb but uses dlopen() or similar. Thus, the runtime dependency to directfb needs to be declared explicitly.

Here, a runtime recommendation is used to allow ignoring the runtime dependency using NO_RECOMMENDATIONS.

Why would anyone want to ignore the runtime dependency?

Quoted 24 lines
---
 meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb +1 -2
index 2ef7d2e5ef..ae42db2610 100644
@@ -58,7 +58,7 @@ PACKAGECONFIG ??= " \
 "
 PACKAGECONFIG[alsa]       = "--enable-alsa --disable-alsatest,--disable-alsa,alsa-lib,"
 PACKAGECONFIG[arm-neon]   = "--enable-arm-neon,--disable-arm-neon"
-PACKAGECONFIG[directfb]   = "--enable-video-directfb,--disable-video-directfb,directfb"
+PACKAGECONFIG[directfb]   = "--enable-video-directfb,--disable-video-directfb,directfb,,directfb"
 PACKAGECONFIG[gles2]      = "--enable-video-opengles,--disable-video-opengles,virtual/libgles2"
 PACKAGECONFIG[jack]       = "--enable-jack,--disable-jack,jack"
 PACKAGECONFIG[kmsdrm]     = "--enable-video-kmsdrm,--disable-video-kmsdrm,libdrm virtual/libgbm"
--

2.25.1

#2 lore raw
Quoted 10 lines · Andre McCurdy
Quoted 8 lines · Mark Jonas

When building libsdl2 with PACKAGECONFIG[directfb] then directfb is added to the DEPENDS. But the automatically generated runtime dependencies do not add the directfb package to the runtime dependencies. Most likely this happens because libsdl2 does not link
against directfb but uses dlopen() or similar. Thus, the runtime dependency to directfb needs to be declared explicitly.

Quoted 5 lines
Quoted 3 lines

Here, a runtime recommendation is used to allow ignoring the runtime
dependency using NO_RECOMMENDATIONS.

Why would anyone want to ignore the runtime dependency?

Agreed, that does seem strange. Whichever way this goes, the patch shortlog needs to match the commit (it says rdepends right now).

Cheers,

Richard

author
#3 lore raw

Hi Richard and Andre,

Quoted 11 lines · Richard Purdie
Quoted 10 lines · Andre McCurdy
Quoted 8 lines · Mark Jonas

When building libsdl2 with PACKAGECONFIG[directfb] then directfb is added to the DEPENDS. But the automatically generated runtime dependencies do not add the directfb package to the runtime dependencies. Most likely this happens because libsdl2 does not link
against directfb but uses dlopen() or similar. Thus, the runtime dependency to directfb needs to be declared explicitly.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

Here, a runtime recommendation is used to allow ignoring the runtime
dependency using NO_RECOMMENDATIONS.

Why would anyone want to ignore the runtime dependency?

Agreed, that does seem strange. Whichever way this goes, the patch shortlog needs to match the commit (it says rdepends right now).

Thank you for the feedback. I'll send a V2 of the patch.

Greetings,
Mark

author
#4 lore raw

PATCH v2 1/1 libsdl2: Add directfb to PACKAGECONFIG rdepends

In reply to Mark Jonas

PACKAGECONFIG[directfb] already adds directfb to the build dependencies. But the automatically generated runtime dependencies do not add the directfb package to the runtime dependencies. Most likely this happens because libsdl2 does not link against directfb but uses dlopen() or similar. Thus, the runtime dependency to directfb needs to be declared explicitly.

---
Changes in v2:
- Add directfb as a rdepends instead of a rrecommends.
- Rework commit message.

 meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb +1 -1
index 2ef7d2e5ef..5fa99821c4 100644
@@ -58,7 +58,7 @@ PACKAGECONFIG ??= " \
 "
 PACKAGECONFIG[alsa]       = "--enable-alsa --disable-alsatest,--disable-alsa,alsa-lib,"
 PACKAGECONFIG[arm-neon]   = "--enable-arm-neon,--disable-arm-neon"
-PACKAGECONFIG[directfb]   = "--enable-video-directfb,--disable-video-directfb,directfb"
+PACKAGECONFIG[directfb]   = "--enable-video-directfb,--disable-video-directfb,directfb,directfb"
 PACKAGECONFIG[gles2]      = "--enable-video-opengles,--disable-video-opengles,virtual/libgles2"
 PACKAGECONFIG[jack]       = "--enable-jack,--disable-jack,jack"
 PACKAGECONFIG[kmsdrm]     = "--enable-video-kmsdrm,--disable-video-kmsdrm,libdrm virtual/libgbm"

--
2.25.1