libsdl2: Add directfb to PACKAGECONFIG rdepends
PATCH 1/1 libsdl2: Add directfb to PACKAGECONFIG rdepends
When building libsdl2 with PACKAGECONFIG[directfb] then directfb is added to the DEPENDS. But the automatically generated runtime dependencies do not add the directfb package to the runtime dependencies. Most likely this happens because libsdl2 does not link against directfb but uses dlopen() or similar. Thus, the runtime dependency to directfb needs to be declared explicitly.
Here, a runtime recommendation is used to allow ignoring the runtime dependency using NO_RECOMMENDATIONS.
--- meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb +1 -1
@@ -58,7 +58,7 @@ PACKAGECONFIG ??= " \ " PACKAGECONFIG[alsa] = "--enable-alsa --disable-alsatest,--disable-alsa,alsa-lib," PACKAGECONFIG[arm-neon] = "--enable-arm-neon,--disable-arm-neon" -PACKAGECONFIG[directfb] = "--enable-video-directfb,--disable-video-directfb,directfb" +PACKAGECONFIG[directfb] = "--enable-video-directfb,--disable-video-directfb,directfb,,directfb" PACKAGECONFIG[gles2] = "--enable-video-opengles,--disable-video-opengles,virtual/libgles2" PACKAGECONFIG[jack] = "--enable-jack,--disable-jack,jack" PACKAGECONFIG[kmsdrm] = "--enable-video-kmsdrm,--disable-video-kmsdrm,libdrm virtual/libgbm"
Signature · 1 line
2.25.1
Quoted 10 lines · Mark Jonas
When building libsdl2 with PACKAGECONFIG[directfb] then directfb is added to the DEPENDS. But the automatically generated runtime dependencies do not add the directfb package to the runtime dependencies. Most likely this happens because libsdl2 does not link against directfb but uses
dlopen()or similar. Thus, the runtime dependency to directfb needs to be declared explicitly.Here, a runtime recommendation is used to allow ignoring the runtime dependency using
NO_RECOMMENDATIONS.
Why would anyone want to ignore the runtime dependency?
Quoted 24 lines
Signed-off-by Mark Jonas <[email protected]>--- meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb +1
-2@@ -58,7 +58,7 @@ PACKAGECONFIG ??= " \ " PACKAGECONFIG[alsa] = "--enable-alsa --disable-alsatest,--disable-alsa,alsa-lib," PACKAGECONFIG[arm-neon] = "--enable-arm-neon,--disable-arm-neon" -PACKAGECONFIG[directfb] = "--enable-video-directfb,--disable-video-directfb,directfb" +PACKAGECONFIG[directfb] = "--enable-video-directfb,--disable-video-directfb,directfb,,directfb" PACKAGECONFIG[gles2] = "--enable-video-opengles,--disable-video-opengles,virtual/libgles2" PACKAGECONFIG[jack] = "--enable-jack,--disable-jack,jack" PACKAGECONFIG[kmsdrm] = "--enable-video-kmsdrm,--disable-video-kmsdrm,libdrm virtual/libgbm" --2.25.1
Quoted 10 lines · Andre McCurdy
Quoted 8 lines · Mark Jonas
When building libsdl2 with PACKAGECONFIG[directfb] then directfb is added to the DEPENDS. But the automatically generated runtime dependencies do not add the directfb package to the runtime dependencies. Most likely this happens because libsdl2 does not link
against directfb but usesdlopen()or similar. Thus, the runtime dependency to directfb needs to be declared explicitly.
Quoted 5 lines
Quoted 3 lines
Here, a runtime recommendation is used to allow ignoring the runtime
dependency usingNO_RECOMMENDATIONS.Why would anyone want to ignore the runtime dependency?
Agreed, that does seem strange. Whichever way this goes, the patch shortlog needs to match the commit (it says rdepends right now).
Cheers,
Richard
Hi Richard and Andre,
Quoted 11 lines · Richard Purdie
Quoted 10 lines · Andre McCurdy
Quoted 8 lines · Mark Jonas
When building libsdl2 with PACKAGECONFIG[directfb] then directfb is added to the DEPENDS. But the automatically generated runtime dependencies do not add the directfb package to the runtime dependencies. Most likely this happens because libsdl2 does not link
against directfb but usesdlopen()or similar. Thus, the runtime dependency to directfb needs to be declared explicitly.
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Here, a runtime recommendation is used to allow ignoring the runtime
dependency usingNO_RECOMMENDATIONS.Why would anyone want to ignore the runtime dependency?
Agreed, that does seem strange. Whichever way this goes, the patch shortlog needs to match the commit (it says rdepends right now).
Thank you for the feedback. I'll send a V2 of the patch.
Greetings,
Mark
PATCH v2 1/1 libsdl2: Add directfb to PACKAGECONFIG rdepends
In reply to Mark JonasPACKAGECONFIG[directfb] already adds directfb to the build dependencies. But the automatically generated runtime dependencies do not add the directfb package to the runtime dependencies. Most likely this happens because libsdl2 does not link against directfb but uses dlopen() or similar. Thus, the runtime dependency to directfb needs to be declared explicitly.
---
Changes in v2:
- Add directfb as a rdepends instead of a rrecommends.
- Rework commit message.
meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb +1 -1
@@ -58,7 +58,7 @@ PACKAGECONFIG ??= " \ " PACKAGECONFIG[alsa] = "--enable-alsa --disable-alsatest,--disable-alsa,alsa-lib," PACKAGECONFIG[arm-neon] = "--enable-arm-neon,--disable-arm-neon" -PACKAGECONFIG[directfb] = "--enable-video-directfb,--disable-video-directfb,directfb" +PACKAGECONFIG[directfb] = "--enable-video-directfb,--disable-video-directfb,directfb,directfb" PACKAGECONFIG[gles2] = "--enable-video-opengles,--disable-video-opengles,virtual/libgles2" PACKAGECONFIG[jack] = "--enable-jack,--disable-jack,jack" PACKAGECONFIG[kmsdrm] = "--enable-video-kmsdrm,--disable-video-kmsdrm,libdrm virtual/libgbm"
--
2.25.1