Enable HDR on MCA LSPCON based Gen9 devices
Subsystems (3)
v11 cover Enable HDR on MCA LSPCON based Gen9 devices
Gen9 hardware supports HDMI2.0 through LSPCON chips. Extending HDR support for MCA and Parade LSPCON based GEN9 devices.
SOC will drive LSPCON as DP and send HDR metadata as standard DP SDP packets. LSPCON will be set to operate in PCON mode, will receive the metadata and create Dynamic Range and Mastering Infoframe (DRM packets) and send it to HDR capable HDMI sink devices.
v2: Fixed Ville's review comments. Suppressed some warnings. Patch 8 of the series is marked "Not for Merge" and is just for reference to userspace people to incorporate in order to support 10bit content with 4K@60 resolutions.
v3: Added Infoframe readout support for DRM infoframes. Addressed Jani Nikula's review comments.
v4: Addressed Ville's review comments and added proper bitmask for enabled infoframes. Series also incorporates Ville's patch for stopping infoframes to be sent to DVI sinks. Extended the same for DRM as well.
v5: Created separate helper function for lspcon_infoframes_enabled as per Ville's suggestion.
v6: Rebase
v7: Addressed Ville's review comments.
v8: Addressed Ville's review comments. Fixed the colorspace handling for Pcon and property attachment logic based on new lspcon detetction changes.
v9: Rebase
v10: Fixed one patch for detection
v11: Addressed Ville's review comments and added RB in the respective patches.
Thanks Ville for all the suggestions and inputs.
Note: Patch 13 of the series is for reference to userspace, not to be merged to driver.
Uma Shankar (13):
drm/i915/display: Add HDR Capability detection for LSPCON drm/i915/display: Enable HDR on gen9 devices with MCA Lspcon drm/i915/display: Attach HDR property for capable Gen9 devices drm/i915/display: Enable quantization range for HDR on LSPCON devices drm/i915/display: Add a WARN for invalid output range and format drm/i915/display: Attach content type property for LSPCON i915/display: Enable BT2020 for HDR on LSPCON devices drm/i915/display: Enable HDR for Parade based lspcon drm/i915/display: Implement infoframes readback for LSPCON drm/i915/display: Implement DRM infoframe read for LSPCON drm/i915/lspcon: Create separate infoframe_enabled helper drm/i915/lspcon: Do not send DRM infoframes to non-HDMI sinks drm/i915/display: [NOT FOR MERGE] Reduce blanking to support
4k60@10bpp for LSPCON
drivers/gpu/drm/i915/display/intel_ddi.c | 20 +- .../drm/i915/display/intel_display_types.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 36 ++++ drivers/gpu/drm/i915/display/intel_hdmi.c | 15 +- drivers/gpu/drm/i915/display/intel_lspcon.c | 177 +++++++++++++++--- drivers/gpu/drm/i915/display/intel_lspcon.h | 12 ++ 6 files changed, 226 insertions(+), 35 deletions(-)
Signature · 6 lines
2.26.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 1/13 drm/i915/display: Add HDR Capability detection for LSPCON
LSPCON firmware exposes HDR capability through LPCON_CAPABILITIES DPCD register. LSPCON implementations capable of supporting HDR set HDR_CAPABILITY bit in LSPCON_CAPABILITIES to 1. This patch reads the same, detects the HDR capability and adds this to intel_lspcon struct.
v2: Addressed Jani Nikula's review comment and fixed the HDR
capability detection logic
v3: Deferred HDR detection from lspcon_init (Ville)
v4: Addressed Ville's minor review comments, added his RB.
--- .../drm/i915/display/intel_display_types.h | 1 + drivers/gpu/drm/i915/display/intel_lspcon.c | 27 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_lspcon.h | 1 + 3 files changed, 29 insertions(+)
drivers/gpu/drm/i915/display/intel_display_types.h +1 -0
@@ -1450,6 +1450,7 @@ enum lspcon_vendor {struct intel_lspcon {bool active; +bool hdr_supported;enum drm_lspcon_mode mode;enum lspcon_vendor vendor; };
drivers/gpu/drm/i915/display/intel_lspcon.c +27 -0
@@ -35,6 +35,8 @@#define LSPCON_VENDOR_PARADE_OUI 0x001CF8#define LSPCON_VENDOR_MCA_OUI 0x0060AD +#define DPCD_MCA_LSPCON_HDR_STATUS 0x70003 +/* AUX addresses to write MCA AVI IF */ #define LSPCON_MCA_AVI_IF_WRITE_OFFSET 0x5C0#define LSPCON_MCA_AVI_IF_CTRL 0x5DF
@@ -104,6 +106,31 @@ static bool lspcon_detect_vendor(struct intel_lspcon *lspcon)return true; } +void lspcon_detect_hdr_capability (struct intel_lspcon *lspcon) +{ +struct intel_digital_port *dig_port = + container_of(lspcon, struct intel_digital_port, lspcon); +struct drm_device *dev = dig_port->base.base.dev; +struct intel_dp *dp =lspcon_to_intel_dp (lspcon); +u8 hdr_caps; +int ret; + +/* Enable HDR for MCA based LSPCON devices */ +if (lspcon->vendor ==LSPCON_VENDOR_MCA ) + ret =drm_dp_dpcd_read (&dp->aux,DPCD_MCA_LSPCON_HDR_STATUS , + &hdr_caps,1 ); +else +return ; + +if (ret <0 ) { +drm_dbg_kms (dev,"HDR capability detection failed\n" ); + lspcon->hdr_supported = false; + }else if (hdr_caps &0x1 ) { +drm_dbg_kms (dev,"LSPCON capable of HDR\n" ); + lspcon->hdr_supported = true; + } +} +static enum drm_lspcon_mode lspcon_get_current_mode (struct intel_lspcon *lspcon) {enum drm_lspcon_mode current_mode;
drivers/gpu/drm/i915/display/intel_lspcon.h +1 -0
@@ -15,6 +15,7 @@ struct intel_digital_port;struct intel_encoder ;struct intel_lspcon ; +void lspcon_detect_hdr_capability (struct intel_lspcon *lspcon);void lspcon_resume (struct intel_digital_port *dig_port);void lspcon_wait_pcon_mode (struct intel_lspcon *lspcon); void lspcon_write_infoframe(struct intel_encoder *encoder,
Signature · 6 lines
2.26.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [v11 01/13] drm/i915/display: Add HDR Capability detection for LSPCON
Quoted 9 lines · Uma Shankar
LSPCON firmware exposes HDR capability through
LPCON_CAPABILITIESDPCD register. LSPCON implementations capable of supporting HDR setHDR_CAPABILITYbit inLSPCON_CAPABILITIESto 1. This patch reads the same, detects the HDR capability and adds this tointel_lspconstruct.v2: Addressed Jani Nikula's review comment and fixed the HDR
capability detection logic
Quoted 6 lines
v3: Deferred HDR detection from
lspcon_init(Ville)v4: Addressed Ville's minor review comments, added his RB.
Signed-off-by Uma Shankar <[email protected]>Reviewed-by Ville Syrjä <[email protected]>
Wrong name
Quoted 77 lines
--- .../drm/i915/display/intel_display_types.h | 1 + drivers/gpu/drm/i915/display/intel_lspcon.c | 27 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_lspcon.h | 1 + 3 files changed, 29 insertions(+)drivers/gpu/drm/i915/display/intel_display_types.h +1
-0@@ -1450,6 +1450,7 @@ enum lspcon_vendor {struct intel_lspcon {bool active; +bool hdr_supported;enum drm_lspcon_mode mode;enum lspcon_vendor vendor; };drivers/gpu/drm/i915/display/intel_lspcon.c +27
-0@@ -35,6 +35,8 @@#define LSPCON_VENDOR_PARADE_OUI 0x001CF8#define LSPCON_VENDOR_MCA_OUI 0x0060AD +#define DPCD_MCA_LSPCON_HDR_STATUS 0x70003 +/* AUX addresses to write MCA AVI IF */ #define LSPCON_MCA_AVI_IF_WRITE_OFFSET 0x5C0#define LSPCON_MCA_AVI_IF_CTRL 0x5DF@@ -104,6 +106,31 @@ static bool lspcon_detect_vendor(struct intel_lspcon *lspcon)return true; } +void lspcon_detect_hdr_capability (struct intel_lspcon *lspcon) +{ +struct intel_digital_port *dig_port = + container_of(lspcon, struct intel_digital_port, lspcon); +struct drm_device *dev = dig_port->base.base.dev; +struct intel_dp *dp =lspcon_to_intel_dp (lspcon); +u8 hdr_caps; +int ret; + +/* Enable HDR for MCA based LSPCON devices */ +if (lspcon->vendor ==LSPCON_VENDOR_MCA ) + ret =drm_dp_dpcd_read (&dp->aux,DPCD_MCA_LSPCON_HDR_STATUS , + &hdr_caps,1 ); +else +return ; + +if (ret <0 ) { +drm_dbg_kms (dev,"HDR capability detection failed\n" ); + lspcon->hdr_supported = false; + }else if (hdr_caps &0x1 ) { +drm_dbg_kms (dev,"LSPCON capable of HDR\n" ); + lspcon->hdr_supported = true; + } +} +static enum drm_lspcon_mode lspcon_get_current_mode (struct intel_lspcon *lspcon) {enum drm_lspcon_mode current_mode;drivers/gpu/drm/i915/display/intel_lspcon.h +1
-0@@ -15,6 +15,7 @@ struct intel_digital_port;struct intel_encoder ;struct intel_lspcon ; +void lspcon_detect_hdr_capability (struct intel_lspcon *lspcon);void lspcon_resume (struct intel_digital_port *dig_port);void lspcon_wait_pcon_mode (struct intel_lspcon *lspcon); void lspcon_write_infoframe(struct intel_encoder *encoder,Signature · 1 line
2.26.2
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [v11 01/13] drm/i915/display: Add HDR Capability detection for LSPCON
Quoted 19 lines
-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Thursday, November 26, 2020 9:56 PM
To: Shankar, Uma <[email protected]>
Cc: [email protected]
Subject: Re: [v11 01/13] drm/i915/display: Add HDR Capability detection for LSPCONQuoted 8 lines · Uma Shankar
LSPCON firmware exposes HDR capability through
LPCON_CAPABILITIESDPCD register. LSPCON implementations capable of supporting HDR setHDR_CAPABILITYbit inLSPCON_CAPABILITIESto 1. This patch reads the same, detects the HDR capability and adds this tointel_lspconstruct.v2: Addressed Jani Nikula's review comment and fixed the HDR
capability detection logic
Quoted 8 lines
Quoted 6 lines
v3: Deferred HDR detection from
lspcon_init(Ville)v4: Addressed Ville's minor review comments, added his RB.
Signed-off-by Uma Shankar <[email protected]>Reviewed-by Ville Syrjä <[email protected]>Wrong name
Oh, somehow editor messed this up. Will fix this.
Quoted 74 lines
Quoted 31 lines
--- .../drm/i915/display/intel_display_types.h | 1 + drivers/gpu/drm/i915/display/intel_lspcon.c | 27 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_lspcon.h | 1 + 3 files changed, 29 insertions(+)drivers/gpu/drm/i915/display/intel_display_types.h +1
-0@@ -1450,6 +1450,7 @@ enum lspcon_vendor {struct intel_lspcon {bool active; +bool hdr_supported;enum drm_lspcon_mode mode;enum lspcon_vendor vendor; };drivers/gpu/drm/i915/display/intel_lspcon.c +0
-0@@ -35,6 +35,8 @@#define LSPCON_VENDOR_PARADE_OUI 0x001CF8 #define
LSPCON_VENDOR_MCA_OUI0x0060ADdrivers/gpu/drm/i915/display/intel_lspcon.c +2
-0+#define DPCD_MCA_LSPCON_HDR_STATUS 0x70003 + /* AUX addresses to write MCA AVI IF */ #defineQuoted 1 line
LSPCON_MCA_AVI_IF_WRITE_OFFSET0x5C0#define
LSPCON_MCA_AVI_IF_CTRLQuoted 6 lines
0x5DF@@ -104,6 +106,31 @@ static boollspcon_detect_vendor(struct intel_lspcon *lspcon)drivers/gpu/drm/i915/display/intel_lspcon.c +1
-0return true; } +void lspcon_detect_hdr_capability (struct intel_lspcon *lspcon) {drivers/gpu/drm/i915/display/intel_lspcon.c static bool lspcon_detect_vendor(struct intel_lspcon *lspcon)
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_lspcon.c +10
-0+struct intel_digital_port *dig_port = + container_of(lspcon, struct intel_digital_port, lspcon); +struct drm_device *dev = dig_port->base.base.dev; +struct intel_dp *dp =lspcon_to_intel_dp (lspcon); +u8 hdr_caps; +int ret; + +/* Enable HDR for MCA based LSPCON devices */ +if (lspcon->vendor ==LSPCON_VENDOR_MCA ) + ret = drm_dp_dpcd_read(&dp->aux,
DPCD_MCA_LSPCON_HDR_STATUS,Quoted 24 lines
drivers/gpu/drm/i915/display/intel_lspcon.c +13
-0+ &hdr_caps, 1); + else + return; + +if (ret <0 ) { +drm_dbg_kms (dev,"HDR capability detection failed\n" ); + lspcon->hdr_supported = false; + }else if (hdr_caps &0x1 ) { +drm_dbg_kms (dev,"LSPCON capable of HDR\n" ); + lspcon->hdr_supported = true; + } +} + static enum drm_lspcon_mode lspcon_get_current_mode(struct
intel_lspcon*lspcon) {drivers/gpu/drm/i915/display/intel_lspcon.c +0
-0enum drm_lspcon_mode current_mode;drivers/gpu/drm/i915/display/intel_lspcon.h +0
-0@@ -15,6 +15,7 @@ struct intel_digital_port; struct intel_encoder;struct intel_lspcon ;
Quoted 10 lines
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_lspcon.h +1
-0+void lspcon_detect_hdr_capability (struct intel_lspcon *lspcon);void lspcon_resume (struct intel_digital_port *dig_port);void
lspcon_wait_pcon_mode(struct intel_lspcon *lspcon); void lspcon_write_infoframe(structintel_encoder*encoder, --
2.26.2--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 2/13 drm/i915/display: Enable HDR on gen9 devices with MCA Lspcon
In reply to Uma ShankarGen9 hardware supports HDMI2.0 through LSPCON chips. Extending HDR support for MCA LSPCON based GEN9 devices.
SOC will drive LSPCON as DP and send HDR metadata as standard DP SDP packets. LSPCON will be set to operate in PCON mode, will receive the metadata and create Dynamic Range and Mastering Infoframe (DRM packets) and send it to HDR capable HDMI sink devices.
v2: Re-used hsw infoframe write implementation for HDR metadata for LSPCON as per Ville's suggestion.
v3: Addressed Jani Nikula's review comments.
v4: Addressed Ville's review comments, removed redundant wrapper and checks, passed arguments instead of hardcodings.
--- drivers/gpu/drm/i915/display/intel_hdmi.c | 8 +++--- drivers/gpu/drm/i915/display/intel_lspcon.c | 31 ++++++++++++--------- drivers/gpu/drm/i915/display/intel_lspcon.h | 4 +++ 3 files changed, 26 insertions(+), 17 deletions(-)
drivers/gpu/drm/i915/display/intel_hdmi.c +4 -4
@@ -518,10 +518,10 @@ static u32 vlv_infoframes_enabled(struct intel_encoder *encoder, VIDEO_DIP_ENABLE_SPD | VIDEO_DIP_ENABLE_GCP); } -static void hsw_write_infoframe (struct intel_encoder *encoder, -const struct intel_crtc_state *crtc_state, -unsigned int type, -const void *frame,ssize_t len) +void hsw_write_infoframe (struct intel_encoder *encoder, +const struct intel_crtc_state *crtc_state, +unsigned int type, +const void *frame,ssize_t len) {const u32 *data = frame;struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev);
drivers/gpu/drm/i915/display/intel_lspcon.c +18 -13
@@ -445,27 +445,32 @@ void lspcon_write_infoframe(struct intel_encoder *encoder,unsigned int type, const void *frame, ssize_t len) { - bool ret; + bool ret = true;struct intel_dp *intel_dp =enc_to_intel_dp (encoder);struct intel_lspcon *lspcon =enc_to_intel_lspcon (encoder); -/* LSPCON only needs AVI IF */ -if (type !=HDMI_INFOFRAME_TYPE_AVI ) +switch (type) { +case HDMI_INFOFRAME_TYPE_AVI : +if (lspcon->vendor ==LSPCON_VENDOR_MCA ) + ret =_lspcon_write_avi_infoframe_mca (&intel_dp->aux, + frame, len); +else + ret =_lspcon_write_avi_infoframe_parade (&intel_dp->aux, + frame, len); +break ; +case HDMI_PACKET_TYPE_GAMUT_METADATA : +drm_dbg_kms (encoder->base.dev,"Update HDR metadata for lspcon\n" ); +/* It uses the legacy hsw implementation for the same */ +hsw_write_infoframe (encoder, crtc_state, type, frame, len); +break ; +default :return ; - -if (lspcon->vendor ==LSPCON_VENDOR_MCA ) - ret =_lspcon_write_avi_infoframe_mca (&intel_dp->aux, - frame, len); -else - ret =_lspcon_write_avi_infoframe_parade (&intel_dp->aux, - frame, len); + }if (!ret) { -DRM_ERROR ("Failed to write AVI infoframes\n" ); +DRM_ERROR ("Failed to write infoframes\n" );return ; } - -DRM_DEBUG_DRIVER ("AVI infoframes updated successfully\n" ); } void lspcon_read_infoframe(struct intel_encoder *encoder,
drivers/gpu/drm/i915/display/intel_lspcon.h +4 -0
@@ -32,5 +32,9 @@ void lspcon_set_infoframes(struct intel_encoder *encoder, const struct drm_connector_state *conn_state);u32 lspcon_infoframes_enabled (struct intel_encoder *encoder,const struct intel_crtc_state *pipe_config); +void hsw_write_infoframe (struct intel_encoder *encoder, +const struct intel_crtc_state *crtc_state, +unsigned int type, +const void *frame,ssize_t len);#endif /* __INTEL_LSPCON_H__ */
Signature · 6 lines
2.26.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 3/13 drm/i915/display: Attach HDR property for capable Gen9 devices
In reply to Uma ShankarAttach HDR property for Gen9 devices with MCA LSPCON chips.
v2: Cleaned HDR property attachment logic based on capability as per Jani Nikula's suggestion.
v3: Fixed the HDR property attachment logic as per the new changes by Kai-Feng to align with lspcon detection failure on some devices.
v4: Add HDR proprty in late_register to handle lspcon detection, as suggested by Ville.
v5: Init Lspcon only if advertized from BIOS.
v6: Added a Todo to plan a cleanup later, added Ville's RB.
--- drivers/gpu/drm/i915/display/intel_dp.c | 18 ++++++++++++++++++ drivers/gpu/drm/i915/display/intel_lspcon.c | 2 +- drivers/gpu/drm/i915/display/intel_lspcon.h | 1 + 3 files changed, 20 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_dp.c +18 -0
@@ -6774,6 +6774,8 @@ intel_dp_connector_register(struct drm_connector *connector) {struct drm_i915_private *i915 =to_i915 (connector->dev);struct intel_dp *intel_dp =intel_attached_dp (to_intel_connector (connector)); +struct intel_digital_port *dig_port =dp_to_dig_port (intel_dp); +struct intel_lspcon *lspcon = &dig_port->lspcon;int ret; ret =intel_connector_register (connector);
@@ -6787,6 +6789,22 @@ intel_dp_connector_register(struct drm_connector *connector) ret =drm_dp_aux_register (&intel_dp->aux);if (!ret)drm_dp_cec_register_connector (&intel_dp->aux, connector); + +if (!intel_bios_is_lspcon_present (i915, dig_port->base.port)) +return ret; + +/* +* ToDo: Clean this up to handle lspcon init and resume more +* efficiently and streamlined. +*/ +if (lspcon_init (dig_port)) { +lspcon_detect_hdr_capability (lspcon); +if (lspcon->hdr_supported) +drm_object_attach_property (&connector->base, + connector->dev->mode_config.hdr_output_metadata_property, +0 ); + } +return ret; }
drivers/gpu/drm/i915/display/intel_lspcon.c +1 -1
@@ -552,7 +552,7 @@ void lspcon_wait_pcon_mode(struct intel_lspcon *lspcon)lspcon_wait_mode (lspcon,DRM_LSPCON_MODE_PCON ); } -static bool lspcon_init (struct intel_digital_port *dig_port) +bool lspcon_init (struct intel_digital_port *dig_port) {struct intel_dp *dp = &dig_port->dp;struct intel_lspcon *lspcon = &dig_port->lspcon;
drivers/gpu/drm/i915/display/intel_lspcon.h +1 -0
@@ -15,6 +15,7 @@ struct intel_digital_port;struct intel_encoder ;struct intel_lspcon ; +bool lspcon_init (struct intel_digital_port *dig_port);void lspcon_detect_hdr_capability (struct intel_lspcon *lspcon);void lspcon_resume (struct intel_digital_port *dig_port);void lspcon_wait_pcon_mode (struct intel_lspcon *lspcon);
Signature · 6 lines
2.26.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 4/13 drm/i915/display: Enable quantization range for HDR on LSPCON devices
In reply to Uma ShankarThis patch handles the quantization range for Lspcon.
--- drivers/gpu/drm/i915/display/intel_lspcon.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_lspcon.c +11 -6
@@ -523,12 +523,17 @@ void lspcon_set_infoframes(struct intel_encoder *encoder,else frame.avi.colorspace =HDMI_COLORSPACE_RGB ; -drm_hdmi_avi_infoframe_quant_range (&frame.avi, - conn_state->connector, - adjusted_mode, - crtc_state->limited_color_range ? -HDMI_QUANTIZATION_RANGE_LIMITED : -HDMI_QUANTIZATION_RANGE_FULL ); +if (crtc_state->output_format ==INTEL_OUTPUT_FORMAT_RGB ) { +drm_hdmi_avi_infoframe_quant_range (&frame.avi, + conn_state->connector, + adjusted_mode, + crtc_state->limited_color_range ? +HDMI_QUANTIZATION_RANGE_LIMITED : +HDMI_QUANTIZATION_RANGE_FULL ); + }else { + frame.avi.quantization_range =HDMI_QUANTIZATION_RANGE_DEFAULT ; + frame.avi.ycc_quantization_range =HDMI_YCC_QUANTIZATION_RANGE_LIMITED ; + } ret =hdmi_infoframe_pack (&frame, buf,sizeof (buf));if (ret <0 ) {
Signature · 6 lines
2.26.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [v11 04/13] drm/i915/display: Enable quantization range for HDR on LSPCON devices
Quoted 1 line · Uma Shankar
This patch handles the quantization range for Lspcon.
I would state it as "fixes quantization range for YCbCr output" or something along those lins.
Quoted 36 lines
Signed-off-by Uma Shankar <[email protected]>--- drivers/gpu/drm/i915/display/intel_lspcon.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-)drivers/gpu/drm/i915/display/intel_lspcon.c +11
-6@@ -523,12 +523,17 @@ void lspcon_set_infoframes(struct intel_encoder *encoder,else frame.avi.colorspace =HDMI_COLORSPACE_RGB ; -drm_hdmi_avi_infoframe_quant_range (&frame.avi, - conn_state->connector, - adjusted_mode, - crtc_state->limited_color_range ? -HDMI_QUANTIZATION_RANGE_LIMITED : -HDMI_QUANTIZATION_RANGE_FULL ); +if (crtc_state->output_format ==INTEL_OUTPUT_FORMAT_RGB ) { +drm_hdmi_avi_infoframe_quant_range (&frame.avi, + conn_state->connector, + adjusted_mode, + crtc_state->limited_color_range ? +HDMI_QUANTIZATION_RANGE_LIMITED : +HDMI_QUANTIZATION_RANGE_FULL ); + }else { + frame.avi.quantization_range =HDMI_QUANTIZATION_RANGE_DEFAULT ; + frame.avi.ycc_quantization_range =HDMI_YCC_QUANTIZATION_RANGE_LIMITED ; + } ret =hdmi_infoframe_pack (&frame, buf,sizeof (buf));if (ret <0 ) {Signature · 1 line
2.26.2
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 5/13 drm/i915/display: Add a WARN for invalid output range and format
In reply to Uma ShankarAdd a WARN to rule out an invalid output range and format combination. This is to align the lspcon code with compute_avi_infoframes.
--- drivers/gpu/drm/i915/display/intel_lspcon.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/gpu/drm/i915/display/intel_lspcon.c +4 -0
@@ -523,6 +523,10 @@ void lspcon_set_infoframes(struct intel_encoder *encoder,else frame.avi.colorspace =HDMI_COLORSPACE_RGB ; +/* nonsense combination */ +drm_WARN_ON (encoder->base.dev, crtc_state->limited_color_range && + crtc_state->output_format !=INTEL_OUTPUT_FORMAT_RGB ); +if (crtc_state->output_format ==INTEL_OUTPUT_FORMAT_RGB ) { drm_hdmi_avi_infoframe_quant_range(&frame.avi, conn_state->connector,
Signature · 6 lines
2.26.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [v11 05/13] drm/i915/display: Add a WARN for invalid output range and format
Quoted 5 lines · Uma Shankar
Add a WARN to rule out an invalid output range and format combination. This is to align the lspcon code with
compute_avi_infoframes.Signed-off-by Uma Shankar <[email protected]>
Quoted 21 lines
--- drivers/gpu/drm/i915/display/intel_lspcon.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/gpu/drm/i915/display/intel_lspcon.c +4
-0@@ -523,6 +523,10 @@ void lspcon_set_infoframes(struct intel_encoder *encoder,else frame.avi.colorspace =HDMI_COLORSPACE_RGB ; +/* nonsense combination */ +drm_WARN_ON (encoder->base.dev, crtc_state->limited_color_range && + crtc_state->output_format !=INTEL_OUTPUT_FORMAT_RGB ); +if (crtc_state->output_format ==INTEL_OUTPUT_FORMAT_RGB ) { drm_hdmi_avi_infoframe_quant_range(&frame.avi, conn_state->connector,Signature · 1 line
2.26.2
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 6/13 drm/i915/display: Attach content type property for LSPCON
In reply to Uma ShankarContent type is supported on HDMI sink devices. Attached the property for the same for LSPCON based devices.
v2: Added the content type programming when we are attaching the property to connector, as suggested by Ville.
--- drivers/gpu/drm/i915/display/intel_dp.c | 1 + drivers/gpu/drm/i915/display/intel_lspcon.c | 2 ++ 2 files changed, 3 insertions(+)
drivers/gpu/drm/i915/display/intel_dp.c +1 -0
@@ -6803,6 +6803,7 @@ intel_dp_connector_register(struct drm_connector *connector)drm_object_attach_property (&connector->base, connector->dev->mode_config.hdr_output_metadata_property,0 ); +drm_connector_attach_content_type_property (connector); }return ret;
drivers/gpu/drm/i915/display/intel_lspcon.c +2 -0
@@ -539,6 +539,8 @@ void lspcon_set_infoframes(struct intel_encoder *encoder, frame.avi.ycc_quantization_range =HDMI_YCC_QUANTIZATION_RANGE_LIMITED ; } +drm_hdmi_avi_infoframe_content_type (&frame.avi, conn_state); + ret =hdmi_infoframe_pack (&frame, buf,sizeof (buf));if (ret <0 ) {DRM_ERROR ("Failed to pack AVI IF\n" );
Signature · 6 lines
2.26.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [v11 06/13] drm/i915/display: Attach content type property for LSPCON
Quoted 7 lines · Uma Shankar
Content type is supported on HDMI sink devices. Attached the property for the same for LSPCON based devices.
v2: Added the content type programming when we are attaching the property to connector, as suggested by Ville.
Signed-off-by Uma Shankar <[email protected]>
Quoted 32 lines
--- drivers/gpu/drm/i915/display/intel_dp.c | 1 + drivers/gpu/drm/i915/display/intel_lspcon.c | 2 ++ 2 files changed, 3 insertions(+)drivers/gpu/drm/i915/display/intel_dp.c +1
-0@@ -6803,6 +6803,7 @@ intel_dp_connector_register(struct drm_connector *connector)drm_object_attach_property (&connector->base, connector->dev->mode_config.hdr_output_metadata_property,0 ); +drm_connector_attach_content_type_property (connector); }return ret;drivers/gpu/drm/i915/display/intel_lspcon.c +2
-0@@ -539,6 +539,8 @@ void lspcon_set_infoframes(struct intel_encoder *encoder, frame.avi.ycc_quantization_range =HDMI_YCC_QUANTIZATION_RANGE_LIMITED ; } +drm_hdmi_avi_infoframe_content_type (&frame.avi, conn_state); + ret =hdmi_infoframe_pack (&frame, buf,sizeof (buf));if (ret <0 ) {DRM_ERROR ("Failed to pack AVI IF\n" );Signature · 1 line
2.26.2
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 7/13 i915/display: Enable BT2020 for HDR on LSPCON devices
In reply to Uma ShankarEnable Colorspace as BT2020 if driving HDR content.Sending Colorimetry data for HDR using AVI infoframe. LSPCON firmware expects this and though SOC drives DP, for HDMI panel AVI infoframe is sent to the LSPCON device which transfers the same to HDMI sink.
v2: Dropped state managed in drm core as per Jani Nikula's suggestion.
v3: Aligned colorimetry handling for lspcon as per compute_avi_infoframes, as suggested by Ville.
v4: Added BT2020 as default for HDR. Adding the colorspace property interface for pcon will be take up separately. Moved changes of quantization in a separate patch as per Ville's comments.
--- drivers/gpu/drm/i915/display/intel_lspcon.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
drivers/gpu/drm/i915/display/intel_lspcon.c +18 -0
@@ -481,6 +481,10 @@ void lspcon_read_infoframe(struct intel_encoder *encoder,/* FIXME implement this */ } +/* HDMI HDR Colorspace Spec Definitions */ +#define NORMAL_COLORIMETRY_MASK 0x3 +#define EXTENDED_COLORIMETRY_MASK 0x7 +#define HDMI_COLORIMETRY_BT2020_YCC ((3 << 0) | (6 << 2) | (0 << 5)) void lspcon_set_infoframes(struct intel_encoder *encoder, bool enable, const struct intel_crtc_state *crtc_state,
@@ -523,6 +527,20 @@ void lspcon_set_infoframes(struct intel_encoder *encoder,else frame.avi.colorspace =HDMI_COLORSPACE_RGB ; +/* +* Set BT2020 colorspace if driving HDR data +* ToDo: Make this generic and expose all colorspaces for +* lspcon. We need to expose HDMI colorspaces when we detect +* lspcon, this has to happen after connector is registered, +* so need to fix this appropriately +*/ +if (lspcon->active && conn_state->hdr_output_metadata) { + frame.avi.colorimetry =HDMI_COLORIMETRY_BT2020_YCC & +NORMAL_COLORIMETRY_MASK ; + frame.avi.extended_colorimetry = (HDMI_COLORIMETRY_BT2020_YCC >>2 ) & +EXTENDED_COLORIMETRY_MASK ; + } +/* nonsense combination */ drm_WARN_ON (encoder->base.dev, crtc_state->limited_color_range && crtc_state->output_format !=INTEL_OUTPUT_FORMAT_RGB );
Signature · 6 lines
2.26.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [v11 07/13] i915/display: Enable BT2020 for HDR on LSPCON devices
Quoted 42 lines · Uma Shankar
Enable Colorspace as BT2020 if driving HDR content.Sending Colorimetry data for HDR using AVI infoframe. LSPCON firmware expects this and though SOC drives DP, for HDMI panel AVI infoframe is sent to the LSPCON device which transfers the same to HDMI sink.
v2: Dropped state managed in drm core as per Jani Nikula's suggestion.
v3: Aligned colorimetry handling for lspcon as per
compute_avi_infoframes, as suggested by Ville.v4: Added BT2020 as default for HDR. Adding the colorspace property interface for pcon will be take up separately. Moved changes of quantization in a separate patch as per Ville's comments.
Signed-off-by Uma Shankar <[email protected]>--- drivers/gpu/drm/i915/display/intel_lspcon.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)drivers/gpu/drm/i915/display/intel_lspcon.c +8
-0@@ -481,6 +481,10 @@ void lspcon_read_infoframe(struct intel_encoder *encoder,/* FIXME implement this */ } +/* HDMI HDR Colorspace Spec Definitions */ +#define NORMAL_COLORIMETRY_MASK 0x3 +#define EXTENDED_COLORIMETRY_MASK 0x7 +#define HDMI_COLORIMETRY_BT2020_YCC ((3 << 0) | (6 << 2) | (0 << 5)) void lspcon_set_infoframes(struct intel_encoder *encoder, bool enable, const struct intel_crtc_state *crtc_state,@@ -523,6 +527,20 @@ void lspcon_set_infoframes(struct intel_encoder *encoder,else frame.avi.colorspace =HDMI_COLORSPACE_RGB ; +/* +* Set BT2020 colorspace if driving HDR data +* ToDo: Make this generic and expose all colorspaces for +* lspcon. We need to expose HDMI colorspaces when we detect
drivers/gpu/drm/i915/display/intel_lspcon.c void lspcon_set_infoframes(struct intel_encoder *encoder, · line 543
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_lspcon.c +10
-0+* lspcon, this has to happen after connector is registered, +* so need to fix this appropriately +*/ +if (lspcon->active && conn_state->hdr_output_metadata) { + frame.avi.colorimetry =HDMI_COLORIMETRY_BT2020_YCC & +NORMAL_COLORIMETRY_MASK ; + frame.avi.extended_colorimetry = (HDMI_COLORIMETRY_BT2020_YCC >>2 ) & +EXTENDED_COLORIMETRY_MASK ; + } +
I don't understand the point of dancing around this instead of just fixing it.
There, I did half the work for you
https://patchwork.freedesktop.org/series/84309/
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_lspcon.c +0
-0/* nonsense combination */ drm_WARN_ON (encoder->base.dev, crtc_state->limited_color_range && crtc_state->output_format !=INTEL_OUTPUT_FORMAT_RGB );Signature · 1 line
2.26.2
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [v11 07/13] i915/display: Enable BT2020 for HDR on LSPCON devices
Quoted 64 lines
-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Thursday, November 26, 2020 10:43 PM
To: Shankar, Uma <[email protected]>
Cc: [email protected]
Subject: Re: [v11 07/13] i915/display: Enable BT2020 for HDR on LSPCON devicesdrivers/gpu/drm/i915/display/intel_lspcon.c void lspcon_read_infoframe(struct intel_encoder
Quoted 25 lines · Uma Shankar
Enable Colorspace as BT2020 if driving HDR content.Sending Colorimetry data for HDR using AVI infoframe. LSPCON firmware expects this and though SOC drives DP, for HDMI panel AVI infoframe is sent to the LSPCON device which transfers the same to HDMI sink.
v2: Dropped state managed in drm core as per Jani Nikula's suggestion.
v3: Aligned colorimetry handling for lspcon as per
compute_avi_infoframes, as suggested by Ville.v4: Added BT2020 as default for HDR. Adding the colorspace property interface for pcon will be take up separately. Moved changes of quantization in a separate patch as per Ville's comments.
Signed-off-by Uma Shankar <[email protected]>--- drivers/gpu/drm/i915/display/intel_lspcon.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)drivers/gpu/drm/i915/display/intel_lspcon.c +0
-0@@ -481,6 +481,10 @@ void lspcon_read_infoframe(struct intel_encoder*encoder,
drivers/gpu/drm/i915/display/intel_lspcon.c void lspcon_read_infoframe(struct intel_encoder *encoder,
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_lspcon.c +4
-0/* FIXME implement this */ } +/* HDMI HDR Colorspace Spec Definitions */ +#define NORMAL_COLORIMETRY_MASK 0x3 +#define EXTENDED_COLORIMETRY_MASK 0x7 +#define HDMI_COLORIMETRY_BT2020_YCC ((3 << 0) | (6 << 2) | (0 << 5)) void lspcon_set_infoframes(struct intel_encoder *encoder, bool enable, const struct intel_crtc_state *crtc_state, @@ -523,6+527,20 @@
Quoted 5 lines
void lspcon_set_infoframes(struct
intel_encoder*encoder,drivers/gpu/drm/i915/display/intel_lspcon.c +1
-0else frame.avi.colorspace =HDMI_COLORSPACE_RGB ; +/* drivers/gpu/drm/i915/display/intel_lspcon.c void lspcon_set_infoframes(struct intel_encoder *encoder,
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_lspcon.c +10
-0+* Set BT2020 colorspace if driving HDR data +* ToDo: Make this generic and expose all colorspaces for +* lspcon. We need to expose HDMI colorspaces when we detect +* lspcon, this has to happen after connector is registered, +* so need to fix this appropriately +*/ +if (lspcon->active && conn_state->hdr_output_metadata) { + frame.avi.colorimetry =HDMI_COLORIMETRY_BT2020_YCC & +NORMAL_COLORIMETRY_MASK ; + frame.avi.extended_colorimetry =(
HDMI_COLORIMETRY_BT2020_YCC>> 2) &Quoted 1 line
+
Quoted 8 lines
EXTENDED_COLORIMETRY_MASK;drivers/gpu/drm/i915/display/intel_lspcon.c void lspcon_set_infoframes(struct intel_encoder *encoder, · line 543
Quoted 2 lines
drivers/gpu/drm/i915/display/intel_lspcon.c +2
-0+ } +I don't understand the point of dancing around this instead of just fixing it.
There, I did half the work for you
https://patchwork.freedesktop.org/series/84309/
Somehow was not able to think of right way to handle this.
Thanks Ville for your patience and help. I will add the patch to series and build on top of it.
Regards,
Uma Shankar
Quoted 10 lines
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_lspcon.c +0
-1/* nonsense combination */ drm_WARN_ON (encoder->base.dev, crtc_state->limited_color_range && crtc_state->output_format !=INTEL_OUTPUT_FORMAT_RGB ); --2.26.2
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 8/13 drm/i915/display: Enable HDR for Parade based lspcon
In reply to Uma ShankarEnable HDR for LSPCON based on Parade along with MCA.
v2: Added a helper for status reg as suggested by Ville.
v3: Removed a redundant variable, added Ville's RB.
--- drivers/gpu/drm/i915/display/intel_lspcon.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_lspcon.c +11 -6
@@ -36,6 +36,7 @@#define LSPCON_VENDOR_MCA_OUI 0x0060AD#define DPCD_MCA_LSPCON_HDR_STATUS 0x70003 +#define DPCD_PARADE_LSPCON_HDR_STATUS 0x00511/* AUX addresses to write MCA AVI IF */ #define LSPCON_MCA_AVI_IF_WRITE_OFFSET 0x5C0
@@ -106,6 +107,14 @@ static bool lspcon_detect_vendor(struct intel_lspcon *lspcon)return true; } +static u32 get_hdr_status_reg (struct intel_lspcon *lspcon) +{ +if (lspcon->vendor ==LSPCON_VENDOR_MCA ) +return DPCD_MCA_LSPCON_HDR_STATUS ; +else +return DPCD_PARADE_LSPCON_HDR_STATUS ; +} +void lspcon_detect_hdr_capability (struct intel_lspcon *lspcon) { struct intel_digital_port *dig_port =
@@ -115,12 +124,8 @@ void lspcon_detect_hdr_capability(struct intel_lspcon *lspcon)u8 hdr_caps;int ret; -/* Enable HDR for MCA based LSPCON devices */ -if (lspcon->vendor ==LSPCON_VENDOR_MCA ) - ret =drm_dp_dpcd_read (&dp->aux,DPCD_MCA_LSPCON_HDR_STATUS , - &hdr_caps,1 ); -else -return ; + ret =drm_dp_dpcd_read (&dp->aux,get_hdr_status_reg (lspcon), + &hdr_caps,1 );if (ret <0 ) {drm_dbg_kms (dev,"HDR capability detection failed\n" );
Signature · 6 lines
2.26.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 9/13 drm/i915/display: Implement infoframes readback for LSPCON
In reply to Uma ShankarImplemented Infoframes enabled readback for LSPCON devices. This will help align the implementation with state readback infrastructure.
v2: Added proper bitmask of enabled infoframes as per Ville's recommendation.
v3: Added pcon specific infoframe types instead of using the HSW one's, as recommended by Ville.
v4: Addressed Ville's review comment by adding HDMI infoframe versions directly instead of DIP wrappers.
--- drivers/gpu/drm/i915/display/intel_lspcon.c | 57 ++++++++++++++++++++- 1 file changed, 55 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_lspcon.c +55 -2
@@ -574,11 +574,64 @@ void lspcon_set_infoframes(struct intel_encoder *encoder, buf, ret); } +static bool _lspcon_read_avi_infoframe_enabled_mca (struct drm_dp_aux *aux) +{ +int ret; +u32 val =0 ; +u16 reg =LSPCON_MCA_AVI_IF_CTRL ; + + ret =drm_dp_dpcd_read (aux, reg, &val,1 ); +if (ret <0 ) { +DRM_ERROR ("DPCD read failed, address 0x%x\n" , reg); +return false; + } + +return val &LSPCON_MCA_AVI_IF_KICKOFF ; +} + +static bool _lspcon_read_avi_infoframe_enabled_parade (struct drm_dp_aux *aux) +{ +int ret; +u32 val =0 ; +u16 reg =LSPCON_PARADE_AVI_IF_CTRL ; + + ret =drm_dp_dpcd_read (aux, reg, &val,1 ); +if (ret <0 ) { +DRM_ERROR ("DPCD read failed, address 0x%x\n" , reg); +return false; + } + +return val &LSPCON_PARADE_AVI_IF_KICKOFF ; +} +u32 lspcon_infoframes_enabled (struct intel_encoder *encoder,const struct intel_crtc_state *pipe_config) { -/* FIXME actually read this from the hw */ -return 0 ; +struct intel_dp *intel_dp =enc_to_intel_dp (encoder); +struct intel_lspcon *lspcon =enc_to_intel_lspcon (encoder); +struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev); +bool infoframes_enabled; +u32 val =0 ; +u32 mask, tmp; + +if (lspcon->vendor ==LSPCON_VENDOR_MCA ) + infoframes_enabled =_lspcon_read_avi_infoframe_enabled_mca (&intel_dp->aux); +else + infoframes_enabled =_lspcon_read_avi_infoframe_enabled_parade (&intel_dp->aux); + +if (infoframes_enabled) + val |=intel_hdmi_infoframe_enable (HDMI_INFOFRAME_TYPE_AVI ); + +if (lspcon->hdr_supported) { + tmp =intel_de_read (dev_priv, +HSW_TVIDEO_DIP_CTL (pipe_config->cpu_transcoder)); + mask =VIDEO_DIP_ENABLE_GMP_HSW ; + +if (tmp & mask) + val |=intel_hdmi_infoframe_enable (HDMI_PACKET_TYPE_GAMUT_METADATA ); + } + +return val; }void lspcon_wait_pcon_mode (struct intel_lspcon *lspcon)
Signature · 6 lines
2.26.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [v11 09/13] drm/i915/display: Implement infoframes readback for LSPCON
Quoted 77 lines · Uma Shankar
Implemented Infoframes enabled readback for LSPCON devices. This will help align the implementation with state readback infrastructure.
v2: Added proper bitmask of enabled infoframes as per Ville's recommendation.
v3: Added pcon specific infoframe types instead of using the HSW one's, as recommended by Ville.
v4: Addressed Ville's review comment by adding HDMI infoframe versions directly instead of DIP wrappers.
Signed-off-by Uma Shankar <[email protected]>--- drivers/gpu/drm/i915/display/intel_lspcon.c | 57 ++++++++++++++++++++- 1 file changed, 55 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/display/intel_lspcon.c +46
-2@@ -574,11 +574,64 @@ void lspcon_set_infoframes(struct intel_encoder *encoder, buf, ret); } +static bool _lspcon_read_avi_infoframe_enabled_mca (struct drm_dp_aux *aux) +{ +int ret; +u32 val =0 ; +u16 reg =LSPCON_MCA_AVI_IF_CTRL ; + + ret =drm_dp_dpcd_read (aux, reg, &val,1 ); +if (ret <0 ) { +DRM_ERROR ("DPCD read failed, address 0x%x\n" , reg); +return false; + } + +return val &LSPCON_MCA_AVI_IF_KICKOFF ; +} + +static bool _lspcon_read_avi_infoframe_enabled_parade (struct drm_dp_aux *aux) +{ +int ret; +u32 val =0 ; +u16 reg =LSPCON_PARADE_AVI_IF_CTRL ; + + ret =drm_dp_dpcd_read (aux, reg, &val,1 ); +if (ret <0 ) { +DRM_ERROR ("DPCD read failed, address 0x%x\n" , reg); +return false; + } + +return val &LSPCON_PARADE_AVI_IF_KICKOFF ; +} +u32 lspcon_infoframes_enabled (struct intel_encoder *encoder,const struct intel_crtc_state *pipe_config) { -/* FIXME actually read this from the hw */ -return 0 ; +struct intel_dp *intel_dp =enc_to_intel_dp (encoder); +struct intel_lspcon *lspcon =enc_to_intel_lspcon (encoder); +struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev); +bool infoframes_enabled; +u32 val =0 ; +u32 mask, tmp; + +if (lspcon->vendor ==LSPCON_VENDOR_MCA ) + infoframes_enabled =_lspcon_read_avi_infoframe_enabled_mca (&intel_dp->aux); +else + infoframes_enabled =_lspcon_read_avi_infoframe_enabled_parade (&intel_dp->aux); + +if (infoframes_enabled) + val |=intel_hdmi_infoframe_enable (HDMI_INFOFRAME_TYPE_AVI ); + +if (lspcon->hdr_supported) {
drivers/gpu/drm/i915/display/intel_lspcon.c void lspcon_set_infoframes(struct intel_encoder *encoder, · line 635
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_lspcon.c +9
-0+ tmp =intel_de_read (dev_priv, +HSW_TVIDEO_DIP_CTL (pipe_config->cpu_transcoder)); + mask =VIDEO_DIP_ENABLE_GMP_HSW ; + +if (tmp & mask) + val |=intel_hdmi_infoframe_enable (HDMI_PACKET_TYPE_GAMUT_METADATA ); + } + +return val; }
This seem broken until patch 10 which avoids the remapping from DIP bits to the index. With some reordering of the patches this seems good.
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_lspcon.c +0
-0void lspcon_wait_pcon_mode (struct intel_lspcon *lspcon)Signature · 1 line
2.26.2
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [v11 09/13] drm/i915/display: Implement infoframes readback for LSPCON
Quoted 82 lines · Ville Syrjälä
Quoted 81 lines · Uma Shankar
Implemented Infoframes enabled readback for LSPCON devices. This will help align the implementation with state readback infrastructure.
v2: Added proper bitmask of enabled infoframes as per Ville's recommendation.
v3: Added pcon specific infoframe types instead of using the HSW one's, as recommended by Ville.
v4: Addressed Ville's review comment by adding HDMI infoframe versions directly instead of DIP wrappers.
Signed-off-by Uma Shankar <[email protected]>--- drivers/gpu/drm/i915/display/intel_lspcon.c | 57 ++++++++++++++++++++- 1 file changed, 55 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/display/intel_lspcon.c +50
-2@@ -574,11 +574,64 @@ void lspcon_set_infoframes(struct intel_encoder *encoder, buf, ret); } +static bool _lspcon_read_avi_infoframe_enabled_mca (struct drm_dp_aux *aux) +{ +int ret; +u32 val =0 ; +u16 reg =LSPCON_MCA_AVI_IF_CTRL ; + + ret =drm_dp_dpcd_read (aux, reg, &val,1 ); +if (ret <0 ) { +DRM_ERROR ("DPCD read failed, address 0x%x\n" , reg); +return false; + } + +return val &LSPCON_MCA_AVI_IF_KICKOFF ; +} + +static bool _lspcon_read_avi_infoframe_enabled_parade (struct drm_dp_aux *aux) +{ +int ret; +u32 val =0 ; +u16 reg =LSPCON_PARADE_AVI_IF_CTRL ; + + ret =drm_dp_dpcd_read (aux, reg, &val,1 ); +if (ret <0 ) { +DRM_ERROR ("DPCD read failed, address 0x%x\n" , reg); +return false; + } + +return val &LSPCON_PARADE_AVI_IF_KICKOFF ; +} +u32 lspcon_infoframes_enabled (struct intel_encoder *encoder,const struct intel_crtc_state *pipe_config) { -/* FIXME actually read this from the hw */ -return 0 ; +struct intel_dp *intel_dp =enc_to_intel_dp (encoder); +struct intel_lspcon *lspcon =enc_to_intel_lspcon (encoder); +struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev); +bool infoframes_enabled; +u32 val =0 ; +u32 mask, tmp; + +if (lspcon->vendor ==LSPCON_VENDOR_MCA ) + infoframes_enabled =_lspcon_read_avi_infoframe_enabled_mca (&intel_dp->aux); +else + infoframes_enabled =_lspcon_read_avi_infoframe_enabled_parade (&intel_dp->aux); + +if (infoframes_enabled) + val |=intel_hdmi_infoframe_enable (HDMI_INFOFRAME_TYPE_AVI ); + +if (lspcon->hdr_supported) { + tmp =intel_de_read (dev_priv, +HSW_TVIDEO_DIP_CTL (pipe_config->cpu_transcoder)); + mask =VIDEO_DIP_ENABLE_GMP_HSW ; +
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_lspcon.c void lspcon_set_infoframes(struct intel_encoder *encoder, · line 635
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_lspcon.c +5
-0+if (tmp & mask) + val |=intel_hdmi_infoframe_enable (HDMI_PACKET_TYPE_GAMUT_METADATA ); + } + +return val; }This seem broken until patch 10 which avoids the
Actually, make that patch 11
Quoted 12 lines
remapping from DIP bits to the index. With some reordering of the patches this seems good.
Reviewed-by Ville Syrjälä <[email protected]>Quoted 4 lines
drivers/gpu/drm/i915/display/intel_lspcon.c +0
-0void lspcon_wait_pcon_mode (struct intel_lspcon *lspcon)Signature · 1 line
2.26.2Signature · 2 lines
Ville Syrjälä Intel
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [v11 09/13] drm/i915/display: Implement infoframes readback for LSPCON
Quoted 100 lines
-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Thursday, November 26, 2020 11:14 PM
To: Shankar, Uma <[email protected]>
Cc: [email protected]
Subject: Re: [v11 09/13] drm/i915/display: Implement infoframes readback for LSPCONQuoted 20 lines · Ville Syrjälä
Quoted 19 lines · Uma Shankar
Implemented Infoframes enabled readback for LSPCON devices. This will help align the implementation with state readback infrastructure.
v2: Added proper bitmask of enabled infoframes as per Ville's recommendation.
v3: Added pcon specific infoframe types instead of using the HSW one's, as recommended by Ville.
v4: Addressed Ville's review comment by adding HDMI infoframe versions directly instead of DIP wrappers.
Signed-off-by Uma Shankar <[email protected]>--- drivers/gpu/drm/i915/display/intel_lspcon.c | 57 ++++++++++++++++++++- 1 file changed, 55 insertions(+), 2 deletions(-)Quoted 6 lines
drivers/gpu/drm/i915/display/intel_lspcon.c void lspcon_set_infoframes(struct intel_encoder
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_lspcon.c +0
-0@@ -574,11 +574,64 @@ void lspcon_set_infoframes(struct intel_encoder*encoder,
Quoted 36 lines
Quoted 36 lines
drivers/gpu/drm/i915/display/intel_lspcon.c +29
-2buf, ret); } +static bool _lspcon_read_avi_infoframe_enabled_mca (struct +drm_dp_aux *aux) { +int ret; +u32 val =0 ; +u16 reg =LSPCON_MCA_AVI_IF_CTRL ; + + ret =drm_dp_dpcd_read (aux, reg, &val,1 ); +if (ret <0 ) { +DRM_ERROR ("DPCD read failed, address 0x%x\n" , reg); +return false; + } + +return val &LSPCON_MCA_AVI_IF_KICKOFF ; } + +static bool _lspcon_read_avi_infoframe_enabled_parade (struct +drm_dp_aux *aux) { +int ret; +u32 val =0 ; +u16 reg =LSPCON_PARADE_AVI_IF_CTRL ; + + ret =drm_dp_dpcd_read (aux, reg, &val,1 ); +if (ret <0 ) { +DRM_ERROR ("DPCD read failed, address 0x%x\n" , reg); +return false; + } + +return val &LSPCON_PARADE_AVI_IF_KICKOFF ; } +u32 lspcon_infoframes_enabled (struct intel_encoder *encoder,const struct intel_crtc_state *pipe_config) { -/* FIXME actually read this from the hw */ -return 0 ; +struct intel_dp *intel_dp =enc_to_intel_dp (encoder);Quoted 8 lines
drivers/gpu/drm/i915/display/intel_lspcon.c void lspcon_set_infoframes(struct intel_encoder *encoder,
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_lspcon.c +8
-0+struct intel_lspcon *lspcon =enc_to_intel_lspcon (encoder); +struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev); +bool infoframes_enabled; +u32 val =0 ; +u32 mask, tmp; + +if (lspcon->vendor ==LSPCON_VENDOR_MCA ) + infoframes_enabled =
_lspcon_read_avi_infoframe_enabled_mca(&intel_dp->aux);Quoted 6 lines
drivers/gpu/drm/i915/display/intel_lspcon.c void lspcon_set_infoframes(struct intel_encoder *encoder,
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_lspcon.c +6
-0+else + infoframes_enabled = +_lspcon_read_avi_infoframe_enabled_parade (&intel_dp->aux); + +if (infoframes_enabled) + val |=
intel_hdmi_infoframe_enable(HDMI_INFOFRAME_TYPE_AVI);Quoted 9 lines
drivers/gpu/drm/i915/display/intel_lspcon.c void lspcon_set_infoframes(struct intel_encoder *encoder,
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_lspcon.c +4
-0+ +if (lspcon->hdr_supported) { + tmp = intel_de_read(dev_priv, + HSW_TVIDEO_DIP_CTL(pipe_config-
cpu_transcoder));drivers/gpu/drm/i915/display/intel_lspcon.c void lspcon_set_infoframes(struct intel_encoder *encoder,
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_lspcon.c +4
-0+ mask =VIDEO_DIP_ENABLE_GMP_HSW ; + +if (tmp & mask) + val |=
intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GAMUT_METADATA);
Quoted 8 lines
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_lspcon.c void lspcon_set_infoframes(struct intel_encoder *encoder, · line 635
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_lspcon.c +3
-0+ } + +return val; }This seem broken until patch 10 which avoids the
Actually, make that patch 11
Yeah, Sure will re-order the changes.
Quoted 9 lines
Quoted 9 lines
remapping from DIP bits to the index. With some reordering of the patches this seems good.
Reviewed-by Ville Syrjälä <[email protected]>Quoted 4 lines
drivers/gpu/drm/i915/display/intel_lspcon.c +0
-1void lspcon_wait_pcon_mode (struct intel_lspcon *lspcon) --2.26.2
Quoted 7 lines
Quoted 3 lines
--
Ville Syrjälä
Intel--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 10/13 drm/i915/display: Implement DRM infoframe read for LSPCON
In reply to Uma ShankarImplement Read back of HDR metadata infoframes i.e Dynamic Range and Mastering Infoframe for LSPCON devices.
v2: Added proper bitmask of enabled infoframes as per Ville's recommendation.
v3: Dropped a redundant wrapper as per Ville's comment.
v4: Dropped a redundant print, added Ville's RB.
--- drivers/gpu/drm/i915/display/intel_hdmi.c | 7 +++---- drivers/gpu/drm/i915/display/intel_lspcon.c | 5 ++++- drivers/gpu/drm/i915/display/intel_lspcon.h | 4 ++++ 3 files changed, 11 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/intel_hdmi.c +3 -4
@@ -555,10 +555,9 @@ void hsw_write_infoframe(struct intel_encoder *encoder,intel_de_posting_read (dev_priv, ctl_reg); } -static void hsw_read_infoframe (struct intel_encoder *encoder, -const struct intel_crtc_state *crtc_state, -unsigned int type, -void *frame,ssize_t len) +void hsw_read_infoframe (struct intel_encoder *encoder, +const struct intel_crtc_state *crtc_state, +unsigned int type,void *frame,ssize_t len) {struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev);enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
drivers/gpu/drm/i915/display/intel_lspcon.c +4 -1
@@ -483,7 +483,10 @@ void lspcon_read_infoframe(struct intel_encoder *encoder,unsigned int type, void *frame, ssize_t len) { - /* FIXME implement this */ + /* FIXME implement for AVI Infoframe as well */ + if (type == HDMI_PACKET_TYPE_GAMUT_METADATA) + hsw_read_infoframe(encoder, crtc_state, type, + frame, len); }/* HDMI HDR Colorspace Spec Definitions */
drivers/gpu/drm/i915/display/intel_lspcon.h +4 -0
@@ -37,5 +37,9 @@ void hsw_write_infoframe(struct intel_encoder *encoder,const struct intel_crtc_state *crtc_state, unsigned int type, const void *frame, ssize_t len); +void hsw_read_infoframe (struct intel_encoder *encoder, +const struct intel_crtc_state *crtc_state, +unsigned int type, +void *frame,ssize_t len);#endif /* __INTEL_LSPCON_H__ */
Signature · 6 lines
2.26.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 11/13 drm/i915/lspcon: Create separate infoframe_enabled helper
In reply to Uma ShankarLspcon has Infoframes as well as DIP for HDR metadata(DRM Infoframe). Create a separate mechanism for lspcon compared to HDMI in order to address the same and ensure future scalability.
v2: Streamlined this as per Ville's suggestions, making sure that HDMI infoframe versions are directly returned instead of a redundant and confusing DIP overhead.
--- drivers/gpu/drm/i915/display/intel_ddi.c | 10 +++++++--- drivers/gpu/drm/i915/display/intel_lspcon.c | 9 +++++++++ drivers/gpu/drm/i915/display/intel_lspcon.h | 2 ++ 3 files changed, 18 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_ddi.c +7 -3
@@ -4583,6 +4583,7 @@ static void intel_ddi_read_func_ctl(struct intel_encoder *encoder,struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev);struct intel_crtc *intel_crtc =to_intel_crtc (pipe_config->uapi.crtc);enum transcoder cpu_transcoder = pipe_config->cpu_transcoder; +struct intel_digital_port *dig_port =enc_to_dig_port (encoder);u32 temp, flags =0 ; temp =intel_de_read (dev_priv,TRANS_DDI_FUNC_CTL (cpu_transcoder));
@@ -4657,9 +4658,12 @@ static void intel_ddi_read_func_ctl(struct intel_encoder *encoder, pipe_config->fec_enable); } - pipe_config->infoframes.enable |= -intel_hdmi_infoframes_enabled (encoder, pipe_config); - +if (dig_port->lspcon.active && dig_port->dp.has_hdmi_sink) + pipe_config->infoframes.enable |= +intel_lspcon_infoframes_enabled (encoder, pipe_config); +else + pipe_config->infoframes.enable |= +intel_hdmi_infoframes_enabled (encoder, pipe_config);break ;case TRANS_DDI_MODE_SELECT_DP_MST : pipe_config->output_types |=BIT (INTEL_OUTPUT_DP_MST );
drivers/gpu/drm/i915/display/intel_lspcon.c +9 -0
@@ -30,6 +30,7 @@#include "intel_display_types.h" #include "intel_dp.h" #include "intel_lspcon.h" +#include "intel_hdmi.h" /* LSPCON OUI Vendor ID(signatures) */ #define LSPCON_VENDOR_PARADE_OUI 0x001CF8
@@ -672,6 +673,14 @@ bool lspcon_init(struct intel_digital_port *dig_port)return true; } +u32 intel_lspcon_infoframes_enabled (struct intel_encoder *encoder, +const struct intel_crtc_state *pipe_config) +{ +struct intel_digital_port *dig_port =enc_to_dig_port (encoder); + +return dig_port->infoframes_enabled (encoder, pipe_config); +} +void lspcon_resume (struct intel_digital_port *dig_port) {struct intel_lspcon *lspcon = &dig_port->lspcon;
drivers/gpu/drm/i915/display/intel_lspcon.h +2 -0
@@ -41,5 +41,7 @@ void hsw_read_infoframe(struct intel_encoder *encoder,const struct intel_crtc_state *crtc_state, unsigned int type, void *frame, ssize_t len); +u32 intel_lspcon_infoframes_enabled (struct intel_encoder *encoder, +const struct intel_crtc_state *pipe_config);#endif /* __INTEL_LSPCON_H__ */
Signature · 6 lines
2.26.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 12/13 drm/i915/lspcon: Do not send DRM infoframes to non-HDMI sinks
In reply to Uma ShankarNon-HDMI sinks shouldn't be sent Dynamic Range and Mastering infoframes. Check for that when using LSPCON.
--- drivers/gpu/drm/i915/display/intel_ddi.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_ddi.c +9 -1
@@ -4118,6 +4118,7 @@ static void intel_enable_ddi_dp(struct intel_atomic_state *state, {struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev);struct intel_dp *intel_dp =enc_to_intel_dp (encoder); +struct intel_digital_port *dig_port =enc_to_dig_port (encoder);enum port port = encoder->port;if (port ==PORT_A &&INTEL_GEN (dev_priv) <9 )
@@ -4125,7 +4126,14 @@ static void intel_enable_ddi_dp(struct intel_atomic_state *state,intel_edp_backlight_on (crtc_state, conn_state);intel_psr_enable (intel_dp, crtc_state, conn_state); -intel_dp_set_infoframes (encoder, true, crtc_state, conn_state); + +if (dig_port->lspcon.active) { +if (dig_port->dp.has_hdmi_sink) +intel_dp_set_infoframes (encoder, true, crtc_state, conn_state); + }else { +intel_dp_set_infoframes (encoder, true, crtc_state, conn_state); + } +intel_edp_drrs_enable (intel_dp, crtc_state);if (crtc_state->has_audio)
Signature · 6 lines
2.26.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v11 13/13 drm/i915/display: [NOT FOR MERGE] Reduce blanking to support 4k60@10bpp for LSPCON
In reply to Uma ShankarBlanking needs to be reduced to incorporate DP and HDMI timing/link bandwidth limitations for CEA modes (4k@60 at 10 bpp). DP can drive 17.28Gbs while 4k modes (VIC97 etc) at 10 bpp required 17.8 Gbps. This will cause mode to blank out. Reduced Htotal by shortening the back porch and front porch within permissible limits.
Note: This is for reference for userspace, not to be merged in kernel.
v2: This is marked as Not for merge and the responsibilty to program these custom timings will be on userspace. This patch is just for reference purposes. This is based on Ville's recommendation.
v3: updated commit message.
--- drivers/gpu/drm/i915/display/intel_dp.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)
drivers/gpu/drm/i915/display/intel_dp.c +17 -0
@@ -741,8 +741,10 @@ intel_dp_mode_valid(struct drm_connector *connector, {struct intel_dp *intel_dp =intel_attached_dp (to_intel_connector (connector));struct intel_connector *intel_connector =to_intel_connector (connector); +struct intel_encoder *intel_encoder =intel_attached_encoder (intel_connector);struct drm_display_mode *fixed_mode = intel_connector->panel.fixed_mode;struct drm_i915_private *dev_priv =to_i915 (connector->dev); +struct intel_lspcon *lspcon =enc_to_intel_lspcon (intel_encoder);int target_clock = mode->clock;int max_rate, mode_rate, max_lanes, max_link_clock;int max_dotclk = dev_priv->max_dotclk_freq;
@@ -778,6 +780,21 @@ intel_dp_mode_valid(struct drm_connector *connector,if (target_clock > max_dotclk)return MODE_CLOCK_HIGH ; +/* +* Reducing Blanking to incorporate DP and HDMI timing/link bandwidth +* limitations for CEA modes (4k@60 at 10 bpp). DP can drive 17.28Gbs +* while 4k modes (VIC97 etc) at 10 bpp required 17.8 Gbps. This will +* cause mode to blank out. Reduced Htotal by shortening the back porch +* and front porch within permissible limits. +*/ +if (lspcon->active && lspcon->hdr_supported && + mode->clock >570000 ) { + mode->clock =570000 ; + mode->htotal -=180 ; + mode->hsync_start -=72 ; + mode->hsync_end -=72 ; + } + max_link_clock =intel_dp_max_link_rate (intel_dp); max_lanes =intel_dp_max_lane_count (intel_dp);
Signature · 6 lines
2.26.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enable HDR on MCA LSPCON based Gen9 devices (rev11)
In reply to Uma Shankar== Series Details ==
== Series Details ==
Series: Enable HDR on MCA LSPCON based Gen9 devices (rev11)
URL : https://patchwork.freedesktop.org/series/68081/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip e7d69665cf73 drm/i915/display: Add HDR Capability detection for LSPCON b5fa510007a1 drm/i915/display: Enable HDR on gen9 devices with MCA Lspcon 94da9b381802 drm/i915/display: Attach HDR property for capable Gen9 devices -:58: WARNING:LONG_LINE: line length of 108 exceeds 100 columns #58: FILE: drivers/gpu/drm/i915/display/intel_dp.c:6804: + connector->dev->mode_config.hdr_output_metadata_property,
total: 0 errors, 1 warnings, 0 checks, 45 lines checked37af9241ac63 drm/i915/display: Enable quantization range for HDR on LSPCON devices 90a45305d915 drm/i915/display: Add a WARN for invalid output range and format 99311bb61d69 drm/i915/display: Attach content type property for LSPCON 78f2b24a1ff7 i915/display: Enable BT2020 for HDR on LSPCON devices05833c4d31da drm/i915/display: Enable HDR for Parade based lspcon9e5f135c0a29 drm/i915/display: Implement infoframes readback for LSPCON ae81dd3d5f06 drm/i915/display: Implement DRM infoframe read for LSPCON 9cad91480b72 drm/i915/lspcon: Create separate infoframe_enabled helper fd7bd8dacdb0 drm/i915/lspcon: Do not send DRM infoframes to non-HDMI sinks 35f0ce30d872 drm/i915/display: [NOT FOR MERGE] Reduce blanking to support 4k60@10bpp for LSPCON
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Enable HDR on MCA LSPCON based Gen9 devices (rev11)
In reply to Uma Shankar== Series Details ==
== Series Details ==
Series: Enable HDR on MCA LSPCON based Gen9 devices (rev11)
URL : https://patchwork.freedesktop.org/series/68081/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/gt/intel_reset.c:1312:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block +drivers/gpu/drm/i915/gt/selftest_reset.c:100:20: expected void *in +drivers/gpu/drm/i915/gt/selftest_reset.c:100:20: got void [noderef] __iomem *[assigned] s +drivers/gpu/drm/i915/gt/selftest_reset.c:100:20: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/i915/gt/selftest_reset.c:101:46: expected void const *src +drivers/gpu/drm/i915/gt/selftest_reset.c:101:46: got void [noderef] __iomem *[assigned] s +drivers/gpu/drm/i915/gt/selftest_reset.c:101:46: warning: incorrect type in argument 2 (different address spaces) +drivers/gpu/drm/i915/gt/selftest_reset.c:136:20: expected void *in +drivers/gpu/drm/i915/gt/selftest_reset.c:136:20: got void [noderef] __iomem *[assigned] s +drivers/gpu/drm/i915/gt/selftest_reset.c:136:20: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/i915/gt/selftest_reset.c:137:46: expected void const *src +drivers/gpu/drm/i915/gt/selftest_reset.c:137:46: got void [noderef] __iomem *[assigned] s +drivers/gpu/drm/i915/gt/selftest_reset.c:137:46: warning: incorrect type in argument 2 (different address spaces) +drivers/gpu/drm/i915/gt/selftest_reset.c:98:34: expected unsigned int [usertype] *s +drivers/gpu/drm/i915/gt/selftest_reset.c:98:34: got void [noderef] __iomem *[assigned] s +drivers/gpu/drm/i915/gt/selftest_reset.c:98:34: warning: incorrect type in argument 1 (different address spaces) +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write8' - different lock contexts for basic block
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for Enable HDR on MCA LSPCON based Gen9 devices (rev11)
In reply to Uma Shankar== Series Details ==
== Series Details ==
Series: Enable HDR on MCA LSPCON based Gen9 devices (rev11)
URL : https://patchwork.freedesktop.org/series/68081/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9392 -> Patchwork_18985
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/index.html
New tests
---------
New tests have been introduced between CI_DRM_9392 and Patchwork_18985:
### New CI tests (1) ###
* boot:
- Statuses : 40 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18985 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_create@basic:
- fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#402]) +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/fi-tgl-y/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/fi-tgl-y/igt@[email protected]
* igt@i915_module_load@reload:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#1982] / [k.org#205379])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/fi-tgl-y/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/fi-tgl-y/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-byt-j1900: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/fi-byt-j1900/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/fi-byt-j1900/igt@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- fi-kbl-soraka: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/fi-kbl-soraka/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/fi-kbl-soraka/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-tgl-y: [PASS][9] -> [DMESG-WARN][10] ([i915#1982])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/fi-tgl-y/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/fi-tgl-y/igt@[email protected]
#### Possible fixes ####
* igt@debugfs_test@read_all_entries:
- {fi-kbl-7560u}: [INCOMPLETE][11] ([i915#2417]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/fi-kbl-7560u/igt@debugfs_test@read_all_entries.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/fi-kbl-7560u/igt@debugfs_test@read_all_entries.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/fi-bsw-kefka/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/fi-bsw-kefka/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- fi-icl-u2: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16] +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/fi-icl-u2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/fi-icl-u2/igt@[email protected]
* igt@prime_self_import@basic-with_one_bo:
- fi-tgl-y: [DMESG-WARN][17] ([i915#402]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/fi-tgl-y/igt@prime_self_import@basic-with_one_bo.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/fi-tgl-y/igt@prime_self_import@basic-with_one_bo.html
#### Warnings ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-tgl-y: [DMESG-FAIL][19] ([i915#2601] / [i915#541]) -> [DMESG-FAIL][20] ([i915#2601])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/fi-tgl-y/igt@i915_selftest@live@gt_heartbeat.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/fi-tgl-y/igt@i915_selftest@live@gt_heartbeat.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2417]: https://gitlab.freedesktop.org/drm/intel/issues/2417
[i915#2601]: https://gitlab.freedesktop.org/drm/intel/issues/2601
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
[k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379
Participating hosts (44 -> 40)
------------------------------
Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_9392 -> Patchwork_18985
CI-20190529: 20190529
CI_DRM_9392: 000f10be44a48c2fe20ba33544a6094da2e56fc9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5870: 08b13995b85df26a77212e4fb21fd772976ef33c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18985: 35f0ce30d8729fd2d24909397c0a0b0e5d6fbcf2 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
35f0ce30d872 drm/i915/display: [NOT FOR MERGE] Reduce blanking to support 4k60@10bpp for LSPCON fd7bd8dacdb0 drm/i915/lspcon: Do not send DRM infoframes to non-HDMI sinks 9cad91480b72 drm/i915/lspcon: Create separate infoframe_enabled helper ae81dd3d5f06 drm/i915/display: Implement DRM infoframe read for LSPCON 9e5f135c0a29 drm/i915/display: Implement infoframes readback for LSPCON 05833c4d31da drm/i915/display: Enable HDR for Parade based lspcon78f2b24a1ff7 i915/display: Enable BT2020 for HDR on LSPCON devices99311bb61d69 drm/i915/display: Attach content type property for LSPCON 90a45305d915 drm/i915/display: Add a WARN for invalid output range and format 37af9241ac63 drm/i915/display: Enable quantization range for HDR on LSPCON devices 94da9b381802 drm/i915/display: Attach HDR property for capable Gen9 devices b5fa510007a1 drm/i915/display: Enable HDR on gen9 devices with MCA Lspcon e7d69665cf73 drm/i915/display: Add HDR Capability detection for LSPCON
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for Enable HDR on MCA LSPCON based Gen9 devices (rev11)
In reply to Uma Shankar== Series Details ==
== Series Details ==
Series: Enable HDR on MCA LSPCON based Gen9 devices (rev11)
URL : https://patchwork.freedesktop.org/series/68081/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9392_full -> Patchwork_18985_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18985_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_18985_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18985_full:
### IGT changes ###
#### Possible regressions ####
* igt@api_intel_bb@blit-noreloc-purge-cache:
- shard-hsw: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-hsw1/igt@[email protected]
* igt@i915_selftest@live@gem_contexts:
- shard-skl: NOTRUN -> [INCOMPLETE][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-skl6/igt@i915_selftest@live@gem_contexts.html
#### Warnings ####
* igt@i915_pm_backlight@fade_with_suspend:
- shard-iclb: [INCOMPLETE][3] ([i915#1185] / [i915#2369]) -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-iclb6/igt@i915_pm_backlight@fade_with_suspend.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-iclb3/igt@i915_pm_backlight@fade_with_suspend.html
New tests
---------
New tests have been introduced between CI_DRM_9392_full and Patchwork_18985_full:
### New CI tests (1) ###
* boot:
- Statuses : 200 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18985_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_whisper@basic-fds-all:
- shard-kbl: [PASS][5] -> [INCOMPLETE][6] ([i915#794])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-kbl1/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-kbl1/igt@[email protected]
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-glk: [PASS][7] -> [FAIL][8] ([i915#644])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-glk3/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-glk8/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-64x21-random:
- shard-skl: [PASS][9] -> [FAIL][10] ([i915#54]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-skl10/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-skl1/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-tglb: [PASS][11] -> [FAIL][12] ([i915#2346])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-tglb5/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-tglb1/igt@[email protected]
* igt@kms_flip@2x-flip-vs-fences-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][13] -> [DMESG-WARN][14] ([i915#1982]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-glk3/igt@kms_flip@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-glk7/igt@kms_flip@[email protected]
* igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-vga1-hdmi-a1:
- shard-hsw: [PASS][15] -> [DMESG-WARN][16] ([i915#1982])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-hsw8/igt@kms_flip@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-hsw6/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
- shard-kbl: [PASS][17] -> [DMESG-WARN][18] ([i915#1982]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-kbl2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-kbl4/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-rte:
- shard-tglb: [PASS][19] -> [DMESG-WARN][20] ([i915#1982])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-tglb6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-tglb6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][21] -> [FAIL][22] ([fdo#108145] / [i915#265]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-skl5/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-skl6/igt@[email protected]
* igt@kms_plane_cursor@pipe-a-viewport-size-128:
- shard-skl: [PASS][23] -> [DMESG-WARN][24] ([i915#1982]) +8 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-skl10/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-skl1/igt@[email protected]
* igt@perf@polling-parameterized:
- shard-skl: [PASS][25] -> [FAIL][26] ([i915#1542])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-skl2/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-skl1/igt@[email protected]
* igt@perf_pmu@module-unload:
- shard-skl: [PASS][27] -> [DMESG-WARN][28] ([i915#1982] / [i915#262])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-skl9/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-skl7/igt@[email protected]
#### Possible fixes ####
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][29] ([i915#658]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-iclb1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-iclb2/igt@[email protected]
* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-glk: [FAIL][31] ([i915#2389]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-glk4/igt@gem_exec_reloc@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-glk6/igt@gem_exec_reloc@[email protected]
* igt@gem_partial_pwrite_pread@writes-after-reads:
- shard-hsw: [INCOMPLETE][33] -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-hsw6/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-hsw7/igt@[email protected]
* igt@gem_partial_pwrite_pread@writes-after-reads-display:
- shard-skl: [DMESG-WARN][35] ([i915#1982]) -> [PASS][36] +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-skl2/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-skl2/igt@[email protected]
* igt@i915_module_load@reload:
- shard-tglb: [DMESG-WARN][37] ([i915#1982]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-tglb6/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-tglb6/igt@[email protected]
* igt@i915_pm_rpm@system-suspend-modeset:
- shard-skl: [INCOMPLETE][39] ([i915#151]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-skl3/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-skl3/igt@[email protected]
* igt@kms_color@pipe-a-gamma:
- shard-tglb: [FAIL][41] ([i915#1149]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-tglb2/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-tglb1/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-64x64-offscreen:
- shard-skl: [FAIL][43] ([i915#54]) -> [PASS][44] +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-skl10/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-skl1/igt@[email protected]
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: [FAIL][45] ([i915#2370]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-hsw6/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-hsw8/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic:
- shard-skl: [FAIL][47] ([i915#2346]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-skl3/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-skl9/igt@[email protected]
* igt@kms_flip@2x-flip-vs-blocking-wf-vblank@ab-vga1-hdmi-a1:
- shard-hsw: [DMESG-WARN][49] ([i915#1982]) -> [PASS][50] +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-hsw1/igt@kms_flip@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-hsw1/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@b-edp1:
- shard-skl: [INCOMPLETE][51] ([i915#198]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-skl9/igt@kms_flip@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-kbl: [DMESG-WARN][53] ([i915#180]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-kbl3/igt@kms_flip@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-kbl7/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@c-hdmi-a1:
- shard-hsw: [INCOMPLETE][55] ([i915#2055] / [i915#2295]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-hsw6/igt@kms_flip@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-hsw4/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-ts-check@a-dp1:
- shard-kbl: [DMESG-WARN][57] ([i915#1982]) -> [PASS][58] +3 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-kbl4/igt@kms_flip@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-kbl2/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@psr-shrfb-scaledprimary:
- shard-iclb: [DMESG-WARN][59] ([i915#1982]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-iclb5/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-iclb1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [FAIL][61] ([fdo#108145] / [i915#265]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-skl3/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-skl9/igt@[email protected]
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][63] ([fdo#109642] / [fdo#111068]) -> [PASS][64] +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-iclb1/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-iclb2/igt@[email protected]
* igt@perf@blocking:
- shard-skl: [FAIL][65] ([i915#1542]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-skl6/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-skl6/igt@[email protected]
* igt@sysfs_timeslice_duration@timeout@vecs0:
- shard-skl: [FAIL][67] ([i915#1732]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-skl10/igt@sysfs_timeslice_duration@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-skl1/igt@sysfs_timeslice_duration@[email protected]
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][69] ([i915#1804] / [i915#2684]) -> [WARN][70] ([i915#2681] / [i915#2684])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-iclb4/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-iclb8/igt@[email protected]
* igt@runner@aborted:
- shard-hsw: [FAIL][71] ([i915#2283] / [i915#2295] / [i915#483]) -> [FAIL][72] ([i915#2283] / [i915#2295])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-hsw1/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-hsw2/igt@[email protected]
- shard-kbl: ([FAIL][73], [FAIL][74]) ([i915#2295] / [i915#483]) -> ([FAIL][75], [FAIL][76], [FAIL][77]) ([i915#2263] / [i915#2295] / [i915#483])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-kbl3/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-kbl6/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-kbl2/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-kbl1/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-kbl3/igt@[email protected]
- shard-apl: ([FAIL][78], [FAIL][79]) ([i915#2295]) -> ([FAIL][80], [FAIL][81], [FAIL][82], [FAIL][83], [FAIL][84], [FAIL][85], [FAIL][86], [FAIL][87], [FAIL][88], [FAIL][89], [FAIL][90], [FAIL][91], [FAIL][92], [FAIL][93], [FAIL][94], [FAIL][95], [FAIL][96], [FAIL][97], [FAIL][98], [FAIL][99], [FAIL][100], [FAIL][101], [FAIL][102], [FAIL][103], [FAIL][104]) ([i915#1610] / [i915#2295])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-apl2/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-apl6/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl3/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl2/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl1/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl2/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl3/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl2/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl4/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl1/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl3/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl2/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl3/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl2/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl6/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl4/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl4/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl6/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl8/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl7/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl8/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl6/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl6/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl6/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl7/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl7/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-apl7/igt@[email protected]
- shard-skl: [FAIL][105] ([i915#2295] / [i915#483]) -> [FAIL][106] ([i915#2295])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9392/shard-skl5/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/shard-skl8/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
[i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185
[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#1732]: https://gitlab.freedesktop.org/drm/intel/issues/1732
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055
[i915#2263]: https://gitlab.freedesktop.org/drm/intel/issues/2263
[i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369
[i915#2370]: https://gitlab.freedesktop.org/drm/intel/issues/2370
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#794]: https://gitlab.freedesktop.org/drm/intel/issues/794
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9392 -> Patchwork_18985
CI-20190529: 20190529
CI_DRM_9392: 000f10be44a48c2fe20ba33544a6094da2e56fc9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5870: 08b13995b85df26a77212e4fb21fd772976ef33c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18985: 35f0ce30d8729fd2d24909397c0a0b0e5d6fbcf2 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18985/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx