Skip to content

Enable HDR on MCA LSPCON based Gen9 devices

Uma Shankar intel-gfx 12 versions – Applied

Status from this message: Pushed to dinq.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v14 Latest15 patches 1 replyApplied
  2. v1215 patches 9 repliesSuperseded
  3. v1113 patches 10 repliesSuperseded
Earlier versions · 9
VersionPostedPatchesRepliesStatus
v912 patches10 repliesSuperseded
v812 patches0 repliesSuperseded
v710 patches3 repliesSuperseded
v611 patches16 repliesSuperseded
v511 patches0 repliesSuperseded
v410 patches0 repliesSuperseded
v38 patches15 repliesSuperseded
v26 patches0 repliesSuperseded
v16 patches8 repliesSuperseded

Patches in v14 Applied

#Subject and filesSizeRepliesApplied
1/15drm/i915/display: Add HDR Capability detection for LSPCONdrivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/display/intel_lspcon.c drivers/gpu/drm/i915/display/intel_lspcon.h+29 -00 replies
2/15drm/i915/display: Enable HDR on gen9 devices with MCA Lspcondrivers/gpu/drm/i915/display/intel_hdmi.c drivers/gpu/drm/i915/display/intel_lspcon.c drivers/gpu/drm/i915/display/intel_lspcon.h+26 -170 replies
3/15drm/i915/display: Attach HDR property for capable Gen9 devicesdrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_lspcon.c drivers/gpu/drm/i915/display/intel_lspcon.h+20 -10 replies
4/15drm/i915/display: Fixes quantization range for YCbCr outputdrivers/gpu/drm/i915/display/intel_lspcon.c+11 -60 replies
5/15drm/i915/display: Add a WARN for invalid output range and formatdrivers/gpu/drm/i915/display/intel_lspcon.c+4 -00 replies
6/15drm/i915/display: Attach content type property for LSPCONdrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_lspcon.c+5 -00 replies
7/15drm/i915: Split intel_attach_colorspace_property() into HDMI vs. DP variantsdrivers/gpu/drm/i915/display/intel_connector.c drivers/gpu/drm/i915/display/intel_connector.h drivers/gpu/drm/i915/display/intel_dp.c +1 more+15 -210 replies
8/15drm/i915/display: Enable colorspace programming for LSPCON devicesdrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_lspcon.c+9 -30 replies
9/15drm/i915/display: Nuke bogus lspcon checkdrivers/gpu/drm/i915/display/intel_hdmi.c+1 -100 replies
10/15drm/i915/display: Enable HDR for Parade based lspcondrivers/gpu/drm/i915/display/intel_lspcon.c+11 -60 replies
11/15drm/i915/lspcon: Create separate infoframe_enabled helperdrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_lspcon.c drivers/gpu/drm/i915/display/intel_lspcon.h+18 -30 replies
12/15drm/i915/display: Implement infoframes readback for LSPCONdrivers/gpu/drm/i915/display/intel_lspcon.c+55 -20 replies
13/15drm/i915/display: Implement DRM infoframe read for LSPCONdrivers/gpu/drm/i915/display/intel_hdmi.c drivers/gpu/drm/i915/display/intel_lspcon.c drivers/gpu/drm/i915/display/intel_lspcon.h+11 -50 replies
14/15drm/i915/lspcon: Do not send DRM infoframes to non-HDMI sinksdrivers/gpu/drm/i915/display/intel_ddi.c+5 -10 replies
15/15drm/i915/display: [NOT FOR MERGE] Reduce blanking to support 4k60@10bpp for LSPCONdrivers/gpu/drm/i915/display/intel_dp.c+17 -00 replies

Reviews trailers per patch

14 of 15 patches have a Reviewed-by or Acked-by.

PatchVille SyrjäläUma Shankar
1/15R-b
2/15R-b
3/15R-b
4/15R-b
5/15R-b
6/15R-b
7/15R-b
8/15R-b
9/15R-b
10/15R-b
11/15R-b
12/15R-b
13/15R-b
14/15R-b
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v14 thread

Cover letter [Intel-gfx] [v14 00/15] Enable HDR on MCA LSPCON based Gen9 devices

Gen9 hardware supports HDMI2.0 through LSPCON chips. Extending HDR support for MCA and Parade LSPCON based GEN9 devices.

SOC will drive LSPCON as DP and send HDR metadata as standard DP SDP packets. LSPCON will be set to operate in PCON mode, will receive the metadata and create Dynamic Range and Mastering Infoframe (DRM packets) and send it to HDR capable HDMI sink devices.

v2: Fixed Ville's review comments. Suppressed some warnings. Patch 8 of the series is marked "Not for Merge" and is just for reference to userspace people to incorporate in order to support 10bit content with 4K@60 resolutions.

v3: Added Infoframe readout support for DRM infoframes. Addressed Jani Nikula's review comments.

v4: Addressed Ville's review comments and added proper bitmask for enabled infoframes. Series also incorporates Ville's patch for stopping infoframes to be sent to DVI sinks. Extended the same for DRM as well.

v5: Created separate helper function for lspcon_infoframes_enabled as per Ville's suggestion.

v6: Rebase

v7: Addressed Ville's review comments.

v8: Addressed Ville's review comments. Fixed the colorspace handling for Pcon and property attachment logic based on new lspcon detetction changes.

v9: Rebase

v10: Fixed one patch for detection

v11: Addressed Ville's review comments and added RB in the respective patches.

v12: Addressed Ville's review comments, re-order the changes. With Ville's help fixed the lingering colorspace handling for lspcon.

v13: 2 patches updated with feedback.

v14: Final series with all RB's in place, ready to merge.

Thanks Ville for all the suggestions and inputs.
Note: Patch 15 of the series is for reference to userspace, not to be merged to driver.

Uma Shankar (14):
drm/i915/display: Add HDR Capability detection for LSPCON drm/i915/display: Enable HDR on gen9 devices with MCA Lspcon drm/i915/display: Attach HDR property for capable Gen9 devices drm/i915/display: Fixes quantization range for YCbCr output drm/i915/display: Add a WARN for invalid output range and format drm/i915/display: Attach content type property for LSPCON drm/i915/display: Enable colorspace programming for LSPCON devices drm/i915/display: Nuke bogus lspcon check drm/i915/display: Enable HDR for Parade based lspcon drm/i915/lspcon: Create separate infoframe_enabled helper drm/i915/display: Implement infoframes readback for LSPCON drm/i915/display: Implement DRM infoframe read for LSPCON drm/i915/lspcon: Do not send DRM infoframes to non-HDMI sinks drm/i915/display: [NOT FOR MERGE] Reduce blanking to support

    4k60@10bpp for LSPCON

Ville Syrjälä (1):
drm/i915: Split intel_attach_colorspace_property() into HDMI vs. DP
variants

 .../gpu/drm/i915/display/intel_connector.c    |  29 ++--
 .../gpu/drm/i915/display/intel_connector.h    |   3 +-
 drivers/gpu/drm/i915/display/intel_ddi.c      |  16 +-
 .../drm/i915/display/intel_display_types.h    |   1 +
 drivers/gpu/drm/i915/display/intel_dp.c       |  43 ++++-
 drivers/gpu/drm/i915/display/intel_hdmi.c     |  26 +--
 drivers/gpu/drm/i915/display/intel_lspcon.c   | 162 +++++++++++++++---
 drivers/gpu/drm/i915/display/intel_lspcon.h   |  12 ++
 8 files changed, 227 insertions(+), 65 deletions(-)
Signature · 6 lines
2.26.2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx