Skip to contentSkip to conversation

mtd: spi-nor-ids: add STMICRO MT25QL01G flash

PATCH New Hongwei Zhang 2 participants 8 messages Dec 4, 2020 – Dec 10, 2020 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

cover mtd: spi-nor-ids: add STMICRO MT25QL01G flash

Hello Reviewer,

STMICRO MT25QL01G flash is used on AST2600 board, this patch add it in the table.

Please add this update in v2019.04-aspeed-openbmc branch when it is accepted. If I need to submit a separate patch to that branch, please let me know.

Thanks!

Hongwei Zhang (1):
mtd: spi-nor-ids: add STMICRO MT25QL01G flash

 drivers/mtd/spi/spi-nor-ids.c | 1 +
 1 file changed, 1 insertion(+)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 mtd: spi-nor-ids: add STMICRO MT25QL01G flash

Add STMICRO MT25QL01G flash, used on AST2600 board.

---
 drivers/mtd/spi/spi-nor-ids.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mtd/spi/spi-nor-ids.c +1 -0
index 09e8196048..6d22b80586 100644
@@ -185,6 +185,7 @@ const struct flash_info spi_nor_ids[] = {
 	{ INFO("n25q512ax3",  0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
 	{ INFO("n25q00",      0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
 	{ INFO("n25q00a",     0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
+	{ INFO("mt25ql01g",   0x21ba20, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
 	{ INFO("mt25qu02g",   0x20bb22, 0, 64 * 1024, 4096, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
 	{ INFO("mt35xu512aba", 0x2c5b1a, 0,  128 * 1024,  512, USE_FSR | SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES) },
 	{ INFO("mt35xu02g",  0x2c5b1c, 0, 128 * 1024,  2048, USE_FSR | SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES) },
Signature · 1 line
2.17.1
#2 lore raw

PATCH 1/1 mtd: spi-nor-ids: add STMICRO MT25QL01G flash

Hi Hongwei

Quoted 1 line · Hongwei Zhang

Add STMICRO MT25QL01G flash, used on AST2600 board.

MT25QL01G is not a STMicroelectronics flash but a Micron one ;-)

Patrice

Quoted 18 lines
---
 drivers/mtd/spi/spi-nor-ids.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mtd/spi/spi-nor-ids.c +1 -0
index 09e8196048..6d22b80586 100644
@@ -185,6 +185,7 @@ const struct flash_info spi_nor_ids[] = {
 	{ INFO("n25q512ax3",  0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
 	{ INFO("n25q00",      0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
 	{ INFO("n25q00a",     0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
+	{ INFO("mt25ql01g",   0x21ba20, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
 	{ INFO("mt25qu02g",   0x20bb22, 0, 64 * 1024, 4096, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
 	{ INFO("mt35xu512aba", 0x2c5b1a, 0,  128 * 1024,  512, USE_FSR | SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES) },
 	{ INFO("mt35xu02g",  0x2c5b1c, 0, 128 * 1024,  2048, USE_FSR | SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES) },
#3 lore raw

cover mtd: spi-nor-ids: add Micron MT25QL01G flash

In reply to Hongwei Zhang

Hello Reviewer,

Micron MT25QL01G flash is used on AST2600 board, this patch add it in the table.

Please add this update in v2019.04-aspeed-openbmc branch when it is accepted. If I need to submit a separate patch to that branch, please let me know.

Thanks!

Hongwei Zhang (1):
mtd: spi-nor-ids: add Micron MT25QL01G flash

 drivers/mtd/spi/spi-nor-ids.c | 1 +
 1 file changed, 1 insertion(+)

--
2.17.1

#4 lore raw

PATCH 1/1 mtd: spi-nor-ids: add Micron MT25QL01G flash

Add Micron MT25QL01G flash, used on AST2600 board.

---
 drivers/mtd/spi/spi-nor-ids.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mtd/spi/spi-nor-ids.c +1 -0
index 09e8196048..6d22b80586 100644
@@ -185,6 +185,7 @@ const struct flash_info spi_nor_ids[] = {
 	{ INFO("n25q512ax3",  0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ) },
 	{ INFO("n25q00",      0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
 	{ INFO("n25q00a",     0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
+	{ INFO("mt25ql01g",   0x21ba20, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
 	{ INFO("mt25qu02g",   0x20bb22, 0, 64 * 1024, 4096, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
 	{ INFO("mt35xu512aba", 0x2c5b1a, 0,  128 * 1024,  512, USE_FSR | SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES) },
 	{ INFO("mt35xu02g",  0x2c5b1c, 0, 128 * 1024,  2048, USE_FSR | SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES) },
Signature · 1 line
2.17.1
#5 lore raw

cover mtd: spi-nor-ids: add Micron MT25QL01G flash

In reply to Hongwei Zhang
Quoted 8 lines

From: Patrice CHOTARD <[email protected]>

Hi Hongwei

Quoted 1 line · Hongwei Zhang

Add STMICRO MT25QL01G flash, used on AST2600 board.

MT25QL01G is not a STMicroelectronics flash but a Micron one ;-)

Thanks for the correction, Patrice.

I came back to spi-nor-ids.c, there are two places in the code checking CONFIG_SPI_FLASH_STMICRO define, at line 167 (a lot of Micron flashes included in the block), and at line 239, furthermore, there is no SPI_FLASH_MICRON config menu in Kconfig file. I got confused, why SPI_FLASH_MICRON is not in Kconfig?

Quoted 24 lines

Patrice

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 185

Quoted 12 lines
---
 drivers/mtd/spi/spi-nor-ids.c | 1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/drivers/mtd/spi/spi-nor-ids.c index 09e8196048..6d22b80586 100644

drivers/mtd/spi/spi-nor-ids.c +0 -0
@@ -185,6 +185,7 @@ const struct flash_info spi_nor_ids[] = {
     { INFO("n25q512ax3",  0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR |

SPI_NOR_QUAD_READ) },

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 186

Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +0 -0
     { INFO("n25q00",      0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ

| NO_CHIP_ERASE) },

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 187

Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +0 -0
     { INFO("n25q00a",     0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ

| NO_CHIP_ERASE) },

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 188

Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +1 -0
+    { INFO("mt25ql01g",   0x21ba20, 0, 64 * 1024, 2048, SECT_4K | USE_FSR |

SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 189

Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +0 -0
     { INFO("mt25qu02g",   0x20bb22, 0, 64 * 1024, 4096, SECT_4K | USE_FSR |

SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },

#6 lore raw

cover mtd: spi-nor-ids: add Micron MT25QL01G flash

Hi Hongwei

Quoted 6 lines · Hongwei Zhang
Quoted 6 lines

From: Patrice CHOTARD <[email protected]>

Hi Hongwei

Quoted 1 line · Hongwei Zhang

Add STMICRO MT25QL01G flash, used on AST2600 board.

Quoted 8 lines
Quoted 1 line

MT25QL01G is not a STMicroelectronics flash but a Micron one ;-)

Thanks for the correction, Patrice.

I came back to spi-nor-ids.c, there are two places in the code checking CONFIG_SPI_FLASH_STMICRO define, at line 167 (a lot of Micron flashes included in the block), and at line 239, furthermore, there is no SPI_FLASH_MICRON config menu in Kconfig file. I got confused, why SPI_FLASH_MICRON is not in Kconfig?

To sum up, at the beginning, it was STMicroelectronics flashes, since 2010, MICRON acquired this activities. If you want the full history, you will find information here: https://en.wikipedia.org/wiki/Numonyx
So the CONFIG_SPI_FLASH_STMICRO compilation flag is historical and didn't get renamed to CONFIG_SPI_FLASH_MICRON.

Patrice

Quoted 23 lines
Quoted 23 lines

Patrice

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 185

Quoted 11 lines
---
 drivers/mtd/spi/spi-nor-ids.c | 1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/drivers/mtd/spi/spi-nor-ids.c index 09e8196048..6d22b80586 100644

drivers/mtd/spi/spi-nor-ids.c +0 -0
@@ -185,6 +185,7 @@ const struct flash_info spi_nor_ids[] = {
     { INFO("n25q512ax3",  0x20ba20, 0, 64 * 1024, 1024, SECT_4K | USE_FSR |

SPI_NOR_QUAD_READ) },

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 186

Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +0 -0
     { INFO("n25q00",      0x20ba21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ

| NO_CHIP_ERASE) },

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 187

Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +0 -0
     { INFO("n25q00a",     0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ

| NO_CHIP_ERASE) },

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 188

Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +1 -0
+    { INFO("mt25ql01g",   0x21ba20, 0, 64 * 1024, 2048, SECT_4K | USE_FSR |

SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 189

Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +0 -0
     { INFO("mt25qu02g",   0x20bb22, 0, 64 * 1024, 4096, SECT_4K | USE_FSR |

SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },

#7 lore raw

cover mtd: spi-nor-ids: add Micron MT25QL01G flash

In reply to Hongwei Zhang

Hi Jagan,

Please remove the other patch serie:
_https://patchwork.ozlabs.org/project/uboot/list/?series=218779

This serie (219106) has the correct flash maker name.

Thanks!

Hi Patrice,

Quoted 20 lines

From: Patrice CHOTARD <[email protected]>
Sent: Tuesday, December 8, 2020 2:54 AM

Hi Hongwei

Quoted 6 lines · Hongwei Zhang
Quoted 6 lines

From: Patrice CHOTARD <[email protected]>

Hi Hongwei

Quoted 1 line · Hongwei Zhang

Add STMICRO MT25QL01G flash, used on AST2600 board.

Quoted 8 lines
Quoted 1 line

MT25QL01G is not a STMicroelectronics flash but a Micron one ;-)

Thanks for the correction, Patrice.

I came back to spi-nor-ids.c, there are two places in the code checking CONFIG_SPI_FLASH_STMICRO define, at line 167 (a lot of Micron flashes included in the block), and at line 239, furthermore, there is no SPI_FLASH_MICRON config menu in Kconfig file. I got confused, why SPI_FLASH_MICRON is not in Kconfig?

Quoted 6 lines

To sum up, at the beginning, it was STMicroelectronics flashes, since 2010, MICRON acquired this activities.
If you want the full history, you will find information here: https://en.wikipedia.org/wiki/Numonyx
So the CONFIG_SPI_FLASH_STMICRO compilation flag is historical and didn't get renamed to CONFIG_SPI_FLASH_MICRON.

Thanks for the information, it is an interesting history!

--Hongwei

Quoted 1 line