mfd: wm831x-auxadc: Prevent use after free in wm831x_auxadc_read_irq()
PATCH 1/1 mfd: wm831x-auxadc: Prevent use after free in wm831x_auxadc_read_irq()
The "req" struct is always added to the "wm831x->auxadc_pending" list, but it's only removed from the list on the success path. If a failure occurs then the "req" struct is freed but it's still on the list, leading to a use after free.
Fixes 78bb3688ea18 ("mfd: Support multiple active WM831x AUXADC conversions")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/mfd/wm831x-auxadc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/mfd/wm831x-auxadc.c +1 -2
@@ -93,11 +93,10 @@ static int wm831x_auxadc_read_irq(struct wm831x *wm831x,wait_for_completion_timeout (&req->done,msecs_to_jiffies (500 ));mutex_lock (&wm831x->auxadc_lock); - -list_del (&req->list); ret = req->val; out: +list_del (&req->list);mutex_unlock (&wm831x->auxadc_lock);kfree (req);
Signature · 1 line
2.29.2
Quoted 8 lines · Dan Carpenter
The "req" struct is always added to the "
wm831x->auxadc_pending" list, but it's only removed from the list on the success path. If a failure occurs then the "req" struct is freed but it's still on the list, leading to a use after free.Fixes 78bb3688ea18 ("mfd: Support multiple active WM831x AUXADC conversions")Signed-off-by Dan Carpenter <[email protected]>---
Acked-by Charles Keepax <[email protected]>
Thanks,
Charles