Skip to contentSkip to conversation

mfd: wm831x-auxadc: Prevent use after free in wm831x_auxadc_read_irq()

PATCH In review Dan Carpenter 2 participants 2 messages Dec 14, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: wm831x-auxadc: Prevent use after free in wm831x_auxadc_read_irq()

The "req" struct is always added to the "wm831x->auxadc_pending" list, but it's only removed from the list on the success path. If a failure occurs then the "req" struct is freed but it's still on the list, leading to a use after free.

Fixes 78bb3688ea18 ("mfd: Support multiple active WM831x AUXADC conversions")
---
 drivers/mfd/wm831x-auxadc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/mfd/wm831x-auxadc.c +1 -2
index 8a7cc0f86958..65b98f3fbd92 100644
@@ -93,11 +93,10 @@ static int wm831x_auxadc_read_irq(struct wm831x *wm831x,
 	wait_for_completion_timeout(&req->done, msecs_to_jiffies(500));
 
 	mutex_lock(&wm831x->auxadc_lock);
-
-	list_del(&req->list);
 	ret = req->val;
 
 out:
+	list_del(&req->list);
 	mutex_unlock(&wm831x->auxadc_lock);
 
 	kfree(req);
Signature · 1 line
2.29.2
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Dan Carpenter

The "req" struct is always added to the "wm831x->auxadc_pending" list, but it's only removed from the list on the success path. If a failure occurs then the "req" struct is freed but it's still on the list, leading to a use after free.

Fixes 78bb3688ea18 ("mfd: Support multiple active WM831x AUXADC conversions")

---

Thanks,
Charles